Fix DOMBreakpoints duplicating on refresh and not persisting toggled state upon page reload

Issue: DOM breakpoints don't deduplicate or persist their enabled state
on page reload. https://imgur.com/a/3LUjYNn

Upon page reload, documentUpdated fires which calls appendBreakpoint.
Before, we would end up creating a new breakpoint for the same
breakpoint type and for the same node, thus creating duplicate
breakpoints.

Also, saveDOMBreakpoint needs to be called upon toggle to update the
breakpoint setting so we persist state between page reloads.

Bug: 411163945
Change-Id: Icb2ba93b304dc1492e14ad02e9fd61764882e024
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6466456
Commit-Queue: Sylvester Elorm Coch <elormcoch@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
4 files changed
tree: 26dedc7f942dc594155ca989babc859fdf9c15db
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. .clang-format
  15. .editorconfig
  16. .git-blame-ignore-revs
  17. .gitallowed
  18. .gitattributes
  19. .gitignore
  20. .gitmodules
  21. .gn
  22. .mailmap
  23. .npmignore
  24. .npmrc
  25. .style.yapf
  26. .stylelintignore
  27. .stylelintrc.json
  28. AUTHORS
  29. BUILD.gn
  30. codereview.settings
  31. CONTRIBUTING.md
  32. DEPS
  33. eslint.config.mjs
  34. favicon.ico
  35. LICENSE
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch

There are a few options to keep an eye on the latest and greatest of DevTools development: