Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/322a501acebf69a8d78684cbbc8c1f422c96fef3
commit
322a501acebf69a8d78684cbbc8c1f422c96fef3
[log]
author
Ergun Erdogmus <ergunsh@chromium.org>
Mon Feb 10 10:08:52 2025
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tue Feb 11 09:04:23 2025
tree
19e9ceb7b4b4d662c393101b5d2f71ed25be962a
parent
29c367bf0fc197d017646784e7b679e87eb37d40 [diff]
[CSSMatchedStyles] Do not bail out when getAnimatedStylesForNode errors

Previously, we were returning `null` for `CSSMatchedStyles` creation
when either `getMatchedStylesForNode` or `getAnimatedStylesForNode`
errored.

However, native UI DevTools do not implement `getAnimatedStylesForNode`
CDP method; thus it causes `CSSMatchedStyles` to be not created
since this method now errors.

I have updated the logic to not bail out from `matchedStyles`
creation for animated styles so that UI native DevTools still works.

This also makes sense for the case where somehow
`getAnimatedStylesForNode` returns an error (then we don't show the
animated styles until it stops erroring after computed style updates)

Fixed: 395131432
Change-Id: Ic12568467d0cd34ee95a836b94f52a1182945b8b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6243807
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
1 file changed
tree: 19e9ceb7b4b4d662c393101b5d2f71ed25be962a
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .git-blame-ignore-revs
  19. .gitallowed
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. .mailmap
  25. .npmignore
  26. .npmrc
  27. .style.yapf
  28. .stylelintignore
  29. .stylelintrc.json
  30. AUTHORS
  31. BUILD.gn
  32. codereview.settings
  33. CONTRIBUTING.md
  34. DEPS
  35. eslint.config.mjs
  36. favicon.ico
  37. LICENSE
  38. OWNERS
  39. package-lock.json
  40. package.json
  41. PRESUBMIT.py
  42. README.md
  43. tsconfig.json
  44. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch

There are a few options to keep an eye on the latest and greatest of DevTools development: