Google Git
Sign in
chromium/devtools/devtools-frontend/39240fa3e012e131e2d6a4e2069b636c5d08d331
commit
39240fa3e012e131e2d6a4e2069b636c5d08d331
[log]
author
Connor Clark <cjamcl@chromium.org>
Thu Sep 26 19:37:32 2024
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu Sep 26 20:15:16 2024
tree
5bb4ee67173b974c473851a3a86784f4c2ebcd22
parent
e6796272dc534345f936479de75d58ca04a8109a [diff]
[RPP] Move temporary overlays logic into insights

This lets us keep TimelineFlameChartView simple.

- The Table component now takes an `insight` instance, which it uses to
  store state and provide/unset temporary insights
- ActiveInsight now is given just an array of overlays, not a function.
- These initial overlays are now cached, so createOverlays is never
  called more than once for an insight
- Also fixes bug where a table row remained highlighted when
closing/re-opening an insight

Bug: 369102516
Change-Id: I5af03482c55e0e146ad5d3767474e35d26a1b4cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5894026
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
13 files changed
tree: 5bb4ee67173b974c473851a3a86784f4c2ebcd22
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitallowed
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .mailmap
  27. .npmignore
  28. .npmrc
  29. .style.yapf
  30. .stylelintignore
  31. .stylelintrc.json
  32. AUTHORS
  33. BUILD.gn
  34. codereview.settings
  35. CONTRIBUTING.md
  36. DEPS
  37. favicon.ico
  38. LICENSE
  39. OWNERS
  40. package-lock.json
  41. package.json
  42. PRESUBMIT.py
  43. README.md
  44. tsconfig.json
  45. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch

There are a few options to keep an eye on the latest and greatest of DevTools development: