RPP: do not aria announce if the user triggers settings This CL fixes a bug where if the user changed a setting (such as "Show custom tracks") that triggered a redraw, we would re-announce any annotations, despite the fact that they do not change and always remained on screen. The diff ended up being relatively large for this change; mostly because during my testing I also found a bug where we do not clear up event listeners on the ModificationsManager when the trace is not visible. To fix this I moved the event handler into a distinct bound method, and then we can remove the listener in the `#changeView` method. This CL also removes the debouncer for the Aria Utils, I do not remember why it was added, but in my testing today when creating a lot of annotations and navigating around the panel, I could not recreate the scenario where we spam the user. R=ergunsh@chromium.org Bug: none Change-Id: I99212373b17a2d26c5da27021b03a35ff39a6f88 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6888592 Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.
The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
There are a few options to keep an eye on the latest and greatest of DevTools development:
Follow What's new in DevTools.
Follow Umar's Dev Tips.
Follow these individual Twitter accounts: @umaar, @malyw, @kdzwinel, @addyosmani, @paul_irish, @samccone, @mathias, @mattzeunert, @PrashantPalikhe, @ziyunfei, and @bmeurer.
Follow to g/devtools-reviews@chromium.org mailing list for all reviews of pending code, and view the log, or follow @DevToolsCommits on Twitter.
Checkout all open DevTools tickets on crbug.com
Use Chrome Canary and poke around the experiments.