Make the security panel's origin view a proper table The origin view is currently a <table> with <div>s instead it, which is a little odd. The row <div>s are inidividually laid out with flexbox to look like a table, but the only thing forcing the column width to match is a 110px width. But this means, if one of the names doesn't fit in the space (the names are now localized), it gets cut off from the left. Were it a min-width instead, just that row would be pushed over, which looks weird. Since this is an actual table, and is even a <table> element already, switch the contents to <tr> and <td> and match the layout with table rules. (I got the spacing to match, but there's a few pixels of shift that I wasn't able to work through. I assume that's not significant.) Screenshots: https://drive.google.com/drive/folders/1uqVhwfnf478OmASC2_ssRGOxqpN85-Fz?resourcekey=0-exd_0Jg18vPKYTuGOg06LA&usp=sharing (CT coming and going in the screenshot is unrelated to the CL and just a consequence of official vs unofficial builds.) Bug: 1344541 Change-Id: Ia9efe067bfc1fdd8460c77f00ccd8561f78a2705 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3758116 Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org>
The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.
The frontend is available on chromium.googlesource.com.
Please be aware that DevTools follows additional development guidelines.
The issue triage guidelines can be found in docs/triage_guidelines.md.
Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
All DevTools commits: View the log or follow @DevToolsCommits on Twitter
All open DevTools tickets on crbug.com
File a new DevTools ticket: new.crbug.com
Code reviews mailing list: devtools-reviews@chromium.org
@ChromeDevTools on Twitter
Chrome DevTools mailing list: groups.google.com/forum/google-chrome-developer-tools