Google Git
Sign in
chromium/devtools/devtools-frontend/7322deeb77b7bfbb55ff1f11bb0c446ed4afcbc0
commit
7322deeb77b7bfbb55ff1f11bb0c446ed4afcbc0
[log]
author
Michael Liao <michael.liao@microsoft.com>
Wed Apr 07 18:33:30 2021
committer
Commit Bot <commit-bot@chromium.org>
Thu Apr 08 21:06:32 2021
tree
332bd63dc04f423975e407afd4a67203a04d516d
parent
e08f0d3fbdc820a0a330fd58f7171590fce869bc [diff]
[ARIAUtils]: Remove element parameter for alert()

This CL removes the element parameter from ARIAUtils.alert.  The element parameter is used to access the owner document.  In place of that, this CL introduces ARIAUtils.setOwnerDocument which is called in MainImpl._showAppUI.  This change allows ARIAUtils.alert to be called when an element is not readily accessible.

Bug: 1195232
Change-Id: I646b604d281ad32bd0811514a3bfbc3254f998c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2801093
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
14 files changed
tree: 332bd63dc04f423975e407afd4a67203a04d516d
  1. build_overrides/
  2. config/
  3. docs/
  4. front_end/
  5. inspector_overlay/
  6. node_modules/
  7. scripts/
  8. test/
  9. third_party/
  10. v8/
  11. .clang-format
  12. .editorconfig
  13. .eslintignore
  14. .eslintrc.js
  15. .gitattributes
  16. .gitignore
  17. .gn
  18. .npmignore
  19. .npmrc
  20. .style.yapf
  21. .stylelintignore
  22. .stylelintrc.json
  23. all_devtools_files.gni
  24. all_devtools_modules.gni
  25. ARCHITECTURE.md
  26. AUTHORS
  27. BUILD.gn
  28. DEPS
  29. devtools_grd_files.gni
  30. devtools_image_files.gni
  31. devtools_module_entrypoints.gni
  32. LICENSE
  33. OWNERS
  34. package-lock.json
  35. package.json
  36. PRESUBMIT.py
  37. README.md
  38. tsconfig.base.json
  39. tsconfig.json
  40. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found in docs/triage_guidelines.md.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch