Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/818270702a6dd3eae64f20854e90fc4d7faeb4d1
commit
818270702a6dd3eae64f20854e90fc4d7faeb4d1
[log]
author
Jack Franklin <jacktfranklin@chromium.org>
Wed Aug 28 10:29:37 2024
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Aug 28 10:54:13 2024
tree
bfaf0eac10d387e044771577c65803994c6bb6af
parent
25ba3401dee476c69cb9df7be12fea0b9a9377d4 [diff]
RPP: fix overlay visibility

We had a bug where sometimes some overlays would incorrectly stay
visible even though they should be hidden.

The problem was we were controlling this via the `visibility` property,
but an element with `visibility: hidden` may still have its children
visible if they have their visibility set to `visible`. This was the
root of the bug; we were setting the parent overlay to hidden, but that
did not apply to all children.

This CL moves us to `display: block` and `display: none` which does not
have this problem.

Fixed: 356352905,356359407,356353052
Change-Id: I8479a237e9f47bbbf2f89789367a8409f0303f28
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5822073
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
2 files changed
tree: bfaf0eac10d387e044771577c65803994c6bb6af
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitallowed
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .mailmap
  27. .npmignore
  28. .npmrc
  29. .style.yapf
  30. .stylelintignore
  31. .stylelintrc.json
  32. AUTHORS
  33. BUILD.gn
  34. codereview.settings
  35. CONTRIBUTING.md
  36. DEPS
  37. favicon.ico
  38. LICENSE
  39. OWNERS
  40. package-lock.json
  41. package.json
  42. PRESUBMIT.py
  43. README.md
  44. tsconfig.json
  45. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch

There are a few options to keep an eye on the latest and greatest of DevTools development: