Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/857739cce6b446e28d785e1141bf05599b9dc40d
commit
857739cce6b446e28d785e1141bf05599b9dc40d
[log]
author
Jack Franklin <jacktfranklin@google.com>
Thu Sep 10 07:13:14 2026
committer
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu Sep 10 09:13:50 2026
tree
aba617a6f0a742faeda9a8b57eb498e5d5e6090d
parent
bc32a8747805ea5bd391ad67e19605ceaf2a0d49 [diff]
[AI Assistance] Refactor origin lock checks

This change refactors origin gating to a single fail-closed boolean
predicate isOriginAllowedByLock(establishedOrigin, targetOrigin) in
Tool.ts:
- Eliminates validateOriginLock and removes redundant gate in AiAgent2, the check already existed in AiAgent and when V2 is shipped fully we can squash AiAgent2 and AiAgent into one class to avoid this future confusion.
- GetSourceContentTool filters candidate files against the origin lock
  upfront, preventing cross-origin existence probing.
- ListSourcesTool evaluates the established origin once outside its
  filter loop.
- Adds dedicated unit tests for isOriginAllowedByLock and canonicalizes
  test assertions across tool test suites.

Bug: 559104374
Change-Id: Idd0205fb121f4990fbe853f42935125a9824e1d1
TAG=agy
CONV=401d6ddf-8863-46c0-b0da-516acd8cbdda
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8378426
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
11 files changed
tree: aba617a6f0a742faeda9a8b57eb498e5d5e6090d
  1. .agents/
  2. .gemini/
  3. .github/
  4. .vscode/
  5. build_overrides/
  6. config/
  7. docs/
  8. extension-api/
  9. extensions/
  10. front_end/
  11. inspector_overlay/
  12. mcp/
  13. node_modules/
  14. scripts/
  15. test/
  16. third_party/
  17. v8/
  18. build
  19. buildtools
  20. .clang-format
  21. .clang-format-ignore
  22. .editorconfig
  23. .env.template
  24. .geminiignore
  25. .git-blame-ignore-revs
  26. .gitallowed
  27. .gitattributes
  28. .gitignore
  29. .gitmodules
  30. .gn
  31. .mailmap
  32. .npmignore
  33. .npmrc
  34. .style.yapf
  35. .stylelintignore
  36. .stylelintrc.json
  37. AUTHORS
  38. BUILD.gn
  39. codereview.settings
  40. CONTRIBUTING.md
  41. DEPS
  42. DIR_METADATA
  43. eslint.config.mjs
  44. favicon.ico
  45. LICENSE
  46. OWNERS
  47. package-lock.json
  48. package.json
  49. PRESUBMIT.py
  50. README.md
  51. SECURITY.md
  52. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch

There are a few options to keep an eye on the latest and greatest of DevTools development: