Google Git
Sign in
chromium / devtools / devtools-frontend / 974f5cccd455afb776f5393089fb99616c7077bf
commit974f5cccd455afb776f5393089fb99616c7077bf[log] [tgz]
authorKrishna Govind <govind@chromium.org>Wed Dec 16 01:15:39 2020
committerKrishna Govind <govind@chromium.org>Wed Dec 16 01:32:04 2020
tree2b1a5bf84935409b004cd2661d17dec53b0437f4
parentdb2245479d114a694ad92e5cf7a5d06f7325733f [diff]
Revert "TextPrompt: Limit Autocomplete Retry to suggestion builder filters"

This reverts commit db2245479d114a694ad92e5cf7a5d06f7325733f.

Reason for revert: Breaks Android M88 Official Beta Build, https://bugs.chromium.org/p/chromium/issues/detail?id=1157017#c18

Original change's description:
> TextPrompt: Limit Autocomplete Retry to suggestion builder filters
>
> This CL addresses a bug caused by attempting to autocomplete
> a suggestion repeatedly when the list of suggestions has not changed.
>
> The autocomplete retry was added to fix a bug with filters that
> use suggestion builders, which change suggestions with successive
> autocompletes: i.e "m" -> "method:" -> "method:GET" in the network
> tool filter bar.
>
> However, for text prompts with static suggestions, it's possible
> to get stuck in an autocomplete loop if the user types the full
> suggestion, then presses "tab" to accept.
>
> This CL limits the autocomplete retry to text prompts that use
> suggestion builders (network filter, console filter, Protocol
> Monitor filter)
>
> Original CL: https://crrev.com/c/2472845
>
> Repro steps available in bug
>
> Bug: 1157017
> Change-Id: Ifb2c211fb9014c5409a055945493a1c8f50d1db7
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2582446
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
> (cherry picked from commit b9e29f68c2686a10b51d712dd223652448d43709)
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2594367
> Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>

TBR=yangguo@chromium.org,brgoddar@microsoft.com,tvanderlippe@chromium.org

Change-Id: I5aed2035e7d860347451c9202b6a66c498909eff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1157017
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2594474
Reviewed-by: Krishna Govind <govind@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
5 files changed
tree: 2b1a5bf84935409b004cd2661d17dec53b0437f4
  1. build_overrides/
  2. docs/
  3. front_end/
  4. inspector_overlay/
  5. node_modules/
  6. scripts/
  7. test/
  8. third_party/
  9. v8/
  10. .clang-format
  11. .editorconfig
  12. .eslintignore
  13. .eslintrc.js
  14. .gitattributes
  15. .gitignore
  16. .gn
  17. .npmignore
  18. .npmrc
  19. .style.yapf
  20. .stylelintignore
  21. .stylelintrc.json
  22. all_devtools_files.gni
  23. all_devtools_modules.gni
  24. AUTHORS
  25. BUILD.gn
  26. COMMON_OWNERS
  27. DEPS
  28. devtools_grd_files.gni
  29. devtools_image_files.gni
  30. devtools_module_entrypoints.gni
  31. ENG_REVIEW_OWNERS
  32. INFRA_OWNERS
  33. LICENSE
  34. LIGHTHOUSE_OWNERS
  35. OWNERS
  36. package-lock.json
  37. package.json
  38. PRESUBMIT.py
  39. README.md
  40. tsconfig.base.json
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found here.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found here.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch