)]}'
{
  "commit": "ad57f134ea40cd48a4bb4934b348f7a5d369ffda",
  "tree": "e8b1d02701f67d127a3e5fc244ec8bfa446753c3",
  "parents": [
    "f70189824dd1085e406bf369160ce060c2e66ba9"
  ],
  "author": {
    "name": "Will Hernandez",
    "email": "w.hernandez.code@gmail.com",
    "time": "Tue Jul 09 13:37:38 2024"
  },
  "committer": {
    "name": "Devtools-frontend LUCI CQ",
    "email": "devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Jul 10 07:16:01 2024"
  },
  "message": "A plain text search should be performed when regex option is toggled off.\n\n1. Search option should NOT perform a regex search when regex option is toggled off.\n2. Regex searches are NOT being performed on queries that are already surrounded by forward slashes.\n\nProblem with code:\nChecks and edits during our const Query creation are too broad.\n\n1. Queries were being surrounded by forward slashes even when they were already included in the query, eg below.\nquery \u003d /example/ would then become //example//\n2. In the try/catch where a new regex is created, regex.text(\u0027/example/\u0027) would create a regex for our query which is expected BUT should only occur when our Regex search option is enabled.\n\nFix:\nAdded additional checks during the creation of a new Regex.\n\n1. First confirm this.isRegex is true \u0026\u0026 our query is NOT already surrounded by forward slashes before adding any.\n2. Added an additional this.isRegex check on all new Regex creations.\n\nR\u003dszuend@chromium.org\n\nFixed: 349428386\nChange-Id: If4a985c7cec3098f6a5358c9091db8b2cfe6890c\nReviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5683367\nReviewed-by: Simon Zünd \u003cszuend@chromium.org\u003e\nCommit-Queue: Simon Zünd \u003cszuend@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "54be7348fdfd07dc4ae5ff4c8c9e54caeb31643a",
      "old_mode": 33188,
      "old_path": "front_end/ui/legacy/SearchableView.ts",
      "new_id": "14541f2409fbf372ab9c767b301799933f090fbd",
      "new_mode": 33188,
      "new_path": "front_end/ui/legacy/SearchableView.ts"
    }
  ]
}