[GdpIntegration] Handle HTTP errors gracefully Previously, if an HTTP error happened on `getProfile` calls, we were assuming it is a user with no GDP profile and was enabling the starter flows (e.g. starter badge, and the "Sign up" button in Settings). However, considering that an overloaded API can provide 503 responses much more frequently, we need to handle those failures gracefully and disable the starter flows. There are 2 types of error handling here: 1. Internal to `GdpClient`: `makeHttpRequest` throws a `GdpError` for non-200 responses and internally, calls in the `makeHttpRequest` handled in try-catch blocks. 2. External to `GdpClient`: For the external methods (like `getProfile` or `createAward`), if the request succeeds we return the response otherwise we return `null` to the caller. Fixed: 448012975 Change-Id: I910542a4edb13999b82e0c91d7c7aef26456adb8 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6992374 Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org>
The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.
The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
There are a few options to keep an eye on the latest and greatest of DevTools development:
Follow What's new in DevTools.
Follow Umar's Dev Tips.
Follow these individual Twitter accounts: @umaar, @malyw, @kdzwinel, @addyosmani, @paul_irish, @samccone, @mathias, @mattzeunert, @PrashantPalikhe, @ziyunfei, and @bmeurer.
Follow to g/devtools-reviews@chromium.org mailing list for all reviews of pending code, and view the log, or follow @DevToolsCommits on Twitter.
Checkout all open DevTools tickets on crbug.com
Use Chrome Canary and poke around the experiments.