Google Git
Sign in
chromium/devtools/devtools-frontend/c8cb45dc34fe5965c87efed4447a481842b8568a
commit
c8cb45dc34fe5965c87efed4447a481842b8568a
[log]
author
Jack Franklin <jacktfranklin@chromium.org>
Tue Oct 08 11:02:59 2024
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tue Oct 08 12:35:49 2024
tree
dfa0dee2fde157b7ae11d4207082bc71c81e5fc7
parent
b9be5f9d02e373952bc6633553c0fb4d3b55e91b [diff]
Insights: improvements to a11y of links

This CL improves the a11y of links within the sidebar by turning them
into buttons, which are focusable + fire the click on "enter" by
default.

It also fixes the interactivity with the toggle icon by:

1. Making the toggle icon inert, so it doesn't take user events or
   appear in the a11y tree (which is fine for us; any time the user
   clicks on it it fires a click on the header element which is where
   the toggle behaviour is).
2. Adds a keydown handler to allow Enter+Space to toggle the insight
   expansion state.
3. Makes each insight header keyboard focusable.

Fixed: 372086700, 372092783, 372085384, 372084952
Change-Id: I0a7e58b57db0142b343412d2a74ba4862206f879
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5914255
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
5 files changed
tree: dfa0dee2fde157b7ae11d4207082bc71c81e5fc7
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitallowed
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .mailmap
  27. .npmignore
  28. .npmrc
  29. .style.yapf
  30. .stylelintignore
  31. .stylelintrc.json
  32. AUTHORS
  33. BUILD.gn
  34. codereview.settings
  35. CONTRIBUTING.md
  36. DEPS
  37. favicon.ico
  38. LICENSE
  39. OWNERS
  40. package-lock.json
  41. package.json
  42. PRESUBMIT.py
  43. README.md
  44. tsconfig.json
  45. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch

There are a few options to keep an eye on the latest and greatest of DevTools development: