See Get the Code for details on how to checkout the code, and Chrome DevTools Design Review Guidelines for information regarding our design process.
Usual steps for creating a change work out of the box, when executed in the DevTools frontend repository.
Tips to create meaningful CL descriptions:
Example CL, adapted from Chromium guidelines:
Summary of change (one line) Longer description of change addressing as appropriate: what change was made, why the change is made, context if it is part of many changes, description of previous behavior and newly introduced differences, etc. Long lines should be wrapped to 72 columns for easier log message viewing in terminals. How to test: 1. .. 2. .. Before: https://page-to-before-screenshot.com/before After: https://page-to-after-screenshot.com/after Bug: 123456
Merge request/approval is handled by Chromium Release Managers. DevTools follows Chromium's merge criteria. In exceptional cases please get in touch with hablich@chromium.org.
Step-by-step guide on how to merge:
Merge-Request-XX
label to the relevant crbug. A bot will come by and either ask for more info (example) or approve the request.chromium/xxxx
(e.g. chromium/3979
) branch on the DevTools frontend repo. Use https://chromiumdash.appspot.com/branches or Omahaproxy to find out what branch a major Chromium version has (column true_branch
).chromium/3968
.If the approach above causes conflicts that need resolving, you can use an alternative git workflow which allows you to resolve conflicts locally before uploading. This is very similar to the chromium git merge steps but with different branch names. These steps will create the cherry-pick CL via git.
It is suggested to use the Gerrit UI approach when possible, it is more straightforward and automated. Only use this approach if your cherry-pick causes conflicts.
For the commands below, replace xxxx
with the Chromium branch number that you are merging into.
To set up your local environment run:
gclient sync --with_branch_heads git fetch git checkout -b BRANCH_NAME origin/chromium/xxxx git cl upstream origin/chromium/xxxx
You can then cherry-pick your commit from the main branch:
git cherry-pick -x YOUR_COMMIT
You can then resolve any conflicts, run tests, build DevTools, etc, locally to verify everything is working. Then run git cl upload
to upload the CL and get a review as normal.
Make sure you remove the Change-ID: line from the description to avoid issues when uploading the CL.