Google Git
Sign in
chromium/devtools/devtools-frontend/fa980207621697d99cadcf8fb1347d4c8f538340
commit
fa980207621697d99cadcf8fb1347d4c8f538340
[log]
author
Simon Zünd <szuend@chromium.org>
Fri Jul 16 08:26:09 2021
committer
Simon Zünd <szuend@chromium.org>
Tue Jul 20 05:14:46 2021
tree
fc530f5f72e2b431a3a0bc36ee80767f1c89bc2d
parent
3393236ac77815dea1a6aa98d6841e6d3576ff95 [diff]
[issues] Fix IssuesResolver using outdated event payload type

The payload for the IssueManager.Events.IssueAdded changed a few months
ago from passing a single issue to passing a (issue, model) tuple.

This CL updates the MockIssuesManager and IssuesResolver to use the
correct type.

Once type-safe event listeners are available, this sort of bug will
be prevented.

Fixed: 1229955
Change-Id: Ia574420f49efe222309bb62b6bad0732ae7c93c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3034064
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
(cherry picked from commit 9a59e40402fc87261377e84338f155038eb87e99)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3038589
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2 files changed
tree: fc530f5f72e2b431a3a0bc36ee80767f1c89bc2d
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. front_end/
  6. inspector_overlay/
  7. node_modules/
  8. scripts/
  9. test/
  10. third_party/
  11. v8/
  12. .clang-format
  13. .editorconfig
  14. .eslintignore
  15. .eslintrc.js
  16. .gitattributes
  17. .gitignore
  18. .gn
  19. .mailmap
  20. .npmignore
  21. .npmrc
  22. .style.yapf
  23. .stylelintignore
  24. .stylelintrc.json
  25. ARCHITECTURE.md
  26. AUTHORS
  27. BUILD.gn
  28. DEPS
  29. LICENSE
  30. OWNERS
  31. package-lock.json
  32. package.json
  33. PRESUBMIT.py
  34. README.md
  35. tsconfig.json
  36. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found in docs/triage_guidelines.md.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch