tree f1ef5cd6aef4f9fc85e2255a1b8c522044e26d12
parent aa133ed0962407c6ea731db3e83e2fc13b1013c6
author e52a82bdfb5106bd658c2c5ea465e200 <vidorteg@microsoft.com> 1573150473 -0800
committer Commit Bot <commit-bot@chromium.org> 1574117986 +0000

Verifying that the tab exists in TabbedEditorcontainer tab map before consuming it.

Root cause:
To set the error icon code passes tab_id to the setTabIcon function on this._tabbedPane but never verified that the tab_id exists in the tab Map structure and then proceed to modify its property which causes an error.

e.g
https://imgur.com/a/4Nb0Chu
In the attached image code wants to consume tab: "tab_43" but it does not exist in the current map of tabs
then it tries to modify the properties of an undefined object triggering the error:

Uncaught (in promise) TypeError: Cannot read property '_setIcon' of undefined
    at TabbedPane.setTabIcon (TabbedPane.js:formatted)
    at Sources.TabbedEditorContainer._addLoadErrorIcon (sources_module.js:formatted)
    at eval (sources_module.js:formatted)

Fix:
Verify that the tab_id exists on the map before modifying the object.
Change-Id: I51b704597d0b1b68eee2e099d747d97339e9f59d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1904287
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Mandy Chen <mandy.chen@microsoft.com>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>