)]}'
{
  "commit": "1a0338a1175bc5e4a7eb22ed93e981a59aa22e66",
  "tree": "81afa1940384d3480166808a7c1bddfedd7e5587",
  "parents": [
    "49b1682c7301b7c5127446dd852e912c223a0c70"
  ],
  "author": {
    "name": "Tim van der Lippe",
    "email": "tvanderlippe@chromium.org",
    "time": "Fri Feb 21 14:44:49 2020"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Fri Feb 21 15:05:54 2020"
  },
  "message": "Reland \"Build Karma test with Ninja\"\n\nThis reverts commit 01ac2b90b3893b8355208cbba7ce8ee9c18e53ec.\n\nReason for revert: Build fixed in Chromium\n\nOriginal change\u0027s description:\n\u003e Revert \"Build Karma test with Ninja\"\n\u003e\n\u003e This reverts commit 4b654444ed5ef198c8551503670895d67ae7856a.\n\u003e\n\u003e Reason for revert: Broke the build in Chromium: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887844056671365856/+/steps/compile__with_patch_/0/stdout\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Build Karma test with Ninja\n\u003e \u003e\n\u003e \u003e This instructs Ninja to generate the appropriate files for the test\n\u003e \u003e files. It adds a separate `ts_library` definition for tests.\n\u003e \u003e\n\u003e \u003e Some caveats:\n\u003e \u003e - It currently hardcodes the Ninja build output name. We should fix out\n\u003e \u003e a solution on how to make this irrespective of build name\n\u003e \u003e - The test name has to be renamed to Color_test.ts. While I think this\n\u003e \u003e is clearer for code navigation, it was necessary because `ts_library`\n\u003e \u003e currently copies to `resources/inspector`, which is not necessary for\n\u003e \u003e test files. We could therefore filter these out, based on the files that\n\u003e \u003e end with `_test.ts`. We could also add a separate Ninja template,\n\u003e \u003e something like `ts_test_library`. Not sure yet what is the best\n\u003e \u003e approach.\n\u003e \u003e\n\u003e \u003e DISABLE_THIRD_PARTY_CHECK\u003dUpdating TypeScript configuration\n\u003e \u003e\n\u003e \u003e Bug: 1011811\n\u003e \u003e Change-Id: If7448474e84a013d8d4b00a16743575a12112f58\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2064669\n\u003e \u003e Reviewed-by: Jack Franklin \u003cjacktfranklin@chromium.org\u003e\n\u003e \u003e Commit-Queue: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\n\u003e\n\u003e TBR\u003daerotwist@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org\n\u003e\n\u003e Change-Id: I1048a5003b5680b257586cf3720fc5eaddb435d5\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Bug: 1011811\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2067061\n\u003e Reviewed-by: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\n\u003e Commit-Queue: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\n\nDISABLE_THIRD_PARTY_CHECK\u003dReland\n\nBug: 1011811\nChange-Id: I9df8d551a18c7733fca586f504621c18262e941d\nReviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2067062\nCommit-Queue: Tim van der Lippe \u003ctvanderlippe@chromium.org\u003e\nReviewed-by: Paul Lewis \u003caerotwist@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "4c375627d313f4fb2d4650eee572fd380bc6317a",
      "old_mode": 33188,
      "old_path": "BUILD.gn",
      "new_id": "571501e5526c84d055dc69fa4141790d8d5d8e7c",
      "new_mode": 33188,
      "new_path": "BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "503ceeb338a1b4fd025c4b8f7ab7cbeb11f80585",
      "old_mode": 33261,
      "old_path": "scripts/test/run_unittests.py",
      "new_id": "da3c917edd424a8c3e16ff8325e263def625b4a1",
      "new_mode": 33261,
      "new_path": "scripts/test/run_unittests.py"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "41a2cfff1b6e1ff885277d786f0f6420d774c2ff",
      "new_mode": 33188,
      "new_path": "test/unittests/front_end/common/BUILD.gn"
    },
    {
      "type": "rename",
      "old_id": "4d168e94b295a93c0c2278d36b751ee6dc679214",
      "old_mode": 33188,
      "old_path": "test/unittests/front_end/common/Color.ts",
      "new_id": "3ca3bfcd7f85ccc2a5d74d7b90cae71a74eb056b",
      "new_mode": 33188,
      "new_path": "test/unittests/front_end/common/Color_test.ts",
      "score": 66
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "21bc97d470e5a28810abcc41be0d10aa9bf19ca3",
      "new_mode": 33188,
      "new_path": "test/unittests/front_end/karma.conf.js"
    },
    {
      "type": "modify",
      "old_id": "f5af5bf7f3c1d28cc2602492c14f835782b47bc1",
      "old_mode": 33188,
      "old_path": "third_party/typescript/ts_library.py",
      "new_id": "5ed151af24b9536f204951f7c6364d33c4c4a612",
      "new_mode": 33188,
      "new_path": "third_party/typescript/ts_library.py"
    },
    {
      "type": "modify",
      "old_id": "d5b9f8c6558ae022e0efe5f61ea3bf71e58c097c",
      "old_mode": 33188,
      "old_path": "third_party/typescript/typescript.gni",
      "new_id": "965eef0463e3369d60404ea3472be719df7403a2",
      "new_mode": 33188,
      "new_path": "third_party/typescript/typescript.gni"
    }
  ]
}