Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/4267
commit
11880b30c36028e6d7c1d923d3c9a605d01790c9
[log]
author
Michael Liao <michael.liao@microsoft.com>
Thu Sep 17 00:46:29 2020
committer
Commit Bot <commit-bot@chromium.org>
Thu Sep 17 21:43:18 2020
tree
9f8c0f2d1eaec258a6d1f50d5483ef69d15f8f1b
parent
5f863da9c92410edf3de8cab6d5a832c2835d548 [diff]
[Sources]: Bug fix where frontend is imporoperly handling a pausedEvent with empty callframes

Issue:
- the DevTools crashes when trying to access "callFrame.script" on line 472 of DebuggerWorkspaceBinding.js
    - This is caused when there is no callframes in the callframes array
    - The DevTools should handle this scenario gracefully without crashing

Changes:
- returning false early in _beforePaused
    - This causes a "stepOver"/"stepInto" call and try to set the paused details at the new location

Bug: 1129220
Change-Id: I7d73aa9ff2b83298163e11516ec67450554ea39d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2415235
Reviewed-by: Tony Ross <tross@microsoft.com>
Reviewed-by: Jack Lynch <jalyn@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
1 file changed
tree: 9f8c0f2d1eaec258a6d1f50d5483ef69d15f8f1b
  1. back_end/
  2. build_overrides/
  3. docs/
  4. front_end/
  5. inspector_overlay/
  6. node_modules/
  7. scripts/
  8. test/
  9. third_party/
  10. v8/
  11. .clang-format
  12. .editorconfig
  13. .eslintignore
  14. .eslintrc.js
  15. .gitattributes
  16. .gitignore
  17. .gn
  18. .npmignore
  19. .npmrc
  20. .style.yapf
  21. .stylelintignore
  22. .stylelintrc.json
  23. all_devtools_files.gni
  24. all_devtools_modules.gni
  25. AUTHORS
  26. BUILD.gn
  27. COMMON_OWNERS
  28. DEPS
  29. devtools_grd_files.gni
  30. devtools_image_files.gni
  31. devtools_module_entrypoints.gni
  32. ENG_REVIEW_OWNERS
  33. INFRA_OWNERS
  34. LICENSE
  35. LIGHTHOUSE_OWNERS
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.base.json
  42. tsconfig.json
  43. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found here.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found here.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch