Google Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/4274
commit
a3fd937cbdeeb3391698e29efc910f28b0dd40b3
[log]
author
Patrick Brosset <patrick.brosset@microsoft.com>
Tue Sep 22 07:55:35 2020
committer
Commit Bot <commit-bot@chromium.org>
Thu Sep 24 08:49:55 2020
tree
ef4274fac8e31f4c1ead8e1d72aac8c937971ebf
parent
eeeaa840fa19cd17064c534ce3ca2623830e79d9 [diff]
Don't display grid adorners on shadow roots

If an element in the Elements tree is a grid, it will get a grid adorner
but there's a bug where if that element contains a shadow root, then it
will also be getting the same adorner.

To avoid this, we skip document fragment nodes in the code.

Before: https://imgur.com/YU041Po.jpg
After: https://imgur.com/qaFdQle.jpg

Bug: 1129760
Change-Id: Ice4d9044b2a8a77a20d1db05ba4fb2acaa17775c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2418171
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
6 files changed
tree: ef4274fac8e31f4c1ead8e1d72aac8c937971ebf
  1. back_end/
  2. build_overrides/
  3. docs/
  4. front_end/
  5. inspector_overlay/
  6. node_modules/
  7. scripts/
  8. test/
  9. third_party/
  10. v8/
  11. .clang-format
  12. .editorconfig
  13. .eslintignore
  14. .eslintrc.js
  15. .gitattributes
  16. .gitignore
  17. .gn
  18. .npmignore
  19. .npmrc
  20. .style.yapf
  21. .stylelintignore
  22. .stylelintrc.json
  23. all_devtools_files.gni
  24. all_devtools_modules.gni
  25. AUTHORS
  26. BUILD.gn
  27. COMMON_OWNERS
  28. DEPS
  29. devtools_grd_files.gni
  30. devtools_image_files.gni
  31. devtools_module_entrypoints.gni
  32. ENG_REVIEW_OWNERS
  33. INFRA_OWNERS
  34. LICENSE
  35. LIGHTHOUSE_OWNERS
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.base.json
  42. tsconfig.json
  43. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found here.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found here.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch