Google Git
Sign in
chromium / devtools / devtools-frontend / refs/heads/chromium/4635
commit18ec12005cb9595424c29014a5e0505af10ab8ec[log] [tgz]
authorTim van der Lippe <tvanderlippe@chromium.org>Mon Sep 06 12:01:03 2021
committerDevtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Sep 06 12:49:30 2021
tree93b115d85772d4a25d69c3e81255e7d7c695f5a1
parent220027016aee322104747fc702ac8957505e4583 [diff]
Fix size input elements in dark mode

In dark mode, when there is a pre-selected device size, we disable
the corresponding input elements. However, the styling was making
it not ideal in dark mode.

Instead, we should show the size as normal, but disable test selection.
That way, it is still readable, but also clear to the user that they
can't change it.

R=jacktfranklin@chromium.org

Fixed: 1246346
Change-Id: I3166b3141b005915b75be5af54787f911b60c1ef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3142421
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
1 file changed
tree: 93b115d85772d4a25d69c3e81255e7d7c695f5a1
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. ARCHITECTURE.md
  27. AUTHORS
  28. BUILD.gn
  29. DEPS
  30. LICENSE
  31. OWNERS
  32. package-lock.json
  33. package.json
  34. PRESUBMIT.py
  35. README.md
  36. tsconfig.json
  37. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Design guidelines

Please be aware that DevTools follows additional development guidelines.

Issue triage

The issue triage guidelines can be found in docs/triage_guidelines.md.

Workflows

Instructions to set up, use, and maintain a DevTools frontend checkout can be found in docs/workflows.md.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch