)]}' { "commit": "cc5008ae3396a10aec62ac54f7299db6c83474dc", "tree": "64554ab7a80687992fca94d4c0498ded46dbf032", "parents": [ "547149f24d073810580862c7f94a03543236ac65" ], "author": { "name": "Connor Clark", "email": "cjamcl@chromium.org", "time": "Fri Nov 08 23:17:00 2024" }, "committer": { "name": "Devtools-frontend LUCI CQ", "email": "devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Nov 08 23:50:54 2024" }, "message": "Reland \"Use Intl.NumberFormat for time and byte formatting\"\n\nThis reverts commit 55ffe2fb876bae23ee9b83f1b7824b2021834c12.\n\nReason for revert: fixed conflicting internal code (NPP)\n\nOriginal change\u0027s description:\n\u003e Revert \"Use Intl.NumberFormat for time and byte formatting\"\n\u003e\n\u003e This reverts commit 6b3449efbc12670977cc04ecf0f1c66148f2df5d.\n\u003e\n\u003e Reason for revert: currently failing the auto roller: https://ci.chromium.org/ui/p/devtools-internal/builders/try/devtools_frontend_linux_rel/b8731890377373202833/overview\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Use Intl.NumberFormat for time and byte formatting\n\u003e \u003e\n\u003e \u003e TimeUtilities now uses Intl.NumberFormat (instead of UIStrings),\n\u003e \u003e and bytesToString now uses Intl.NumberFormat (instead of non-locale\n\u003e \u003e aware strings). Additionally, bytesToString is now under the i18n\n\u003e \u003e module.\n\u003e \u003e\n\u003e \u003e Impacts of this change:\n\u003e \u003e\n\u003e \u003e * use Chrome ICU locale data to format, rather than human translators,\n\u003e \u003e which allows us to be more accurate in regards to unit display style\n\u003e \u003e (narrow vs short vs long)\n\u003e \u003e * group separators (ex: thousands decimals in english) are now present\n\u003e \u003e * slight change to rounding behavior - Intl.NumberFormat defaults to\n\u003e \u003e \"halfExpand\", which rounds away from zeroes to break ties. Previously\n\u003e \u003e we just truncated\n\u003e \u003e\n\u003e \u003e See go/cpq:i18n-units-design\n\u003e \u003e\n\u003e \u003e Bug: 372723536\n\u003e \u003e Change-Id: Iff05ca9ff01213660d64ca88fadb613296153fa9\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5981156\n\u003e \u003e Reviewed-by: Simon Zünd \u003cszuend@chromium.org\u003e\n\u003e \u003e Commit-Queue: Connor Clark \u003ccjamcl@chromium.org\u003e\n\u003e \u003e Reviewed-by: Benedikt Meurer \u003cbmeurer@chromium.org\u003e\n\u003e \u003e Reviewed-by: Paul Irish \u003cpaulirish@chromium.org\u003e\n\u003e\n\u003e Bug: 372723536\n\u003e Change-Id: I82f74ae04729b9f6c514d7e186572a8ffade30cd\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6003765\n\u003e Commit-Queue: Kim-Anh Tran \u003ckimanh@chromium.org\u003e\n\u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\nBug: 372723536\nChange-Id: I1d6f3ddc5fb0cc97a88b79e27a74ba29c134c83f\nReviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6005878\nCommit-Queue: Connor Clark \u003ccjamcl@chromium.org\u003e\nReviewed-by: Paul Irish \u003cpaulirish@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "35c848ba7777fa92ce0f068c8cbaf95fabca83e3", "old_mode": 33188, "old_path": "config/gni/devtools_grd_files.gni", "new_id": "62ef8e6d8c05474881867faf121ffcb314a0e7e1", "new_mode": 33188, "new_path": "config/gni/devtools_grd_files.gni" }, { "type": "modify", "old_id": "12711f509e5fc1b421b57f20fee1c16d41e911c2", "old_mode": 33188, "old_path": "front_end/core/i18n/BUILD.gn", "new_id": "8f09bed1593adebdd3ef39ac1b76e14b458b664d", "new_mode": 33188, "new_path": "front_end/core/i18n/BUILD.gn" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "c0a9db4564dbd29a1800a3d9b2721eae809e4f3f", "new_mode": 33188, "new_path": "front_end/core/i18n/ByteUtilities.test.ts" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "7a79200c0b204fcec3a1482cf47c48ef58a7fb60", "new_mode": 33188, "new_path": "front_end/core/i18n/ByteUtilities.ts" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "c29e1ed1c6c857b50acd139958fe8d91266bc3a6", "new_mode": 33188, "new_path": "front_end/core/i18n/NumberFormatter.ts" }, { "type": "modify", "old_id": "a2c167ac6725b5b57e185127c89d69149ba5a94d", "old_mode": 33188, "old_path": "front_end/core/i18n/i18n.ts", "new_id": "c519750596a120e88f1cf5bbb6094f09bc55291b", "new_mode": 33188, "new_path": "front_end/core/i18n/i18n.ts" }, { "type": "modify", "old_id": "898028dcaae0e3b2c2de9d705cbb8bce0c0c3386", "old_mode": 33188, "old_path": "front_end/core/i18n/time-utilities.test.ts", "new_id": "41e00c57fe2a0c105aa9d0b81acf806040a1de5c", "new_mode": 33188, "new_path": "front_end/core/i18n/time-utilities.test.ts" }, { "type": "modify", "old_id": "3c720196ff031330164f5909f3aef7083b920066", "old_mode": 33188, "old_path": "front_end/core/i18n/time-utilities.ts", "new_id": "0b8aa731add97551f7d89e93f6ce0d53030e2937", "new_mode": 33188, "new_path": "front_end/core/i18n/time-utilities.ts" }, { "type": "modify", "old_id": "327d6215e89cacb69a26947155d0db1da6826a91", "old_mode": 33188, "old_path": "front_end/core/platform/NumberUtilities.test.ts", "new_id": "eeaffb3ae31a6a618701d6e3875bb43566383029", "new_mode": 33188, "new_path": "front_end/core/platform/NumberUtilities.test.ts" }, { "type": "modify", "old_id": "46a998380910113770ed1b517ae74243a664129c", "old_mode": 33188, "old_path": "front_end/core/platform/NumberUtilities.ts", "new_id": "ba5ed894f92d955d8598a25ffdeaa288dde60c81", "new_mode": 33188, "new_path": "front_end/core/platform/NumberUtilities.ts" }, { "type": "modify", "old_id": "4905683ce4db460f39602e445ce503219fa39c96", "old_mode": 33188, "old_path": "front_end/panels/application/StorageView.ts", "new_id": "8c273a9fcff3b2c15c946627782e555a19eb2fcf", "new_mode": 33188, "new_path": "front_end/panels/application/StorageView.ts" }, { "type": "modify", "old_id": "b915fe95283cfc380b78ebea77856fa185c65342", "old_mode": 33188, "old_path": "front_end/panels/application/components/StorageMetadataView.ts", "new_id": "d5d92fb86614becebe93666779674cc7ab353030", "new_mode": 33188, "new_path": "front_end/panels/application/components/StorageMetadataView.ts" }, { "type": "modify", "old_id": "fcf28657c1d88955cf25b9687a35f778524d7ca8", "old_mode": 33188, "old_path": "front_end/panels/coverage/CoverageView.ts", "new_id": "7d7b9d1e47ff3a11fcef5af44e653875796f0a4d", "new_mode": 33188, "new_path": "front_end/panels/coverage/CoverageView.ts" }, { "type": "modify", "old_id": "7ad57d57331189e422691cab34d1302072d261cf", "old_mode": 33188, "old_path": "front_end/panels/freestyler/DrJonesNetworkAgent.test.ts", "new_id": "2aae657beafd03c42ec2ab58e9b6bb20fab52895", "new_mode": 33188, "new_path": "front_end/panels/freestyler/DrJonesNetworkAgent.test.ts" }, { "type": "modify", "old_id": "33548663dd8609e92ece679d41cf7b33a6c123e9", "old_mode": 33188, "old_path": "front_end/panels/layer_viewer/LayerDetailsView.ts", "new_id": "90d73107a52575d652442b67f5620e58027509a1", "new_mode": 33188, "new_path": "front_end/panels/layer_viewer/LayerDetailsView.ts" }, { "type": "modify", "old_id": "8e31a7b5d864c7450851d8cb538b5aad1456e22d", "old_mode": 33188, "old_path": "front_end/panels/network/NetworkDataGridNode.ts", "new_id": "158608fe70c858610dbe0a2021c9f4777ef1a5e3", "new_mode": 33188, "new_path": "front_end/panels/network/NetworkDataGridNode.ts" }, { "type": "modify", "old_id": "58596a8bc9c3fa660ac18cc0c787024f9188d1ad", "old_mode": 33188, "old_path": "front_end/panels/network/NetworkLogView.ts", "new_id": "cf51243881f9ebd17ab035984d6287ac3da6068d", "new_mode": 33188, "new_path": "front_end/panels/network/NetworkLogView.ts" }, { "type": "modify", "old_id": "8b3442dbf3fe43d391b5fee1f42dbbba1def4941", "old_mode": 33188, "old_path": "front_end/panels/network/ResourceWebSocketFrameView.ts", "new_id": "34c88c86cf31afdd0aeac81f7fb12cd64ca5c5da", "new_mode": 33188, "new_path": "front_end/panels/network/ResourceWebSocketFrameView.ts" }, { "type": "modify", "old_id": "9dea59a571a427f10f8373901e28163e72c65474", "old_mode": 33188, "old_path": "front_end/panels/performance_monitor/PerformanceMonitor.ts", "new_id": "c79804727f8c0517d762f9412ee5fbbfafd2ec8a", "new_mode": 33188, "new_path": "front_end/panels/performance_monitor/PerformanceMonitor.ts" }, { "type": "modify", "old_id": "ed7f16b18f2b846e8fab7eeaf5282344e2acc72c", "old_mode": 33188, "old_path": "front_end/panels/profiler/HeapProfileView.ts", "new_id": "44245191e0ddd804c2b231fa1881a3f212602471", "new_mode": 33188, "new_path": "front_end/panels/profiler/HeapProfileView.ts" }, { "type": "modify", "old_id": "adbf16ed32fba63f78d0dc1519e75af8f6a4e234", "old_mode": 33188, "old_path": "front_end/panels/profiler/HeapSnapshotView.ts", "new_id": "ccf05bf9842bdc94d322fc2917365c7ee1383697", "new_mode": 33188, "new_path": "front_end/panels/profiler/HeapSnapshotView.ts" }, { "type": "modify", "old_id": "ab73988b753ff7620abbf22cf88cc560632d17a3", "old_mode": 33188, "old_path": "front_end/panels/profiler/HeapTimelineOverview.ts", "new_id": "24cebc5b4db42c2d3159fa3ce508348f4624f732", "new_mode": 33188, "new_path": "front_end/panels/profiler/HeapTimelineOverview.ts" }, { "type": "modify", "old_id": "30375f2902bf8bc4eb15f306bf7cd33d6f15ca12", "old_mode": 33188, "old_path": "front_end/panels/profiler/IsolateSelector.ts", "new_id": "72a86dd1102ca1dec814d2abb8de105b53df4f09", "new_mode": 33188, "new_path": "front_end/panels/profiler/IsolateSelector.ts" }, { "type": "modify", "old_id": "cade6c4741504f778ec32e2da9bff691ab8f9296", "old_mode": 33188, "old_path": "front_end/panels/profiler/ProfileView.ts", "new_id": "399e03fc1863e88b471181552e821811bb779a94", "new_mode": 33188, "new_path": "front_end/panels/profiler/ProfileView.ts" }, { "type": "modify", "old_id": "26a4bc1e95b3553bec899be19961949c7a12c27a", "old_mode": 33188, "old_path": "front_end/panels/recorder/components/RecordingView.ts", "new_id": "452309ed993598db4b21708ee06ed7d84d4a519e", "new_mode": 33188, "new_path": "front_end/panels/recorder/components/RecordingView.ts" }, { "type": "modify", "old_id": "769c7b2fdc9996094f654f215c54510251e40178", "old_mode": 33188, "old_path": "front_end/panels/timeline/CountersGraph.ts", "new_id": "d3f23fb0f469cc0993302436abbead9b1a8d5333", "new_mode": 33188, "new_path": "front_end/panels/timeline/CountersGraph.ts" }, { "type": "modify", "old_id": "9ee5a1c1372f677e9236b1bcede23555e542b690", "old_mode": 33188, "old_path": "front_end/panels/timeline/TimelineEventOverview.ts", "new_id": "4bbfffdc648345c0df5d25bc698d4c2698469218", "new_mode": 33188, "new_path": "front_end/panels/timeline/TimelineEventOverview.ts" }, { "type": "modify", "old_id": "4085af2f8e07a0dd5dae6b09cc7c7dff7f39a0f3", "old_mode": 33188, "old_path": "front_end/panels/timeline/TimelineUIUtils.test.ts", "new_id": "230713c1ca15d000685911c29408fab049e4a43d", "new_mode": 33188, "new_path": "front_end/panels/timeline/TimelineUIUtils.test.ts" }, { "type": "modify", "old_id": "5e0024c0d67f90fe1867488f443571fb9f4d4c70", "old_mode": 33188, "old_path": "front_end/panels/timeline/TimelineUIUtils.ts", "new_id": "2099ac765e6638422824641aed445162e78a498a", "new_mode": 33188, "new_path": "front_end/panels/timeline/TimelineUIUtils.ts" }, { "type": "modify", "old_id": "26c868517ca57cb6615ffa481439ab3a80562bf8", "old_mode": 33188, "old_path": "front_end/panels/timeline/components/MetricCard.test.ts", "new_id": "f95a6a0bef681a03bc9b439731ae940ab009b1fe", "new_mode": 33188, "new_path": "front_end/panels/timeline/components/MetricCard.test.ts" }, { "type": "modify", "old_id": "55c5429837b27cd94c62df475055ac6ec8eb817c", "old_mode": 33188, "old_path": "front_end/panels/timeline/components/NetworkRequestDetails.ts", "new_id": "da295cda7149bb8b8c9b208b8072084f9e5ab6d4", "new_mode": 33188, "new_path": "front_end/panels/timeline/components/NetworkRequestDetails.ts" }, { "type": "modify", "old_id": "47b5d1a96a4c4d70359a90229c523d7aa0403a87", "old_mode": 33188, "old_path": "front_end/panels/timeline/components/insights/LCPDiscovery.ts", "new_id": "fb16de8fcc87e4ed0eba89f21ec2b5cfb38ea463", "new_mode": 33188, "new_path": "front_end/panels/timeline/components/insights/LCPDiscovery.ts" }, { "type": "modify", "old_id": "bf0c7bcaf2aac470c7a071e25e1024f19fab8d04", "old_mode": 33188, "old_path": "front_end/panels/timeline/components/insights/SidebarInsight.ts", "new_id": "a17b590af16a9afc7cdc7022a24b61f4846cbf9d", "new_mode": 33188, "new_path": "front_end/panels/timeline/components/insights/SidebarInsight.ts" }, { "type": "modify", "old_id": "b092ca068d61b7cf29e406834a37097356740114", "old_mode": 33188, "old_path": "front_end/panels/timeline/components/insights/ThirdParties.ts", "new_id": "9c2dc1094857f080004dba0e594e86e18cbe3b92", "new_mode": 33188, "new_path": "front_end/panels/timeline/components/insights/ThirdParties.ts" }, { "type": "modify", "old_id": "4a052453da44b13a6b8ea064a2b6238434978cd1", "old_mode": 33188, "old_path": "front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts", "new_id": "833f62e4faa7f7d371361cfb1140dcd1533165d6", "new_mode": 33188, "new_path": "front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts" }, { "type": "modify", "old_id": "ecd142934096553d06cda7d0e6d6a13519e2372d", "old_mode": 33188, "old_path": "front_end/ui/legacy/components/source_frame/ImageView.ts", "new_id": "3610eb77c4542dc778bbe1bd4708766e13faa001", "new_mode": 33188, "new_path": "front_end/ui/legacy/components/source_frame/ImageView.ts" }, { "type": "modify", "old_id": "6894030e11ac1218c7b7c6b37ebfa35b2261df77", "old_mode": 33188, "old_path": "front_end/ui/legacy/components/utils/ImagePreview.ts", "new_id": "3e50a4c655084a8787ff2f4ca8044adaceaa56da", "new_mode": 33188, "new_path": "front_end/ui/legacy/components/utils/ImagePreview.ts" }, { "type": "modify", "old_id": "97344dfae658f081375090f75d3e40db108cb3ab", "old_mode": 33188, "old_path": "test/e2e/helpers/application-helpers.ts", "new_id": "9e600d096a0860becc3f2c1b106fa8bbd968625b", "new_mode": 33188, "new_path": "test/e2e/helpers/application-helpers.ts" }, { "type": "modify", "old_id": "ec2b69c9ec66ed993f5cbfa70cb9ba8857539282", "old_mode": 33188, "old_path": "test/interactions/goldens/linux/performance/gpu_track_collapsed.png", "new_id": "f502c52ad0623093244bd6b468cc1e2657897ae2", "new_mode": 33188, "new_path": "test/interactions/goldens/linux/performance/gpu_track_collapsed.png" }, { "type": "modify", "old_id": "ec2b69c9ec66ed993f5cbfa70cb9ba8857539282", "old_mode": 33188, "old_path": "test/interactions/goldens/linux/performance/gpu_track_expanded.png", "new_id": "f502c52ad0623093244bd6b468cc1e2657897ae2", "new_mode": 33188, "new_path": "test/interactions/goldens/linux/performance/gpu_track_expanded.png" }, { "type": "modify", "old_id": "e3cfad6371dcca1fa9879961a106e8c0ff10c6df", "old_mode": 33188, "old_path": "test/interactions/goldens/linux/performance/interactions_track_long_interactions.png", "new_id": "e8766b47436cab0a007d8be44ef9ead3cb338c3f", "new_mode": 33188, "new_path": "test/interactions/goldens/linux/performance/interactions_track_long_interactions.png" }, { "type": "modify", "old_id": "240b99aa4219efc9602e2a7bea32441d4869ef1d", "old_mode": 33188, "old_path": "test/interactions/goldens/linux/performance/layout_shifts_track.png", "new_id": "8aa9c8086edfe6db546e8ce7e7e76fd56c1fcc71", "new_mode": 33188, "new_path": "test/interactions/goldens/linux/performance/layout_shifts_track.png" }, { "type": "modify", "old_id": "b02628795cde509dc7d0e30950249fa4230d371d", "old_mode": 33188, "old_path": "test/interactions/goldens/linux/performance/layout_shifts_track_dark_mode.png", "new_id": "2115ea156e85ec571875c00eb290bf2340a67c12", "new_mode": 33188, "new_path": "test/interactions/goldens/linux/performance/layout_shifts_track_dark_mode.png" } ] }