Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/7081
commit
2035fcae39c13a0b667467378dc1a69735908d04
[log]
author
Connor Clark <cjamcl@chromium.org>
Thu Mar 20 21:16:26 2025
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu Mar 20 21:52:15 2025
tree
daecfa4dc4edbc4ce6eb1ddcf9d8a8094034dbd0
parent
166922fd12dec25e782014dcc8f2c2618e7ba90c [diff]
[RPP] Improve performance of singleton overlays

Every call to `add` a new overlay would iterate over all existing
overlays to manage singletons specially. For an extreme case of ~70k
overlays, this resulted in ~22s of extra processing time on my M1 Mac.

This CL reduces it down to 5ms by simply storing singleton overlays in
a map for constant time lookup.

Example trace w/ many overlays on 3p insight:  https://trace.cafe/t/V7sS5bz7F0

Bug: 40278532
Change-Id: Ia8b76892e4f22f1a60215fffcc999fb4862121a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376737
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
1 file changed
tree: daecfa4dc4edbc4ce6eb1ddcf9d8a8094034dbd0
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .git-blame-ignore-revs
  19. .gitallowed
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. .mailmap
  25. .npmignore
  26. .npmrc
  27. .style.yapf
  28. .stylelintignore
  29. .stylelintrc.json
  30. AUTHORS
  31. BUILD.gn
  32. codereview.settings
  33. CONTRIBUTING.md
  34. DEPS
  35. eslint.config.mjs
  36. favicon.ico
  37. LICENSE
  38. OWNERS
  39. package-lock.json
  40. package.json
  41. PRESUBMIT.py
  42. README.md
  43. tsconfig.json
  44. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch

There are a few options to keep an eye on the latest and greatest of DevTools development: