Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/refs/heads/chromium/7973
commit
b72fdc299cd8f427b0e6f0d22c27f59940eec7e6
[log]
author
Kateryna Prokopenko <kprokopenko@google.com>
Thu Jul 23 15:43:46 2026
committer
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fri Jul 24 17:43:26 2026
tree
b231f8c120fe51737d2b4ebba85b4c366a2d0352
parent
18f3a1b26fff82ec8b9270c5bee7c83c93b022d3 [diff]
Do not focus main menu button when undocking or re-docking DevTools

In MainMenuItem within MainImpl.ts, the setDockSide callback registered a listener on AFTER_DOCK_SIDE_CHANGED to focus the main menu button ('Customize and control DevTools'). While restoring focus after changing dock side within the same window is desirable, undocking into a separate window or re-docking from an undocked window back into the main tab was inappropriately forcing tab focus onto the main menu button.

This CL updates setDockSide so that button focus is only scheduled when switching between docked states in the same window (i.e. neither the current state nor the target state is UNDOCKED).

Fixed: 458644241
TAG=agy
CONV=3807fccb-7a14-4271-9612-8419f0f441c1
Change-Id: If392bfb4126e7355630da987453d11f424903972
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8138251
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
2 files changed
tree: b231f8c120fe51737d2b4ebba85b4c366a2d0352
  1. .agents/
  2. .gemini/
  3. .github/
  4. .vscode/
  5. build_overrides/
  6. config/
  7. docs/
  8. extension-api/
  9. extensions/
  10. front_end/
  11. inspector_overlay/
  12. mcp/
  13. node_modules/
  14. scripts/
  15. test/
  16. third_party/
  17. v8/
  18. build
  19. buildtools
  20. .clang-format
  21. .clang-format-ignore
  22. .editorconfig
  23. .env.template
  24. .geminiignore
  25. .git-blame-ignore-revs
  26. .gitallowed
  27. .gitattributes
  28. .gitignore
  29. .gitmodules
  30. .gn
  31. .mailmap
  32. .npmignore
  33. .npmrc
  34. .style.yapf
  35. .stylelintignore
  36. .stylelintrc.json
  37. AUTHORS
  38. BUILD.gn
  39. codereview.settings
  40. CONTRIBUTING.md
  41. DEPS
  42. DIR_METADATA
  43. eslint.config.mjs
  44. favicon.ico
  45. LICENSE
  46. OWNERS
  47. package-lock.json
  48. package.json
  49. PRESUBMIT.py
  50. README.md
  51. SECURITY.md
  52. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the Chromium DevTools documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch

There are a few options to keep an eye on the latest and greatest of DevTools development: