| commit | 29ac68b4c7eb67ebef01e5afbc7d99943edd5a3b | [log] [tgz] |
|---|---|---|
| author | Mathieu Binette <mbinette@google.com> | Tue Jan 22 20:06:34 2019 |
| committer | Mathieu Binette <mbinette@google.com> | Tue Jan 22 23:33:15 2019 |
| tree | 5ffbfd7998d8d232e259ec03ab191865c48d203b | |
| parent | d154b94b822708c915443ab76106bbf6e3b844ed [diff] |
Fix retry bug in watcher.go When I ported the WaitForAllAssetsReady implementation from python to golang, I forgot a "continue" in the retry loop when I got rid of the try/catch, which leads to a null ptr crash right after. Original change that introduced the bug: https://chromium-review.googlesource.com/c/enterprise/cel/+/1388185 Bug itself: https://crrev.com/c/1388185/10/go/cel/deploy/watcher.go#88 https://crrev.com/c/1388185/10/test/infra/gcp/runtime_config.py#b100 Change-Id: I7499054e134e81fa4e30fbb66785c65fd2de6572 Reviewed-on: https://chromium-review.googlesource.com/c/1427379 Reviewed-by: Fei Ling <feiling@chromium.org>
Chrome Enterprise Lab is an inaccurately named set of tools for building enterprise labs quickly and easily. The labs so built can be used for system level end-to-end testing of Google Chrome/Chromium.
Have a peek at the Design document.
Also have a peek at the Code of Conduct.
Most of the code is in Go. See Guide to code to get a head start on the code in this repository.
Go: Download Go from the Go download page. This project requires Go 1.9.4 or later. The build will fail with prior versions.
Depot Tools: Used for managing the checkout and the contributor workflow.
Protocol Buffers Compiler: Protocol buffers are used extensively for wranging all the data that needs to be shuttled around. Can be installed automatically via ./build.py deps --install.
Dep : Used for Go depedency management. This can be installed automatically by running ./build.py deps --install from the root of the source tree.
Go support for Protocol Buffers : This can be installed automatically by running ./build.py deps --install from the root of the source tree.
There are two ways to get the source. One is to use managed deps, and the other is to use plain go get. The latter workflow doesn't quite work yet due to this repository not being integrated with go.chromium.org. So this page only mentions the managed dependency workflow.
Clone this repository:
Assumes that $GOPATH is a single path and not a : delimited list.
mkdir -p ${GOPATH}/src/chromium.googlesource.com/enterprise cd ${GOPATH}/src/chromium.googlesource.com/enterprise git clone https://chromium.googlesource.com/enterprise/cel cd cel
Get the dependencies:
python build.py deps --install
Use the build script:
python build.py build
Also make sure the tests pass.
python build.py test
See CONTRIBUTING.