Google Git
Sign in
chromium / experimental / codesearch / infra / infra / 391b512d34ebaad0eb91093cf88ece8d6eca78d5
commit391b512d34ebaad0eb91093cf88ece8d6eca78d5[log] [tgz]
authorTiff Zhang <zhangtiff@google.com>Mon Jan 14 23:39:55 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jan 14 23:39:55 2019
tree43be6ac584814f54440f1606ce542c99952a4d7f
parentcee88ea75a8bd1912dd0f5cf44e6bfbd386e915c [diff]
Revert "Monorail: Make comment numbers on the FLT page based on displayed sections."

This reverts commit d1d54387560870f290474017fd24807f4667b4bc.

Reason for revert: Implementing this in only the frontend means notification emails will have different numbers than the listed comments. 

Original change's description:
> Monorail: Make comment numbers on the FLT page based on displayed sections.
> 
> Bug: monorail:4582
> Change-Id: I280338dcd6afb58a57c1c70792727e71bba0e36b
> Reviewed-on: https://chromium-review.googlesource.com/c/1403888
> Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#19906}

TBR=zhangtiff@chromium.org,ehmaldonado@chromium.org,jojwang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: monorail:4582
Change-Id: I430eaed5ac157f341a54d03d151bcea50a764b8f
Reviewed-on: https://chromium-review.googlesource.com/c/1410202
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19970}
Cr-Mirrored-Commit: 1d85460b28207034bb7b06e5a6855254ab65ec44
2 files changed
tree: 43be6ac584814f54440f1606ce542c99952a4d7f
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. cipd/
  7. crdx/
  8. data/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. recipes/
  17. test/
  18. utils/
  19. luci
  20. recipes-py
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, integrate your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. More your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have init.py files in each directory of your module so Python recognizes it as a package.