Revert "Remove JSON output from public API of SkSLDebugTrace"
This reverts commit 47f59c4368e202c276aee0534b7d8dc9df4bf65b.
Reason for revert: Potentially breaking roll
Original change's description:
> Remove JSON output from public API of SkSLDebugTrace
>
> SkSLDebugTrace was the only place in //src that used //src/utils/SkJSON.h (Skia's JSON parser). This parsing
> wasn't visible via the public API, instead hiding it in
> DebugTracePriv).
>
> I would like to remove our JSON parser from Skia proper and
> move it into //modules. This makes Skia the library easier
> to build (as there is a static_assert() that flat out fails
> on big-endian systems [1]), reduces our potential security
> footprint, and our code size (marginally).
>
> Aside: Skia's JSON writer appears to be mainly used by some
> Ganesh code to output debug info. One could wonder if that's
> strictly necessary or if it could be moved to //tools too.
>
> In any case, this removes the JSON parsing and output logic
> from SkSLDebugTrace (and SkSLDebugTracePriv), moving them
> to //tools where we can access it for some of our tooling
> when we need to. A follow-up CL will move SkJSON.h to //modules.
>
> Change-Id: I48558630e7bd9963609947f839657a89f064bd1a
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/926676
> Reviewed-by: Florin Malita <fmalita@google.com>
Change-Id: Id5a67adb8d3602c1e426cf2b5844548cd82ed0e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/927597
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
17 files changed
