| 2013-05-08 Gavin Barraclough <barraclough@apple.com> |
| |
| Process suppression should throttle scripted animations |
| https://bugs.webkit.org/show_bug.cgi?id=115812 |
| |
| Reviewed by Simon Fraser. |
| |
| <rdar://problem/13799726> |
| |
| * WebCore.exp.in: |
| - Expose Page::setThrottled |
| * dom/Document.cpp: |
| (WebCore::Document::scriptedAnimationControllerSetThrottled): |
| (WebCore): |
| * dom/Document.h: |
| (Document): |
| - Forwards to ScriptedAnimationController::setThrottled |
| * dom/ScriptedAnimationController.cpp: |
| (WebCore::ScriptedAnimationController::setThrottled): |
| (WebCore): |
| * dom/ScriptedAnimationController.h: |
| - Force use of a timer. |
| (ScriptedAnimationController): |
| * page/Page.cpp: |
| (WebCore::Page::setThrottled): |
| (WebCore): |
| * page/Page.h: |
| (Page): |
| - When under throttling force the ScriptedAnimationController to use a timer. |
| |
| 2013-05-15 Igor Oliveira <igor.o@sisa.samsung.com> |
| |
| Implement run-in remove child cases. |
| https://bugs.webkit.org/show_bug.cgi?id=86520 |
| |
| Move runin to original position when sibling element is destroyed. |
| |
| Reviewed by David Hyatt. |
| |
| Tests: fast/runin/runin-remove-child-simple.html |
| fast/runin/runin-sibling-inline.html |
| |
| * rendering/RenderBlock.cpp: |
| (WebCore::RenderBlock::willBeDestroyed): |
| (WebCore::RenderBlock::moveRunInUnderSiblingBlockIfNeeded): |
| If moveRunInUnderSiblingBlockIfNeeded is called when the sibling run-in block |
| is being destroyed, it means that the run-in is moving to original position and |
| we do not need to do nothing. |
| |
| 2013-05-15 Anders Carlsson <andersca@apple.com> |
| |
| Remove WebSocketHandshakeResponse class |
| https://bugs.webkit.org/show_bug.cgi?id=116190 |
| |
| Reviewed by Andreas Kling. |
| |
| Just use ResourceResponse instead of WebSocketHandshakeResponse. |
| |
| * CMakeLists.txt: |
| * GNUmakefile.list.am: |
| * Modules/websockets/WebSocketHandshake.cpp: |
| (WebCore::WebSocketHandshake::readServerHandshake): |
| (WebCore::WebSocketHandshake::serverWebSocketProtocol): |
| (WebCore::WebSocketHandshake::serverSetCookie): |
| (WebCore::WebSocketHandshake::serverSetCookie2): |
| (WebCore::WebSocketHandshake::serverUpgrade): |
| (WebCore::WebSocketHandshake::serverConnection): |
| (WebCore::WebSocketHandshake::serverWebSocketAccept): |
| (WebCore::WebSocketHandshake::serverHandshakeResponse): |
| (WebCore::WebSocketHandshake::readHTTPHeaders): |
| * Modules/websockets/WebSocketHandshake.h: |
| * Modules/websockets/WebSocketHandshakeResponse.cpp: Removed. |
| * Modules/websockets/WebSocketHandshakeResponse.h: Removed. |
| * Target.pri: |
| * WebCore.vcproj/WebCore.vcproj: |
| * WebCore.vcxproj/WebCore.vcxproj: |
| * WebCore.vcxproj/WebCore.vcxproj.filters: |
| * WebCore.xcodeproj/project.pbxproj: |
| * inspector/InspectorInstrumentation.cpp: |
| (WebCore): |
| (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): |
| * inspector/InspectorInstrumentation.h: |
| (InspectorInstrumentation): |
| (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse): |
| * inspector/InspectorResourceAgent.cpp: |
| (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): |
| * inspector/InspectorResourceAgent.h: |
| (WebCore): |
| (InspectorResourceAgent): |
| |
| 2013-05-15 Eric Carlson <eric.carlson@apple.com> |
| |
| [Mac] media engine may deliver NULL in-band "cue" |
| https://bugs.webkit.org/show_bug.cgi?id=116180 |
| |
| Reviewed by Jer Noble. |
| |
| * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: |
| (WebCore::InbandTextTrackPrivateAVF::processCue): NULL check before logging cue count. |
| |
| 2013-05-15 Darin Adler <darin@apple.com> |
| |
| List platforms that still use the legacy clipboard instead of just saying "not Mac" |
| https://bugs.webkit.org/show_bug.cgi?id=116177 |
| |
| Reviewed by Andreas Kling. |
| |
| * dom/Clipboard.h: Replaced the "!MAC || IOS" with a list of platforms still on the |
| legacy model. |
| |
| 2013-05-15 Yongjun Zhang <yongjun_zhang@apple.com> |
| |
| We should clear mainResource in DocumentLoader::cancelMainResourceLoad. |
| https://bugs.webkit.org/show_bug.cgi?id=116119 |
| |
| Reviewed by Oliver Hunt. |
| |
| MainResourceLoader::clearResource() was left out in r146239 when moving MainResourceLoader::cancel() |
| to DocumentLoader::cancelMainResourceLoad(), we need to add it back to make sure m_mainResource is |
| cleared when we cancel the loader. |
| |
| No new tests needed. |
| |
| * loader/DocumentLoader.cpp: |
| (WebCore::DocumentLoader::~DocumentLoader): |
| (WebCore::DocumentLoader::continueAfterNavigationPolicy): |
| (WebCore::DocumentLoader::cancelMainResourceLoad): |
| (WebCore::DocumentLoader::clearMainResource): |
| (WebCore): |
| * loader/DocumentLoader.h: add helper method clearMainResource() |
| (DocumentLoader): |
| |
| 2013-05-15 Joe Mason <jmason@blackberry.com> |
| |
| [BlackBerry] When HTTP auth fails, only purge credentials that match the failed credentials |
| https://bugs.webkit.org/show_bug.cgi?id=116164 |
| |
| Reviewed by Rob Buis. |
| |
| Internal PR: 338490 |
| Internally Reviewed By: Lyon Chen |
| |
| When there are multiple HTTP requests in flight with the same bad credentials (common with |
| proxy auth if the user mistyped their password), the first 407 that's received will cause |
| the credentials to be purged and the password dialog to open for new credentials. This means |
| that all 407's received after this should only purge the credentials if they have not |
| already been updated from the dialog; otherwise they will be wiping out credentials that |
| haven't failed yet. |
| |
| * platform/network/blackberry/NetworkJob.cpp: |
| (WebCore::NetworkJob::sendRequestWithCredentials): |
| (WebCore::NetworkJob::purgeCredentials): |
| |
| 2013-05-15 Chris Fleizach <cfleizach@apple.com> |
| |
| AX: Use caching when requesting children object on iOS |
| https://bugs.webkit.org/show_bug.cgi?id=116112 |
| |
| Reviewed by David Kilzer. |
| |
| Building up the children list in the AX hierarchy can be time consuming. On iOS, this |
| is now much more noticeable (I believe due to the way tables calculate their AX ignored flag). |
| |
| We can speed everything up if we just cache the isIgnored() attribute while building up children. |
| |
| * accessibility/AXObjectCache.cpp: |
| (WebCore::AXAttributeCacheEnabler::AXAttributeCacheEnabler): |
| (WebCore): |
| (WebCore::AXAttributeCacheEnabler::~AXAttributeCacheEnabler): |
| * accessibility/AXObjectCache.h: |
| (AXAttributeCacheEnabler): |
| (WebCore): |
| * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: |
| (-[WebAccessibilityObjectWrapper accessibilityHitTest:]): |
| (-[WebAccessibilityObjectWrapper accessibilityElementCount]): |
| (-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]): |
| (-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]): |
| (-[WebAccessibilityObjectWrapper accessibilityContainer]): |
| |
| 2013-05-15 Anders Carlsson <andersca@apple.com> |
| |
| Remove WebSocketHandshakeRequest class |
| https://bugs.webkit.org/show_bug.cgi?id=116178 |
| |
| Reviewed by Andreas Kling. |
| |
| Turns out WebSocketHandshakeRequest is just used by the web inspector, and there's no reason |
| why we can't just use a ResourceRequest instead. |
| |
| * CMakeLists.txt: |
| * GNUmakefile.list.am: |
| * Modules/websockets/WebSocketChannel.cpp: |
| (WebCore::WebSocketChannel::didOpenSocketStream): |
| * Modules/websockets/WebSocketHandshake.cpp: |
| (WebCore::WebSocketHandshake::clientHandshakeRequest): |
| * Modules/websockets/WebSocketHandshake.h: |
| (WebCore): |
| * Modules/websockets/WebSocketHandshakeRequest.cpp: Removed. |
| * Modules/websockets/WebSocketHandshakeRequest.h: Removed. |
| * Target.pri: |
| * WebCore.vcproj/WebCore.vcproj: |
| * WebCore.vcxproj/WebCore.vcxproj: |
| * WebCore.vcxproj/WebCore.vcxproj.filters: |
| * WebCore.xcodeproj/project.pbxproj: |
| * inspector/InspectorInstrumentation.cpp: |
| (WebCore): |
| (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): |
| * inspector/InspectorInstrumentation.h: |
| (InspectorInstrumentation): |
| (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest): |
| * inspector/InspectorResourceAgent.cpp: |
| (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): |
| * inspector/InspectorResourceAgent.h: |
| (WebCore): |
| (InspectorResourceAgent): |
| * platform/network/HTTPRequest.cpp: |
| (WebCore): |
| |
| 2013-05-15 Darin Adler <darin@apple.com> |
| |
| Try to fix iOS build. |
| |
| * platform/Pasteboard.h: Fix #if so that we don't try to compile pasteboard name code |
| on iOS. |
| |
| 2013-05-13 Anders Carlsson <andersca@apple.com> |
| |
| Frame::editor() should return a reference |
| https://bugs.webkit.org/show_bug.cgi?id=116037 |
| |
| Reviewed by Darin Adler. |
| |
| A frame's editor can never be null. Change Frame::editor() to return a reference to reflect this. |
| Also, make Frame::m_editor a const member variable so nobody will accidentally set it to null. |
| |
| * accessibility/AccessibilityObject.cpp: |
| (WebCore::AccessibilityObject::hasMisspelling): |
| * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: |
| (AXAttributeStringSetSpelling): |
| * dom/ContainerNode.cpp: |
| (WebCore::ContainerNode::cloneChildNodes): |
| * dom/Document.cpp: |
| (WebCore::acceptsEditingFocus): |
| (WebCore::Document::setFocusedNode): |
| (WebCore::command): |
| * editing/AlternativeTextController.cpp: |
| (WebCore::AlternativeTextController::timerFired): |
| (WebCore::AlternativeTextController::applyDictationAlternative): |
| * editing/CompositeEditCommand.cpp: |
| (WebCore::EditCommandComposition::unapply): |
| (WebCore::EditCommandComposition::reapply): |
| (WebCore::CompositeEditCommand::apply): |
| (WebCore::CompositeEditCommand::moveParagraphs): |
| * editing/DeleteButton.cpp: |
| (WebCore::DeleteButton::defaultEventHandler): |
| * editing/DeleteButtonController.cpp: |
| (WebCore::DeleteButtonController::show): |
| * editing/DeleteButtonController.h: |
| (WebCore::DeleteButtonControllerDisableScope::DeleteButtonControllerDisableScope): |
| (WebCore::DeleteButtonControllerDisableScope::~DeleteButtonControllerDisableScope): |
| * editing/DeleteSelectionCommand.cpp: |
| (WebCore::DeleteSelectionCommand::mergeParagraphs): |
| (WebCore::DeleteSelectionCommand::doApply): |
| * editing/EditCommand.cpp: |
| (WebCore::EditCommand::EditCommand): |
| * editing/EditingStyle.cpp: |
| (WebCore::StyleChange::StyleChange): |
| * editing/Editor.cpp: |
| (WebCore::Editor::markMisspellingsAfterTypingToWord): |
| * editing/EditorCommand.cpp: |
| (WebCore::applyCommandToFrame): |
| (WebCore::executeToggleStyle): |
| (WebCore::executeApplyParagraphStyle): |
| (WebCore::expandSelectionToGranularity): |
| (WebCore::stateStyle): |
| (WebCore::valueStyle): |
| (WebCore::executeCopy): |
| (WebCore::executeCut): |
| (WebCore::executeDefaultParagraphSeparator): |
| (WebCore::executeDelete): |
| (WebCore::executeDeleteBackward): |
| (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): |
| (WebCore::executeDeleteForward): |
| (WebCore::executeDeleteToBeginningOfLine): |
| (WebCore::executeDeleteToBeginningOfParagraph): |
| (WebCore::executeDeleteToEndOfLine): |
| (WebCore::executeDeleteToEndOfParagraph): |
| (WebCore::executeDeleteToMark): |
| (WebCore::executeDeleteWordBackward): |
| (WebCore::executeDeleteWordForward): |
| (WebCore::executeFindString): |
| (WebCore::executeForwardDelete): |
| (WebCore::executeIgnoreSpelling): |
| (WebCore::executeInsertNewline): |
| (WebCore::executeMakeTextWritingDirectionLeftToRight): |
| (WebCore::executeMakeTextWritingDirectionNatural): |
| (WebCore::executeMakeTextWritingDirectionRightToLeft): |
| (WebCore::executeToggleOverwrite): |
| (WebCore::executePaste): |
| (WebCore::executePasteGlobalSelection): |
| (WebCore::executePasteAndMatchStyle): |
| (WebCore::executePasteAsPlainText): |
| (WebCore::executeRedo): |
| (WebCore::executeRemoveFormat): |
| (WebCore::executeSelectToMark): |
| (WebCore::executeSetMark): |
| (WebCore::executeStyleWithCSS): |
| (WebCore::executeUseCSS): |
| (WebCore::executeSwapWithMark): |
| (WebCore::executeTakeFindStringFromSelection): |
| (WebCore::executeTranspose): |
| (WebCore::executeUndo): |
| (WebCore::executeYank): |
| (WebCore::executeYankAndSelect): |
| (WebCore::supportedCopyCut): |
| (WebCore::supportedPaste): |
| (WebCore::enabledVisibleSelection): |
| (WebCore::enabledVisibleSelectionAndMark): |
| (WebCore::enableCaretInEditableText): |
| (WebCore::enabledCopy): |
| (WebCore::enabledCut): |
| (WebCore::enabledInEditableText): |
| (WebCore::enabledDelete): |
| (WebCore::enabledPaste): |
| (WebCore::enabledRedo): |
| (WebCore::enabledTakeFindStringFromSelection): |
| (WebCore::enabledUndo): |
| (WebCore::stateOrderedList): |
| (WebCore::stateStyleWithCSS): |
| (WebCore::stateUnorderedList): |
| (WebCore::valueDefaultParagraphSeparator): |
| * editing/FrameSelection.cpp: |
| (WebCore::shouldAlwaysUseDirectionalSelection): |
| (WebCore::FrameSelection::setSelection): |
| (WebCore::FrameSelection::nextWordPositionForPlatform): |
| (WebCore::FrameSelection::modifyMovingRight): |
| (WebCore::FrameSelection::modifyMovingLeft): |
| (WebCore::FrameSelection::modify): |
| (WebCore::shouldStopBlinkingDueToTypingCommand): |
| (WebCore::FrameSelection::shouldDeleteSelection): |
| (WebCore::FrameSelection::shouldChangeSelection): |
| * editing/InsertTextCommand.cpp: |
| (WebCore::InsertTextCommand::doApply): |
| * editing/SpellChecker.cpp: |
| (WebCore::SpellChecker::didCheck): |
| * editing/SpellingCorrectionCommand.cpp: |
| * editing/TypingCommand.cpp: |
| (WebCore::TypingCommand::insertText): |
| (WebCore::TypingCommand::lastTypingCommandIfStillOpenForTyping): |
| (WebCore::TypingCommand::markMisspellingsAfterTyping): |
| (WebCore::TypingCommand::typingAddedToOpenCommand): |
| (WebCore::TypingCommand::deleteKeyPressed): |
| (WebCore::TypingCommand::forwardDeleteKeyPressed): |
| * editing/htmlediting.cpp: |
| (WebCore::createDefaultParagraphElement): |
| * editing/mac/EditorMac.mm: |
| (WebCore::Editor::pasteWithPasteboard): |
| * editing/markup.cpp: |
| (WebCore::createMarkup): |
| * html/HTMLInputElement.cpp: |
| (WebCore::HTMLInputElement::endEditing): |
| * html/HTMLTextAreaElement.cpp: |
| (WebCore::HTMLTextAreaElement::subtreeHasChanged): |
| * html/TextFieldInputType.cpp: |
| (WebCore::TextFieldInputType::handleKeydownEvent): |
| (WebCore::TextFieldInputType::didSetValueByUserEdit): |
| * loader/FrameLoader.cpp: |
| (WebCore::FrameLoader::closeURL): |
| (WebCore::FrameLoader::didOpenURL): |
| (WebCore::FrameLoader::clear): |
| * page/ContextMenuController.cpp: |
| (WebCore::insertUnicodeCharacter): |
| (WebCore::ContextMenuController::contextMenuItemSelected): |
| (WebCore::ContextMenuController::populate): |
| (WebCore::ContextMenuController::checkOrEnableIfNeeded): |
| * page/DOMWindow.cpp: |
| (WebCore::DOMWindow::find): |
| * page/DragController.cpp: |
| (WebCore::DragController::dispatchTextInputEventFor): |
| (WebCore::DragController::concludeEditDrag): |
| (WebCore::DragController::startDrag): |
| * page/EventHandler.cpp: |
| (WebCore::EventHandler::selectClosestWordFromMouseEvent): |
| (WebCore::EventHandler::handleMousePressEventSingleClick): |
| (WebCore::EventHandler::handlePasteGlobalSelection): |
| (WebCore::EventHandler::sendContextMenuEvent): |
| (WebCore::EventHandler::sendContextMenuEventForKey): |
| (WebCore::EventHandler::keyEvent): |
| (WebCore::EventHandler::defaultKeyboardEventHandler): |
| (WebCore::EventHandler::defaultTextInputEventHandler): |
| (WebCore::EventHandler::defaultBackspaceEventHandler): |
| * page/FocusController.cpp: |
| (WebCore::relinquishesEditingFocus): |
| * page/Frame.cpp: |
| (WebCore::Frame::rangeForPoint): |
| * page/Frame.h: |
| (Frame): |
| (WebCore::Frame::editor): |
| * page/Page.cpp: |
| (WebCore::Page::findString): |
| (WebCore::Page::findStringMatchingRanges): |
| (WebCore::Page::rangeOfString): |
| (WebCore::Page::markAllMatchesForText): |
| (WebCore::Page::setDeviceScaleFactor): |
| * platform/mac/ClipboardMac.mm: |
| (WebCore::ClipboardMac::writeRange): |
| * platform/mac/DragDataMac.mm: |
| (WebCore::DragData::asURL): |
| * platform/mac/PasteboardMac.mm: |
| (WebCore::Pasteboard::getStringSelection): |
| (WebCore::Pasteboard::getDataSelection): |
| (WebCore::Pasteboard::writeSelectionForTypes): |
| (WebCore::writeURLForTypes): |
| (WebCore::Pasteboard::plainText): |
| (WebCore::documentFragmentWithRTF): |
| (WebCore::Pasteboard::documentFragment): |
| * rendering/HitTestResult.cpp: |
| (WebCore::HitTestResult::dictationAlternatives): |
| * rendering/InlineTextBox.cpp: |
| (WebCore::InlineTextBox::paint): |
| (WebCore::InlineTextBox::paintTextMatchMarker): |
| * rendering/RenderBlock.cpp: |
| (WebCore::RenderBlock::positionForPointWithInlineChildren): |
| * testing/Internals.cpp: |
| (WebCore::spellchecker): |
| (WebCore::Internals::resetToConsistentState): |
| (WebCore::Internals::hasSpellingMarker): |
| (WebCore::Internals::hasAutocorrectedMarker): |
| (WebCore::Internals::setContinuousSpellCheckingEnabled): |
| (WebCore::Internals::setAutomaticQuoteSubstitutionEnabled): |
| (WebCore::Internals::setAutomaticLinkDetectionEnabled): |
| (WebCore::Internals::setAutomaticDashSubstitutionEnabled): |
| (WebCore::Internals::setAutomaticTextReplacementEnabled): |
| (WebCore::Internals::setAutomaticSpellingCorrectionEnabled): |
| (WebCore::Internals::isOverwriteModeEnabled): |
| (WebCore::Internals::toggleOverwriteModeEnabled): |
| (WebCore::Internals::hasGrammarMarker): |
| |
| 2013-05-15 Darin Adler <darin@apple.com> |
| |
| [Mac] Make Clipboard class no longer polymorphic by removing the last virtual functions |
| https://bugs.webkit.org/show_bug.cgi?id=116166 |
| |
| Reviewed by Anders Carlsson. |
| |
| * WebCore.exp.in: Add ~Clipboard since it's no longer a virtual function, but to the |
| non-iOS section, since iOS is still using the legacy version of Clipboard. |
| |
| * dom/Clipboard.h: Mark items non-virtual, too. It's not implemented on Mac yet. |
| |
| 2013-05-15 Dongseong Hwang <dongseong.hwang@intel.com> |
| |
| Remove an overloaded strokeRect in <canvas> |
| https://bugs.webkit.org/show_bug.cgi?id=116017 |
| |
| Reviewed by Benjamin Poulain. |
| |
| The canvas spec [1] does not define strokeRect with 5 arguments, so this issue |
| remains only strokeRect with 4 arguments. |
| |
| [1] http://www.w3.org/TR/2dcontext2/ |
| |
| Covered by existing tests: canvas/philip/tests/2d.missingargs.html |
| |
| * html/canvas/CanvasRenderingContext2D.cpp: |
| (WebCore::CanvasRenderingContext2D::strokeRect): |
| * html/canvas/CanvasRenderingContext2D.h: |
| (CanvasRenderingContext2D): |
| * html/canvas/CanvasRenderingContext2D.idl: |
| |
| 2013-05-15 Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> |
| |
| [css3-text] text-decoration-line now accepts "blink" as valid value |
| https://bugs.webkit.org/show_bug.cgi?id=116104 |
| |
| Reviewed by Andreas Kling. |
| |
| As of November 13th 2012, the W3C specification has been updated to |
| accept "blink" as a valid property value in text-decoration-line. Though |
| accepting the value as valid, it is ignored as CSS Level 1 |
| text-decoration property currently does. |
| |
| Updated related layout tests to reflect changes in specification. |
| |
| * css/CSSParser.cpp: |
| (WebCore::CSSParser::parseValue): |
| (WebCore::CSSParser::parseTextDecoration): |
| |
| 2013-05-14 Simon Fraser <simon.fraser@apple.com> |
| |
| Revert http://trac.webkit.org/changeset/150047 |
| |
| It introduced unwanted behavioral differences between |
| Retina and non-Retina Mac hardware. |
| |
| * platform/graphics/ca/GraphicsLayerCA.cpp: |
| (WebCore::GraphicsLayerCA::requiresTiledLayer): |
| (WebCore::GraphicsLayerCA::computePixelAlignment): |
| |
| 2013-05-15 Darin Adler <darin@apple.com> |
| |
| [Mac] Remove the ClipboardMac class and header file |
| https://bugs.webkit.org/show_bug.cgi?id=116165 |
| |
| Reviewed by Anders Carlsson. |
| |
| * WebCore.xcodeproj/project.pbxproj: Remove ClipboardMac.h. |
| * editing/mac/EditorMac.mm: Import Clipboard.h rather than ClipboardMac.h. |
| * page/mac/EventHandlerMac.mm: Ditto. |
| * platform/mac/ClipboardMac.h: Removed. |
| |
| * platform/mac/ClipboardMac.mm: Import Clipboard.h rather than ClipboardMac.h. |
| Deleted ClipboardMac constructor. |
| |
| 2013-05-15 Darin Adler <darin@apple.com> |
| |
| [Mac] Change Clipboard::create functions so they don't use ClipboardMac::create any more |
| https://bugs.webkit.org/show_bug.cgi?id=116163 |
| |
| Reviewed by Anders Carlsson. |
| |
| * dom/Clipboard.h: Made the file drag boolean default to false, better for most callers. |
| |
| * platform/mac/ClipboardMac.mm: Remove #if ENABLE(DRAG_SUPPORT); that's always on for Mac |
| and it's not helpful to have the conditionals in here. It's helpful in cross-platform |
| source files. |
| (WebCore::Clipboard::create): Create a Pasteboard and then create a Clipboard with new. |
| Later could refactor to have the Pasteboard creation be platform-specific, and make these |
| functions platform-independent. |
| (WebCore::Clipboard::createForDragAndDrop): Ditto. |
| (WebCore::Clipboard::createForCopyAndPaste): Ditto. |
| |
| 2013-05-15 Darin Adler <darin@apple.com> |
| |
| [Mac] Remove call to ClipboardMac::create from Editor::newGeneralClipboard |
| https://bugs.webkit.org/show_bug.cgi?id=116162 |
| |
| Reviewed by Andreas Kling. |
| |
| * dom/Clipboard.h: Add createForCopyAndPaste function. |
| |
| * editing/mac/EditorMac.mm: |
| (WebCore::Editor::newGeneralClipboard): Call createForCopyAndPaste. |
| |
| * platform/mac/ClipboardMac.mm: |
| (WebCore::Clipboard::createForCopyAndPaste): Added. Moved code here from |
| Editor::newGeneralClipboard. |
| |
| 2013-05-15 Darin Adler <darin@apple.com> |
| |
| [Mac] Remove call to ClipboardMac::create from EventHandler::createDraggingClipboard |
| https://bugs.webkit.org/show_bug.cgi?id=116161 |
| |
| Reviewed by Andreas Kling. |
| |
| * dom/Clipboard.h: Added createForDragAndDrop function. |
| |
| * page/mac/EventHandlerMac.mm: |
| (WebCore::EventHandler::createDraggingClipboard): Changed to use new Clipboard function |
| instead of ClipboardMac::create. |
| |
| * platform/mac/ClipboardMac.mm: |
| (WebCore::Clipboard::createForDragAndDrop): Added. For now it does exactly what the |
| EventHandler::createDraggingClipboard function did, soon to be refactored better. |
| |
| 2013-05-15 Darin Adler <darin@apple.com> |
| |
| [Mac] Thin out the ClipboardMac class and header file to prepare for deleting them |
| https://bugs.webkit.org/show_bug.cgi?id=116159 |
| |
| Reviewed by Andreas Kling. |
| |
| * dom/Clipboard.h: |
| (WebCore::Clipboard::pasteboard): Added. For clients that have a DOM clipboard |
| object and need to get to the Pasteboard platform abstraction. |
| |
| * editing/Editor.cpp: |
| (WebCore::Editor::dispatchCPPEvent): Call writePasteboard instead of writeClipboard. |
| Our long term plan is to delete writeClipboard. |
| |
| * platform/Pasteboard.h: Added writePasteboard function. |
| (WebCore::Pasteboard::name): Made this const. |
| |
| * platform/mac/ClipboardMac.h: Deleted unneeded includes and forward declarations. |
| Deleted all the data members and the virtual destructor. |
| |
| * platform/mac/ClipboardMac.mm: Deleted the many includes that are no longer needed. |
| Deleted the destructor, since it's now automatically generated. Deleted the comment |
| on an #endif since it's only a few source lines away from the #if. |
| (WebCore::ClipboardMac::ClipboardMac): Deleted the code to set the data members, |
| since they are no longer used. |
| |
| * platform/mac/PasteboardMac.mm: Changed include to Clipboard.h instead of ClipboardMac.h. |
| (WebCore::Pasteboard::writePasteboard): Replaced writeClipboard with this. |
| |
| 2013-05-15 Seokju Kwon <seokju.kwon@gmail.com> |
| |
| Web Inspector: Get rid of addNativeSnapshotChunk and HeapSnapshotChunk from Memory domain |
| https://bugs.webkit.org/show_bug.cgi?id=116144 |
| |
| Reviewed by Timothy Hatcher. |
| |
| No new tests, no behavior change. |
| |
| * inspector/Inspector.json: |
| |
| 2013-05-15 Jocelyn Turcotte <jocelyn.turcotte@digia.com> |
| |
| [Qt] Fix a crash under ~PingLoader when the QNAM on the page has been destroyed. |
| https://bugs.webkit.org/show_bug.cgi?id=116035 |
| |
| Reviewed by Allan Sandfeld Jensen. |
| |
| The previous fix only moved the crash location from WebKit down to QNetworkReplyHttpImpl |
| which expects its QNetworkAccessManager to still be alive. |
| |
| Fix it by watching the QNetworkReply's destroyed() signal and avoid the dangling pointer |
| instead. The QNetworkReply doesn't need to be aborted in this case anyway. |
| |
| * platform/network/qt/QNetworkReplyHandler.cpp: |
| (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper): |
| (WebCore::QNetworkReplyWrapper::release): |
| (WebCore::QNetworkReplyWrapper::stopForwarding): |
| Rename resetConnections to stopForwarding since not all connections are related |
| to data forwarding to the client anymore. |
| (WebCore::QNetworkReplyWrapper::receiveMetaData): |
| (WebCore::QNetworkReplyWrapper::replyDestroyed): |
| (WebCore::QNetworkReplyWrapper::didReceiveFinished): |
| * platform/network/qt/QNetworkReplyHandler.h: |
| (QNetworkReplyWrapper): |
| |
| 2013-05-15 Darin Adler <darin@apple.com> |
| |
| [Mac] Make Clipboard::declareAndWriteDragImage non-virtual |
| https://bugs.webkit.org/show_bug.cgi?id=116156 |
| |
| Reviewed by Anders Carlsson. |
| |
| * dom/Clipboard.h: Make declareAndWriteDragImage non-virtual for non-legacy. |
| |
| * platform/Pasteboard.h: |
| (WebCore::Pasteboard::name): Added. Can be used in Mac platform code to do |
| pasteboard operations directly instead of through the Pasteboard class |
| functions. Not sure if we'll need it long term or not. |
| |
| * platform/mac/ClipboardMac.h: Removed declareAndWriteDragImage function. |
| |
| * platform/mac/ClipboardMac.mm: |
| (WebCore::Clipboard::declareAndWriteDragImage): Made this function a Clipboard |
| member instead of ClipboardMac. |
| |
| 2013-05-15 Peter Gal <galpeter@inf.u-szeged.hu> |
| |
| [curl] Remove version #if guards |
| https://bugs.webkit.org/show_bug.cgi?id=116152 |
| |
| Reviewed by Brent Fulgham. |
| |
| No tests required. |
| |
| * platform/network/curl/ResourceHandleCurl.cpp: |
| (WebCore::ResourceHandle::platformSetDefersLoading): Removed version guard. |
| * platform/network/curl/ResourceHandleManager.cpp: |
| (WebCore::writeCallback): Ditto. |
| (WebCore::headerCallback): Ditto. |
| (WebCore::readCallback): Ditto. |
| (WebCore::ResourceHandleManager::dispatchSynchronousJob): Ditto. |
| (WebCore::ResourceHandleManager::initializeHandle): Ditto. |
| |
| 2013-05-15 David Kilzer <ddkilzer@apple.com> |
| |
| BUILD FIX (r150089): Make WebCoreTestShim build for iOS |
| |
| * Configurations/WebCoreTestShim.xcconfig: Exclude |
| WebCoreTestShimLibrary.cpp when building for iOS. |
| |
| 2013-05-15 Radu Stavila <stavila@adobe.com> |
| |
| [CSSRegions] Implement offsetParent for elements inside named flow |
| https://bugs.webkit.org/show_bug.cgi?id=113276 |
| |
| In the offsetParent algorithm, the nearest ancestor search skips from the topmost named flow elements directly to the body element. |
| http://dev.w3.org/csswg/css-regions/#cssomview-offset-attributes |
| |
| As a result of this change, the DumpRenderTree tool would crash in |
| WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent when running the selecting-text-through-different-region-flows.html |
| test. The RenderObjects inside a flow are attached to the RenderFlowThread. However, the RenderFlowThread is attached to the |
| RenderView directly, meaning that we are going to bypass the <body>'s RenderObject while iterating the parents. |
| |
| Reviewed by Darin Adler. |
| |
| Tests: fast/regions/offsetParent-body-in-flow-thread.html |
| fast/regions/offsetParent-in-flow-thread.html |
| |
| * rendering/RenderBoxModelObject.cpp: |
| (WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent): |
| * rendering/RenderObject.cpp: |
| (WebCore::RenderObject::offsetParent): |
| |
| 2013-05-15 Darin Adler <darin@apple.com> |
| |
| [Mac] Make Clipboard::createDragImage non-virtual |
| https://bugs.webkit.org/show_bug.cgi?id=116136 |
| |
| Reviewed by Benjamin Poulain. |
| |
| * dom/Clipboard.h: Made createDragImage non-virtual for non-legacy. |
| |
| * platform/mac/ClipboardMac.h: Removed frame argument from create function |
| and constructor. Removed createDragImage and dragNSImage. Removed m_frame |
| data member. |
| |
| * platform/mac/ClipboardMac.mm: |
| (WebCore::ClipboardMac::ClipboardMac): Removed frame argument and code |
| to initialize m_frame. |
| (WebCore::Clipboard::createDragImage): Merged the createDragImage and |
| dragNSImage functions, since they were the same thing. Changed code to get |
| the frame from the drag image element. Made the createDragImage function |
| a Clipboard member instead of ClipboardMac. |
| |
| 2013-05-15 Patrick Gansterer <paroga@webkit.org> |
| |
| [WINCE] Fix calls to GlyphPage::setGlyphDataForIndex() |
| https://bugs.webkit.org/show_bug.cgi?id=116137 |
| |
| Reviewed by Andreas Kling. |
| |
| Use zero for the glyp when the fontData pointer is null. |
| This aligns GlyphPageTreeNodeWinCE with the other implementations |
| and makes all ASSERT() pass in setGlyphDataForIndex(). |
| |
| * platform/graphics/wince/GlyphPageTreeNodeWinCE.cpp: |
| (WebCore::GlyphPage::fill): |
| |
| 2013-05-15 Benjamin Poulain <bpoulain@apple.com> |
| |
| Do not bloat HTMLTokenizer with a giant inline InputStreamPreprocessor::peek |
| https://bugs.webkit.org/show_bug.cgi?id=116066 |
| |
| Reviewed by Ryosuke Niwa. |
| |
| Merge https://chromium.googlesource.com/chromium/blink/+/45e0337b2f2db535ab08365f6e763a5015e4d990. |
| |
| On x86_64, this removes 40kb from the binary. On my machine it is completely neutral on performance. |
| |
| * html/parser/InputStreamPreprocessor.h: |
| (WebCore::InputStreamPreprocessor::peek): |
| (InputStreamPreprocessor): |
| (WebCore::InputStreamPreprocessor::advance): |
| (WebCore::InputStreamPreprocessor::skipNextNewLine): |
| (WebCore::InputStreamPreprocessor::reset): |
| (WebCore::InputStreamPreprocessor::processNextInputCharacter): |
| |
| 2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com> |
| |
| Remove WTF_USE_PLATFORM_STRATEGIES |
| https://bugs.webkit.org/show_bug.cgi?id=114431 |
| |
| Reviewed by Darin Adler. |
| |
| * Modules/webdatabase/DatabaseManager.cpp: |
| (WebCore::DatabaseManager::DatabaseManager): |
| * dom/ContainerNode.cpp: |
| (WebCore::ContainerNode::suspendPostAttachCallbacks): |
| (WebCore::ContainerNode::resumePostAttachCallbacks): |
| * dom/VisitedLinkState.cpp: |
| (WebCore::VisitedLinkState::determineLinkStateSlowCase): |
| * loader/CookieJar.cpp: |
| (WebCore::cookies): |
| (WebCore::setCookies): |
| (WebCore::cookiesEnabled): |
| (WebCore::cookieRequestHeaderFieldValue): |
| (WebCore::getRawCookies): |
| (WebCore::deleteCookie): |
| * loader/FrameLoader.cpp: |
| (WebCore::FrameLoader::loadResourceSynchronously): |
| * loader/HistoryController.cpp: |
| (WebCore::addVisitedLink): |
| * loader/LoaderStrategy.cpp: |
| * loader/LoaderStrategy.h: |
| * loader/ResourceLoadScheduler.cpp: |
| (WebCore::resourceLoadScheduler): |
| * loader/ResourceLoader.cpp: |
| (WebCore::ResourceLoader::releaseResources): |
| (WebCore::ResourceLoader::willSendRequest): |
| * loader/cache/CachedResource.cpp: |
| (WebCore::CachedResource::load): |
| * loader/cache/CachedResourceLoader.cpp: |
| (WebCore::CachedResourceLoader::performPostLoadActions): |
| * platform/CookiesStrategy.h: |
| * platform/DatabaseStrategy.cpp: |
| * platform/DatabaseStrategy.h: |
| * platform/PasteboardStrategy.h: |
| * platform/PlatformStrategies.cpp: |
| * platform/PlatformStrategies.h: |
| * platform/VisitedLinkStrategy.h: |
| * platform/mac/PasteboardMac.mm: |
| * platform/network/BlobRegistry.cpp: |
| (WebCore::blobRegistry): |
| * plugins/PluginData.cpp: |
| (WebCore::PluginData::initPlugins): |
| * plugins/PluginStrategy.h: |
| * storage/StorageNamespace.cpp: |
| (WebCore::StorageNamespace::localStorageNamespace): |
| (WebCore::StorageNamespace::transientLocalStorageNamespace): |
| (WebCore::StorageNamespace::sessionStorageNamespace): |
| * storage/StorageStrategy.cpp: |
| * storage/StorageStrategy.h: |
| * workers/SharedWorkerStrategy.h: |
| |
| 2013-05-15 Dávid Szabolcs <David.Szabolcs@stud.u-szeged.hu> |
| |
| [curl] Add support for HttpOnly cookies |
| https://bugs.webkit.org/show_bug.cgi?id=116102 |
| |
| Reviewed by Brent Fulgham. |
| |
| * platform/network/curl/CookieJarCurl.cpp: |
| (WebCore::addMatchingCurlCookie): |
| (WebCore::cookiesForSession): |
| (WebCore::cookiesForDOM): |
| (WebCore): |
| (WebCore::cookieRequestHeaderFieldValue): |
| |
| 2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com> |
| |
| REGRESSION(r147548): Broken comboboxes |
| https://bugs.webkit.org/show_bug.cgi?id=115475 |
| |
| Reviewed by Gustavo Noronha Silva. |
| |
| The problem is that r147548 made the popup to be closed when a |
| blur event is received. Right before showing the popup the input |
| element is focused, so that after the the popup is shown the focus |
| event is emitted and the event handler is called again hiding the |
| popup. |
| |
| * html/HTMLSelectElement.cpp: |
| (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Check |
| element has lost the focus before closing the popup menu. |
| |
| 2013-05-14 Darin Adler <darin@apple.com> |
| |
| [Mac] Move setDragImage from ClipboardMac to PasteboardMac |
| https://bugs.webkit.org/show_bug.cgi?id=116036 |
| |
| Reviewed by Anders Carlsson. |
| |
| * dom/Clipboard.cpp: |
| (WebCore::Clipboard::~Clipboard): Stop loading the drag image when |
| the clipboard object is deallocated. It would be better if there was |
| a more-well-defined time to stop the load. |
| (WebCore::Clipboard::setDragImage): Added. Sets up a drag image |
| based on a CachedImage. This tells the image loader to load the image |
| and updates the drag image when the image arrives. Copied from the |
| code in ClipboardMac, but refactored to use a separate loader object. |
| (WebCore::Clipboard::setDragImageElement): Added. Sets up a drag image |
| based on an element. |
| (WebCore::Clipboard::updateDragImage): Added. Common code to update |
| drag image when a new one is set or when a drag image load completes. |
| (WebCore::DragImageLoader::create): Added. |
| (WebCore::DragImageLoader::DragImageLoader): Ditto. |
| (WebCore::DragImageLoader::startLoading): Ditto. |
| (WebCore::DragImageLoader::stopLoading): Ditto. |
| (WebCore::DragImageLoader::imageChanged): Ditto. |
| |
| * dom/Clipboard.h: Made setDragImage and setDragImageElement non-virtual |
| for non-legacy. Added updateDragImage and m_dragImageLoader. |
| |
| * platform/Pasteboard.h: Added setDragImage function. |
| |
| * platform/mac/ClipboardMac.h: Removed CachedImageClient as a base class |
| for ClipboardMac. Removed setDragImage and setDragImageElement. |
| |
| * platform/mac/ClipboardMac.mm: Removed setDragImage and setDragImageElement. |
| (WebCore::ClipboardMac::~ClipboardMac): Removed code to remove self as |
| client loading the drag image. This is now in the Clipboard base class. |
| |
| * platform/mac/PasteboardMac.mm: |
| (WebCore::Pasteboard::setDragImage): Added. Contains code moved here |
| from ClipboardMac. |
| |
| 2013-05-14 Ryosuke Niwa <rniwa@webkit.org> |
| |
| Use ElementTraversal in SelectorDataList::execute |
| https://bugs.webkit.org/show_bug.cgi?id=116131 |
| |
| Reviewed by Darin Adler. |
| |
| Use ElementTraversal::firstWithin and ElementTraversal::next to simplify the code. |
| |
| * dom/SelectorQuery.cpp: |
| (WebCore::SelectorDataList::execute): |
| |
| 2013-05-14 Tim Horton <timothy_horton@apple.com> |
| |
| [wk2] Not updating tiled backing coverage when main frame scrollability changes |
| https://bugs.webkit.org/show_bug.cgi?id=116123 |
| <rdar://problem/13836559> |
| |
| Reviewed by Simon Fraser. |
| |
| Export FrameView::adjustTiledBackingCoverage. |
| |
| * WebCore.exp.in: |
| |
| 2013-05-14 Alexey Proskuryakov <ap@apple.com> |
| |
| [Mac] Add a testing shim for secure event input functions |
| https://bugs.webkit.org/show_bug.cgi?id=116122 |
| |
| Reviewed by Mark Rowe. |
| |
| Added a new target with a dynamic library that interposes secure event input functions. |
| We need this to avoid interfering with user session state. |
| |
| * Configurations/WebCoreTestShim.xcconfig: Added. |
| * WebCore.xcodeproj/project.pbxproj: |
| * platform/mac/DynamicLinkerInterposing.h: Moved from Source/WebKit2/Shared/mac/DyldInterpose.h. |
| * testing/WebCoreTestShimLibrary.cpp: Added. |
| (shimEnableSecureEventInput): |
| (shimDisableSecureEventInput): |
| (shimIsSecureEventInputEnabled): |
| |
| 2013-05-14 Benjamin Poulain <bpoulain@apple.com> |
| |
| Get rid of Gradient::getColor() |
| https://bugs.webkit.org/show_bug.cgi?id=116089 |
| |
| Reviewed by Andreas Kling. |
| |
| This code is now useless, remove it. |
| |
| * html/canvas/CanvasGradient.h: |
| (CanvasGradient): |
| * platform/graphics/Gradient.cpp: |
| (WebCore::Gradient::Gradient): |
| (WebCore::Gradient::hash): |
| * platform/graphics/Gradient.h: |
| (Gradient): |
| |
| 2013-05-14 David Hyatt <hyatt@apple.com> |
| |
| REGRESSION: united.com has overlapping elements and is broken by flex box changes. |
| https://bugs.webkit.org/show_bug.cgi?id=115329 |
| <rdar://problem/13690610> |
| |
| The new flexbox spec says that flex-basis omitted in the flex shorthand defaults to |
| 0 when flex-grow/shrink are set. This has undesirable behavior when objects don't |
| end up flexing at all, and it's something the spec is going to eventually address. |
| |
| For now, though, to fix the regression, I'm making a targeted "hack" to deliberately |
| violate the spec, but to do so as minimally as possible. This hack detects if there |
| is infinite available space on a line, and if so, it treats a flex-basis of 0 like |
| auto. |
| |
| This means that when height is constrained and set by a container, flexing will do |
| the right thing. Basically any time you end up actually flexing, the spec behavior |
| should happen. If you're just laying out at intrinsic sizes, though, and no flexing |
| is going to occur, we ignore a flex-basis of 0 and just use the child's normal size. |
| |
| Note that widths don't have to be patched because the preferred logical widths |
| algorithm is broken right now and not checking flex-basis. If it did, we'd have seen |
| the same bug in the width direction. |
| |
| This width issue is covered by https://bugs.webkit.org/show_bug.cgi?id=116117 |
| |
| Reviewed by Simon Fraser. |
| |
| Added fast/flexbox/auto-height-with-flex.html |
| |
| * rendering/RenderFlexibleBox.cpp: |
| (WebCore::RenderFlexibleBox::mainAxisContentExtent): |
| Make sure we return LayoutUnit::max when you have infinite free space and not |
| max - borderPadding. |
| |
| (WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): |
| Only clear override size if it was set. Only mark for relayout if we did |
| an override size clear (i.e., if we were actually flexed). Add a new parameter, |
| hasInfiniteLineLength, that - if set - causes us to special case flex-basis:0 |
| and treat it like flex-basis:auto. |
| |
| (WebCore::RenderFlexibleBox::layoutFlexItems): |
| Define hasInfiniteLineLength and pass it to all the functions that need it. |
| |
| (WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): |
| Remove the code that marks for layout and does a layout so early. This code |
| is moving (and changing) to preferredMainAxisContentExtentForChild. |
| |
| (WebCore::RenderFlexibleBox::computeNextFlexLine): |
| Computes whether or not we have infinite line length now. |
| |
| (WebCore::RenderFlexibleBox::freezeViolations): |
| (WebCore::RenderFlexibleBox::resolveFlexibleLengths): |
| Propagate hasInfiniteLineLength through to preferredMainAxisContentExtentForChild. |
| |
| * rendering/RenderFlexibleBox.h: |
| (RenderFlexibleBox): |
| Add hasInfiniteLineLength parameter to a bunch of functions. |
| |
| 2013-05-14 Andreas Kling <akling@apple.com> |
| |
| Assertion failure in GlyphPage::setGlyphDataForIndex: (!glyph || fontData == m_fontDataForAllGlyphs) |
| <http://webkit.org/b/116113> |
| <rdar://problem/13833790> |
| |
| Reviewed by Dan Bernstein. |
| |
| If we're filling a full GlyphPage with a SimpleFontData that is actually a composite font reference, |
| we need to make sure we have per-glyph font data pointers, since it may end up using them. |
| |
| Added GlyphPage::mayUseMixedFontDataWhenFilling() which can be implemented by the platform to let |
| GlyphPageTreeNode know that it should allocate a full-sized GlyphPage for mixed font data pointers |
| in case the font is a composite font reference, or if there are CJK ideographs in the text. |
| |
| This code can be made smarter, but that's outside the scope of this change. |
| Fixes heavy asserting on bots running unreleased software. |
| |
| * platform/graphics/GlyphPage.h: |
| (GlyphPage): |
| (WebCore::GlyphPage::mayUseMixedFontDataWhenFilling): |
| * platform/graphics/GlyphPageTreeNode.cpp: |
| (WebCore::GlyphPageTreeNode::initializePage): |
| * platform/graphics/mac/GlyphPageTreeNodeMac.cpp: |
| (WebCore::shouldUseCoreText): |
| (WebCore::GlyphPage::mayUseMixedFontDataWhenFilling): |
| |
| 2013-05-14 Bem Jones-Bey <bjonesbe@adobe.com> |
| |
| Heap-use-after-free in WebCore::RenderBox::exclusionShapeOutsideInfo |
| https://bugs.webkit.org/show_bug.cgi?id=115566 |
| |
| Reviewed by David Hyatt. |
| |
| When a portion of the render tree is being detached, anonymous blocks |
| will be combined as their children are deleted. In this process, the |
| anonymous block later in the tree is merged into the one preceeding it. |
| It can happen that the later block contains floats that the previous |
| block did not contain, and thus are not in the floating objects list for |
| the new block. This can result in the new block containing floats that |
| are not in it's floating objects list, but are in the floating objects |
| lists of siblings and parents. This can cause problems when the float |
| itself is deleted, since the deletion code assumes that if a float is not |
| in it's containing block's floating objects list, it isn't in any |
| floating objects list, causing dangling pointers in the floating objects |
| lists of the siblings and parents. In order to preserve this condition |
| (removing it has serious performance implications), we need to copy the |
| floating objects from the old block to the new block. The float's |
| metrics will likely all be wrong, but since the new block is already |
| marked for layout, this will get fixed before anything gets displayed. |
| |
| Test: fast/block/float/float-append-child-crash.html |
| |
| * rendering/RenderBlock.cpp: |
| (WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo): Copy |
| floating objects list in addition to children. |
| (WebCore::RenderBlock::FloatingObject::clone): Added. |
| (WebCore::RenderBlock::removeChild): Use new method to copy children. |
| * rendering/RenderBlock.h: |
| (RenderBlock): Add method. |
| |
| 2013-05-14 Commit Queue <commit-queue@webkit.org> |
| |
| Unreviewed, rolling out r150023. |
| http://trac.webkit.org/changeset/150023 |
| https://bugs.webkit.org/show_bug.cgi?id=116120 |
| |
| Causes table layout issues (Bug 116118) and crashes on |
| buildbot waterfall pages. (Requested by ddkilzer on #webkit). |
| |
| * rendering/RenderTableSection.cpp: |
| (WebCore::RenderTableSection::calcRowLogicalHeight): |
| * rendering/RenderTableSection.h: |
| (RenderTableSection): |
| |
| 2013-05-14 Antoine Quint <graouts@apple.com> |
| |
| Snapshotted plug-ins shadow tree should reset style inheritance |
| https://bugs.webkit.org/show_bug.cgi?id=116098 |
| |
| Reset the styles such that only injected user-agent stylesheets affect |
| the rendering of snapshotted plug-ins' shadow content. |
| |
| Reviewed by Darin Adler. |
| |
| * html/HTMLPlugInImageElement.cpp: |
| (WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): |
| |
| 2013-05-14 Mihnea Ovidenie <mihnea@adobe.com> |
| |
| [CSSRegions] Improve hit testing for empty regions |
| https://bugs.webkit.org/show_bug.cgi?id=115534 |
| |
| Reviewed by David Hyatt. |
| |
| As a better follow up after WebKit bug https://bugs.webkit.org/show_bug.cgi?id=107752, |
| we can improve the code by not doing hit testing on the render flow thread object when |
| we are trying to hit test the render flow thread background. In this case, we should just bail out. |
| No new tests, covered by existing regions tests. |
| |
| * rendering/RenderFlowThread.cpp: |
| (WebCore::RenderFlowThread::nodeAtPoint): |
| (WebCore): |
| (WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion): |
| * rendering/RenderFlowThread.h: |
| |
| 2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com> |
| |
| [BlackBerry] Handle network errors when starting a new job |
| https://bugs.webkit.org/show_bug.cgi?id=116101 |
| |
| Reviewed by Rob Buis. |
| |
| Make startJob() return a network status that can be used by the |
| caller to create a network error. |
| |
| * platform/network/blackberry/NetworkJob.cpp: |
| (WebCore::NetworkJob::initialize): createNetworkStream() should |
| always return a valid pointer so use an ASSERT instead of an early |
| return to make sure we have a valid stream. |
| (WebCore::NetworkJob::startNewJobWithRequest): Only return true if |
| the network job was started successfully. |
| * platform/network/blackberry/NetworkJob.h: |
| (NetworkJob): Make initialize method void instead of bool since it |
| can't fail. |
| * platform/network/blackberry/NetworkManager.cpp: |
| (WebCore::NetworkManager::startJob): Return a network error or |
| StatusSuccess. |
| * platform/network/blackberry/NetworkManager.h: |
| (NetworkManager): |
| * platform/network/blackberry/ResourceHandleBlackBerry.cpp: |
| (WebCore::ResourceHandle::start): Return true if job was started |
| successfully. |
| (WebCore::ResourceHandle::platformLoadResourceSynchronously): |
| Check return value of startJob and fill the ResourceError with the |
| network status returned to finish the load. |
| |
| 2013-05-14 Antoine Quint <graouts@apple.com> |
| |
| [Mac] captions menu is not positioned correctly in full-screen |
| https://bugs.webkit.org/show_bug.cgi?id=116103 |
| |
| Update the positioning properties of the captions menu in full-screen |
| following the fix for https://webkit.org/b/115968. |
| |
| Reviewed by Darin Adler. |
| |
| * css/fullscreenQuickTime.css: |
| (video:-webkit-full-screen::-webkit-media-controls-closed-captions-container): |
| Add 50px to the bottom position since we're now positioned relative to the |
| media element, and use a calc() command to be right-aligned to the captions |
| icon in the media controller. The max-width and max-height properties follow |
| the same technique used for the non-full-screen mode. |
| |
| 2013-05-14 Zan Dobersek <zdobersek@igalia.com> |
| |
| [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform |
| https://bugs.webkit.org/show_bug.cgi?id=115921 |
| |
| Reviewed by Gustavo Noronha Silva. |
| |
| No new tests - no new functionality. |
| |
| * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreSVG, libWebCore, |
| libWebCorePlatform, libWebCoreGtk. Remove generation rules for ColorData.cpp and WebKitFontFamilyNames.(cpp|h). |
| * GNUmakefile.list.am: Include the ColorData.cpp and WebKitFontFamilyNames.(cpp|h) build targers under |
| platform_built_sources. |
| * bindings/gobject/GNUmakefile.am: Add platform_cppflags to the list of libWebCoreDOM CPPFLAGS. |
| |
| 2013-05-14 Zan Dobersek <zdobersek@igalia.com> |
| |
| [GTK] libPlatform, libPlatformGtk must depend on the related GNUmakefiles |
| https://bugs.webkit.org/show_bug.cgi?id=115937 |
| |
| Reviewed by Martin Robinson. |
| |
| No new tests - no new functionality. |
| |
| * GNUmakefile.am: Fix typos in two libraries' names - Webcore -> WebCore. |
| |
| 2013-05-13 Ryosuke Niwa <rniwa@webkit.org> |
| |
| Removing Attr can delete a wrong Attribute in ElementData |
| https://bugs.webkit.org/show_bug.cgi?id=116077 |
| |
| Reviewed by Benjamin Poulain. |
| |
| Merge https://chromium.googlesource.com/chromium/blink/+/e861452a292e185501e48940305947aa6a4e23c2 |
| after simplifying and renaming functions to be more WebKit style. |
| |
| The XML parser can produce elements with attributes whose names have |
| distinct prefixes, but the same expanded name. When one of these |
| attributes is put up for adoption, it may be its similarly named |
| sibling that is removed from its owner element. As a result the |
| original owner hangs onto the adopted attribute, despite the fact that |
| it is now in a different document. Sometimes it's just hard to let go. |
| |
| Test: fast/dom/adopt-attribute-crash.svg |
| |
| * dom/Element.cpp: |
| (WebCore::Element::setAttributeNode): |
| (WebCore::Element::removeAttributeNode): |
| (WebCore::ElementData::getAttributeItemIndex): |
| * dom/Element.h: |
| (ElementData): |
| (Element): |
| |
| 2013-05-14 Antti Koivisto <antti@apple.com> |
| |
| Remove ::-webkit-distributed() |
| https://bugs.webkit.org/show_bug.cgi?id=116106 |
| |
| Reviewed by Andreas Kling. |
| |
| This experimental Shadow DOM selector code is unused and has no owner. |
| |
| * css/CSSGrammar.y.in: |
| * css/CSSParser.cpp: |
| (WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded): |
| (WebCore::CSSParser::rewriteSpecifiersWithElementName): |
| * css/CSSParser.h: |
| * css/CSSParserValues.cpp: |
| (WebCore::CSSParserSelector::CSSParserSelector): |
| * css/CSSParserValues.h: |
| (CSSParserSelector): |
| * css/CSSSelector.cpp: |
| (WebCore::CSSSelector::pseudoId): |
| (WebCore::nameToPseudoTypeMap): |
| (WebCore::CSSSelector::selectorText): |
| * css/CSSSelector.h: |
| * css/CSSSelectorList.cpp: |
| * css/CSSSelectorList.h: |
| (CSSSelectorList): |
| * css/DocumentRuleSets.cpp: |
| (WebCore::DocumentRuleSets::resetAuthorStyle): |
| * css/DocumentRuleSets.h: |
| (DocumentRuleSets): |
| * css/ElementRuleCollector.cpp: |
| (WebCore::ElementRuleCollector::matchAuthorRules): |
| * css/ElementRuleCollector.h: |
| (ElementRuleCollector): |
| * css/RuleSet.cpp: |
| (WebCore::RuleSet::addChildRules): |
| * css/SelectorChecker.cpp: |
| (WebCore::SelectorChecker::match): |
| * css/SelectorFilter.cpp: |
| (WebCore::SelectorFilter::collectIdentifierHashes): |
| * html/shadow/InsertionPoint.cpp: |
| * html/shadow/InsertionPoint.h: |
| |
| 2013-05-14 Daker Fernandes Pinheiro <daker.pinheiro@openbossa.org> |
| |
| Remove RenderTheme::supportsCalendarPicker |
| https://bugs.webkit.org/show_bug.cgi?id=116068 |
| |
| Reviewed by Benjamin Poulain. |
| |
| No new tests needed because it doesn't affect behaviour. |
| |
| This method was never overrided by any platform |
| and always leaded to the same behaviour. |
| The code which depended on it was also removed. |
| |
| * html/BaseMultipleFieldsDateAndTimeInputType.cpp: |
| (WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): |
| (WebCore::BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility): |
| * html/BaseMultipleFieldsDateAndTimeInputType.h: |
| (BaseMultipleFieldsDateAndTimeInputType): |
| * page/ChromeClient.h: |
| (ChromeClient): |
| * rendering/RenderTheme.h: |
| |
| 2013-04-30 Balazs Kelemen <b.kelemen@sisa.samsung.com> |
| |
| [GStreamer] cannot seek after video finished |
| https://bugs.webkit.org/show_bug.cgi?id=114044 |
| |
| Reviewed by Philippe Normand. |
| |
| Test: media/video-seek-after-end.html |
| |
| Reland without wrong assertion. If seek is called after didEnd the pipeline |
| state will not be in GST_STATE_NULL yet but it is not a problem because we handle that. |
| |
| Rework the seeking logic to be able to seek after reseting the pipeline. |
| In addition to solve the actual problem this patch supposed to make seeking |
| more robust and correct. |
| The previous implementation tried to hide the complexity of asynchronous operations |
| on the pipeline. It did not handle the GST_MESSAGE_ASYNC_DONE message from the bus |
| but instead reported the seek as finished when it saw an asynchronous pending state |
| (GST_STATE_CHANGE_ASYNC) which could happen way before the seek is really done. |
| Now we pay attention to the GST_MESSAGE_ASYNC_DONE message to track the status of seeks. |
| Seeks are not the only operations executed asynchronously, changing the pipeling state is |
| similar. It means a seek can overlap with onother ongoing asynchronous operation. |
| This change address this by introducing an invariant for seeks, which is that we only request |
| a seek if there are no other ongoing asynchronous operations and the pipeline state is either |
| paused or playing (which is recommended anyway according to GStreamer's documentation). |
| This way we can be sure that the time when we get the next GST_MESSAGE_ASYNC_DONE message the |
| seek has been completed. |
| |
| * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: |
| (WebCore::toGstClockTime): Factored time conversation into a helper. |
| (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): |
| |
| (WebCore::MediaPlayerPrivateGStreamer::playbackPosition): The position might not be available |
| if the pipeline still has a pending state. As a workaround, if we are right after a seek we can |
| use the seek time. Avoiding this situation would be possible by not allowing any asynchronous |
| operation to overlap. I believe it would add a lot more complexity so I decided to rather introduce |
| this workaround. Otherwise those overlapping operations are handled fine by GStreamer. |
| |
| (WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Do not reset internal state variables. |
| This function called when there is an intent to restart playback but it does not actually restart it. |
| (WebCore::MediaPlayerPrivateGStreamer::currentTime): Just removed a staling newline. |
| (WebCore::MediaPlayerPrivateGStreamer::seek): Take a look to the pipeline state and act upon that. |
| If there is an ongoing asynchronous operation make the seek pending, otherwise do it now. |
| Now we handle overlapping seeks as well because I saw that it can happen in some tests. |
| Added an early return for live streams as it doesn't makes sense to try seeking in them. |
| |
| (WebCore::MediaPlayerPrivateGStreamer::handleMessage): Handle GST_MESSAGE_ASYNC_DONE and some refactoring. |
| (WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone): |
| (WebCore::MediaPlayerPrivateGStreamer::updateStates): Only handle seeks in the pending case, the rest is |
| now handled in asyncStateChangeDone. |
| (WebCore::MediaPlayerPrivateGStreamer::cacheDuration): Do not reset the m_mediaDurationKnown if the pipeline |
| has an asynchronous pending state because it would fail. It does actually happen when we get a duration message |
| after restarting the pipeline and it would result in restarting playback from the start. It seems to be a bug |
| in GStreamer that it sends the duration message too early. Also sanitized this function by merging redundant branches. |
| * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: |
| (MediaPlayerPrivateGStreamer): |
| |
| 2013-05-14 Zalan Bujtas <zalan@apple.com> |
| |
| Ellipsis text is placed to wrong position, when the truncated text is fully cut off in RTL direction. |
| https://bugs.webkit.org/show_bug.cgi?id=115858 |
| |
| Reviewed by Darin Adler. |
| |
| Take text direction into account to calculate ellipsis position in case of |
| full truncation. |
| |
| Test: fast/css/text-overflow-ellipsis-full-truncate-rtl.html |
| |
| * rendering/InlineTextBox.cpp: |
| (WebCore::InlineTextBox::placeEllipsisBox): |
| |
| 2013-05-14 Carlos Garcia Campos <cgarcia@igalia.com> |
| |
| [BlackBerry] Implement platform strategies |
| https://bugs.webkit.org/show_bug.cgi?id=112162 |
| |
| Reviewed by Rob Buis. |
| |
| This is just a refactoring, covered by existing tests. |
| |
| * CMakeLists.txt: Move PlatformStrategies.cpp from platform |
| specific makefiles to the global one now that all platforms using |
| cmake implement platform strategies. |
| * PlatformBlackBerry.cmake: |
| * PlatformEfl.cmake: |
| * PlatformWinCE.cmake: |
| * loader/CookieJar.cpp: Remove the preprocessor error that is not |
| needed anymore. |
| * loader/blackberry/CookieJarBlackBerry.cpp: Removed. |
| * platform/network/blackberry/CookieJarBlackBerry.cpp: Added. |
| (WebCore): |
| (WebCore::setCookiesFromDOM): |
| (WebCore::cookiesForDOM): |
| (WebCore::cookieRequestHeaderFieldValue): |
| (WebCore::cookiesEnabled): |
| (WebCore::getRawCookies): |
| (WebCore::deleteCookie): |
| (WebCore::getHostnamesWithCookies): |
| (WebCore::deleteCookiesForHostname): |
| (WebCore::deleteAllCookies): |
| * plugins/blackberry/PluginDataBlackBerry.cpp: Removed. |
| |
| 2013-05-14 Jocelyn Turcotte <jocelyn.turcotte@digia.com> |
| |
| [Qt] Fix a crash under ~PingLoader when the QNAM on the page has been destroyed. |
| https://bugs.webkit.org/show_bug.cgi?id=116035 |
| |
| Reviewed by Simon Hausmann. |
| |
| Reproduced with arora which does destroy the QNetworkAccessManager in some situations. |
| The problem is that PingLoader can still be pending meanwhile, holding a ResourceHandle |
| with a dangling pointer to a QNetworkReply destroyed with the QNetworkAccessManager. |
| |
| * platform/network/qt/QNetworkReplyHandler.cpp: |
| (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper): |
| Set the parent to 0 like we did before the introduction of QNetworkReplyWrapper. |
| (WebCore::QNetworkReplyWrapper::release): |
| |
| 2013-05-13 Eric Carlson <eric.carlson@apple.com> |
| |
| [Mac] update in-band caption attributes |
| https://bugs.webkit.org/show_bug.cgi?id=116057 |
| |
| Reviewed by Dean Jackson. |
| |
| * html/track/InbandTextTrack.cpp: |
| (WebCore::InbandTextTrack::updateCueFromCueData): Copy highlight color. |
| |
| * html/track/TextTrackCueGeneric.cpp: |
| (WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): "highlight" color sets the cue |
| background, "background" color sets the cue container background. |
| * html/track/TextTrackCueGeneric.h: |
| |
| * platform/graphics/InbandTextTrackPrivateClient.h: |
| |
| * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: |
| (WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Process "highlight" color. |
| |
| 2013-05-13 David Kilzer <ddkilzer@apple.com> |
| |
| BUILD FIX (r150049): Fix RetainPtr<> type in PasteboardIOS.mm |
| |
| * platform/ios/PasteboardIOS.mm: |
| (WebCore::Pasteboard::writeImage): Use RetainPtr<CFStringRef> |
| instead of RetainPtr<NSString>. |
| |
| 2013-05-13 Benjamin Poulain <bpoulain@apple.com> |
| |
| Remove platform/graphic's Generator |
| https://bugs.webkit.org/show_bug.cgi?id=116084 |
| |
| Reviewed by Darin Adler. |
| |
| The Generator no longer abstract anything useful, its only |
| implementation is Gradient. |
| |
| * GNUmakefile.list.am: |
| * WebCore.exp.in: |
| * WebCore.vcproj/WebCore.vcproj: |
| * WebCore.vcxproj/WebCore.vcxproj: |
| * WebCore.vcxproj/WebCore.vcxproj.filters: |
| * WebCore.xcodeproj/project.pbxproj: |
| * platform/graphics/GeneratedImage.h: |
| * platform/graphics/Generator.h: Removed. |
| * platform/graphics/GeneratorGeneratedImage.cpp: |
| (WebCore::GeneratorGeneratedImage::draw): |
| (WebCore::GeneratorGeneratedImage::drawPattern): |
| * platform/graphics/GeneratorGeneratedImage.h: |
| (WebCore::GeneratorGeneratedImage::create): |
| (WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage): |
| (GeneratorGeneratedImage): |
| * platform/graphics/Gradient.h: |
| (WebCore): |
| (Gradient): |
| * platform/graphics/GraphicsContext.cpp: |
| (WebCore::GraphicsContext::fillRect): |
| * platform/graphics/GraphicsContext.h: |
| (WebCore): |
| (GraphicsContext): |
| |
| 2013-05-13 David Kilzer <ddkilzer@apple.com> |
| |
| Upstream iOS Clipboard and Pasteboard changes |
| <http://webkit.org/b/116062> |
| |
| Reviewed by Darin Adler. |
| |
| * WebCore.xcodeproj/project.pbxproj: |
| * dom/Clipboard.h: |
| * platform/Pasteboard.h: |
| * platform/ios/ClipboardIOS.h: Added. |
| * platform/ios/ClipboardIOS.mm: Added. |
| * platform/ios/PasteboardIOS.mm: Added. |
| |
| 2013-05-13 Huang Dongsung <luxtella@company100.net> |
| |
| [Mac] Use pageScaleFactor * deviceScaleFactor in requiresTiledLayer() and computePixelAlignment() of GraphicsLayerCA. |
| https://bugs.webkit.org/show_bug.cgi?id=107359 |
| |
| Reviewed by Darin Adler. |
| |
| Currently GraphicsLayerCA uses pageScaleFactor in requiresTiledLayer() and |
| computePixelAlignment(), but we must use pageScaleFactor * deviceScaleFactor in |
| them. |
| It is because: |
| 1. requiresTiledLayer() uses the scale to compute an actual layer size in the device |
| pixel unit. |
| 2. computePixelAlignment() uses the scale to compute an aligned layer position |
| in the device pixel unit. |
| |
| No new tests. We can not test about requiresTiledLayer() because it depends on |
| gpu. computePixelAlignment() is correct now because fortunately Mac uses |
| only 2 (for retina display) as a deviceScaleFactor. |
| |
| * platform/graphics/ca/GraphicsLayerCA.cpp: |
| (WebCore::GraphicsLayerCA::requiresTiledLayer): |
| (WebCore::GraphicsLayerCA::computePixelAlignment): |
| |
| 2013-05-13 Christophe Dumez <ch.dumez@sisa.samsung.com> |
| |
| Rename BarInfo to BarProp and remove [NoInterfaceObject] |
| https://bugs.webkit.org/show_bug.cgi?id=116027 |
| |
| Reviewed by Andreas Kling. |
| |
| Rename BarInfo to BarProp and remove [NoInterfaceObject] extended attribute from |
| the IDL interface to match the specification: |
| http://www.w3.org/html/wg/drafts/html/master/browsers.html#barprop |
| |
| The new behavior also matches Firefox and Blink. |
| |
| No new tests, covered by LayoutTests/fast/js/global-constructors-attributes.html. |
| |
| * CMakeLists.txt: |
| * DerivedSources.cpp: |
| * DerivedSources.make: |
| * DerivedSources.pri: |
| * GNUmakefile.list.am: |
| * Target.pri: |
| * WebCore.order: |
| * WebCore.vcproj/WebCore.vcproj: |
| * WebCore.vcxproj/WebCore.vcxproj: |
| * WebCore.vcxproj/WebCore.vcxproj.filters: |
| * WebCore.xcodeproj/project.pbxproj: |
| * bindings/gobject/GNUmakefile.am: |
| * page/BarProp.cpp: Renamed from Source/WebCore/page/BarInfo.cpp. |
| * page/BarProp.h: Renamed from Source/WebCore/page/BarInfo.h. |
| * page/BarProp.idl: Renamed from Source/WebCore/page/BarInfo.idl. |
| * page/DOMWindow.cpp: |
| * page/DOMWindow.h: |
| * page/DOMWindow.idl: |
| |
| 2013-05-13 Anders Carlsson <andersca@apple.com> |
| |
| Remove ChromeClient::willPopupMenu |
| https://bugs.webkit.org/show_bug.cgi?id=116063 |
| |
| Reviewed by Andreas Kling. |
| |
| Remove ChromeClient::willPopupMenu. |
| |
| * page/ChromeClient.h: |
| |
| 2013-05-13 Beth Dakin <bdakin@apple.com> |
| |
| Headers and footers should be pinned to the left edge of the window when scrolling |
| horizontally |
| https://bugs.webkit.org/show_bug.cgi?id=116061 |
| -and corresponding- |
| <rdar://problem/13599215> |
| |
| Reviewed by Simon Fraser. |
| |
| The scrolling thread will need to know about the header and footer layers in order |
| the implement this custom scrolling behavior. |
| |
| These getters will fetch the header or footer layer from the FrameView as |
| appropriate. |
| * page/scrolling/ScrollingCoordinator.cpp: |
| (WebCore::ScrollingCoordinator::headerLayerForFrameView): |
| (WebCore::ScrollingCoordinator::footerLayerForFrameView): |
| * page/scrolling/ScrollingCoordinator.h: |
| |
| When we’re scrolling on the main thread, adjust the position of the header and |
| footer layers here. |
| (WebCore::ScrollingCoordinator::updateMainFrameScrollPosition): |
| |
| ScrollingStateScrollingNode now stores GraphicsLayers and PlatformLayers for the |
| header and footer, just like it already does for the counterScrollingLayer. |
| * page/scrolling/ScrollingStateScrollingNode.cpp: |
| (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): |
| * page/scrolling/ScrollingStateScrollingNode.h: |
| (ScrollingStateScrollingNode): |
| (WebCore::ScrollingStateScrollingNode::headerLayer): |
| (WebCore::ScrollingStateScrollingNode::footerLayer): |
| |
| Setters for the new layers. |
| * page/scrolling/mac/ScrollingCoordinatorMac.h: |
| (ScrollingCoordinatorMac): |
| * page/scrolling/mac/ScrollingCoordinatorMac.mm: |
| (WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange): |
| (WebCore::ScrollingCoordinatorMac::setHeaderLayerForNode): |
| (WebCore::ScrollingCoordinatorMac::setFooterLayerForNode): |
| |
| These setters and getters mirror the existing one for counterScrollingLayer. |
| * page/scrolling/mac/ScrollingStateScrollingNodeMac.mm: |
| (WebCore::ScrollingStateScrollingNode::headerPlatformLayer): |
| (WebCore::ScrollingStateScrollingNode::setHeaderLayer): |
| (WebCore::ScrollingStateScrollingNode::footerPlatformLayer): |
| (WebCore::ScrollingStateScrollingNode::setFooterLayer): |
| |
| And the ScrollingTree will store CALayers for the header and footer. |
| * page/scrolling/mac/ScrollingTreeScrollingNodeMac.h: |
| (ScrollingTreeScrollingNodeMac): |
| * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm: |
| (WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren): |
| |
| This is where the magic happens when we are scrolling on the scrolling thread. |
| Adjust the horizontal position the behave like a fixed object, but keep the |
| vertical position what it was when layer was created. |
| (WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition): |
| |
| RenderLayerCompositor must now provide getters for the header and footer. |
| * rendering/RenderLayerCompositor.h: |
| * rendering/RenderLayerCompositor.cpp: |
| (WebCore::RenderLayerCompositor::headerLayer): |
| (WebCore::RenderLayerCompositor::footerLayer): |
| |
| Set the anchor point for when we adjust the position later on. Also call |
| frameViewRootLayerDidChange() to get the new layers picked up and sent to the |
| scrolling tree. |
| (WebCore::RenderLayerCompositor::updateLayerForHeader): |
| (WebCore::RenderLayerCompositor::updateLayerForFooter): |
| |
| 2013-05-12 Timothy Hatcher <timothy@apple.com> |
| |
| Add support for updating the Web Inspector toolbar height. |
| |
| https://bugs.webkit.org/show_bug.cgi?id=115996 |
| |
| Reviewed by Joseph Pecoraro and Benjamin Poulain. |
| |
| * inspector/InspectorFrontendClient.h: |
| (InspectorFrontendClient): |
| * inspector/InspectorFrontendHost.cpp: |
| (WebCore::InspectorFrontendHost::setToolbarHeight): |
| * inspector/InspectorFrontendHost.h: |
| (InspectorFrontendHost): |
| * inspector/InspectorFrontendHost.idl: |
| * testing/Internals.cpp: |
| |
| 2013-05-13 Dean Jackson <dino@apple.com> |
| |
| toDataURL can return an empty image in some cases |
| https://bugs.webkit.org/show_bug.cgi?id=115981 |
| <rdar://problem/13760256> |
| |
| Reviewed by Darin Adler. |
| |
| In some accelerated rendering cases, calling toDataURL on |
| an off-screen canvas produced an empty image. The solution |
| was to force a CGContextFlush before extracting the data |
| for image generation. |
| |
| While here, I collected the flushing code from other methods |
| into a single place. Also we were getting into a situation where |
| we called flush two times in a row. |
| |
| Test: fast/canvas/toDataURL-not-empty.html |
| |
| * platform/graphics/ImageBuffer.h: |
| (ImageBuffer): Define two new methods flushContext and flushContextIfNecessary. |
| * platform/graphics/cg/ImageBufferCG.cpp: |
| (WebCore::ImageBuffer::context): Call flushContextIfNecessary. |
| (WebCore::ImageBuffer::flushContextIfNecessary): Moved the 10.7 code in here. |
| (WebCore::ImageBuffer::flushContext): Calls CGContextFlush. |
| (WebCore::ImageBuffer::getUnmultipliedImageData): Call new helper. |
| (WebCore::ImageBuffer::getPremultipliedImageData): Call new helper. |
| (WebCore::ImageBuffer::toDataURL): Flush the CG context. |
| |
| 2013-05-13 David Hyatt <hyatt@apple.com> |
| |
| Regressions in flexbox layout caused by the flexing optimizations. |
| https://bugs.webkit.org/show_bug.cgi?id=116058 |
| <rdar://problem/13863647> |
| |
| Reviewed by Beth Dakin. |
| |
| Roll out the flex-related changes from r149597 so that the layout |
| algorithm goes back to the way it was. Leave the repainting optimizations |
| in place though. |
| |
| * rendering/RenderDeprecatedFlexibleBox.cpp: |
| (WebCore::gatherFlexChildrenInfo): |
| (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): |
| (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): |
| |
| 2013-05-13 Philippe Normand <pnormand@igalia.com> |
| |
| Unreviewed, rolling out r150014. |
| http://trac.webkit.org/changeset/150014 |
| https://bugs.webkit.org/show_bug.cgi?id=86410 |
| |
| Broke video playback on WK2 and some webgl tests |
| |
| * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: |
| (WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase): |
| (WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint): |
| (WebCore::MediaPlayerPrivateGStreamerBase::paint): |
| * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: |
| (MediaPlayerPrivateGStreamerBase): |
| |
| 2013-05-13 Christophe Dumez <ch.dumez@sisa.samsung.com> |
| |
| Unreviewed, rolling out r150022. |
| http://trac.webkit.org/changeset/150022 |
| https://bugs.webkit.org/show_bug.cgi?id=114044 |
| |
| Causes assertions in media tests |
| |
| * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: |
| (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): |
| (WebCore::MediaPlayerPrivateGStreamer::playbackPosition): |
| (WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): |
| (WebCore::MediaPlayerPrivateGStreamer::currentTime): |
| (WebCore::MediaPlayerPrivateGStreamer::seek): |
| (WebCore::MediaPlayerPrivateGStreamer::handleMessage): |
| * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: |
| (MediaPlayerPrivateGStreamer): |
| |
| 2013-05-13 Bem Jones-Bey <bjonesbe@adobe.com> |
| |
| Floats should not overhang from flex items |
| https://bugs.webkit.org/show_bug.cgi?id=115925 |
| |
| Reviewed by David Hyatt. |
| |
| Allowing floats to overhand from flex items is not only against the |
| spec, it causes bad bugs. Fix this by having flex items properly avoid |
| floats. |
| |
| Test: fast/block/float/float-not-removed-crash2.html |
| |
| * rendering/RenderBox.cpp: |
| (WebCore::RenderBox::avoidsFloats): Add flex items to avoid floats. |
| * rendering/RenderBox.h: |
| (WebCore::RenderBox::isFlexItemIncludingDeprecated): Determine if the current box is a |
| flex item or deprecated flex item. |
| |
| 2013-05-13 Zoltan Horvath <zoltan@webkit.org> |
| |
| [CSS Regions][CSS Exclusions] Shape-inside on regions should respect region borders and paddings |
| https://bugs.webkit.org/show_bug.cgi?id=115456 |
| |
| Reviewed by David Hyatt. |
| |
| I refactored the computation logic of shape-inside on regions by removing access to RenderFlowThread from ExclusionShapeInfo's logicalTopOffset |
| function, this means all the logic is now existing in RenderBlockLineLayout.cpp. By modifying the logicalTopOffset it turned out that the borders |
| and padding hadn't worked correctly, since borders and paddings were counted twice in the shape-inside's computation. This patch adds the necessary |
| modifications to let it respect the borders and padding in the correct way. I created 2 new helper functions to prevent increasing the code size of |
| the layoutRunsAndFloatsInRange function. |
| |
| I introduced 7 new tests to test for testing the correct behavior. |
| |
| Tests: fast/regions/shape-inside/shape-inside-on-first-region-block-content.html |
| fast/regions/shape-inside/shape-inside-on-first-region-inline-content.html |
| fast/regions/shape-inside/shape-inside-on-second-region-block-content.html |
| fast/regions/shape-inside/shape-inside-on-second-region-inline-content.html |
| fast/regions/shape-inside/shape-inside-on-regions-inline-content.html |
| fast/regions/shape-inside/shape-inside-with-region-borders.html |
| fast/regions/shape-inside/shape-inside-with-region-padding.html |
| |
| * rendering/ExclusionShapeInfo.cpp: |
| (WebCore): Remove FlowThread logic from logicalTopOffset move definition to header. |
| * rendering/ExclusionShapeInfo.h: |
| (WebCore::ExclusionShapeInfo::logicalTopOffset): Moved from cpp. |
| (WebCore::ExclusionShapeInfo::logicalLeftOffset): Add condition for RenderRegions. |
| * rendering/RenderBlock.h: |
| (RenderBlock): Add definition to the new helper members. |
| * rendering/RenderBlockLineLayout.cpp: |
| (WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Modified the flow thread case to return the appropriate region. |
| (WebCore::RenderBlock::updateLineBoundariesForExclusions): Added new helper function. Modify the shape-inside on regions |
| line boundaries and position computation logic. |
| (WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): Added new helper function which handles the flow thread case also. |
| (WebCore::RenderBlock::layoutRunsAndFloatsInRange): Modified the code to use the helper functions. |
| |
| 2013-05-13 Bear Travis <betravis@adobe.com> |
| |
| [css exclusions] Enable CSS Exclusions by default when CSS_EXCLUSIONS is set |
| https://bugs.webkit.org/show_bug.cgi?id=115919 |
| |
| Reviewed by Dean Jackson. |
| |
| Change the RuntimeEnabledFeatures::isCSSExclusionsEnabled boolean to default |
| to true. CSS Exclusions can still be enabled / disabled in platforms by |
| setting the CSS_EXCLUSIONS compile flag in one of the FeatureDefine files. |
| |
| Test: fast/exclusions/css-exclusions-enabled.html |
| |
| * bindings/generic/RuntimeEnabledFeatures.cpp: |
| (WebCore): |
| |
| 2013-05-13 Suchit Agrawal <a.suchit@samsung.com> |
| |
| Cell heights are disproportional when a row-spanning cell contains a block element that determines the height of the rows |
| https://bugs.webkit.org/show_bug.cgi?id=52185 |
| |
| Reviewed by David Hyatt. |
| |
| Cells heights are not proper when rowspan cell have its own height and rowspan height |
| is more than the height of the rows present in rowspan. |
| |
| After calculating logical height of the rows in the table, we are recalculating the height |
| of the rows present in rowspan. Based on the ratio of row's logical height, we are |
| distributing rowspan cell height in rows. |
| |
| Test: fast/table/table-rowspan-height-distribution-in-rows.html |
| |
| * rendering/RenderTableSection.cpp: |
| (WebCore): |
| |
| Update the logical height of the rows based on rowspan cell height. |
| (WebCore::RenderTableSection::distributeRowSpanHeightToRows): |
| |
| It calculates logical height of the rows in the table. |
| (WebCore::RenderTableSection::calcRowLogicalHeight): |
| |
| Added new private API to distribute rowSpan cell height in rows. |
| * rendering/RenderTableSection.h: |
| (RenderTableSection): |
| |
| 2013-04-30 Balazs Kelemen <b.kelemen@sisa.samsung.com> |
| |
| [GStreamer] cannot seek after video finished |
| https://bugs.webkit.org/show_bug.cgi?id=114044 |
| |
| Reviewed by Philippe Normand. |
| |
| Test: media/video-seek-after-end.html |
| |
| Rework the seeking logic to be able to seek after reseting the pipeline. |
| In addition to solve the actual problem this patch supposed to make seeking |
| more robust and correct. |
| The previous implementation tried to hide the complexity of asynchronous operations |
| on the pipeline. It did not handle the GST_MESSAGE_ASYNC_DONE message from the bus |
| but instead reported the seek as finished when it saw an asynchronous pending state |
| (GST_STATE_CHANGE_ASYNC) which could happen way before the seek is really done. |
| Now we pay attention to the GST_MESSAGE_ASYNC_DONE message to track the status of seeks. |
| Seeks are not the only operations executed asynchronously, changing the pipeling state is |
| similar. It means a seek can overlap with onother ongoing asynchronous operation. |
| This change address this by introducing an invariant for seeks, which is that we only request |
| a seek if there are no other ongoing asynchronous operations and the pipeline state is either |
| paused or playing (which is recommended anyway according to GStreamer's documentation). |
| This way we can be sure that the time when we get the next GST_MESSAGE_ASYNC_DONE message the |
| seek has been completed. |
| |
| * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: |
| (WebCore::toGstClockTime): Factored time conversation into a helper. |
| (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): |
| |
| (WebCore::MediaPlayerPrivateGStreamer::playbackPosition): The position might not be available |
| if the pipeline still has a pending state. As a workaround, if we are right after a seek we can |
| use the seek time. Avoiding this situation would be possible by not allowing any asynchronous |
| operation to overlap. I believe it would add a lot more complexity so I decided to rather introduce |
| this workaround. Otherwise those overlapping operations are handled fine by GStreamer. |
| |
| (WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Do not reset internal state variables. |
| This function called when there is an intent to restart playback but it does not actually restart it. |
| (WebCore::MediaPlayerPrivateGStreamer::currentTime): Just removed a staling newline. |
| (WebCore::MediaPlayerPrivateGStreamer::seek): Take a look to the pipeline state and act upon that. |
| If there is an ongoing asynchronous operation make the seek pending, otherwise do it now. |
| Now we handle overlapping seeks as well because I saw that it can happen in some tests. |
| Added an early return for live streams as it doesn't makes sense to try seeking in them. |
| |
| (WebCore::MediaPlayerPrivateGStreamer::handleMessage): Handle GST_MESSAGE_ASYNC_DONE and some refactoring. |
| (WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone): |
| (WebCore::MediaPlayerPrivateGStreamer::updateStates): Only handle seeks in the pending case, the rest is |
| now handled in asyncStateChangeDone. |
| (WebCore::MediaPlayerPrivateGStreamer::cacheDuration): Do not reset the m_mediaDurationKnown if the pipeline |
| has an asynchronous pending state because it would fail. It does actually happen when we get a duration message |
| after restarting the pipeline and it would result in restarting playback from the start. It seems to be a bug |
| in GStreamer that it sends the duration message too early. Also sanitized this function by merging redundant branches. |
| * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: |
| (MediaPlayerPrivateGStreamer): |
| |
| 2013-05-12 Darin Adler <darin@apple.com> |
| |
| [Mac] Move writeRange/PlainText/URL from ClipboardMac to PasteboardMac |
| https://bugs.webkit.org/show_bug.cgi?id=116009 |
| |
| Reviewed by Andreas Kling. |
| |
| * dom/Clipboard.cpp: |
| (WebCore::Clipboard::writeRange): Added. Moved from ClipboardMac, |
| but added some FIXMEs. |
| (WebCore::Clipboard::writePlainText): Ditto. |
| (WebCore::Clipboard::writeURL): Ditto. |
| |
| * dom/Clipboard.h: Made writeURL, writeRange, and writePlainText |
| non-virtual in non-legacy clipboard implementations. |
| |
| * platform/mac/ClipboardMac.h: Removed writeRange, writeURL, and |
| writePlainText. |
| * platform/mac/ClipboardMac.mm: Ditto. |
| |
| 2013-05-13 Noam Rosenthal <noam@webkit.org> |
| |
| [CoordGfx] requestAnimationFrame performance issues |
| https://bugs.webkit.org/show_bug.cgi?id=112345 |
| |
| Reviewed by Jocelyn Turcotte. |
| |
| Removed current requestAnimationFrame logic from CoordinatedGraphics. The new logic |
| is entirely in WebKit2 CoordinatedLayerTreeHost. |
| |
| Covered by existing tests in fast/animations. |
| |
| * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp: |
| (WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene): |
| (WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext): |
| * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h: |
| (CoordinatedGraphicsScene): |
| |
| 2013-05-13 VÃctor Manuel Jáquez Leal <vjaquez@igalia.com> |
| |
| [texmap][GStreamer] Composited Video support |
| https://bugs.webkit.org/show_bug.cgi?id=86410 |
| |
| Reviewed by Philippe Normand. |
| |
| Enable the video accelerated compositing using the WebKit's |
| TextureMapper. |
| |
| This patch does not use hardware accelerated video decoding. It |
| provides a generic path for system memory buffers. |
| |
| No new tests, already covered by existing tests. |
| |
| * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: |
| (WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase): |
| (WebCore): |
| (WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): update the |
| texture content with the new received video buffer. |
| (WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint): choose to |
| use the accelerated compositing or the normal code path |
| (WebCore::MediaPlayerPrivateGStreamerBase::paint): if accelerated |
| compositing is used this method is halted. |
| (WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper): get |
| a texture from the pool and draws it if it is already available. |
| * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: |
| (MediaPlayerPrivateGStreamerBase): |
| (WebCore::MediaPlayerPrivateGStreamerBase::platformLayer): returns itself |
| (WebCore::MediaPlayerPrivateGStreamerBase::supportsAcceleratedRendering): |
| returns true |
| |
| 2013-05-13 Andreas Kling <akling@apple.com> |
| |
| Document: Use a DeferrableOneShotTimer to throw out StyleResolver when unused. |
| <http://webkit.org/b/115929> |
| |
| Reviewed by Anders Carlsson. |
| |
| Nothing exciting here, just replacing a rickety-looking punting mechanism with a proper |
| DeferrableOneShotTimer. Note that the timeout changes from 60 to 30 seconds because DOST |
| works by punting a full interval on next timeout. |
| |
| * dom/Document.cpp: |
| (WebCore::Document::Document): |
| (WebCore::Document::didAccessStyleResolver): |
| (WebCore::Document::styleResolverThrowawayTimerFired): |
| * dom/Document.h: |
| (Document): |
| |
| 2013-05-13 Andreas Kling <akling@apple.com> |
| |
| REGRESSION(r149287): FoldingText only shows me half of my text. |
| <http://webkit.org/b/115956> |
| <rdar://problem/13831099> |
| |
| Reviewed by Antti Koivisto. |
| |
| Check if the FrameView geometry changed post-layout, and send a resize event if needed. |
| This brings us closer to the original resize event behavior, with the exception that |
| setFrameRect() still fires an event right away if possible. This means we are still |
| guarded from FOUC's but frames that layout via [WebHTMLView layoutToMinimumPageWidth] |
| also get resize events like they used to. |
| |
| No new tests, because I don't know how to test this. |
| |
| * page/FrameView.h: |
| * page/FrameView.cpp: |
| (WebCore::FrameView::setFrameRect): |
| (WebCore::FrameView::performPostLayoutTasks): |
| (WebCore::FrameView::sendResizeEventIfNeeded): |
| |
| Factor out the resize event logic from setFrameRect() so we can call it from both |
| there and performPostLayoutTasks(). sendResizeEventIfNeeded() only sends an event |
| if view geometry or zoom factor has changed since last time it was called. |
| |
| 2013-05-13 Antti Koivisto <antti@apple.com> |
| |
| Remove unneeded counters from ScopeContentDistribution. |
| https://bugs.webkit.org/show_bug.cgi?id=116028 |
| |
| Reviewed by Andreas Kling. |
| |
| They don't do much. |
| |
| * WebCore.exp.in: |
| * dom/ShadowRoot.cpp: |
| (WebCore::ShadowRoot::ShadowRoot): |
| * dom/ShadowRoot.h: |
| |
| No need for registration code anymore. |
| |
| * html/shadow/ContentDistributor.cpp: |
| (WebCore::ScopeContentDistribution::ScopeContentDistribution): |
| |
| Default m_insertionPointListIsValid to true to avoid crawling when there are no InsertionPoints. |
| |
| (WebCore::ScopeContentDistribution::ensureInsertionPointList): |
| (WebCore::ScopeContentDistribution::registerInsertionPoint): |
| (WebCore::ScopeContentDistribution::unregisterInsertionPoint): |
| * html/shadow/ContentDistributor.h: |
| |
| Remove distributeNodeChildrenTo, it was only used by the older/younger shadow root code. |
| |
| * testing/Internals.cpp: |
| * testing/Internals.h: |
| * testing/Internals.idl: |
| |
| 2013-05-13 Seokju Kwon <seokju.kwon@gmail.com> |
| |
| Web Inspector: Remove unused references from projects in Visual Studio |
| https://bugs.webkit.org/show_bug.cgi?id=116002 |
| |
| Reviewed by Csaba Osztrogonác. |
| |
| nativeMemoryProfiler.css and NativeMemorySnapshotView.js were removed in r149807. |
| |
| No new tests, no behavior change. |
| |
| * WebCore.vcproj/WebCore.vcproj: |
| * WebCore.vcxproj/WebCore.vcxproj: |
| * WebCore.vcxproj/WebCore.vcxproj.filters: |
| |
| 2013-05-13 Zalan Bujtas <zalan@apple.com> |
| |
| WebProcess consuming very high CPU on linkedin.com |
| https://bugs.webkit.org/show_bug.cgi?id=115601 |
| |
| Reviewed by Andreas Kling. |
| |
| Disable WEB_TIMING_MINIMAL. |
| Turn off window.performance and performance.now(). Some JS frameworks expect |
| additional Web Timing APIs, when performance.now() is available. |
| |
| * Configurations/FeatureDefines.xcconfig: |
| * dom/EventTargetFactory.in: |
| * page/DOMWindow.cpp: |
| (WebCore::DOMWindow::~DOMWindow): |
| (WebCore::DOMWindow::resetDOMWindowProperties): |
| (WebCore): |
| * page/DOMWindow.h: |
| (DOMWindow): |
| * page/DOMWindow.idl: |
| * page/Performance.cpp: |
| (WebCore::Performance::timing): |
| * page/Performance.h: |
| (Performance): |
| * page/Performance.idl: |
| |
| 2013-05-12 Eric Carlson <eric.carlson@apple.com> |
| |
| REGRESSION (r149749): Video becomes invisible when it starts playing at newyorkbygehry.com |
| https://bugs.webkit.org/show_bug.cgi?id=115963 |
| |
| Reviewed by Dean Jackson. |
| |
| Test: media/video-remove-insert-repaints.html |
| |
| * html/HTMLMediaElement.cpp: |
| (WebCore::HTMLMediaElement::insertedInto): Set m_inActiveDocument when inserted into a document. |
| (WebCore::HTMLMediaElement::removedFrom): Fix logging. |
| |
| 2013-05-12 David Kilzer <ddkilzer@apple.com> |
| |
| Move sudden termination symbols to the Mac-only section |
| |
| * WebCore.exp.in: Move the sudden termination symbols to the |
| !PLATFORM(IOS) section for reals this time. |
| |
| 2013-05-12 Darin Adler <darin@apple.com> |
| |
| Fix Mac build. |
| |
| * platform/mac/PasteboardMac.mm: Add back include of ClipboardMac.h |
| that was removed by accident a couple of patches back. |
| |
| 2013-05-12 Darin Adler <darin@apple.com> |
| |
| [Mac] Moved files function from ClipboardMac to PasteboardMac |
| https://bugs.webkit.org/show_bug.cgi?id=116008 |
| |
| Reviewed by Anders Carlsson. |
| |
| * dom/Clipboard.cpp: |
| (WebCore::Clipboard::files): Added. Moved the DOM-depdendent and |
| platform-independent part of the files function in ClipboardMac here. |
| |
| * dom/Clipboard.h: Made files function non-virtual in non-legacy case. |
| |
| * platform/Pasteboard.h: Removed static member function |
| absoluteURLsFromPasteboardFilenames since it can now be private to |
| PasteboardMac. Added member function readFilenames. |
| |
| * platform/mac/ClipboardMac.h: Removed function member files and also |
| now-unused data member m_clipboardContents. |
| |
| * platform/mac/ClipboardMac.mm: Removed files function. |
| (WebCore::ClipboardMac::ClipboardMac): Removed code to initialize |
| m_clipboardContents. |
| |
| * platform/mac/PasteboardMac.mm: |
| (WebCore::absoluteURLsFromPasteboardFilenames): Changed from a static |
| member function to a file-local function. |
| (WebCore::absoluteURLsFromPasteboard): Changed to call the function |
| above in its new location. |
| (WebCore::Pasteboard::readFilenames): Added. Code from ClipboardMac, |
| minus the DOM-specific parts. Added a FIXME about the peculiar round |
| trip through NSURL this code takes. |
| |
| 2013-05-12 Anders Carlsson <andersca@apple.com> |
| |
| Fix WebKit2 build. |
| |
| * WebCore.exp.in: |
| Put WebCore::disableSuddenTermination and WebCore::enableSuddenTermination symbols in the right section. |
| |
| 2013-05-12 Darin Adler <darin@apple.com> |
| |
| [Mac] Move types function from ClipboardMac to PasteboardMac |
| https://bugs.webkit.org/show_bug.cgi?id=116007 |
| |
| Reviewed by Anders Carlsson. |
| |
| * dom/Clipboard.cpp: |
| (WebCore::Clipboard::types): Added. Calls through to Pasteboard |
| after doing checks needed at this level. |
| |
| * dom/Clipboard.h: Made types function non-virtual in non-legacy case, |
| and removed non-helpful comment. |
| |
| * platform/Pasteboard.h: Updated includes and comments at the top of |
| the file a bit. Removed static member function addHTMLClipboardTypesForCocoaType, |
| since it can now be private to PasteboardMac. Added member function types. |
| |
| * platform/mac/ClipboardMac.h: Removed types function. |
| * platform/mac/ClipboardMac.mm: Ditto. |
| |
| * platform/mac/PasteboardMac.mm: |
| (WebCore::addHTMLClipboardTypesForCocoaType): Made this a file-local |
| function instead of a static member function. |
| (WebCore::Pasteboard::types): Added. Moved from ClipboardMac. |
| |
| 2013-05-12 Darin Adler <darin@apple.com> |
| |
| [Mac] Move setData from ClipboardMac to PasteboardMac |
| https://bugs.webkit.org/show_bug.cgi?id=116006 |
| |
| Reviewed by Anders Carlsson. |
| |
| * dom/Clipboard.cpp: |
| (WebCore::Clipboard::setData): Added. Calls through to Pasteboard |
| after doing checks needed at this level. |
| |
| * dom/Clipboard.h: Made setData non-virtual in non-legacy case. |
| |
| * platform/Pasteboard.h: Updated includes and forward declarations. |
| Removed static member function cocoaTypeFromHTMLClipboardType, since |
| it can now be private to PasteboardMac. Added static member function |
| addHTMLClipboardTypesForCocoaType, which is shared between the |
| ClipboardMac and PasteboardMac files for now. Added writeString. |
| |
| * platform/mac/ClipboardMac.h: Removed setData. |
| |
| * platform/mac/ClipboardMac.mm: Removed utiTypeFromCocoaType, |
| addHTMLClipboardTypesForCocoaType, and setData. |
| (WebCore::ClipboardMac::types): Call addHTMLClipboardTypesForCocoaType |
| as a Pasteboard static member function, for now. |
| |
| * platform/mac/PasteboardMac.mm: |
| (WebCore::cocoaTypeFromHTMLClipboardType): Added. Moved from ClipboardMac. |
| (WebCore::Pasteboard::readString): Changed to call |
| cocoaTypeFromHTMLClipboardType as a file-local function, not a member |
| function (in fact, we didn't need to repeat the class name before, either, |
| so this is just removing something we didn't need). |
| (WebCore::utiTypeFromCocoaType): Added. Moved from ClipboardMac. |
| (WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType): Ditto. |
| (WebCore::Pasteboard::writeString): Ditto. |
| |
| 2013-05-12 Darin Adler <darin@apple.com> |
| |
| [Mac] Move getData from ClipboardMac to PasteboardMac |
| https://bugs.webkit.org/show_bug.cgi?id=116005 |
| |
| Reviewed by Anders Carlsson. |
| |
| * dom/Clipboard.cpp: |
| (WebCore::Clipboard::Clipboard): Added a new boolean argument, forFileDrag, |
| to the constructor. Maybe we can find a better way to do this once we move |
| all the platforms over, but this boolean seems a good way to do it for now. |
| (WebCore::Clipboard::getData): Added. Calls through to Pasteboard after |
| doing the canReadData check, which is part of DOM rules, not the platform. |
| Also checks for the file drag case like the old ClipboardMac code did. |
| |
| * dom/Clipboard.h: Made getData non-virtual in non-legacy case. |
| |
| * platform/Pasteboard.h: Added a static member function named |
| absoluteURLsFromPasteboardFilenames, temporary so it can be shared between |
| ClipboardMac and PasteboardMac. Added a readString public function member, |
| and a m_changeCount data member. The type of m_changeCount is long since |
| that can always hold an NSInteger but yet is a type we can compile without |
| including the header file that defines NSInteger. |
| |
| * platform/mac/ClipboardMac.h: Removed getData. |
| * platform/mac/ClipboardMac.mm: Removed getData. |
| (WebCore::ClipboardMac::ClipboardMac): Added code to pass in the new |
| forFileDrag boolean. |
| (WebCore::ClipboardMac::files): Call absoluteURLsFromPasteboardFilenames |
| as a static member function in Pasteboard since we moved it there. |
| |
| * platform/mac/PasteboardMac.mm: |
| (WebCore::Pasteboard::Pasteboard): Initialize the change count, so later |
| pasteboard operations can check it. |
| (WebCore::Pasteboard::absoluteURLsFromPasteboardFilenames): Added. Moved |
| here from ClipboardMac. |
| (WebCore::absoluteURLsFromPasteboard): Ditto. |
| (WebCore::Pasteboard::readString): Added. Moved here from ClipboardMac. |
| |
| 2013-05-12 Anders Carlsson <andersca@apple.com> |
| |
| Stop including UnusedParam.h |
| https://bugs.webkit.org/show_bug.cgi?id=116003 |
| |
| Reviewed by Sam Weinig. |
| |
| UnusedParam.h is empty now so there's no need to include it anymore. |
| |
| * Modules/encryptedmedia/CDMPrivateAVFoundation.mm: |
| * Modules/indexeddb/IDBFactoryBackendImpl.cpp: |
| * Modules/indexeddb/IDBObjectStore.cpp: |
| * Modules/webdatabase/DatabaseServer.cpp: |
| * Modules/webdatabase/DatabaseThread.cpp: |
| * bindings/js/JSDOMWindowBase.cpp: |
| * bindings/objc/DOMObject.mm: |
| * css/CSSCursorImageValue.cpp: |
| * css/DeprecatedStyleBuilder.cpp: |
| * dom/EventDispatcher.cpp: |
| * dom/Node.cpp: |
| * editing/AlternativeTextController.h: |
| * editing/Editor.cpp: |
| * html/HTMLPlugInElement.cpp: |
| * html/canvas/CanvasRenderingContext2D.cpp: |
| * html/canvas/OESVertexArrayObject.h: |
| * html/parser/HTMLConstructionSite.cpp: |
| * html/parser/HTMLTokenizer.cpp: |
| * html/track/InbandTextTrack.cpp: |
| * inspector/InspectorCanvasInstrumentation.h: |
| * inspector/InspectorConsoleInstrumentation.h: |
| * inspector/InspectorController.cpp: |
| * inspector/InspectorCounters.h: |
| * inspector/InspectorDatabaseInstrumentation.h: |
| * inspector/InspectorInstrumentation.h: |
| * loader/DocumentThreadableLoader.cpp: |
| * loader/PingLoader.cpp: |
| * loader/appcache/ApplicationCacheGroup.cpp: |
| * loader/cache/CachedResourceLoader.cpp: |
| * loader/mac/DocumentLoaderMac.cpp: |
| * page/ChromeClient.h: |
| * page/Console.cpp: |
| * page/FrameView.cpp: |
| * page/PageConsole.cpp: |
| * page/animation/AnimationController.cpp: |
| * page/animation/ImplicitAnimation.cpp: |
| * page/animation/KeyframeAnimation.cpp: |
| * platform/LocalizedStrings.cpp: |
| * platform/ScrollAnimator.h: |
| * platform/ThreadGlobalData.cpp: |
| * platform/blackberry/AsyncFileSystemBlackBerry.cpp: |
| * platform/graphics/Font.cpp: |
| * platform/graphics/GlyphBuffer.h: |
| * platform/graphics/Gradient.cpp: |
| * platform/graphics/ShadowBlur.cpp: |
| * platform/graphics/SimpleFontData.cpp: |
| * platform/graphics/SimpleFontData.h: |
| * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: |
| * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: |
| * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: |
| * platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm: |
| * platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm: |
| * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: |
| * platform/graphics/blackberry/GradientBlackBerry.cpp: |
| * platform/graphics/blackberry/GraphicsContextBlackBerry.cpp: |
| * platform/graphics/ca/mac/PlatformCAAnimationMac.mm: |
| * platform/graphics/ca/mac/PlatformCALayerMac.mm: |
| * platform/graphics/ca/mac/WebTileLayer.mm: |
| * platform/graphics/ca/win/PlatformCAAnimationWin.cpp: |
| * platform/graphics/cg/GraphicsContextCG.cpp: |
| * platform/graphics/cg/ImageBufferCG.cpp: |
| * platform/graphics/cg/ImageSourceCG.cpp: |
| * platform/graphics/clutter/PlatformClutterAnimation.cpp: |
| * platform/graphics/filters/ValidatedCustomFilterOperation.cpp: |
| * platform/graphics/gstreamer/GStreamerVersioning.cpp: |
| * platform/graphics/mac/GraphicsContext3DMac.mm: |
| * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: |
| * platform/graphics/mac/SimpleFontDataMac.mm: |
| * platform/graphics/mac/WebGLLayer.mm: |
| * platform/graphics/mac/WebLayer.mm: |
| * platform/graphics/mac/WebTiledLayer.mm: |
| * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: |
| * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: |
| * platform/graphics/qt/GraphicsContext3DQt.cpp: |
| * platform/graphics/texmap/TextureMapper.h: |
| * platform/graphics/wince/ImageBufferWinCE.cpp: |
| * platform/mac/PasteboardMac.mm: |
| * platform/mac/ScrollAnimatorMac.mm: |
| * platform/mac/ScrollViewMac.mm: |
| * platform/mac/ScrollbarThemeMac.mm: |
| * platform/mac/SharedTimerMac.mm: |
| * platform/mac/WebCoreFullScreenPlaceholderView.mm: |
| * platform/mac/WebCoreObjCExtras.mm: |
| * platform/mac/WebFontCache.mm: |
| * platform/mac/WebVideoFullscreenController.mm: |
| * platform/mac/WebVideoFullscreenHUDWindowController.mm: |
| * platform/mac/WebWindowAnimation.mm: |
| * platform/network/blackberry/CredentialStorageBlackBerry.cpp: |
| * platform/network/cf/ResourceErrorCF.cpp: |
| * platform/network/mac/CookieStorageMac.mm: |
| * platform/network/mac/ResourceHandleMac.mm: |
| * platform/network/win/ResourceHandleWin.cpp: |
| * platform/text/TextEncodingDetectorICU.cpp: |
| * rendering/RenderFlowThread.h: |
| * rendering/RenderImage.cpp: |
| * rendering/RenderLayer.cpp: |
| * rendering/RenderObject.cpp: |
| * rendering/RenderTreeAsText.cpp: |
| * rendering/svg/RenderSVGResourceClipper.cpp: |
| * rendering/svg/RenderSVGResourceFilter.cpp: |
| * rendering/svg/RenderSVGResourceGradient.cpp: |
| * rendering/svg/RenderSVGResourceMasker.cpp: |
| * rendering/svg/SVGRenderSupport.cpp: |
| * rendering/svg/SVGTextLayoutEngineSpacing.cpp: |
| * workers/WorkerContext.cpp: |
| * workers/WorkerScriptLoader.cpp: |
| * xml/XMLHttpRequest.cpp: |
| * xml/parser/XMLDocumentParserLibxml2.cpp: |
| |
| 2013-05-12 Darin Adler <darin@apple.com> |
| |
| [Mac] Move clearAllData from ClipboardMac to PasteboardMac |
| https://bugs.webkit.org/show_bug.cgi?id=116001 |
| |
| Reviewed by Andreas Kling. |
| |
| * dom/Clipboard.cpp: |
| (WebCore::Clipboard::clearAllData): Added. Calls through to Pasteboard after |
| doing the canWriteData check, which is part of DOM rules, not the platform. |
| |
| * dom/Clipboard.h: Made clearAllData non-virtual in non-legacy case. |
| |
| * platform/mac/ClipboardMac.h: Removed clearAllData. |
| * platform/mac/ClipboardMac.mm: Ditto. |
| |
| 2013-05-12 Darin Adler <darin@apple.com> |
| |
| [Mac] Move clearData from ClipboardMac to PasteboardMac |
| https://bugs.webkit.org/show_bug.cgi?id=116000 |
| |
| Reviewed by Andreas Kling. |
| |
| * dom/Clipboard.cpp: |
| (WebCore::Clipboard::clearData): Added. Calls through to Pasteboard after |
| doing the canWriteData check, which is part of DOM rules, not the platform. |
| |
| * dom/Clipboard.h: Made clearData non-virtual in non-legacy case. |
| |
| * platform/Pasteboard.h: Added an overload of the clear function that takes |
| a single type and clears only that type. Also temporarily exported the |
| cocoaTypeFromHTMLClipboardType function as a static member so it can be used |
| in both ClipboardMac and PasteboardMac during the transition. |
| |
| * platform/mac/ClipboardMac.h: Removed clearData. |
| * platform/mac/ClipboardMac.mm: Removed clearData. |
| (WebCore::ClipboardMac::getData): Changed to call cocoaTypeFromHTMLClipboardType |
| as a Pasteboard class static member function. |
| (WebCore::ClipboardMac::setData): Ditto. |
| |
| * platform/mac/PasteboardMac.mm: |
| (WebCore::Pasteboard::cocoaTypeFromHTMLClipboardType): Moved here from |
| ClipboardMac. |
| (WebCore::Pasteboard::clear): Added. Moved here from ClipboardMac. |
| |
| 2013-05-12 Darin Adler <darin@apple.com> |
| |
| [Mac] Move hasData from ClipboardMac to PasteboardMac |
| https://bugs.webkit.org/show_bug.cgi?id=115999 |
| |
| Reviewed by Andreas Kling. |
| |
| * dom/Clipboard.cpp: |
| (WebCore::Clipboard::hasData): Added. Calls through to Pasteboard. |
| |
| * dom/Clipboard.h: Added LEGACY_VIRTUAL and LEGACY_PURE macros, |
| only for within this header file. These help us keep many functions |
| as pure virtual in the legacy style Clipboard class, but have them |
| be non-virtual in the normal/future style. Use LEGACY_VIRTUAL and |
| LEGACY_PURE to make the hasData member non-virtual. |
| |
| * platform/Pasteboard.h: Added hasData, and added some blank lines and a FIXME. |
| |
| * platform/mac/ClipboardMac.h: Removed hasData override. |
| * platform/mac/ClipboardMac.mm: Ditto. |
| |
| * platform/mac/PasteboardMac.mm: |
| (WebCore::Pasteboard::hasData): Added. Moved code here from ClipboardMac. |
| |
| 2013-05-12 David Kilzer <ddkilzer@apple.com> |
| |
| BUILD FIX (r149971): sudden termination is a Mac-only concept |
| |
| * WebCore.exp.in: Move sudden termination symbols to Mac-only |
| section. |
| |
| 2013-05-12 Andreas Kling <akling@apple.com> |
| |
| Node: Use FINAL instead of the non-virtual shadowing hack. |
| <http://webkit.org/b/115995> |
| |
| Reviewed by Anders Carlsson. |
| |
| Decorate Element/Attr implementations of prefix/localName/namespaceURI getters with FINAL |
| so that call sites with a more specific pointer type than Node* can avoid the virtual dispatch. |
| |
| * dom/Attr.h: |
| * dom/Element.h: |
| * dom/Node.cpp: |
| * dom/Node.h: |
| |
| 2013-05-11 Darin Adler <darin@apple.com> |
| |
| [Mac] Give every Clipboard an underlying Pasteboard |
| https://bugs.webkit.org/show_bug.cgi?id=115979 |
| |
| Reviewed by Andreas Kling. |
| |
| This is the first step in Clipboard and Pasteboard refactoring |
| to fix the overlap and many layering violations. |
| |
| * dom/Clipboard.cpp: |
| (WebCore::Clipboard::Clipboard): Add an m_pasteboard data member, |
| Mac-only for now, but eventually for all platforms. |
| (WebCore::Clipboard::~Clipboard): No longer inline the destructor. |
| |
| * dom/Clipboard.h: Add WTF_USE_LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS |
| flag, currently true for all non-Mac platforms. Make the constructor |
| no longer inline. Added a PassOwnPtr<Pasteboard> argument to the |
| constructor and an OwnPtr<Pasteboard> data member. |
| |
| * platform/Pasteboard.h: Added a create function to make it easy |
| to create a pasteboard given a pasteboard name. |
| |
| * platform/mac/ClipboardMac.mm: |
| (WebCore::ClipboardMac::ClipboardMac): Create a pasteboard and pass |
| it to the Clipboard constructor. |
| |
| * platform/mac/PasteboardMac.mm: |
| (WebCore::Pasteboard::create): Added. |
| |
| 2013-05-12 Andreas Kling <akling@apple.com> |
| |
| Unload event listeners should prevent Safari from insta-killing the web process on last tab close. |
| <http://webkit.org/b/115988> |
| <rdar://problem/13870943> |
| |
| Reviewed by Anders Carlsson. |
| |
| Add two methods to Chrome (and ChromeClient): |
| |
| - enableSuddenTermination() |
| - disableSuddenTermination() |
| |
| ..and call these from DOMWindow instead of the free global functions. |
| |
| For WebKit1, it just calls the NSProcessInfo methods to keep behavior the same. |
| For WebKit2, the new methods plumb through the information to the UI process. |
| |
| Also updated the DOMWindow logic to think in terms of per-DOMWindow sudden termination counters |
| instead of a process-global one, since that gets confusing in a WK2 world. |
| When a DOMWindow transitions between having/not having unload/beforeunload event listeners, |
| we send a notification to the Chrome. |
| |
| * WebCore.exp.in: |
| * WebCore.xcodeproj/project.pbxproj: |
| * page/Chrome.h: |
| (WebCore::Chrome::enableSuddenTermination): |
| (WebCore::Chrome::disableSuddenTermination): |
| * page/ChromeClient.h: |
| (WebCore::ChromeClient::enableSuddenTermination): |
| (WebCore::ChromeClient::disableSuddenTermination): |
| * page/DOMWindow.cpp: |
| (WebCore::addUnloadEventListener): |
| (WebCore::removeUnloadEventListener): |
| (WebCore::removeAllUnloadEventListeners): |
| (WebCore::addBeforeUnloadEventListener): |
| (WebCore::removeBeforeUnloadEventListener): |
| (WebCore::removeAllBeforeUnloadEventListeners): |
| (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents): |
| (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): |
| (WebCore::DOMWindow::enableSuddenTermination): |
| (WebCore::DOMWindow::disableSuddenTermination): |
| * page/DOMWindow.h: |
| (DOMWindow): |
| |
| 2013-05-12 Anders Carlsson <andersca@apple.com> |
| |
| Remove Complex.h from WTF |
| https://bugs.webkit.org/show_bug.cgi?id=115989 |
| |
| Reviewed by Beth Dakin. |
| |
| Replace Complex declarations with std::complex<double>. Pass by value since the struct |
| is small enough to go into two registers on X86-64. |
| |
| * Modules/webaudio/RealtimeAnalyser.cpp: |
| (WebCore::RealtimeAnalyser::doFFTAnalysis): |
| (WebCore::RealtimeAnalyser::getFloatFrequencyData): |
| (WebCore::RealtimeAnalyser::getByteFrequencyData): |
| (WebCore::RealtimeAnalyser::getByteTimeDomainData): |
| * platform/audio/Biquad.cpp: |
| (WebCore::Biquad::setZeroPolePairs): |
| (WebCore::Biquad::setAllpassPole): |
| (WebCore::Biquad::getFrequencyResponse): |
| * platform/audio/Biquad.h: |
| * platform/audio/FFTFrame.cpp: |
| (WebCore::FFTFrame::interpolateFrequencyComponents): |
| (WebCore::FFTFrame::extractAverageGroupDelay): |
| (WebCore::FFTFrame::addConstantGroupDelay): |
| |
| 2013-05-12 Simon Fraser <simon.fraser@apple.com> |
| |
| Dropdowns on http://www.exploratorium.edu don't show anything |
| https://bugs.webkit.org/show_bug.cgi?id=115991 |
| |
| Reviewed by Dan Bernstein. |
| |
| We can't optimize away the backing store of a layer by saying that |
| it paints into a composited ancestor if its composited bounds are not contained |
| by that ancestor. |
| |
| Test: compositing/backing/no-backing-for-clip-overhang.html |
| |
| * rendering/RenderLayerBacking.cpp: |
| (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Pass in our |
| previously computed composited bounds relative to our composited ancestor, |
| and its composited bounds. |
| * rendering/RenderLayerCompositor.cpp: |
| (WebCore::RenderLayerCompositor::requiresOwnBackingStore): If the ancestor's |
| composited bounds don't contain the layer's composited bounds, the layer |
| needs its own backing store. |
| * rendering/RenderLayerCompositor.h: |
| |
| 2013-05-12 Commit Queue <commit-queue@webkit.org> |
| |
| Unreviewed, rolling out r149955. |
| http://trac.webkit.org/changeset/149955 |
| https://bugs.webkit.org/show_bug.cgi?id=115990 |
| |
| Broke lots of tests (Requested by smfr on #webkit). |
| |
| * WebCore.exp.in: |
| * rendering/InlineFlowBox.h: |
| * rendering/InlineTextBox.h: |
| (InlineTextBox): |
| * rendering/RenderApplet.h: |
| * rendering/RenderBR.h: |
| * rendering/RenderBlock.h: |
| (RenderBlock): |
| (WebCore::RenderBlock::virtualContinuation): |
| (WebCore::RenderBlock::virtualChildren): |
| (WebCore::RenderBlock::isRenderBlock): |
| (WebCore::RenderBlock::isBlockFlow): |
| (WebCore::RenderBlock::isInlineBlockOrInlineTable): |
| (WebCore::RenderBlock::dirtyLinesFromChangedChild): |
| (WebCore::RenderBlock::collapsedMarginBefore): |
| (WebCore::RenderBlock::collapsedMarginAfter): |
| * rendering/RenderBox.h: |
| (WebCore::RenderBox::borderBoundingBox): |
| (RenderBox): |
| (WebCore::RenderBox::marginLogicalLeft): |
| (WebCore::RenderBox::marginLogicalRight): |
| * rendering/RenderBoxModelObject.h: |
| (WebCore::RenderBoxModelObject::isBoxModelObject): |
| * rendering/RenderButton.h: |
| * rendering/RenderCombineText.h: |
| * rendering/RenderCounter.h: |
| * rendering/RenderDeprecatedFlexibleBox.h: |
| * rendering/RenderDetailsMarker.h: |
| * rendering/RenderEmbeddedObject.h: |
| (RenderEmbeddedObject): |
| (WebCore::RenderEmbeddedObject::isEmbeddedObject): |
| (WebCore::RenderEmbeddedObject::virtualChildren): |
| * rendering/RenderFieldset.h: |
| * rendering/RenderFileUploadControl.h: |
| * rendering/RenderFlexibleBox.h: |
| * rendering/RenderFlowThread.h: |
| * rendering/RenderFrame.h: |
| * rendering/RenderFrameSet.h: |
| * rendering/RenderFullScreen.cpp: |
| * rendering/RenderFullScreen.h: |
| * rendering/RenderGrid.h: |
| * rendering/RenderHTMLCanvas.h: |
| * rendering/RenderIFrame.h: |
| * rendering/RenderImage.h: |
| (RenderImage): |
| (WebCore::RenderImage::isRenderImage): |
| * rendering/RenderInline.h: |
| (RenderInline): |
| (WebCore::RenderInline::virtualContinuation): |
| (WebCore::RenderInline::virtualChildren): |
| (WebCore::RenderInline::isRenderInline): |
| (WebCore::RenderInline::layout): |
| (WebCore::RenderInline::requiresLayer): |
| (WebCore::RenderInline::offsetWidth): |
| (WebCore::RenderInline::offsetHeight): |
| (WebCore::RenderInline::borderBoundingBox): |
| (WebCore::RenderInline::dirtyLinesFromChangedChild): |
| * rendering/RenderLayerModelObject.h: |
| * rendering/RenderListBox.h: |
| * rendering/RenderListItem.h: |
| * rendering/RenderListMarker.h: |
| * rendering/RenderMedia.h: |
| (WebCore::RenderMedia::virtualChildren): |
| (WebCore::RenderMedia::canHaveChildren): |
| (WebCore::RenderMedia::isMedia): |
| (WebCore::RenderMedia::isImage): |
| (WebCore::RenderMedia::requiresForcedStyleRecalcPropagation): |
| * rendering/RenderMediaControlElements.h: |
| * rendering/RenderMenuList.h: |
| * rendering/RenderMeter.h: |
| * rendering/RenderMultiColumnBlock.h: |
| * rendering/RenderMultiColumnFlowThread.h: |
| * rendering/RenderMultiColumnSet.h: |
| * rendering/RenderNamedFlowThread.h: |
| * rendering/RenderPart.h: |
| (RenderPart): |
| (WebCore::RenderPart::isRenderPart): |
| (WebCore::RenderPart::renderName): |
| * rendering/RenderProgress.h: |
| * rendering/RenderRegion.h: |
| (WebCore::RenderRegion::isRenderRegion): |
| * rendering/RenderRegionSet.h: |
| * rendering/RenderReplaced.h: |
| (RenderReplaced): |
| (WebCore::RenderReplaced::renderName): |
| * rendering/RenderReplica.h: |
| * rendering/RenderRuby.h: |
| * rendering/RenderRubyBase.h: |
| * rendering/RenderRubyRun.h: |
| * rendering/RenderRubyText.h: |
| * rendering/RenderScrollbarPart.h: |
| * rendering/RenderSearchField.h: |
| * rendering/RenderSlider.h: |
| * rendering/RenderSnapshottedPlugIn.h: |
| (RenderSnapshottedPlugIn): |
| * rendering/RenderTable.h: |
| (RenderTable): |
| (WebCore::RenderTable::renderName): |
| (WebCore::RenderTable::isTable): |
| (WebCore::RenderTable::avoidsFloats): |
| * rendering/RenderTableCaption.h: |
| * rendering/RenderTableCell.h: |
| * rendering/RenderTableCol.h: |
| * rendering/RenderTableRow.h: |
| * rendering/RenderTableSection.h: |
| * rendering/RenderText.h: |
| (RenderText): |
| (WebCore::RenderText::marginLeft): |
| (WebCore::RenderText::marginRight): |
| (WebCore::RenderText::styleWillChange): |
| (WebCore::RenderText::length): |
| (WebCore::RenderText::paint): |
| (WebCore::RenderText::layout): |
| * rendering/RenderTextControl.h: |
| (RenderTextControl): |
| (WebCore::RenderTextControl::renderName): |
| (WebCore::RenderTextControl::isTextControl): |
| (WebCore::RenderTextControl::avoidsFloats): |
| * rendering/RenderTextControlMultiLine.h: |
| * rendering/RenderTextControlSingleLine.h: |
| (RenderTextControlSingleLine): |
| (WebCore::RenderTextControlSingleLine::isTextField): |
| * rendering/RenderTextFragment.h: |
| * rendering/RenderTextTrackCue.h: |
| * rendering/RenderVideo.h: |
| * rendering/RenderView.h: |
| * rendering/RenderWidget.h: |
| (RenderWidget): |
| (WebCore::RenderWidget::isWidget): |
| * rendering/RenderWordBreak.h: |
| * rendering/RootInlineBox.h: |
| (RootInlineBox): |
| * rendering/mathml/RenderMathMLBlock.h: |
| * rendering/svg/RenderSVGBlock.h: |
| (RenderSVGBlock): |
| * rendering/svg/RenderSVGContainer.h: |
| (WebCore::RenderSVGContainer::setNeedsBoundariesUpdate): |
| (WebCore::RenderSVGContainer::virtualChildren): |
| (WebCore::RenderSVGContainer::isSVGContainer): |
| (WebCore::RenderSVGContainer::renderName): |
| (RenderSVGContainer): |
| (WebCore::RenderSVGContainer::objectBoundingBox): |
| (WebCore::RenderSVGContainer::strokeBoundingBox): |
| (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates): |
| * rendering/svg/RenderSVGEllipse.h: |
| * rendering/svg/RenderSVGForeignObject.h: |
| * rendering/svg/RenderSVGGradientStop.h: |
| * rendering/svg/RenderSVGHiddenContainer.h: |
| (WebCore::RenderSVGHiddenContainer::renderName): |
| (RenderSVGHiddenContainer): |
| (WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer): |
| * rendering/svg/RenderSVGImage.h: |
| * rendering/svg/RenderSVGInline.h: |
| (WebCore::RenderSVGInline::renderName): |
| (WebCore::RenderSVGInline::requiresLayer): |
| (WebCore::RenderSVGInline::isSVGInline): |
| (RenderSVGInline): |
| * rendering/svg/RenderSVGInlineText.h: |
| * rendering/svg/RenderSVGModelObject.h: |
| (WebCore::RenderSVGModelObject::requiresLayer): |
| (RenderSVGModelObject): |
| * rendering/svg/RenderSVGPath.h: |
| * rendering/svg/RenderSVGRect.h: |
| * rendering/svg/RenderSVGResourceClipper.h: |
| * rendering/svg/RenderSVGResourceContainer.h: |
| (RenderSVGResourceContainer): |
| (WebCore::RenderSVGResourceContainer::isSVGResourceContainer): |
| (WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer): |
| * rendering/svg/RenderSVGResourceFilter.h: |
| * rendering/svg/RenderSVGResourceFilterPrimitive.h: |
| * rendering/svg/RenderSVGResourceGradient.h: |
| (RenderSVGResourceGradient): |
| (WebCore::RenderSVGResourceGradient::resourceBoundingBox): |
| * rendering/svg/RenderSVGResourceLinearGradient.h: |
| * rendering/svg/RenderSVGResourceMarker.h: |
| * rendering/svg/RenderSVGResourceMasker.h: |
| * rendering/svg/RenderSVGResourcePattern.h: |
| * rendering/svg/RenderSVGResourceRadialGradient.h: |
| * rendering/svg/RenderSVGRoot.h: |
| * rendering/svg/RenderSVGShape.h: |
| (WebCore::RenderSVGShape::setNeedsBoundariesUpdate): |
| (WebCore::RenderSVGShape::setNeedsTransformUpdate): |
| (WebCore::RenderSVGShape::repaintRectInLocalCoordinates): |
| (WebCore::RenderSVGShape::localToParentTransform): |
| (WebCore::RenderSVGShape::localTransform): |
| (WebCore::RenderSVGShape::isSVGShape): |
| (RenderSVGShape): |
| (WebCore::RenderSVGShape::objectBoundingBox): |
| (WebCore::RenderSVGShape::strokeBoundingBox): |
| * rendering/svg/RenderSVGTSpan.h: |
| * rendering/svg/RenderSVGText.h: |
| * rendering/svg/RenderSVGTextPath.h: |
| * rendering/svg/RenderSVGTransformableContainer.h: |
| * rendering/svg/RenderSVGViewportContainer.h: |
| |
| 2013-05-12 Anders Carlsson <andersca@apple.com> |
| |
| Simplify AutodrainedPool |
| https://bugs.webkit.org/show_bug.cgi?id=115986 |
| |
| Reviewed by Andreas Kling. |
| |
| Remove calls to AutodrainedPool::cycle as well as the iteration counter passed to the constructor. |
| Instead, just declare RAII pools where it seems necessary. |
| |
| * Modules/webdatabase/DatabaseThread.cpp: |
| (WebCore::DatabaseThread::databaseThread): |
| * fileapi/FileThread.cpp: |
| (WebCore::FileThread::runLoop): |
| * loader/icon/IconDatabase.cpp: |
| (WebCore::IconDatabase::setIconDataForIconURL): |
| (WebCore::IconDatabase::performURLImport): |
| (WebCore::IconDatabase::readFromDatabase): |
| |
| 2013-05-12 Andreas Kling <akling@apple.com> |
| |
| Apply FINAL to the Node hierarchy. |
| <http://webkit.org/b/115984> |
| |
| Mostly from Blink r149454 by <cevans@chromium.org> |
| <http://src.chromium.org/viewvc/blink?view=revision&revision=149454> |
| |
| A couple of the stable DOM/ microbenchmarks are perf positive on Linux clang: |
| |
| - CloneNodes time reduced from 162.4 to 156.5 ms. |
| - CreateNodes time reduced from 113.9 to 104.9 ms. |
| |
| * dom/: Beat things with the FINAL stick. |
| * html/: Ditto. |
| * svg/: Ditto. |
| |
| 2013-05-12 Andreas Kling <akling@apple.com> |
| |
| Devirtualize some things on Document. |
| |
| From Blink r149967 by <esprehn@chromium.org> |
| <http://src.chromium.org/viewvc/blink?view=revision&revision=149967> |
| |
| Several methods on Document are virtual but don't override a super class method |
| and don't need to be virtual. This patch devirtualizes: |
| |
| - createElementNS() |
| - finishedParsing() |
| - suspendScriptedAnimationControllerCallbacks() |
| - resumeScriptedAnimationControllerCallbacks() |
| |
| It also removes the suspend and resume callbacks from ScriptExecutionContext |
| since they didn't need to be there. |
| |
| * dom/Document.h: |
| * dom/ScriptExecutionContext.h: |
| |
| 2013-05-12 Andreas Kling <akling@apple.com> |
| |
| Remove redundant call to removeAllEventListeners() in Document::open(). |
| |
| From Blink r150175 by <dcheng@chromium.org> |
| <http://src.chromium.org/viewvc/blink?view=revision&revision=150175> |
| |
| Document::open() already calls Document::removeAllEventListeners(), which |
| removes the event listeners from the DOMWindow it's attached to, so |
| there's no need to do it manually here as well. |
| |
| * dom/Document.cpp: |
| (WebCore::Document::open): |
| |
| 2013-05-12 Andreas Kling <akling@apple.com> |
| |
| Apply FINAL to the RenderObject hierarchy. |
| <http://webkit.org/b/115977> |
| |
| Mostly from Blink r148795 by <cevans@chromium.org> |
| <http://src.chromium.org/viewvc/blink?view=revision&revision=148795> |
| |
| * rendering/: Beat things with the FINAL stick. |
| * WebCore.exp.in: Export a now-needed symbol. |
| |
| 2013-05-12 Carlos Garcia Campos <cgarcia@igalia.com> |
| |
| [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs |
| https://bugs.webkit.org/show_bug.cgi?id=115914 |
| |
| Reviewed by Martin Robinson. |
| |
| * platform/graphics/gtk/FullscreenVideoControllerGtk.cpp: |
| (WebCore::FullscreenVideoControllerGtk::hideHud): |
| (WebCore::FullscreenVideoControllerGtk::initializeWindow): |
| * platform/gtk/GtkVersioning.c: |
| * platform/gtk/GtkVersioning.h: |
| * platform/gtk/WidgetRenderingContext.cpp: |
| (WebCore::WidgetRenderingContext::WidgetRenderingContext): |
| * plugins/gtk/gtk2xtbin.c: |
| (gtk_xtbin_realize): |
| |
| 2013-05-11 Brent Fulgham <bfulgham@apple.com> |
| |
| [Windows] Unreviewed build fix after r149932 |
| |
| * make-export-file-generator: Don't attempt to import |
| (or use) non-existent cxxabi functions on Windows. |
| |
| 2013-05-11 Simon Fraser <simon.fraser@apple.com> |
| |
| Add more info to compositing log channel output |
| https://bugs.webkit.org/show_bug.cgi?id=115978 |
| |
| Reviewed by Dean Jackson. |
| |
| Add to compositing log channel output whether a layer paints |
| into its compositing ancestor. |
| |
| * rendering/RenderLayerCompositor.cpp: |
| (WebCore::RenderLayerCompositor::logLayerInfo): |
| |
| 2013-05-10 Simon Fraser <simon.fraser@apple.com> |
| |
| REGRESSION: Fixed background on ColterReed.com scrolls |
| https://bugs.webkit.org/show_bug.cgi?id=115951 |
| |
| Reviewed by Beth Dakin. |
| |
| The logic for painting the fixed root background into its own layer was |
| broken when the document element's layer was composited. This could be caused |
| by a negative z-index child of the body, or by an explicit compositing-causing |
| style on the <html>. |
| |
| There were two issues. First, when painting the layer for the fixed root |
| background, we would simply short-circuit the fixed background paint in |
| RenderLayer::paintLayer(), when checking for a composited layer. We have |
| to continue to paint through the composited <html> layer to get the root |
| background in this case. |
| |
| Secondly, RenderLayerBacking::paintIntoLayer() would only set the PaintLayerPaintingSkipRootBackground |
| flag if this RenderLayerBacking had a m_backgroundLayer. However, when the <html> is |
| composited, we need to skip painting the root layer for both the RenderView's backing, |
| and for the <html>'s backing. Checking whether there is *any* layer that paints |
| the fixed root background (i.e. checking compositor()->fixedRootBackgroundLayer()) |
| is a simple way to fix this test. |
| |
| Tests: platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html.html |
| platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed.html |
| |
| * rendering/RenderLayer.cpp: |
| (WebCore::paintForFixedRootBackground): |
| (WebCore::RenderLayer::paintLayer): |
| * rendering/RenderLayerBacking.cpp: |
| (WebCore::RenderLayerBacking::paintIntoLayer): |
| |
| 2013-05-11 Simon Fraser <simon.fraser@apple.com> |
| |
| Possible crash when going Back while loading PDF |
| https://bugs.webkit.org/show_bug.cgi?id=115972 |
| |
| Reviewed by Dan Bernstein. |
| |
| It's possible for m_frame to be null when Document::findUnsafeParentScrollPropagationBoundary() |
| is called, so null-check currentFrame. |
| |
| * dom/Document.cpp: |
| (WebCore::Document::findUnsafeParentScrollPropagationBoundary): |
| |
| 2013-05-11 Alexey Proskuryakov <ap@apple.com> |
| |
| <rdar://problem/13823864> TextCodecICU complains about ambiguous codec names with current ICU release |
| https://bugs.webkit.org/show_bug.cgi?id=115953 |
| |
| Reviewed by Darin Adler. |
| |
| Store and use canonical converter name to create converters. |
| |
| As a side effect, we now actually reuse cached converters - previously we would compare |
| a standard encoding name to internal canonical one, which rarely match. |
| |
| * platform/text/TextCodecICU.h: |
| * platform/text/TextCodecICU.cpp: |
| (WebCore::TextCodecICU::create): Pass canonical ICU converter name to constructor. |
| (WebCore::TextCodecICU::registerEncodingNames): |
| - Updated terminology. |
| - Added a comment that special cases should be kept in sync between registerEncodingNames |
| and registerCodecs. |
| - Moved maccyrillic alias to a correct section. It's not present in ICU even today. |
| - Changed a few aliases to actually map to standard name, not to an overridden one |
| (this doesn't change behavior since addToTextEncodingNameMap looks up canonical |
| name, but is clearer). |
| (WebCore::TextCodecICU::registerCodecs): Store a converter name to use with each |
| canonical encoding name. |
| (WebCore::TextCodecICU::TextCodecICU): Ditto. |
| (WebCore::TextCodecICU::releaseICUConverter): Reset the converter to remove any |
| leftover data. |
| (WebCore::TextCodecICU::createICUConverter): |
| - Compare converter name to converter name, not to another alias name. |
| - Use proper string comparison instead of pointer comparison. |
| - When creating a converter, assert that the name is not ambigous - canonical |
| converter names should never be, otherwise there would be no way to create |
| the converter without ambiguity. |
| |
| 2013-05-11 Antoine Quint <graouts@apple.com> |
| |
| [Mac] The captions menu should not use a canned max-width and max-height |
| https://bugs.webkit.org/show_bug.cgi?id=115968 |
| |
| Reviewed by Eric Carlson. |
| |
| Use more real estate to display the captions menu should the caption names |
| be long. |
| |
| * css/mediaControlsQuickTime.css: |
| (video::-webkit-media-controls-closed-captions-container): |
| (video::-webkit-media-controls-closed-captions-track-list): |
| Make the captions menu scale to a max-width and max-height to allow 4px |
| above and below the menu, except on the right where it always aligns with |
| the captions icon in the media controller. |
| * html/shadow/MediaControlsApple.cpp: |
| (WebCore::MediaControlsApple::createControls): |
| Move the captions menu element to be a child of the controls instead of |
| the panel such that it may scale relative to the controls when using % |
| CSS values. |
| |
| 2013-05-11 Jochen Eisinger <jochen@chromium.org> |
| |
| Disallow a window to focus itself via javascript URLs or using target _self |
| https://bugs.webkit.org/show_bug.cgi?id=115906 |
| |
| Reviewed by Geoffrey Garen. |
| |
| Test: fast/dom/Window/window-focus-self.html |
| |
| * loader/FrameLoader.cpp: |
| (WebCore::createWindow): |
| * page/DOMWindow.cpp: |
| (WebCore::DOMWindow::focus): |
| |
| 2013-05-11 Christophe Dumez <ch.dumez@sisa.samsung.com> |
| |
| Fix several style warnings in generated bindings |
| https://bugs.webkit.org/show_bug.cgi?id=115961 |
| |
| Reviewed by Kentaro Hara. |
| |
| Fix several style errors in the bindings generated under |
| Source/WebCore/bindings/scripts/test/ |
| |
| No new tests, no behavior change. |
| |
| * bindings/scripts/CodeGeneratorCPP.pm: |
| (GenerateImplementation): |
| (WriteData): |
| * bindings/scripts/CodeGeneratorJS.pm: |
| (GenerateHeader): |
| (GenerateImplementation): |
| (WriteData): |
| * bindings/scripts/CodeGeneratorObjC.pm: |
| (GenerateHeader): |
| * bindings/scripts/test/CPP/WebDOMFloat64Array.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestCallback.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestException.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestInterface.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestNode.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestObj.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: |
| * bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp: |
| * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestActiveDOMObject.h: |
| (WebCore::JSTestActiveDOMObject::releaseImplIfNotNull): |
| * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestCustomNamedGetter.h: |
| (WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull): |
| * bindings/scripts/test/JS/JSTestEventConstructor.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestEventConstructor.h: |
| (WebCore::JSTestEventConstructor::releaseImplIfNotNull): |
| * bindings/scripts/test/JS/JSTestEventTarget.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestEventTarget.h: |
| (WebCore::JSTestEventTarget::releaseImplIfNotNull): |
| * bindings/scripts/test/JS/JSTestException.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestException.h: |
| (WebCore::JSTestException::releaseImplIfNotNull): |
| * bindings/scripts/test/JS/JSTestInterface.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestInterface.h: |
| (WebCore::JSTestInterface::releaseImplIfNotNull): |
| * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestMediaQueryListListener.h: |
| (WebCore::JSTestMediaQueryListListener::releaseImplIfNotNull): |
| * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestNamedConstructor.h: |
| (WebCore::JSTestNamedConstructor::releaseImplIfNotNull): |
| * bindings/scripts/test/JS/JSTestObj.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestObj.h: |
| (WebCore::JSTestObj::releaseImplIfNotNull): |
| * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestOverloadedConstructors.h: |
| (WebCore::JSTestOverloadedConstructors::releaseImplIfNotNull): |
| * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: |
| (WebCore::JSTestSerializedScriptValueInterface::releaseImplIfNotNull): |
| * bindings/scripts/test/JS/JSTestTypedefs.cpp: |
| (WebCore::toJS): |
| * bindings/scripts/test/JS/JSTestTypedefs.h: |
| (WebCore::JSTestTypedefs::releaseImplIfNotNull): |
| * bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestCallbackInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestExceptionInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestMediaQueryListListenerInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestNamedConstructorInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestNodeInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestObjInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h: |
| (WebCore): |
| * bindings/scripts/test/ObjC/DOMTestTypedefsInternal.h: |
| (WebCore): |
| |
| 2013-05-11 Anders Carlsson <andersca@apple.com> |
| |
| Make it a build error to put invalid C++ symbol names in WebCore.exp.in |
| https://bugs.webkit.org/show_bug.cgi?id=115958 |
| |
| Reviewed by Andreas Kling. |
| |
| While invalid C++ symbols will eventually show up as a link error since the symbol won't be found, |
| this makes it easier to catch invalid symbols inside of #ifdefs. |
| |
| * make-export-file-generator: |
| Try to demangle C++ symbols before printing them. |
| |
| 2013-05-11 David Kilzer <ddkilzer@apple.com> |
| |
| BUILD FIX (r149718): Move exported symbol into ENABLE(FULLSCREEN_API) section |
| |
| Fixes the following build failure when ENABLE(FULLSCREEN_API) is |
| off: |
| |
| Undefined symbols for architecture i386: |
| "__ZNK7WebCore7Element25containsFullScreenElementEv", referenced from: |
| -exported_symbol[s_list] command line option |
| |
| * WebCore.exp.in: Move the symbol. |
| |
| 2013-05-11 Robert Hogan <robert@webkit.org> |
| |
| Unreviewed, remove some lint accidentally left in r149929. |
| |
| * rendering/InlineFlowBox.cpp: |
| (WebCore::verticalAlignApplies): |
| |
| 2013-03-17 Robert Hogan <robert@webkit.org> |
| |
| Text flow broken in elements with vertical align top/bottom and inline elements taller than line-height |
| https://bugs.webkit.org/show_bug.cgi?id=111974 |
| |
| Reviewed by Ryosuke Niwa. |
| |
| Per http://www.w3.org/TR/CSS2/visudet.html#propdef-vertical-align 'vertical-align' only applies to inline and table-cell |
| elements. |
| |
| Test: fast/css/vertical-align-block-elements.html |
| |
| * rendering/InlineFlowBox.cpp: |
| (WebCore::isTextInBlockElement): |
| (WebCore): |
| (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): |
| (WebCore::InlineFlowBox::computeLogicalBoxHeights): |
| (WebCore::InlineFlowBox::placeBoxesInBlockDirection): |
| |
| 2013-05-11 Benjamin Poulain <bpoulain@apple.com> |
| |
| Make CanvasStyle a plain object instead of an RefCounted object |
| https://bugs.webkit.org/show_bug.cgi?id=115775 |
| |
| Reviewed by Andreas Kling. |
| |
| CanvasStyle is just 2 words wide. We do not gain anything from allocating |
| it on the heap. Change the object to be just a type and some data. |
| |
| * bindings/js/JSCanvasRenderingContext2DCustom.cpp: |
| (WebCore::toJS): |
| (WebCore::toHTMLCanvasStyle): |
| * html/HTMLCanvasElement.cpp: |
| * html/canvas/CanvasRenderingContext2D.cpp: |
| (WebCore::CanvasRenderingContext2D::State::State): |
| (WebCore::CanvasRenderingContext2D::setStrokeStyle): |
| (WebCore::CanvasRenderingContext2D::setFillStyle): |
| (WebCore::CanvasRenderingContext2D::setStrokeColor): |
| (WebCore::CanvasRenderingContext2D::setFillColor): |
| (WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill): |
| (WebCore::CanvasRenderingContext2D::drawTextInternal): |
| * html/canvas/CanvasRenderingContext2D.h: |
| (WebCore::CanvasRenderingContext2D::strokeStyle): |
| (CanvasRenderingContext2D): |
| (WebCore::CanvasRenderingContext2D::fillStyle): |
| (State): |
| * html/canvas/CanvasStyle.cpp: |
| (WebCore::CanvasStyle::CanvasStyle): |
| (WebCore::CanvasStyle::createFromString): |
| (WebCore::CanvasStyle::createFromStringWithOverrideAlpha): |
| (WebCore::CanvasStyle::isEquivalentColor): |
| (WebCore): |
| (WebCore::CanvasStyle::operator=): |
| (WebCore::CanvasStyle::applyStrokeColor): |
| (WebCore::CanvasStyle::applyFillColor): |
| * html/canvas/CanvasStyle.h: |
| (CanvasStyle): |
| (WebCore::CanvasStyle::isValid): |
| (WebCore::CanvasStyle::CanvasStyle): |
| (WebCore): |
| (WebCore::CanvasStyle::operator=): |
| |
| 2013-05-11 Benjamin Poulain <benjamin@webkit.org> |
| |
| Gradient::platformGradient: Vector reserveCapacity -> reserveInitialCapacity |
| https://bugs.webkit.org/show_bug.cgi?id=115779 |
| |
| Reviewed by Andreas Kling. |
| |
| * platform/graphics/cg/GradientCG.cpp: |
| (WebCore::Gradient::platformGradient): Clang is surprisingly smart at removing |
| all the branches of this function. Remove two more with reserveInitialCapacity. |
| |
| 2013-05-10 Alexey Proskuryakov <ap@apple.com> |
| |
| <rdar://problem/13666412> Clean up some edge cases of URL parsing. |
| https://bugs.webkit.org/show_bug.cgi?id=104919 |
| |
| Reviewed by Darin Adler. |
| |
| Test: fast/url/segments-userinfo-vs-host.html |
| |
| * page/SecurityOrigin.cpp: |
| (WebCore::schemeRequiresHost): |
| (WebCore::shouldTreatAsUniqueOrigin): |
| Updated function name and comments (host is not the same as authority). We still |
| need this check - KURL can still produce http URLs with an empty host (even as this |
| patch reduces the number of such cases). So can Gecko and current draft of URL |
| Standard. |
| It would be good to have a guarantee that such useless URLs can not come out of |
| URL parser, as relying on downstream code re-parsing the URL correctly would be fragile. |
| |
| * platform/KURL.cpp: |
| (WebCore::hostPortIsEmptyButCredentialsArePresent): Updated an argument name for |
| correctness. |
| (WebCore::KURL::parse): |
| 1. Reverted behavior changes from <http://trac.webkit.org/changeset/82181> - I could |
| find no reason to allow "@" in hostnames, and having a URL like this re-parsed by |
| a different parser would likely produce different results. It's better to just treat |
| these edge case URLs as invalid. |
| 2. When hostname component is a lone colon, preserve it in parsed URL string, |
| as otherwise path would get pushed in its place when re-parsing. |
| 3. When authority component is a lone colon, don't forget to "//" after scheme, too. |
| 4. Added some assertions about contents of authority component, to catch potential |
| mis-parsing earlier. |
| |
| 2013-05-10 Alexey Proskuryakov <ap@apple.com> |
| |
| Make TextCodecICU not depend on TextEncoding |
| https://bugs.webkit.org/show_bug.cgi?id=115848 |
| |
| Reviewed by Darin Adler. |
| |
| * platform/text/TextCodecICU.cpp: |
| (WebCore::TextCodecICU::create): |
| (WebCore::TextCodecICU::TextCodecICU): |
| (WebCore::TextCodecICU::createICUConverter): |
| (WebCore::TextCodecICU::decode): |
| (WebCore::TextCodecICU::encode): |
| * platform/text/TextCodecICU.h: |
| Use a plain encoding string in platform encoder wrapper, not a higher level concept. |
| |
| 2013-05-10 Laszlo Gombos <l.gombos@samsung.com> |
| |
| Remove Mac OS X Leopard (10.5) support |
| https://bugs.webkit.org/show_bug.cgi?id=107964 |
| |
| Reviewed by Ryosuke Niwa. |
| |
| Removed the code for 10.5 and removed if-def for 10.6. |
| |
| No new tests, covered by existing tests. |
| |
| * platform/LocalizedStrings.cpp: |
| (WebCore::contextMenuItemTagLookUpInDictionary): |
| * platform/graphics/cg/GraphicsContextCG.cpp: |
| * platform/mac/EmptyProtocolDefinitions.h: |
| * platform/mac/NSScrollerImpDetails.h: |
| * platform/mac/WebCoreSystemInterface.h: |
| * platform/text/mac/HyphenationMac.mm: |
| |
| 2013-05-10 Laszlo Gombos <l.gombos@samsung.com> |
| |
| Remove USE(OS_RANDOMNESS) |
| https://bugs.webkit.org/show_bug.cgi?id=108095 |
| |
| Reviewed by Darin Adler. |
| |
| Remove the USE(OS_RANDOMNESS) guard as it is turned on for all |
| ports. |
| |
| No new tests as this is covered by existing tests. |
| |
| * page/Crypto.cpp: |
| (WebCore::Crypto::getRandomValues): |
| * platform/UUID.cpp: |
| (WebCore::createCanonicalUUIDString): |
| |
| 2013-05-10 Christophe Dumez <ch.dumez@sisa.samsung.com> |
| |
| Remove [NoInterfaceObject] from several WebAudio IDL interfaces |
| https://bugs.webkit.org/show_bug.cgi?id=115894 |
| |
| Reviewed by Darin Adler. |
| |
| Several WebAudio IDL interfaces had [NoInterfaceObject] extended attribute set, |
| meaning that there was no corresponding attribute on the global window object. |
| This behavior is not according to the specification: |
| https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html |
| |
| This patch removes the [NoInterfaceObject] extended attribute where needed to |
| match the specification. |
| |
| No new tests, already covered by existing tests. |
| |
| * Modules/webaudio/AnalyserNode.idl: |
| * Modules/webaudio/AudioBuffer.idl: |
| * Modules/webaudio/AudioBufferSourceNode.idl: |
| * Modules/webaudio/AudioDestinationNode.idl: |
| * Modules/webaudio/AudioListener.idl: |
| * Modules/webaudio/AudioNode.idl: |
| * Modules/webaudio/AudioParam.idl: |
| * Modules/webaudio/BiquadFilterNode.idl: |
| * Modules/webaudio/ChannelMergerNode.idl: |
| * Modules/webaudio/ChannelSplitterNode.idl: |
| * Modules/webaudio/ConvolverNode.idl: |
| * Modules/webaudio/DelayNode.idl: |
| * Modules/webaudio/DynamicsCompressorNode.idl: |
| * Modules/webaudio/GainNode.idl: |
| * Modules/webaudio/MediaElementAudioSourceNode.idl: |
| * Modules/webaudio/MediaStreamAudioDestinationNode.idl: |
| * Modules/webaudio/MediaStreamAudioSourceNode.idl: |
| * Modules/webaudio/OscillatorNode.idl: |
| * Modules/webaudio/ScriptProcessorNode.idl: |
| * Modules/webaudio/WaveShaperNode.idl: |
| * Modules/webaudio/WaveTable.idl: |
| |
| 2013-05-10 Simon Fraser <simon.fraser@apple.com> |
| |
| REGRESSION (r145680): No box shadow rendered on element with positioned child that obscures it |
| https://bugs.webkit.org/show_bug.cgi?id=115840 |
| |
| Reviewed by Antti Koivisto. |
| |
| In r107836, we moved some box-shadow painting into the paintFillLayer code for performance. |
| However, in r145680 we started to skip background painting when we know the background is |
| obscured. This broke shadow painting in some cases. |
| |
| Fix by always painting the background fill layers if we know that they will also |
| paint the shadow. |
| |
| Test: fast/box-shadow/box-shadow-obscured-backgrounds.html |
| |
| * rendering/RenderBox.cpp: |
| (WebCore::RenderBox::paintBackground): |
| |
| 2013-05-10 Simon Fraser <simon.fraser@apple.com> |
| |
| REGRESSION (r143626): Element shows as garbage in image gallery |
| https://bugs.webkit.org/show_bug.cgi?id=115946 |
| |
| Reviewed by Antti Koivisto. |
| |
| RenderLayer::backgroundIsKnownToBeOpaqueInRect() used hasVisibleContent() |
| to check whether the layer's content was hidden via the visibility property. |
| However, this assumed that a passing hasVisibleContent() check meant that the |
| entire area was covered by the renderers and layers checked layer. |
| |
| This is not always true. It's possible to have a visibility:hidden layer |
| with a non-covering visbility:visible child, or even a single RenderText |
| child that happens to have visibility:visible style. In these situations, |
| hasVisibleContent() returns true but the entire area is not painted. |
| |
| So we have to fall back to on a more conservative check using the |
| visibility style, which will give is a reliable answer for the current layer. |
| |
| Tests: compositing/contents-opaque/hidden-with-visible-child.html |
| compositing/contents-opaque/hidden-with-visible-text.html |
| |
| * rendering/RenderLayer.cpp: |
| (WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect): |
| |
| 2013-05-10 Simon Fraser <simon.fraser@apple.com> |
| |
| Garbage down left side of nytimes.com page (if subscriber) |
| https://bugs.webkit.org/show_bug.cgi?id=115839 |
| |
| Reviewed by Antti Koivisto. |
| |
| RenderLayer::backgroundIsKnownToBeOpaqueInRect() would incorrectly return true |
| for layers where the given rect wasn't contained in the background rect, but |
| where some child layer obscured the rect, even though clipping hid part |
| of that child layer. |
| |
| So bail from RenderLayer::backgroundIsKnownToBeOpaqueInRect() if we have |
| any overflow clipping. This could be enhanced in future to test whether child |
| layers obscure the clipping rect, but that would be more expensive. |
| |
| Test: compositing/contents-opaque/overflow-hidden-child-layers.html |
| |
| * rendering/RenderLayer.cpp: |
| (WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect): |
| |
| 2013-05-10 Eric Carlson <eric.carlson@apple.com> |
| |
| In-band captions not visible immediately after track mode change |
| https://bugs.webkit.org/show_bug.cgi?id=115922 |
| |
| Reviewed by Dean Jackson. |
| |
| Test: media/track/track-in-band-mode.html |
| |
| * html/HTMLMediaElement.cpp: |
| (WebCore::HTMLMediaElement::textTrackModeChanged): Add cues for all loaded tracks, regardless |
| of track type. |
| |
| 2013-05-10 Timothy Hatcher <timothy@apple.com> |
| |
| Web Inspector: determine the resource type in InspectorResourceAgent::willSendRequest. |
| |
| This allows the Network timeline and Resources sidebar to filter Resources earlier, |
| before the server sends a response. Useful for long polling (comet) XHRs. |
| |
| https://webkit.org/b/74935 |
| rdar://problem/13726105 |
| |
| Reviewed by Joseph Pecoraro. |
| |
| * inspector/Inspector.json: |
| (Network.requestWillBeSent): Added. |
| * inspector/InspectorResourceAgent.cpp: |
| (WebCore::InspectorResourceAgent::willSendRequest): Send the type if it isn't Other along in requestWillBeSent. |
| (WebCore::InspectorResourceAgent::didReceiveResponse): Don't determine the type here anymore. Clear the CachedResource |
| if isNotModified like the old code path did by not setting cachedResource if !isNotModified. |
| |
| 2013-05-10 Laszlo Gombos <l.gombos@samsung.com> |
| |
| [CMake] Consolidate list of files to build for WebCore plugin support |
| https://bugs.webkit.org/show_bug.cgi?id=104429 |
| |
| Reviewed by Rob Buis. |
| |
| Move the common files to support plugins and the logic for disabling |
| plugins) to CMakeLists.txt from PlatformXXX.cmake. |
| |
| No new tests as there is no new functionality. |
| |
| * CMakeLists.txt: |
| * PlatformBlackBerry.cmake: |
| * PlatformEfl.cmake: |
| * PlatformWinCE.cmake: |
| |
| 2013-05-10 Robert Hogan <robert@webkit.org> |
| |
| REGRESSION(r148121): Empty Span does not get a linebox when it's in an anonymous block |
| https://bugs.webkit.org/show_bug.cgi?id=115818 |
| |
| Reviewed by David Hyatt. |
| |
| r148121 only worried about split inlines inside anonymous blocks - it ought to have |
| catered for empty inlines, with no continuations, inside a single solitary anonymous block too. |
| |
| Test: fast/inline/anonymous-block-with-empty-inline.html |
| |
| * rendering/RenderBlockLineLayout.cpp: |
| (WebCore::hasInlineDirectionBordersPaddingOrMargin): |
| |
| 2013-05-10 Zan Dobersek <zdobersek@igalia.com> |
| |
| [GTK] Remove unnecessary includes in WidgetGtk.cpp |
| https://bugs.webkit.org/show_bug.cgi?id=115912 |
| |
| Reviewed by Andreas Kling. |
| |
| No new tests - no new functionality. |
| |
| * platform/gtk/WidgetGtk.cpp: Remove the unnecessary includes of the Chrome.h, Frame.h, FrameView.h, |
| Page.h and RenderObject.h headers as the included declarations are not used anywhere. ScrollView.h is |
| included instead as it is required and was previously included by one of the removed header inclusions. |
| |
| 2013-05-10 Zan Dobersek <zdobersek@igalia.com> |
| |
| [Cairo] Remove the unnecessary ImageData.h include in ImageBufferCairo.cpp |
| https://bugs.webkit.org/show_bug.cgi?id=115911 |
| |
| Reviewed by Carlos Garcia Campos. |
| |
| No new tests - no new functionality. |
| |
| * platform/graphics/cairo/ImageBufferCairo.cpp: Remove the ImageData.h include |
| as the included declarations are not used anywhere. |
| |
| 2013-05-10 Zan Dobersek <zdobersek@igalia.com> |
| |
| [Cairo] Remove the unnecessary CSSParser.h include in GradientCairo.cpp |
| https://bugs.webkit.org/show_bug.cgi?id=115910 |
| |
| Reviewed by Laszlo Gombos. |
| |
| No new tests - no new functionality. |
| |
| * platform/graphics/cairo/GradientCairo.cpp: Remove the CSSParser.h include |
| as the included declarations are not used anywhere. |
| |
| 2013-05-10 Dean Jackson <dino@apple.com> |
| |
| Include tab character as a word end for kerning |
| https://bugs.webkit.org/show_bug.cgi?id=115915 |
| <rdar://problem/13861491> |
| |
| Reviewed by Enrica Casucci. |
| |
| This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=112507 |
| which only looked for a space character as a word end. It should |
| look for tab characters too. |
| |
| Test: fast/text/word-space-with-kerning-4.html |
| |
| * rendering/RenderBlockLineLayout.cpp: |
| (WebCore::setLogicalWidthForTextRun): Look for '\t'. |
| |
| 2013-05-10 Anders Carlsson <andersca@apple.com> |
| |
| Remove EventTracer |
| https://bugs.webkit.org/show_bug.cgi?id=115916 |
| |
| Reviewed by Sam Weinig. |
| |
| EventTracer is dead code, remove it. |
| |
| * CMakeLists.txt: |
| * GNUmakefile.list.am: |
| * Target.pri: |
| * WebCore.vcproj/WebCore.vcproj: |
| * WebCore.vcxproj/WebCore.vcxproj: |
| * WebCore.vcxproj/WebCore.vcxproj.filters: |
| * WebCore.xcodeproj/project.pbxproj: |
| * platform/EventTracer.cpp: Removed. |
| * platform/EventTracer.h: Removed. |
| |
| 2013-05-10 Zan Dobersek <zdobersek@igalia.com> |
| |
| [GTK] Generated files are regenerated always |
| https://bugs.webkit.org/show_bug.cgi?id=115908 |
| |
| Reviewed by Carlos Garcia Campos. |
| |
| No new tests - no change in functionality. |
| |
| * GNUmakefile.am: Don't treat the window constructors IDL file as a dependency of the JavaScriptCore bindings. |
| The file is generated during the IDL preprocessing, and the JSC bindings already depend on that step through |
| the idl_supplemental_dependencies file. Because of that the window constructors IDL file has a phony target |
| which seems to confuse the bindings generation rule into thinking that a complete regeration of the bindings is required. |
| |
| 2013-05-10 Andreas Kling <akling@apple.com> |
| |
| Caching of generated images in CSS should be smarter. |
| <http://webkit.org/b/115902> |
| <rdar://problem/13542727> |
| |
| Reviewed by Antti Koivisto. |
| |
| Add an IntSize => GeneratorGeneratedImage cache at the CSSImageGeneratorValue level. |
| |
| CSSGradientValue is currently the only CSSImageGeneratorValue subclass that makes use of the cache. |
| Generated images are kept for 3 seconds after last use. |
| |
| The main problem with the previous approach was that background renderers (e.g <body>, <tr>, etc) |
| would be passed to multiple CSSImageGeneratorValue::getImage() calls with different sizes requested |
| for each of the descendent renderers that inherit their background from the same parent. |
| The cache wasn't smart enough for this, it just thought the background renderer was changing size |
| a lot, and would regenerate the image over and over. |
| |
| We already had caching of intermediate image buffers for GeneratorGeneratedImage::drawPattern(). |
| This removes the eviction timer from that cache so that the intermediate images can live a bit longer. |
| |
| (WebCore::CSSImageGeneratorValue::cachedImageForSize): |
| (WebCore::CSSImageGeneratorValue::saveCachedImageForSize): |
| |
| Renamed from getImage() and putImage(). |
| |
| (WebCore::CSSImageGeneratorValue::evictCachedGeneratedImage): |
| (WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage): |
| (WebCore::CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired): |
| |
| Let the CachedGeneratedImage throw itself out from cache when the timer fires. |
| |
| * css/CSSImageGeneratorValue.h: |
| (CachedGeneratedImage): |
| |
| Exactly what it sounds like. These go into CSSImageGeneratorValue::m_images with the size |
| as the hash key. |
| |
| * platform/graphics/GeneratorGeneratedImage.cpp: |
| (WebCore::GeneratorGeneratedImage::drawPattern): |
| * platform/graphics/GeneratorGeneratedImage.h: |
| (WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage): |
| (WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage): |
| |
| Keep the intermediate image for drawPattern() until destruction instead of dropping it on |
| a timer. These objects are now evicted by the CSSImageGeneratorValue's image cache |
| after 3 seconds of disuse rather than kept for the lifetime of the renderer. |
| |
| * css/CSSCanvasValue.cpp: |
| (WebCore::CSSCanvasValue::canvasChanged): |
| (WebCore::CSSCanvasValue::canvasResized): |
| * css/CSSCrossfadeValue.cpp: |
| (WebCore::CSSCrossfadeValue::crossfadeChanged): |
| * rendering/style/StyleGeneratedImage.cpp: |
| (WebCore::StyleGeneratedImage::addClient): |
| * css/CSSImageGeneratorValue.cpp: |
| (WebCore::CSSImageGeneratorValue::addClient): |
| (WebCore::CSSImageGeneratorValue::removeClient): |
| |
| CSSImageGeneratorValue::m_clients is now a HashCountedSet<RenderObject*>, tweak accordingly. |
| |
| 2013-05-10 Anders Carlsson <andersca@apple.com> |
| |
| Remove MemoryUsageSupport class |
| https://bugs.webkit.org/show_bug.cgi?id=115913 |
| |
| Reviewed by Andreas Kling. |
| |
| MemoryUsageSupport was just used by a single call site in InspectorTimelineAgent, |
| and the function called always returns zero on all platforms! Remove it. |
| |
| * CMakeLists.txt: |
| * GNUmakefile.list.am: |
| * Target.pri: |
| * WebCore.vcproj/WebCore.vcproj: |
| * WebCore.vcxproj/WebCore.vcxproj: |
| * WebCore.vcxproj/WebCore.vcxproj.filters: |
| * WebCore.xcodeproj/project.pbxproj: |
| * inspector/InspectorMemoryAgent.cpp: |
| * inspector/InspectorTimelineAgent.cpp: |
| (WebCore): |
| (WebCore::InspectorTimelineAgent::setNativeHeapStatistics): |
| * platform/MemoryUsageSupport.cpp: Removed. |
| * platform/MemoryUsageSupport.h: Removed. |
| * platform/qt/MemoryUsageSupportQt.cpp: Removed. |
| |
| 2013-05-10 Ryosuke Niwa <rniwa@webkit.org> |
| |
| REGRESSION (r149652): Videos do not play on cnn.com, just black box |
| https://bugs.webkit.org/show_bug.cgi?id=115887 |
| |
| Reviewed by Antti Koivisto. |
| |
| The bug was caused by window and document named item maps counting the same element twice |
| when it has the same id and name attribute values. Fixed the bug by avoiding to add or remove |
| an element per id and name attribute updates when it had already been added or removed by |
| name and id attribute updates respectively. |
| |
| We do this by checking whether the other attribute affects the element's precense in window |
| and document named item maps and avoiding to add or remove the attribute when they do and |
| the other attribute is present in updateId and updateName. |
| |
| Consider a scenario when an object element has id "foo", and name attribute is about to be also |
| set to "foo". If the id attribute doesn't affect element's presense in window or document |
| named item maps, we're done. If it does, then the maps already have this element so we don't |
| want to add it again. Conversely, if the element already has id and name attributes set to |
| "foo", and we're moving the id attribute, then we want to remove the element from the maps only |
| if the id doesn't affect the presence of the element in the maps. |
| |
| Unfortuntely, this logic doesn't work when we're inserting or removing an element on its entirely |
| because updateId and updateName are called when both id and name attributes are present so skip |
| this step (AlwaysUpdateHTMLDocumentNamedItemMaps) for the id attribute to break the symmetry. |
| |
| Test: fast/dom/HTMLDocument/image-with-same-id-and-name.html |
| fast/dom/HTMLDocument/object-with-same-id-and-name.html |
| |
| * dom/Element.cpp: |
| (WebCore::Element::insertedInto): Call updateId and updateName with |
| AlwaysUpdateHTMLDocumentNamedItemMaps. |
| (WebCore::Element::removedFrom): Ditto. |
| (WebCore::Element::updateName): Don't add or remove this element if the id attribute has already |
| done so except when we're inserting, removing, or cloning an element. |
| (WebCore::Element::updateId): Ditto for the name attribute. |
| (WebCore::Element::cloneAttributesFromElement): Added a comment and assert that we never call this |
| function when this element is in the document. We can't update window and documemt named item |
| maps here because image element's id attribute value, for example, is present in the document's |
| named item map if it has a name attribute. Since this function calls updateId and updateName |
| before updating attributes, this check is going to fail in DocumentNameCollection's |
| nodeMatchesIfIdAttributeMatch and bad things will happen. |
| |
| * dom/Element.h: |
| |
| * editing/ReplaceNodeWithSpanCommand.cpp: |
| (WebCore::swapInNodePreservingAttributesAndChildren): Clone children and attributes before |
| inserting the swapped span to avoid hitting the assertion in cloneAttributesFromElement we added. |
| |
| * html/HTMLImageElement.cpp: |
| (WebCore::HTMLImageElement::parseAttribute): |
| |
| * html/HTMLObjectElement.cpp: |
| (WebCore::HTMLObjectElement::updateDocNamedItem): |
| |
| 2013-05-09 Dean Jackson <dino@apple.com> |
| |
| Don't trust character widths for internal OS X fonts in form controls |
| https://bugs.webkit.org/show_bug.cgi?id=115883 |
| <rdar://problem/13817757> |
| |
| Reviewed by Darin Adler. |
| |
| We ignore the character width for a bunch of fonts when predicting |
| the width of a form control. Some of the internal fonts in OS X are |
| not in the ignored list. Rather than add them, simply test for |
| fonts whose family begins with a period character ".". |
| |
| * rendering/RenderTextControl.cpp: |
| (WebCore::RenderTextControl::hasValidAvgCharWidth): Return false for |
| any family that starts with "." |
| |
| 2013-05-10 Carlos Garcia Campos <cgarcia@igalia.com> |
| |
| [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs |
| https://bugs.webkit.org/show_bug.cgi?id=115904 |
| |
| Reviewed by Martin Robinson. |
| |
| * bindings/gobject/WebKitDOMEventTarget.cpp: |
| * platform/gtk/GtkVersioning.c: |
| * platform/gtk/GtkVersioning.h: |
| |
| 2013-05-10 Zoltan Arvai <zarvai@inf.u-szeged.hu> |
| |
| Unreviewed. Fix the ENABLE(SHARED_WORKERS) build after r149864. |
| |
| * workers/SharedWorkerThread.cpp: include "SecurityOrigin.h" |
| |
| 2013-05-10 Claudio Saavedra <csaavedra@igalia.com> |
| |
| Fix build after r149864. |
| |
| Unreviewed build fix. |
| |
| * loader/ThreadableLoader.h: include <wtf/text/AtomicString.h> |
| when building with RESOURCE_TIMING enabled. |
| |
| 2013-05-10 Anders Carlsson <andersca@apple.com> |
| |
| Fix build. |
| |
| * bindings/js/ScriptController.cpp: |
| |
| 2013-05-10 Anders Carlsson <andersca@apple.com> |
| |
| Remove ScriptInstance.h |
| https://bugs.webkit.org/show_bug.cgi?id=115900 |
| |
| Reviewed by Andreas Kling. |
| |
| Remove yet another abstraction now that we don't support V8. |
| |
| * GNUmakefile.list.am: |
| * WebCore.vcproj/WebCore.vcproj: |
| * WebCore.vcxproj/WebCore.vcxproj: |
| * WebCore.vcxproj/WebCore.vcxproj.filters: |
| * WebCore.xcodeproj/project.pbxproj: |
| * bindings/js/ScriptController.h: |
| (Bindings): |
| (ScriptController): |
| * bindings/js/ScriptControllerMac.mm: |
| (WebCore::ScriptController::createScriptInstanceForWidget): |
| * bindings/js/ScriptInstance.h: Removed. |
| * html/HTMLPlugInElement.cpp: |
| (WebCore::HTMLPlugInElement::getInstance): |
| * html/HTMLPlugInElement.h: |
| (Bindings): |
| (HTMLPlugInElement): |
| * platform/graphics/wince/MediaPlayerProxy.h: |
| (WebMediaPlayerProxy): |
| * rendering/RenderEmbeddedObject.cpp: |
| * rendering/RenderSnapshottedPlugIn.cpp: |
| |
| 2013-05-10 Anders Carlsson <andersca@apple.com> |
| |
| Unreviewed, rolling out r149866. |
| http://trac.webkit.org/changeset/149866 |
| https://bugs.webkit.org/show_bug.cgi?id=115898 |
| |
| Broke tests |
| |
| * dom/Document.cpp: |
| (WebCore::Document::setDomain): |
| (WebCore::Document::initSecurityContext): |
| * page/SecurityOrigin.cpp: |
| (WebCore::SecurityOrigin::SecurityOrigin): |
| (WebCore::SecurityOrigin::isolatedCopy): |
| (WebCore::SecurityOrigin::setDomainFromDOM): |
| (WebCore::SecurityOrigin::grantUniversalAccess): |
| * page/SecurityOrigin.h: |
| (SecurityOrigin): |
| |
| 2013-05-10 Andrei Bucur <abucur@adobe.com> |
| |
| Remove overflow dead code |
| https://bugs.webkit.org/show_bug.cgi?id=115893 |
| |
| Reviewed by Antti Koivisto. |
| |
| The patch removes unused public overflow accesor functions from RenderOverflow and InlineFlowBox. |
| |
| Tests: no tests, code cleanup. |
| |
| * rendering/InlineFlowBox.h: Removed logicalLeftLayoutOverflow and logicalRightLayoutOverflow. |
| * rendering/RenderOverflow.h: Removed setMinYLayoutOverflow, setMaxYLayoutOverflow, |
| setMinXLayoutOverflow, setMaxXLayoutOverflow, setMinYVisualOverflow, setMaxYVisualOverflow, |
| setMinXVisualOverflow and setMaxXVisualOverflow. |
| |
| 2013-05-10 Anders Carlsson <andersca@apple.com> |
| |
| Begin making SecurityOrigin immutable |
| https://bugs.webkit.org/show_bug.cgi?id=115898 |
| |
| Reviewed by Andreas Kling. |
| |
| Replace SecurityOrigin::setDomainFromDOM and SecurityOrigin::grantUniversalAccess with |
| member functions that return new SecurityOrigin objects. |
| |
| * dom/Document.cpp: |
| (WebCore::Document::setDomain): |
| Update the security origin to one returned by copyWithDomainSetFromDOM. |
| |
| (WebCore::Document::initSecurityContext): |
| Set the security origin to one returned by copyWithUniversalAccessGranted(). |
| |
| * page/SecurityOrigin.cpp: |
| (WebCore::SecurityOrigin::SecurityOrigin): |
| Add a new constructor that takes all the member variables as parameters. This is a little unwieldy at the moment, |
| but all the boolean parameters could be replaced by a bitmask of flags. |
| |
| (WebCore::SecurityOrigin::isolatedCopy): |
| Call the new constructor. |
| |
| (WebCore::SecurityOrigin::copyWithDomainSetFromDOM): |
| Return a new security origin with m_domainWasSetInDOM set to true and the domain updated. |
| |
| (WebCore::SecurityOrigin::copyWithUniversalAccessGranted): |
| Return a new security origin with m_universalAccess set to true. |
| |
| 2013-05-10 Anders Carlsson <andersca@apple.com> |
| |
| Remove ScriptController::updateSecurityOrigin |
| https://bugs.webkit.org/show_bug.cgi?id=115895 |
| |
| Reviewed by Antti Koivisto. |
| |
| ScriptController::updateSecurityOrigin is just dead code now that the V8 bindings are gone. |
| |
| * bindings/js/ScriptController.cpp: |
| * bindings/js/ScriptController.h: |
| * dom/Document.cpp: |
| (WebCore::Document::setIsViewSource): |
| (WebCore::Document::setDomain): |
| * dom/Document.h: |
| (Document): |
| * dom/SecurityContext.cpp: |
| (WebCore::SecurityContext::enforceSandboxFlags): |
| * dom/SecurityContext.h: |
| (SecurityContext): |
| |
| 2013-05-10 Anders Carlsson <andersca@apple.com> |
| |
| Stop including SecurityOrigin.h where unnecessary |
| https://bugs.webkit.org/show_bug.cgi?id=115897 |
| |
| Reviewed by Antti Koivisto. |
| |
| Move rarely called functions out of line so headers don't have to include SecurityOrigin.h |
| |
| * Modules/indexeddb/IDBFactoryBackendImpl.h: |
| * Modules/webdatabase/DatabaseBackendBase.cpp: |
| (WebCore::DatabaseBackendBase::databaseDebugName): |
| * Modules/webdatabase/DatabaseBackendBase.h: |
| (DatabaseBackendBase): |
| * Modules/webdatabase/DatabaseSync.h: |
| * bindings/js/JSDOMWindowCustom.h: |
| * html/parser/XSSAuditor.cpp: |
| * loader/ThreadableLoader.cpp: |
| (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): |
| (WebCore::ThreadableLoaderOptions::~ThreadableLoaderOptions): |
| (WebCore::ThreadableLoader::create): |
| * loader/ThreadableLoader.h: |
| (ThreadableLoaderOptions): |
| * loader/WorkerThreadableLoader.cpp: |
| * workers/DedicatedWorkerContext.cpp: |
| * workers/DedicatedWorkerThread.cpp: |
| * workers/SharedWorkerContext.cpp: |
| * workers/WorkerThread.cpp: |
| * workers/WorkerThread.h: |
| |
| 2013-05-10 Carlos Garcia Campos <cgarcia@igalia.com> |
| |
| Unreviewed. Fix GTK+ build after r149839. |
| |
| * platform/gtk/RenderThemeGtk3.cpp: |
| (WebCore::gtkStyleChangedCallback): |
| |
| 2013-05-09 Chris Fleizach <cfleizach@apple.com> |
| |
| AX: VoiceOver is no longer seeing items in poorly formed tables |
| https://bugs.webkit.org/show_bug.cgi?id=115837 |
| |
| Reviewed by Darin Adler. |
| |
| In case the author didn't include the rows of a table as the |
| direct children, a table needs to dive down its descendant chain |
| until the rows are found. |
| |
| I also took the opportunity to clean up a bit around what the different |
| meanings of table are in the accessibility classes. |
| |
| Test: accessibility/poorly-formed-aria-table.html |
| |
| * accessibility/AccessibilityARIAGrid.cpp: |
| (WebCore::AccessibilityARIAGrid::addRowDescendant): |
| (WebCore::AccessibilityARIAGrid::addChildren): |
| * accessibility/AccessibilityARIAGrid.h: |
| (AccessibilityARIAGrid): |
| * accessibility/AccessibilityARIAGridRow.cpp: |
| (WebCore::AccessibilityARIAGridRow::parentTable): |
| (WebCore): |
| * accessibility/AccessibilityARIAGridRow.h: |
| (AccessibilityARIAGridRow): |
| * accessibility/AccessibilityObject.h: |
| (WebCore::AccessibilityObject::isTable): |
| * accessibility/AccessibilityTable.h: |
| (AccessibilityTable): |
| (WebCore::AccessibilityTable::isTable): |
| (WebCore::toAccessibilityTable): |
| * accessibility/AccessibilityTableRow.cpp: |
| (WebCore::AccessibilityTableRow::parentTable): |
| |
| 2013-05-09 Yael Aharon <yael.aharon@intel.com> |
| |
| REGRESSION: Disabled multiline select element now responds to (certain) clicks |
| https://bugs.webkit.org/show_bug.cgi?id=115710 |
| |
| Reviewed by Kent Tamura. |
| |
| After http://trac.webkit.org/changeset/140286, select elements can scroll whether they |
| are disabled or not. While they scroll, they also change the selected item. |
| This patch allows the select element to scroll, but does not change the selection |
| if the select element is disabled. |
| |
| Test: fast/forms/select/listbox-disabled-scroll-no-onchange.html |
| Test: fast/forms/select/listbox-disabled-no-autoscroll.html |
| |
| * rendering/RenderListBox.cpp: |
| (WebCore::RenderListBox::autoscroll): |
| * rendering/RenderListBox.cpp: |
| (WebCore::RenderListBox::stopAutoscroll): |
| |
| 2013-05-09 Anders Carlsson <andersca@apple.com> |
| |
| Clean up SecurityOrigin::databaseIdentifier |
| https://bugs.webkit.org/show_bug.cgi?id=115882 |
| |
| Reviewed by Beth Dakin. |
| |
| Remove m_encodedHost and just call encodeHost from databaseIdentifier(). |
| Also, use a StringBuilder when constructing the database identifier to avoid allocating |
| temporary String objects over and over. |
| |
| * page/SecurityOrigin.cpp: |
| (WebCore::SecurityOrigin::SecurityOrigin): |
| (WebCore): |
| (WebCore::SecurityOrigin::createFromDatabaseIdentifier): |
| (WebCore::SecurityOrigin::databaseIdentifier): |
| * page/SecurityOrigin.h: |
| (SecurityOrigin): |
| |
| 2013-05-09 Anders Carlsson <andersca@apple.com> |
| |
| Remove m_securityOrigin from XMLHttpRequest |
| https://bugs.webkit.org/show_bug.cgi?id=115881 |
| |
| Reviewed by Alexey Proskuryakov. |
| |
| The security origin passed to XMLHttpRequest::create was always null, so just get rid of the member variable completely. |
| |
| * xml/XMLHttpRequest.cpp: |
| (WebCore::XMLHttpRequest::create): |
| (WebCore::XMLHttpRequest::XMLHttpRequest): |
| (WebCore::XMLHttpRequest::securityOrigin): |
| * xml/XMLHttpRequest.h: |
| (XMLHttpRequest): |
| |
| 2013-05-09 Christophe Dumez <ch.dumez@sisa.samsung.com> |
| |
| [NoInterfaceObject] extended attribute should be removed for several interfaces |
| https://bugs.webkit.org/show_bug.cgi?id=115852 |
| |
| Reviewed by Benjamin Poulain. |
| |
| Remove [NoInterfaceObject] extended attribute from the following Web IDL |
| interfaces: SecurityPolicy, History, Location, Navigator, Performance, |
| PerformanceEntry, PerformanceMark, PerformanceMeasure, PerformanceNavigation, |
| PerformanceResourceTiming, PerformanceTiming and Screen. |
| |
| These interfaces should not have the [NoInterfaceObject] extended attribute |
| according to their respective specifications: |
| - http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-history-interface |
| - http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-location-interface |
| - https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#securitypolicy |
| - http://www.w3.org/html/wg/drafts/html/master/webappapis.html#the-navigator-object |
| - http://www.w3.org/TR/navigation-timing/#performance |
| - https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html#sec-PerformanceEntry-interface |
| - http://www.w3.org/TR/navigation-timing/#performancenavigation |
| - http://www.w3.org/TR/navigation-timing/#performancetiming |
| - http://www.w3.org/TR/user-timing/#performancemark |
| - http://www.w3.org/TR/user-timing/#performancemeasure |
| - http://www.w3c-test.org/webperf/specs/ResourceTiming/#performanceresourcetiming |
| - http://dev.w3.org/csswg/cssom-view/#the-screen-interface |
| |
| The new behavior is consistent with the specifications, Firefox and soon Blink. |
| |
| No new tests, already covered by existing tests. |
| |
| * page/DOMSecurityPolicy.idl: |
| * page/History.idl: |
| * page/Location.idl: |
| * page/Navigator.idl: |
| * page/Performance.idl: |
| * page/PerformanceEntry.idl: |
| * page/PerformanceMark.idl: |
| * page/PerformanceMeasure.idl: |
| * page/PerformanceNavigation.idl: |
| * page/PerformanceResourceTiming.idl: |
| * page/PerformanceTiming.idl: |
| * page/Screen.idl: |
| |
| 2013-05-09 Robert Hogan <robert@webkit.org> |
| |
| REGRESSION (Safari 3-Safari 4): Replaced element with percent height in table has incorrect height |
| https://bugs.webkit.org/show_bug.cgi?id=26394 |
| |
| Reviewed by David Hyatt. |
| |
| Text controls or any object that has scrollable content should not flex inside a table cell. |
| This makes our behaviour the same as IE, FF and Opera (Presto). |
| |
| * rendering/RenderTableSection.cpp: |
| (WebCore::RenderTableSection::layoutRows): |
| |
| 2013-05-09 Anders Carlsson <andersca@apple.com> |
| |
| Build fix. |
| |
| * WebCore.exp.in: |
| |
| 2013-05-09 Anders Carlsson <andersca@apple.com> |
| |
| Add a StorageStrategy hook for creating transient local storage namespaces |
| https://bugs.webkit.org/show_bug.cgi?id=115870 |
| |
| Reviewed by Geoffrey Garen. |
| |
| * WebCore.exp.in: |
| Export symbol needed by WebKit2. |
| |
| * dom/Document.cpp: |
| (WebCore::Document::topOrigin): |
| * dom/Document.h: |
| * dom/ScriptExecutionContext.h: |
| * workers/WorkerContext.h: |
| Remove const qualifier from topOrigin() to avoid ugly const_casts when assigning into a RefPtr<SecurityOrigin> variable. |
| |
| * page/PageGroup.cpp: |
| (WebCore::PageGroup::transientLocalStorage): |
| Do a single hash lookup instead of three and use the SecurityOrigin itself as the hash key instead of a string representation of it. |
| |
| * page/PageGroup.h: |
| Update HashMap declaration. |
| |
| * storage/StorageNamespace.cpp: |
| (WebCore::StorageNamespace::transientLocalStorageNamespace): |
| Add new implementation that will optionally call out to the storage strategy. |
| |
| * storage/StorageNamespaceImpl.cpp: |
| (WebCore::StorageNamespaceImpl::transientLocalStorageNamespace): |
| Move the default implementation here from PageGroup. |
| |
| * storage/StorageStrategy.cpp: |
| (WebCore::StorageStrategy::transientLocalStorageNamespace): |
| Call the default implementation. |
| |
| 2013-05-09 Enrica Casucci <enrica@apple.com> |
| |
| A change in system environment should force all CSS properties to be recomputed. |
| https://bugs.webkit.org/show_bug.cgi?id=115872 |
| <rdar://problem/13781171> |
| |
| Reviewed by Antti Koivisto. |
| |
| When a change in the global environment occurs, for example system colors, |
| we need to make sure all the CSS properties are recomputed and not fetched |
| from the cache. For this reason we invalidate the properties cache. |
| I've also renamed the function to give it a more meaningful name. |
| |
| * page/Page.cpp: |
| (WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment): |
| * page/Page.h: |
| * rendering/RenderTheme.cpp: |
| (WebCore::RenderTheme::platformColorsDidChange): |
| |
| 2013-05-09 Antti Koivisto <antti@apple.com> |
| |
| Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors. |
| <http://webkit.org/b/115590> |
| |
| Reviewed by Darin Adler. |
| |
| Common pseudo selectors should go into their respective rule buckets instead of ending up in the universal one. |
| |
| * css/RuleSet.cpp: |
| (WebCore::RuleSet::findBestRuleSetAndAdd): |
| |
| Check tag selectors with * local name (usually created for namespace) for a suitable narrower bucket too. |
| |
| 2013-05-09 Darin Adler <darin@apple.com> |
| |
| RenderQuote has giant function for language to quotes map |
| https://bugs.webkit.org/show_bug.cgi?id=115807 |
| |
| Reviewed by Anders Carlsson. |
| |
| * rendering/RenderQuote.cpp: |
| (WebCore::RenderQuote::RenderQuote): Updated for m_isAttached name change. |
| (WebCore::RenderQuote::~RenderQuote): Updated for name change, and also split |
| assertion with && in it into two separate assertions. |
| (WebCore::checkNumberOfDistinctQuoteCharacters): Added. Helper function that is used |
| to check that the number of distinct quote characters is small enough to fit into |
| our fixed size array below. |
| (WebCore::quotesForLanguage): Replaces the old quotesDataLanguageMap function. |
| Returns a pointer to a struct that contains the four quote characters. This new |
| function doesn't have the massive amount of code that the old one did. We use the |
| standard library bsearch function to do a binary search. |
| (WebCore::stringForQuoteCharacter): Added. This returns a string for a given quote |
| character; one string for any given character. |
| (WebCore::quotationMarkString): Added. Returns the string for the quotation mark. |
| (WebCore::apostropheStringImpl): Added. Returns the string for the apostrophe. |
| (WebCore::RenderQuote::originalText): Rewrote this to include all the logic that |
| used to be in the quotesData function. |
| (WebCore::RenderQuote::attachQuote): Tweak assertions as above. Removed unneeded |
| special case for the first quote in a RenderView; sharing the code is better and |
| there is no significant performance difference. Also use m_isAttached directly |
| when looking at predecessores so there is no need for an isAttached function. |
| (WebCore::RenderQuote::detachQuote): Updated assertions and for name change. |
| (WebCore::RenderQuote::updateDepth): Ditto. |
| |
| * rendering/RenderQuote.h: Removed unneeded includes. Marked the class FINAL since |
| we call the originalText function in the class and we don't want to do a virtual |
| function dispatch for that. Removed uneeded const from an argument. Removed a |
| stray semicolon. Removed the quotesData and isAttached functions, since they are no |
| longer needed. Renamed m_attached to m_isAttached. |
| |
| * rendering/style/QuotesData.cpp: Removed the overload of QuotesData::create that |
| takes four quote strings. This was only used to build up the quotes table. |
| * rendering/style/QuotesData.h: Ditto. |
| |
| 2013-05-09 Max Feil <mfeil@rim.com> |
| |
| shouldUsePluginDocument() needs to be respected when a document is created |
| https://bugs.webkit.org/show_bug.cgi?id=110308 |
| |
| Reviewed by Rob Buis. |
| |
| In DOMImplementation::createDocument() we should create |
| a PluginDocument for mime types that return "true" for |
| shouldAlwaysUsePluginDocument(), even if there is no pluginData |
| |