blob: b77231f655ea20be945d60b45f0c8bd94e058f55 [file] [log] [blame]
2012-05-21 Gavin Barraclough <barraclough@apple.com>
Disable private names by default in WebCore
https://bugs.webkit.org/show_bug.cgi?id=87088
Reviewed by Geoff Garen.
r117859 introduced a preliminary implementation of ES6-like private name objects to JSC.
These are probably not yet ready to be web-facing, so disabling by default in WebCore.
Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- Enable private name support in DRT.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
- Enable private name support in WKTR.
2012-05-22 Martin Robinson <mrobinson@igalia.com>
Fix a small syntax error in the GTK+ API test runner.
Reviewed by Gustavo Noronha Silva.
* gtk/run-api-tests:
(TestRunner._setup_testing_environment): When reporting the error use
the correct Python format string syntax.
2012-05-22 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[GTK][DRT] Wrong cache model is taken in LayoutTestController's setCacheModel()
https://bugs.webkit.org/show_bug.cgi?id=86962
Reviewed by Gustavo Noronha Silva.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setCacheModel): Sets WEBKIT_CACHE_MODEL_WEB_BROWSER if argument is 2.
2012-05-22 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[EFL][DRT] Key modifier bit flags have enum type.
https://bugs.webkit.org/show_bug.cgi?id=86838
Reviewed by Antonio Gomes.
Refactoring. Key modifier flags are unsigned int.
Key modifier bit flags used have enum type. It caused problems as a key can have several modifiers
at the same time and the union of modifiers (i.e. EvasKeyModifierControl | EvasKeyModifierShift)
would have been out of EvasKeyModifier enum.
* DumpRenderTree/efl/EventSender.cpp:
(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(MouseEventInfo::MouseEventInfo):
(MouseEventInfo):
(setEvasModifiers):
(modifiersFromJSValue):
(mouseDownCallback):
(mouseUpCallback):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):
2012-05-22 Takashi Sakamoto <tasak@google.com>
Implement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's location property
https://bugs.webkit.org/show_bug.cgi?id=86694
Modify keyDown to create left- and right- control, shift, and alt
keyevent for a test to check that keyLocation property can have
DOM_KEY_LOCATION_LEFT for left-control, shift, and alt, and
DOM_KEY_LOCATION_RIGHT for right-control, shift, and alt.
Reviewed by Alexey Proskuryakov.
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::keyDown):
* DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController keyDown:withModifiers:withLocation:]):
2012-05-22 Christophe Dumez <christophe.dumez@intel.com>
[EFL] EFL's DRT needs to print information about received Web Intents
https://bugs.webkit.org/show_bug.cgi?id=86864
Reviewed by Adam Barth.
Catch "intent,new" signal in EFL's DumpRenderTree and dump information
about the intent. This output is expected by several webintents test
cases.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameIntentNew):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
2012-05-22 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[EFL] Add support to enable/disable DOM paste
https://bugs.webkit.org/show_bug.cgi?id=85040
Reviewed by Gustavo Noronha Silva.
Enable JavascriptCanAccessClipboard setting on each test startup so
that test cases which rely on clipboard can be unskipped.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2012-05-22 Hugo Parente Lima <hugo.lima@openbossa.org>
[Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events
https://bugs.webkit.org/show_bug.cgi?id=87044
Reviewed by Alexis Menard.
Use sendOrQueueEvent instead of m_testController->mainWebView()->sendEvent
* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::keyDown):
2012-05-22 Zan Dobersek <zandobersek@gmail.com>
[Gtk][LayoutTests] Repaint the complete WebKitWebView before dumping pixel results
https://bugs.webkit.org/show_bug.cgi?id=86284
Reviewed by Martin Robinson.
Paint the current dirty regions of the web view once more before
dumping pixel results.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump):
2012-05-22 Allan Sandfeld Jensen <allan.jensen@nokia.com>
GCC 4.7 and C++11 support.
https://bugs.webkit.org/show_bug.cgi?id=86465
Reviewed by Darin Adler.
Update detection of C++11 mode in GCC.
* qmake/mkspecs/features/unix/default_post.prf:
2012-05-22 Hao Zheng <zhenghao@chromium.org>
[chromium] WebViewHost should use ENABLE guards for some features.
https://bugs.webkit.org/show_bug.cgi?id=87087
Reviewed by Kent Tamura.
These features are disabled on OS(ANDROID) and so shouldn't be
compiled when the feature is off.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::reset):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
2012-05-21 Christophe Dumez <christophe.dumez@intel.com>
[EFL] EFL's DumpRenderTree does not print didReceiveTitle messages
https://bugs.webkit.org/show_bug.cgi?id=85971
Reviewed by Antonio Gomes.
Listen for the "title,changed" signal on the frames instead of the
view so that we get notified for other frame than the main one.
Print out the didReceiveTitle messages which are expected if
LayoutTestController's dumpFrameLoadCallbacks() returns true.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameTitleChanged):
(DumpRenderTreeChrome::onFrameCreated):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
2012-05-21 Raphael Kubo da Costa <rakuco@webkit.org>
[EFL] Unreviewed, reverting r116461.
r116461 caused a regression in the pixel tests, as scrollbars
stopped being rendered in the PNGs.
* DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
(createBitmapContextFromWebView):
2012-05-21 Brady Eidson <beidson@apple.com>
<rdar://problem/11460336> and https://bugs.webkit.org/show_bug.cgi?id=87061
WKPageGetScaleFactor can return 0.0 after a session is restored
Reviewed by Beth Dakin.
Loads a simple page, creates a session from it, restores that session, then
queries the page scale factor for the appropriate value of 1.0.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::createSessionState):
(TestWebKitAPI::TEST):
2012-05-21 Hugo Parente Lima <hugo.lima@openbossa.org>
[WK2] Remove a useless #if on Tools/WebKitTestRunner/TestController.cpp
https://bugs.webkit.org/show_bug.cgi?id=87047
Reviewed by Alexis Menard.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2012-05-21 Dirk Pranke <dpranke@chromium.org>
webkitpy: clean up the TestExpectations constructor
https://bugs.webkit.org/show_bug.cgi?id=86926
Reviewed by Ojan Vafai.
The TestExpectations constructor was attempting to pretend
it didn't need to get stuff from the Port, and as a result we
had a complicated constructor with a bunch of arguments, and
calling it was too complicated (although it made testing a
little easier and simplified the style checker).
This patch has the constructor pull all the data it needs from
the port directly, and allows us to delete a bunch of code.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.parse_expectations):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_update_summary_with_result):
(ResultSummaryTest.get_result_summary):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.__init__):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(parse_exp):
(SkippedTests.check):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(lint):
(run):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(LintTest.test_all_configurations.FakePort.__init__):
(LintTest.test_all_configurations.FakePort.test_expectations):
(LintTest.test_all_configurations.FakePort.skipped_layout_tests):
(LintTest.test_all_configurations.FakePort):
(LintTest.test_all_configurations.FakePort.all_test_configurations):
(LintTest.test_all_configurations.FakePort.configuration_specifier_macros):
(LintTest.test_all_configurations.FakePort.path_from_webkit_base):
(LintTest.test_all_configurations.FakePort.get_option):
(LintTest.test_all_configurations.FakeFactory.__init__):
(LintTest.test_all_configurations.FakeFactory.all_port_names):
(LintTest.test_all_configurations):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_result_summary):
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations):
* Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations._model):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._update_expectations_file):
(RebaselineExpectations._expectations):
2012-05-21 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[GTK] DRT support for layoutTestController.setSerializeHTTPLoads
https://bugs.webkit.org/show_bug.cgi?id=86653
Reviewed by Gustavo Noronha Silva.
Add missing implementation setSerializeHTTPLoads to allow
testing resource load order.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setSerializeHTTPLoads):
2012-05-21 Elliot Poger <epoger@chromium.org>
add skia_test_expectations override file to chromium NRWT
https://bugs.webkit.org/show_bug.cgi?id=86749
Reviewed by Dirk Pranke
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.test_expectations_overrides):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.test_expectations_overrides):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_overrides_and_builder_names):
2012-05-21 Thiago Marcos P. Santos <thiago.santos@intel.com>
webkitdirs.pm: Fix undefined CXXFLAGS variable
https://bugs.webkit.org/show_bug.cgi?id=87000
Reviewed by Martin Robinson.
Fixes a warning on Autotools and CMake buildsystem when
CXXFLAGS is not defined.
* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary):
(generateBuildSystemFromCMakeProject):
2012-05-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Move setEditingBehavior() from layoutTestController to window.internals
https://bugs.webkit.org/show_bug.cgi?id=42689
Reviewed by Hajime Morita and Kenneth Rohde Christiansen.
Remove code that implements setEditingBehavior() for each platform. Note that
During the InternalsObject reset the behavior is changed back to the platform
default.
Qt and Chromium ports set a default editing behavior for running tests different
from the platform default, so they still keep code for resetting to the desired
editing behavior. Other ports use the their defaults, that are restored by
internals object.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2012-05-21 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[EFL] PlatformKeyboardEventEfl is missing ESC key handling.
https://bugs.webkit.org/show_bug.cgi?id=86837
Reviewed by Kenneth Rohde Christiansen.
* DumpRenderTree/efl/EventSender.cpp:
(keyNameFromJSValue): Added ESC key handling.
2012-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Add GCancellable parameter to all methods using gio async pattern
https://bugs.webkit.org/show_bug.cgi?id=86843
Reviewed by Gustavo Noronha Silva.
* MiniBrowser/gtk/BrowserWindow.c:
(browser_window_load_uri):
2012-05-20 Daniel Bates <dbates@webkit.org>
svn-apply cannot apply patches to files that contain space
characters in their path
https://bugs.webkit.org/show_bug.cgi?id=85742
Reviewed by Eric Seidel.
Fixes an issue where svn-apply cannot apply a patch to a file
if there is a space in its file path.
The regular expression we were using to fix up +++/--- lines
was too strict; it only matched file paths that contained non-
whitespace characters. Instead, it's sufficient to match file
paths whose characters aren't in the set {\t, \n, \r}.
* Scripts/VCSUtils.pm:
(parseSvnDiffHeader):
(runCommand): Added.
* Scripts/svn-apply:
(scmWillDeleteFile): Modified to call runCommand() so as to
handle querying git for a file whose path may contain a space
character.
* Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
- Added test case "new file with spaces in its name".
* Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: Added.
2012-05-20 Daniel Bates <dbates@webkit.org>
svn-apply fails to apply a patch that moves files from directory A to A/B
https://bugs.webkit.org/show_bug.cgi?id=86973
Reviewed by Eric Seidel.
Fixes an issue where svn-apply fails to apply a patch that moves files in a
directory A to some sub-directory B in A with a Git checkout of WebKit.
Currently, svn-apply only creates new directories along a file system path that
it hasn't already processed. That is, if svn-apply creates/traverses all the
intermediate directories along the path A/B then it will assume the directory A/B
exists for all subsequent requests to create sub-directories in A/B (e.g. A/B/C).
When moving a file F in directory A to directory A/B using a Git checkout, Git
may remove directory A if F is the last file in A. Therefore, svn-apply will fail
to create sub-directory B in A (since A no longer exists).
* Scripts/svn-apply:
(addDirectoriesIfNeeded):
2012-05-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
[Chromium] Print layout test result on buildbot
https://bugs.webkit.org/show_bug.cgi?id=86965
Reviewed by Eric Seidel.
* Scripts/run-webkit-tests: Add chrome-bot to buildbot user list.
(runningOnBuildBot):
2012-05-19 Kevin Ollivier <kevino@theolliviers.com>
[wx] Unreviewed build fix. Don't stop the build if a build system update check fails.
* waf/build/build_utils.py:
(download_if_newer):
2012-05-19 Ryosuke Niwa <rniwa@webkit.org>
Build fix. Sometimes --suffixes isn't supplied.
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.optimizebaselines):
2012-05-19 Ryosuke Niwa <rniwa@webkit.org>
Add "Lion" -> "mac-lion" to the builder port map.
* Scripts/webkitpy/layout_tests/port/builders.py:
2012-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r117675.
http://trac.webkit.org/changeset/117675
https://bugs.webkit.org/show_bug.cgi?id=86938
Broke builds. You can't initialize members by members
themselves (Requested by rniwa on #webkit).
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::numberOfPages):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::printPage):
2012-05-18 Kausalya Madhusudhanan <kmadhusu@chromium.org>
[chromium] User overloaded printBegin() webkit API to support auto fit to page functionality.
https://bugs.webkit.org/show_bug.cgi?id=86684
Reviewed by Darin Fisher.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::numberOfPages):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::printPage):
2012-05-18 Raphael Kubo da Costa <rakuco@webkit.org>
[EFL][DRT] Make it possible to enable CSS Grid Layout.
https://bugs.webkit.org/show_bug.cgi?id=86921
Reviewed by Tony Chang.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::overridePreference):
2012-05-18 Dirk Pranke <dpranke@chromium.org>
scm.add() doesn't work properly with svn 1.7
https://bugs.webkit.org/show_bug.cgi?id=86779
Reviewed by Eric Seidel.
Re-land the change in r117526 with a fix to maintain
compatibility with SVN 1.4.4 (yay Leopard!); turns out
that "svn info foo" works correctly in 1.4.4 but
"svn info" from the directory "foo" doesn't if foo is
not part of a checkout. in_working_directory() and
value_from_svn_info() were using the arguments inconsistently,
leading to weird errors.
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM):
(SCM.in_working_directory):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN):
(SVN.in_working_directory):
2012-05-18 Levi Weintraub <leviw@chromium.org>
Unreviewed. Moving myself from committer to reviewer.
* Scripts/webkitpy/common/config/committers.py:
2012-05-18 Thiago Marcos P. Santos <thiago.santos@intel.com>
[EFL] Buildbot output does not print result stats anymore
https://bugs.webkit.org/show_bug.cgi?id=85366
Reviewed by Ryosuke Niwa.
Make run-webkit-tests pass --verbose to new-run-webkit-tests
on EFL Debug bot.
* Scripts/run-webkit-tests:
(runningOnBuildBot):
2012-05-18 Tony Chang <tony@chromium.org>
remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off
https://bugs.webkit.org/show_bug.cgi?id=86767
Reviewed by Ojan Vafai.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::overridePreference):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):
* Scripts/webkitperl/FeatureList.pm:
2012-05-18 Hugo Parente Lima <hugo.lima@openbossa.org>
[Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
https://bugs.webkit.org/show_bug.cgi?id=86731
Reviewed by Simon Hausmann.
Set the page visibility on a single page instead of on all pages
from the page group.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setPageVisibility):
(WTR::LayoutTestController::resetPageVisibility):
2012-05-18 Yi Shen <yi.4.shen@nokia.com>
REGRESSION (r102553): Smart links do not work
https://bugs.webkit.org/show_bug.cgi?id=85463
Reviewed by Ryosuke Niwa.
Add LayoutTestController::setAutomaticLinkDetectionEnabled().
* DumpRenderTree/LayoutTestController.cpp:
(setAutomaticLinkDetectionEnabledCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Set automatic link detection enabled.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
2012-05-18 Thiago Marcos P. Santos <thiago.santos@intel.com>
[EFL] Add shortcut to dump Security Origin and Web Database information
https://bugs.webkit.org/show_bug.cgi?id=86521
Reviewed by Gustavo Noronha Silva.
Added key combination (CTRL+s) to dump information about the
security origin and databases of the main frame. Useful for API
testing and debugging.
* EWebLauncher/main.c:
(on_key_down):
2012-05-18 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[EFL] DRT needs an implementation of layoutTestController.setSerializeHTTPLoads
https://bugs.webkit.org/show_bug.cgi?id=86101
Reviewed by Ryosuke Niwa.
Add missing implementation setSerializeHTTPLoads to allow
testing resource load order.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setSerializeHTTPLoads):
2012-05-18 Jochen Eisinger <jochen@chromium.org>
[chromium] plumb the frame for which a drag was initiated to the WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=86670
Reviewed by Kent Tamura.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::startDragging):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
2012-05-18 Christophe Dumez <christophe.dumez@intel.com>
[EFL] appcache tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86619
Reviewed by Ryosuke Niwa.
Correctly set the application cache database path in EFL's
DumpRenderTree initialization code.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
2012-05-17 Raphael Kubo da Costa <rakuco@webkit.org>
[EFL][DRT] Call resetInternalsObject() after each test.
https://bugs.webkit.org/show_bug.cgi?id=86793
Reviewed by Antonio Gomes.
We need to reset the internals object's settings after running
each test so that there are no interferences between each test's
results.
* DumpRenderTree/efl/DumpRenderTree.cpp:
(runTest):
2012-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r117526.
http://trac.webkit.org/changeset/117526
https://bugs.webkit.org/show_bug.cgi?id=86801
broke Chromium Mac 10.5 layout test canaries (Requested by
pkasting on #webkit).
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM):
(SCM.in_working_directory):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN):
(SVN.in_working_directory):
2012-05-17 Dirk Pranke <dpranke@chromium.org>
scm.add() doesn't work properly with svn 1.7
https://bugs.webkit.org/show_bug.cgi?id=86779
Reviewed by Ojan Vafai.
The code relied on '.svn' directories being present
in order to tell if a directory had already been added to the
repository; this is no longer true in SVN 1.7.
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM):
(SCM.in_working_directory):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN):
(SVN.in_working_directory):
2012-05-17 Jon Lee <jonlee@apple.com>
Update Apple buildbots to prioritize latest changelists
https://bugs.webkit.org/show_bug.cgi?id=86766
Reviewed by Brady Eidson.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(pickLatestBuild): Function to get the most pick the most recent build request.
(loadBuilderConfig): Configure builders in the AppleMac and AppleWin categories to
use the pickLatestBuild function when choosing which request to build next.
2012-05-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
[Qt] Fix MiniBrowser by using correct syntax for qrc URLs
https://bugs.webkit.org/show_bug.cgi?id=86761
Reviewed by Alexis Menard.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::updateVisualMockTouchPoints):
2012-05-17 Thiago Marcos P. Santos <thiago.santos@intel.com>
[EFL] Add API for Web Database handling
https://bugs.webkit.org/show_bug.cgi?id=85178
Reviewed by Antonio Gomes.
Use the newly introduced Web Database API in EFL's DRT.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearAllDatabases):
2012-05-17 Dan Bernstein <mitz@apple.com>
REGRESSION (r117428): WebKit API/SPI was removed
https://bugs.webkit.org/show_bug.cgi?id=86748
Reverted r117428.
* DumpRenderTree/LayoutTestController.cpp:
(setDomainRelaxationForbiddenForURLSchemeCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2012-05-17 Li Yin <li.yin@intel.com>
[chromium] run-webkit-tests can't work on ubuntu 12.04
https://bugs.webkit.org/show_bug.cgi?id=86565
Reviewed by Kent Tamura.
On ubuntu 12.04, the package ttf-thai-tlwg install the Garuda.ttf
into /usr/share/fonts/truetype/tlwg/Garuda.ttf, not /usr/share/fonts/truetype/thai/Garuda.ttf
* DumpRenderTree/chromium/TestShellLinux.cpp:
(checkAndLoadFontFile):
(setupFontconfig):
2012-05-17 Elliot Poger <epoger@chromium.org>
Add setting of additional_expectations option to
chromium_unittest.test_overrides_and_builder_names(),
so we can test order in which the base and chromium expectations files
are combined.
https://bugs.webkit.org/show_bug.cgi?id=86642
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_overrides_and_builder_names):
2012-05-17 Balazs Kelemen <kbalazs@webkit.org>
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620
Reviewed by Csaba Osztrogonác.
Reenable TestNetscapePlugin with Qt 4.
* Tools.pro:
2012-05-17 Hugo Parente Lima <hugo.lima@openbossa.org>
[Qt][WK2] fast/events/page-visibility-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=83263
Reviewed by Kenneth Rohde Christiansen.
Handle "preview" state and avoid string conversion.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setPageVisibility):
2012-05-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
https://bugs.webkit.org/show_bug.cgi?id=86704
Reviewed by Eric Seidel.
Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2012-05-17 Mariusz Grzegorczyk <mariusz.g@samsung.com>
[EFL] [DRT] EFL's DumpRenderTree should support LayoutTestController's dumpEditingCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=84835
Reviewed by Eric Seidel.
Added editing callbacks implementation.
* DumpRenderTree/efl/CMakeLists.txt: Add EditingCallbacks.cpp to compilation.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Invoke connectEditingCallbacks.
(DumpRenderTreeChrome::createView):
* DumpRenderTree/efl/EditingCallbacks.cpp: Added. Dump editing callbacks.
(dumpPath):
(dumpRange):
(insertActionString):
(selectionAffinityString):
(shouldBeginEditing):
(shouldEndEditing):
(shouldInsertNode):
(shouldInsertText):
(shouldDeleteRange):
(shouldChangeSelectedRange):
(shouldApplyStyle):
(editingBegan):
(userChangedContents):
(editingEnded):
(selectionChanged):
(connectEditingCallbacks):
* DumpRenderTree/efl/EditingCallbacks.h: Added.
2012-05-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed. Roll out r117382 because of layout test crashes on EFL debug buildbot.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
2012-05-17 Kentaro Hara <haraken@chromium.org>
[Performance test] In perftest.py, do not include 'description' in 'results'
https://bugs.webkit.org/show_bug.cgi?id=86696
Reviewed by Csaba Osztrogoná.
'results' in perftest.py should not include any data that is not expected
by the perf bot server. We do not need to send 'description' to the perf bot
server since 'description' is always the same.
Thus this patch just removes 'description' from 'results'.
* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest.run):
2012-05-17 Kentaro Hara <haraken@chromium.org>
[Performance test] Always fill results['description'] in perftest.py
https://bugs.webkit.org/show_bug.cgi?id=86696
Reviewed by Ryosuke Niwa.
This is a follow-up patch for r117397 to fix perf bot failures.
This patch fills results['description'] always.
* Scripts/webkitpy/performance_tests/perftest.py:
(PageLoadingPerfTest.run):
2012-05-16 Kentaro Hara <haraken@chromium.org>
[Performance test] Support "description" for PerfTestRunner.run and PerfTestRunner.runPerSecond
https://bugs.webkit.org/show_bug.cgi?id=86696
Reviewed by Ryosuke Niwa.
We want to add some description for each PerfTestRunner.run and
PerfTestRunner.runPerSecond, so that people can know what each
run is testing.
Output example:
$ ./Tools/Scripts/run-perf-tests Bindings/first-child.html
Running Bindings/first-child.html (1 of 1)
DESCRIPTION: Benchmark for DOM attributes that return a Node object.
RESULT Bindings: first-child= 788.359076534 runs/s
median= 797.508097751 runs/s, stdev= 19.0972905207 runs/s, min= 746.666666667 runs/s, max= 801.001251564 runs/s
* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output):
(PerfTest.output_statistics):
2012-05-16 Christophe Dumez <christophe.dumez@intel.com>
[EFL] appcache tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86619
Reviewed by Gustavo Noronha Silva.
Correctly set the application cache database path in EFL's
DumpRenderTree initialization code.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
2012-05-16 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Add new build slave for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=86567
Reviewed by Ryosuke Niwa.
Add a build slave for EFL 32-bit linux build.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2012-05-16 Kihong Kwon <kihong.kwon@samsung.com>
[EFL] Support for Battery Status API on the WebKit-Efl
https://bugs.webkit.org/show_bug.cgi?id=83254
Reviewed by Chang Shu.
Add e_dbus libraries to jhbuild's modules list.
* efl/jhbuild.modules:
2012-05-16 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Rounding errors on 32-bit machines causes tests to fail
https://bugs.webkit.org/show_bug.cgi?id=86194
Reviewed by Martin Robinson.
Pass additional CXXFLAGS to CMake in an attempt to harmonize floating
point values between 32-bit and 64-bit architectures.
Same flags are already used by Qt and GTK ports.
* Scripts/webkitdirs.pm:
(determineArchitecture):
(generateBuildSystemFromCMakeProject):
2012-05-16 Balazs Kelemen <kbalazs@webkit.org>
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620
Reviewed by Csaba Osztrogonác.
Temporary workaround not to fail layout tests.
* Tools.pro: Disable TestNetscapePlugin.
2012-05-16 Dinu Jacob <dinu.jacob@nokia.com>
Add didFinishProgress BundleUIClient callback
https://bugs.webkit.org/show_bug.cgi?id=86541
Reviewed by Kenneth Rohde Christiansen.
Added support for dumpProgressFinishedCallback.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didFinishProgress):
(WTR):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpProgressFinishedCallback):
(WTR::LayoutTestController::setShouldDumpProgressFinishedCallback):
(WTR::LayoutTestController::shouldDumpProgressFinishedCallback):
(LayoutTestController):
2012-05-15 Pierre Rossi <pierre.rossi@gmail.com>
[Qt] Enable SVG Fonts by default
https://bugs.webkit.org/show_bug.cgi?id=86463
Reviewed by Nikolas Zimmermann.
* qmake/mkspecs/features/features.pri:
2012-05-16 Christophe Dumez <christophe.dumez@intel.com>
[EFL] EFL's LayoutTestController does not implement setApplicationCacheOriginQuota
https://bugs.webkit.org/show_bug.cgi?id=85585
Reviewed by Gustavo Noronha Silva.
Implement setApplicationCacheOriginQuota in EFL's
LayoutTestController.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededApplicationCacheQuota):
(drtViewAdd):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setApplicationCacheOriginQuota):
2012-05-16 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[EFL] EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation
https://bugs.webkit.org/show_bug.cgi?id=83776
Reviewed by Tor Arne Vestbø.
Added missing implementation of LayoutTestController::evaluateScriptInIsolatedWorld().
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
2012-05-16 Grzegorz Czajkowski <g.czajkowski@samsung.com>
Unreviewed. Add myself as a committer.
* Scripts/webkitpy/common/config/committers.py:
2012-05-15 Kangil Han <kangil.han@samsung.com>
[EFL][DRT] Fix eventSender key providing
https://bugs.webkit.org/show_bug.cgi?id=84710
Reviewed by Andreas Kling.
Currently eventSender doesn't provide key event correctly.
For example, 'Right' will be visible when 'right arrow' key event is fired.
Given circumstance, nothing has to be shown.
Therefore, this patch fixed incorrectly provided key event.
* DumpRenderTree/efl/EventSender.cpp:
(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):
2012-05-15 Dan Bernstein <mitz@apple.com>
Fixed a typo.
* Scripts/copy-webkitlibraries-to-product-directory:
2012-05-15 Kihong Kwon <kihong.kwon@samsung.com>
[EFL] Enable Fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=85870
Reviewed by Antonio Gomes.
Enable full screen api feature on the EFL port.
There are two failed test cases under LayoutTests/fullscreen.
They are going to be fixed with other patch.
* Scripts/webkitperl/FeatureList.pm:
2012-05-15 James Robinson <jamesr@chromium.org>
[chromium] Chromium port never sets USE(CG) so code behind it is dead
https://bugs.webkit.org/show_bug.cgi?id=86537
Reviewed by Adrienne Walker.
Deletes code behind USE(CG) in chromium-specific code and removes unneeded USE(SKIA) guards.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::paintRect):
2012-05-15 James Robinson <jamesr@chromium.org>
[chromium] Remove WEBKIT_USING_(SKIA|CG) #defines
https://bugs.webkit.org/show_bug.cgi?id=86536
Reviewed by Adam Barth.
Deletes dead WEBKIT_USING_CG code and #ifdefs guarding it.
* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::paintPagesWithBoundaries):
2012-05-15 James Robinson <jamesr@chromium.org>
[chromium] Unreviewed build fix.
Partial revert of r117166 - it appears making DumpRenderTree depend on webkit_platform causes crashes in the
component build, at least on linux. This restores Tools/DumpRenderTree to its pre-r117166 state.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::initialize):
2012-05-15 Elliot Poger <epoger@google.com>
add unit test for NRWT's --additional-expectations option
https://bugs.webkit.org/show_bug.cgi?id=86501
Reviewed by Ojan Vafai.
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_additional_expectations):
2012-05-15 James Robinson <jamesr@chromium.org>
[chromium] Move createOffscreenGraphicsContext3D() from WebKitPlatformSupport to Platform
https://bugs.webkit.org/show_bug.cgi?id=86524
Reviewed by Adam Barth.
Updates TestWebPlugin to use the Platform headers and updates the build dependencies so it can.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::initialize):
2012-05-15 Jessie Berlin <jberlin@apple.com>
WKContextSetCacheModel(contextref, kWKCacheModelDocumentViewer) doesn't prevent pages from
going into the PageCache.
https://bugs.webkit.org/show_bug.cgi?id=85891
Reviewed by Brady Eidson.
Set the cache model in DOMWindowExtensionNoCache so that the page cache is not used. This is
better than using pages with unload handlers because we may find a way to make pages with
unload handlers cacheable in the future.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Remove simple-iframe-unload.html and simple-unload.html, since they are no longer used.
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
(TestWebKitAPI::TEST):
Set the cache model to kWKCacheModelDocumentViewer.
* TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Removed.
* TestWebKitAPI/Tests/WebKit2/simple-unload.html: Removed.
2012-05-15 Kenneth Rohde Christiansen <kenneth@webkit.org>
[Qt] Add infra for testing double-tap to zoom functionality etc
https://bugs.webkit.org/show_bug.cgi?id=86474
Reviewed by Simon Hausmann.
The WebViewportInfo class was renamed to QWebKitTest in preparation
of becoming a separate module. Adapt the use API.
* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/qml/ViewportInfoItem.qml:
2012-05-15 Csaba Osztrogonác <ossy@webkit.org>
Introduce ENABLE_CSS_VARIABLES compile flag.
https://bugs.webkit.org/show_bug.cgi?id=86338
Reviewed by Hajime Morita.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Unittest fix after r117028.
(WebKitPortTest.test_skipped_directories_for_symbols):
2012-05-15 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Teach webkit-patch to gracefully handle writes of raw utf-8 encoded strings to sys.stdout
https://bugs.webkit.org/show_bug.cgi?id=85809
webkit-patch overrides sys.stdout with a StreamWriter that ensures we write utf8
output to stdout, but StreamWriter will by default always encode the object that's
passed to write(). This blows up when the object is a raw string, already encoded
as utf8, and does not match the default behavior of sys.stdout.
To solve this in one place, instead of every single call-site that might write
raw strings, we extend the stdout-wrapper to assume raw strings are utf8 before
passing them on to StreamWriter.write(). This has the benefit of also making the
stacktrace easy to read in the case where this assumption does not hold.
The source of this particular bug was that Executive.run_and_throw_if_fail() will
tee the output of the subprocess, and in the case of running prepare-ChangeLog this
might produce non-ascii output, which gets written directly to sys.stdout as raw
utf8-encoded strings.
Reviewed by Dirk Pranke.
* Scripts/webkit-patch:
2012-05-15 Tomasz Morawski <t.morawski@samsung.com>
[EFL][DRT] Split ewk_private.h file to multiple private files.
https://bugs.webkit.org/show_bug.cgi?id=84572
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2012-05-15 Michael Brüning <michael.bruning@nokia.com>
[Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with timeout
https://bugs.webkit.org/show_bug.cgi?id=83576
Reviewed by Simon Hausmann.
Set the PlatformWebView for the Qt port to accept all SSL certificates.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
2012-05-14 Luke Macpherson <macpherson@chromium.org>
Introduce ENABLE_CSS_VARIABLES compile flag.
https://bugs.webkit.org/show_bug.cgi?id=86338
Reviewed by Dimitri Glazkov.
Add a configuration option for CSS Variables support, disabling it by default.
* Scripts/webkitperl/FeatureList.pm:
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._missing_symbol_to_skipped_tests):
* qmake/mkspecs/features/features.pri:
2012-05-14 Nate Chapin <japhet@chromium.org>
Add end-of-life test cases for https://bugs.webkit.org/show_bug.cgi?id=86131.
Reviewed by Adam Barth.
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(callDeletePlugin):
(pluginHasProperty):
(pluginHasMethod):
(pluginGetProperty):
(pluginSetProperty):
(pluginInvoke):
2012-05-14 Dirk Pranke <dpranke@chromium.org>
Re-enable "drt mode" on chromium-mac-leopard
https://bugs.webkit.org/show_bug.cgi?id=83076
Unreviewed, build fix (change?).
This change is another attempt to gather data on
the flakiness and timeouts we're seeing on Mac SL
now that we have another bot.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.__init__):
2012-05-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r116981.
http://trac.webkit.org/changeset/116981
https://bugs.webkit.org/show_bug.cgi?id=86402
Caused compositing and mathml tests to fail. (Requested by
rakuco on #webkit).
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):
2012-05-14 Dirk Pranke <dpranke@chromium.org>
Fix regressions in garden-o-matic after r116988.
Unreviewed, build fix.
I had a typo in a field name in checkout.js, and unfortunately
the unittests had the same typo :(.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2012-05-14 Dirk Pranke <dpranke@chromium.org>
garden-o-matic should specify which types of baselines to rebaseline
https://bugs.webkit.org/show_bug.cgi?id=86242
Reviewed by Adam Barth.
This change modifies garden-o-matic so that we are explicit
about whether to rebaseline the text file, the image file, or
both. This should prevent us from pulling incorrect or
unexpected baselines off the bots.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
(.):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(AbstractRebaseliningCommand.__init__):
(RebaselineTest):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
(OptimizeBaselines):
(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines):
(AnalyzeBaselines._analyze_baseline):
(AnalyzeBaselines.execute):
(RebaselineExpectations._rebaseline_port):
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.optimizebaselines):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline):
(GardeningServerTest.test_rebaseline_new_port):
(GardeningServerTest.test_optimizebaselines):
2012-05-14 Kangil Han <kangil.han@samsung.com>
[EFL][DRT] Fix WebCore library path
https://bugs.webkit.org/show_bug.cgi?id=86355
Reviewed by Dirk Pranke.
Currently EFL DRT uses wrong WebCore library path when running DRT.
This patch simply adjusted it.
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):
2012-05-14 Wei James <james.wei@intel.com>
[Chromium] ImageDiff should be build for host on Android
https://bugs.webkit.org/show_bug.cgi?id=82039
Reviewed by Adam Barth.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2012-05-14 Joone Hur <joone@webkit.org>
Unreviewed. Updating email for committers.py script.
* Scripts/webkitpy/common/config/committers.py:
2012-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix make distcheck.
* GNUmakefile.am: Add run-api-tests script to EXTRA_DIST.
* gtk/run-api-tests:
(TestRunner._lookup_atspi2_binary): Handle the case when
pkg_config_file_variable() return None.
2012-05-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r116935.
http://trac.webkit.org/changeset/116935
https://bugs.webkit.org/show_bug.cgi?id=86373
Something is still broken (Requested by Ossy on #webkit).
* Scripts/webkitpy/common/checksvnconfigfile.py: Removed.
* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.check):
(PNGChecker):
(PNGChecker._config_file_path):
* Scripts/webkitpy/tool/commands/download.py:
(Land):
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Removed.
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Removed.
2012-05-14 Allan Sandfeld Jensen <allan.jensen@nokia.com>
[Qt] Doesn't build with ENABLE_INSPECTOR=0
https://bugs.webkit.org/show_bug.cgi?id=85056
Reviewed by Tor Arne Vestbø.
* WebKitTestRunner/TestInvocation.cpp: Ifdef otherwise unused static function.
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/features.pri:
2012-05-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Make sure dialogs have their parent and attached properties set before Component.onCompleted
https://bugs.webkit.org/show_bug.cgi?id=86222
The WebView QML api for dialogs is based on delegates for each dialog, which
are implemented as components. Since there's no explicit API to show the dialog,
the natural place to allow the dialog to choose how to display itself is in
Component.onCompleted.
The issue was that we were using QQmlComponent::create() when instantiating the
component, at which point the component did not have a parent or it's attached
WebView property set. That meant that we had to do some ugly workaround in our
test, using a 1ms timer, to get a callback once the parent was there.
We now use the QQmlComponent::beginCreate() -> QQmlComponent::completeCreate()
pair, which allows us to set the relevant properties before triggering the
Component.onCompleted callback. We were already doing this for the context
menus (except for setting the parent, which we did afterwards).
Reviewed by Simon Hausmann.
* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/qml/Dialog.qml:
2012-05-14 Balazs Ankes <bank@inf.u-szeged.hu>
webkit-patch land should automatically add svn:mime-type for .png files
https://bugs.webkit.org/show_bug.cgi?id=75825
I refactored the png.py to avoid code duplication.
Reviewed by Dirk Pranke.
* Scripts/webkitpy/common/checksvnconfigfile.py: Added.
(check):
(_config_file_path):
(errorstr_autoprop):
(errorstr_png):
* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.check):
* Scripts/webkitpy/tool/commands/download.py:
(Land):
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.
(AddSvnMimetypeForPng):
(AddSvnMimetypeForPng.__init__):
(AddSvnMimetypeForPng.run):
(AddSvnMimetypeForPng._check_pngs):
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.
(MockSCMDetector):
(MockSCMDetector.__init__):
(MockSCMDetector.display_name):
(AddSvnMimetypeForPngTest):
(AddSvnMimetypeForPngTest.test_run):
2012-05-14 David Kilzer <ddkilzer@apple.com>
webkit-patch apply-attachment is very slow for big patches
https://bugs.webkit.org/show_bug.cgi?id=74929
Add "excludefield=attachmentdata" to the URL everywhere
"ctype=xml" is used to exclude this field from the XML.
Reviewed by Adam Barth.
* Scripts/prepare-ChangeLog:
(fetchBugDescriptionFromURL):
* Scripts/webkitpy/common/config/urls.py:
* Scripts/webkitpy/common/config/urls_unittest.py:
(URLsTest.test_parse_bug_id):
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.bug_url_for_bug_id):
2012-05-13 Ryosuke Niwa <rniwa@webkit.org>
performance tests should be able to measure runs/sec rather than time
https://bugs.webkit.org/show_bug.cgi?id=86021
Reviewed by Ojan Vafai.
Allow " runs/s" or " ms" to appear after numerical values in tests.
* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
2012-05-12 Tim Horton <timothy_horton@apple.com>
run-safari and co. should support --guard-malloc command line argument
https://bugs.webkit.org/show_bug.cgi?id=86287
Reviewed by Dan Bernstein.
Add setUpGuardMallocIfNeeded(), which consults the argument --guard-malloc on OS X,
setting DYLD_INSERT_LIBRARIES="/usr/lib/libgmalloc.dylib" if it's enabled.
Use setUpGuardMallocIfNeeded() before running a WebKit app (whether standalone or
in the debugger). This will cause gmalloc to be loaded for gdb as well, but this
tends to be harmless.
Change "malloc guard" to the more common "Guard Malloc" in run-webkit-tests.
* Scripts/old-run-webkit-tests:
* Scripts/webkitdirs.pm:
(appendToEnvironmentVariableList):
(setUpGuardMallocIfNeeded):
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
(runMacWebKitApp):
(execMacWebKitAppForDebugging):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
2012-05-11 Ojan Vafai <ojan@chromium.org>
Add previous/next buttons the garden-o-matics perf panel
https://bugs.webkit.org/show_bug.cgi?id=86280
Reviewed by Dimitri Glazkov.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css:
2012-05-11 Kevin Ollivier <kevino@theolliviers.com>
[wx] Unreviewed build fix. Fix memory exhausted errors from 32-bit ld on *nix.
* waf/build/settings.py:
(common_configure):
2012-05-11 Dirk Pranke <dpranke@chromium.org>
webkit-patch rebaseline should fetch stale expectations :)
https://bugs.webkit.org/show_bug.cgi?id=86231
Unreviewed, build fix.
This change reverts r115492 and goes back to fetching individual
baselines from the layout tests directory, rather than fetching
entire zip files. The performance hit over networks for people
far away from the bots has turned out to be severe, so we need a
better solution to this.
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._results_url):
(RebaselineTest._file_name_for_expected_result):
(RebaselineTest._rebaseline_test):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_test):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
2012-05-11 Christophe Dumez <christophe.dumez@intel.com>
[GTK] LayoutTests/svg/batik/text/verticalText.svg fails to display Chinese characters
https://bugs.webkit.org/show_bug.cgi?id=86198
Reviewed by Martin Robinson.
Update webkitgtk-fonts package to v0.0.3 in order to get new Kochi
Mincho / Gothic fonts to display Japanese and Chinese characters.
* gtk/jhbuild.modules:
2012-05-11 Christophe Dumez <christophe.dumez@intel.com>
[EFL][DRT] SVG Batik test fails to display Chinese characters
https://bugs.webkit.org/show_bug.cgi?id=84461
Reviewed by Martin Robinson.
Update webkitgtk-fonts package from v0.0.1 to v0.0.3 in order to get
new Kochi Mincho / Gothic fonts to display Japanese and Chinese
characters.
* DumpRenderTree/efl/CMakeLists.txt:
* efl/jhbuild.modules:
2012-05-11 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK 64-bit Debug bot fix attempt.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_gdb_output): Ignore unicode decoding errors when
processing gdb output.
2012-05-11 Gustavo Noronha Silva <gns@gnome.org>
REGRESSION(r116205): [GTK]: build no longer supports thin archives
https://bugs.webkit.org/show_bug.cgi?id=86207
* GNUmakefile.am: link libWebCoreModules to DRT.
2012-05-10 Ojan Vafai <ojan@chromium.org>
Add a perf tab to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=86169
Reviewed by Dimitri Glazkov.
This is a first stab at making it easier to view the Chromium WebKit canary
perf graphs. For now, it's just a couple select elements and an iframe.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2012-05-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Move resumeAnimations to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=86063
Reviewed by Alexey Proskuryakov.
Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
2012-05-10 Alexey Proskuryakov <ap@apple.com>
Crash in 3rd party WebKit apps that disable cache at a wrong time
https://bugs.webkit.org/show_bug.cgi?id=86027
<rdar://problem/10615880>
Reviewed by Antti Koivisto.
Added a test that's very similar to MemoryCachePruneWithinResourceLoadDelegate,
but for disabling the cache instead of triggering a prune.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.html: Added.
* TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm: Added.
(-[MemoryCacheDisableTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
(-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
(-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
(TestWebKitAPI::TEST):
2012-05-10 Anders Carlsson <andersca@apple.com>
WebKit2: Add a way to blacklist specific plug-ins/plug-in versions
https://bugs.webkit.org/show_bug.cgi?id=86164
<rdar://problem/9551196>
Reviewed by Sam Weinig.
Update for WK2 API changes.
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
2012-05-10 Dirk Pranke <dpranke@chromium.org>
nrwt: [chromium] fix path to asan symbolize script
https://bugs.webkit.org/show_bug.cgi?id=86161
Reviewed by Abhishek Arya.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._get_crash_log):
2012-05-10 Lei Zhang <thestig@chromium.org>
[chromium] Set Valgrind environment variables for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=86156
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.setup_environ_for_server):
2012-05-10 Raphael Kubo da Costa <rakuco@webkit.org>
[webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
https://bugs.webkit.org/show_bug.cgi?id=86145
Reviewed by Dirk Pranke.
The GTK+ and EFL ports use jhbuild to build a few base libraries
which are then used when building the port itself. Programs such
as DRT and ImageDiff are then supposed to be run with the
`run-with-jhbuild' wrapper so that the libraries are properly
found and loaded.
This was already the case for DumpRenderTree (EflPort defines the
'wrapper' option for that), but it was not possible to do the same
with ImageDiff so far.
The code which created the ImageDiff command-line call has been
moved to a separate method, _image_diff_command, which is then
overridden by EflPort to add the jhbuild wrapper.
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.__init__):
(EflPort._image_diff_command):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort):
(WebKitPort._image_diff_command):
(WebKitPort._start_image_diff_process):
2012-05-10 Zan Dobersek <zandobersek@gmail.com>
[GTK] ENABLE_IFRAME_SEAMLESS support
https://bugs.webkit.org/show_bug.cgi?id=85843
Reviewed by Eric Seidel.
Add the iframe-seamless option to the options list. This makes it
possible to enable the iframe seamless support through build-webkit
script. Enabled by default for all the ports.
* Scripts/webkitperl/FeatureList.pm:
2012-05-10 Raphael Kubo da Costa <rakuco@webkit.org>
[EFL][webkitpy] Do not redefine check_build() in EflPort.
https://bugs.webkit.org/show_bug.cgi?id=86124
Reviewed by Dirk Pranke.
Remove an old FIXME and do not redefine check_build in EflPort;
once build-dumprendertree recognizes --efl, we can use the
check_build implementation in WebKitPort.
* Scripts/build-dumprendertree:
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.check_build):
2012-05-10 Tommy Widenflycht <tommyw@google.com>
[chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=86087
Reviewed by Adam Barth.
* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(MockExtraData):
(WebKit):
(WebKit::WebUserMediaClientMock::requestUserMedia):
2012-05-10 Varun Jain <varunjain@google.com>
[chromium] Trigger context menu for long press gesture
https://bugs.webkit.org/show_bug.cgi?id=85919
Reviewed by Adam Barth.
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::gestureLongPress):
(EventSender::gestureEvent):
* DumpRenderTree/chromium/EventSender.h:
(EventSender):
2012-05-10 Takashi Toyoshima <toyoshim@chromium.org>
don't use autoinstall to import pywebsocket but check it in WebKit directly.
https://bugs.webkit.org/show_bug.cgi?id=86107
Reviewed by Adam Barth.
This change removes pywebsocket from webkitpy's autoinstall list and
imports pywebsocket 0.7.4 directly into webkitpy/thirparty.
* Scripts/webkitpy/layout_tests/servers/websocket_server.py:
(PyWebSocket._prepare_config):
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_irc):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.__init__):
(ThirdpartyTest.test_import_hook.MockImportHook._install_eliza):
(ThirdpartyTest):
(ThirdpartyTest.test_import_hook):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Added.
* Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Added.
* Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Added.
(ConnectionTerminatedException):
(InvalidFrameException):
(BadOperationException):
(UnsupportedFrameException):
(InvalidUTF8Exception):
(StreamBase):
(StreamBase.__init__):
(StreamBase._read):
(StreamBase._write):
(StreamBase.receive_bytes):
(StreamBase._read_until):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Added.
(for):
(StreamHixie75):
(StreamHixie75.for):
(StreamHixie75.__init__):
(StreamHixie75.send_message):
(StreamHixie75._read_payload_length_hixie75):
(StreamHixie75.receive_message):
(StreamHixie75._send_closing_handshake):
(StreamHixie75.close_connection):
(StreamHixie75.send_ping):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Added.
(Frame):
(Frame.__init__):
(create_length_header):
(create_header):
(_build_frame):
(_filter_and_format_frame_object):
(create_binary_frame):
(create_text_frame):
(FragmentedFrameBuilder):
(FragmentedFrameBuilder.to):
(FragmentedFrameBuilder.__init__):
(FragmentedFrameBuilder.build):
(_create_control_frame):
(create_ping_frame):
(create_pong_frame):
(create_close_frame):
(StreamOptions):
(StreamOptions.__init__):
(Stream):
(Stream.for):
(Stream.__init__):
(Stream._receive_frame):
(Stream._receive_frame_as_frame_object):
(Stream.send_message):
(Stream.receive_message):
(Stream._send_closing_handshake):
(Stream.close_connection):
(Stream.send_ping):
(Stream._send_pong):
(Stream._drain_received_data):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Added.
(is_control_opcode):
(ExtensionParameter):
(ExtensionParameter.__init__):
(ExtensionParameter.name):
(ExtensionParameter.add_parameter):
(ExtensionParameter.get_parameters):
(ExtensionParameter.get_parameter_names):
(ExtensionParameter.has_parameter):
(ExtensionParameter.get_parameter_value):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Added.
(DispatchException):
(DispatchException.__init__):
(_default_passive_closing_handshake_handler):
(_normalize_path):
(_create_path_to_resource_converter):
(_create_path_to_resource_converter.converter):
(_enumerate_handler_file_paths):
(_HandlerSuite):
(_HandlerSuite.__init__):
(_source_handler_file):
(_extract_handler):
(Dispatcher):
(Dispatcher.maintains):
(Dispatcher.__init__):
(Dispatcher.add_resource_path_alias):
(Dispatcher.source_warnings):
(Dispatcher.do_extra_handshake):
(Dispatcher.transfer_data):
(Dispatcher.passive_closing_handshake):
(Dispatcher.get_handler_suite):
(Dispatcher._source_handler_files_in_dir):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Added.
(ExtensionProcessorInterface):
(ExtensionProcessorInterface.get_extension_response):
(ExtensionProcessorInterface.setup_stream_options):
(DeflateStreamExtensionProcessor):
(DeflateStreamExtensionProcessor.__init__):
(DeflateStreamExtensionProcessor.get_extension_response):
(DeflateStreamExtensionProcessor.setup_stream_options):
(DeflateFrameExtensionProcessor):
(DeflateFrameExtensionProcessor.__init__):
(DeflateFrameExtensionProcessor.get_extension_response):
(DeflateFrameExtensionProcessor.setup_stream_options):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.__init__):
(DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.filter):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.__init__):
(DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.filter):
(DeflateFrameExtensionProcessor.set_response_window_bits):
(DeflateFrameExtensionProcessor.set_response_no_context_takeover):
(DeflateFrameExtensionProcessor.enable_outgoing_compression):
(DeflateFrameExtensionProcessor.disable_outgoing_compression):
(DeflateFrameExtensionProcessor._outgoing_filter):
(DeflateFrameExtensionProcessor._incoming_filter):
(get_extension_processor):
(get_extension_processor.is):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Added.
(try):
(do_handshake):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Added.
(AbortedByUserException):
(HandshakeException):
(HandshakeException.__init__):
(VersionException):
(VersionException.__init__):
(get_default_port):
(validate_subprotocol):
(parse_host_header):
(format_header):
(build_location):
(get_mandatory_header):
(validate_mandatory_header):
(check_request_line):
(check_header_lines):
(parse_token_list):
(_parse_extension_param):
(_parse_extension):
(parse_extensions):
(format_extensions):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/draft75.py: Added.
(Handshaker):
(Handshaker.performs):
(Handshaker.__init__):
(Handshaker.do_handshake):
(Handshaker._set_resource):
(Handshaker._set_origin):
(Handshaker._set_location):
(Handshaker._set_subprotocol):
(Handshaker._set_protocol_version):
(Handshaker._sendall):
(Handshaker._send_handshake):
(Handshaker._check_header_lines):
(Handshaker._check_first_lines):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Added.
(compute_accept):
(Handshaker):
(Handshaker.__init__):
(Handshaker._validate_connection_header):
(Handshaker.do_handshake):
(Handshaker._get_origin):
(Handshaker._check_version):
(Handshaker._set_protocol):
(Handshaker._parse_extensions):
(Handshaker._validate_key):
(Handshaker._get_key):
(Handshaker._send_handshake):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Added.
(Handshaker):
(Handshaker.__init__):
(Handshaker.do_handshake):
(Handshaker._set_resource):
(Handshaker._set_subprotocol):
(Handshaker._set_location):
(Handshaker._set_origin):
(Handshaker._set_protocol_version):
(Handshaker._set_challenge_response):
(Handshaker._get_key_value):
(Handshaker._get_challenge):
(Handshaker._send_handshake):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Added.
(ApacheLogHandler):
(ApacheLogHandler.__init__):
(ApacheLogHandler.emit):
(_configure_logging):
(_parse_option):
(_create_dispatcher):
(headerparserhandler):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Added.
(_is_char):
(_is_ctl):
(ParsingState):
(ParsingState.__init__):
(peek):
(consume):
(consume_string):
(consume_lws):
(consume_lwses):
(consume_token):
(consume_token_or_quoted_string):
(quote_if_necessary):
(parse_uri):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Added.
(MemorizingFile):
(MemorizingFile.__init__):
(MemorizingFile.__getattribute__):
(MemorizingFile.readline):
(MemorizingFile.get_memorized_lines):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Added.
(close_connection):
(send_message):
(receive_message):
(send_ping):
(MessageReceiver):
(MessageReceiver.receives):
(MessageReceiver.provides):
(MessageReceiver.should):
(MessageReceiver.__init__):
(MessageReceiver.run):
(MessageReceiver.receive):
(MessageReceiver.receive_nowait):
(MessageReceiver.stop):
(MessageSender):
(MessageSender.sends):
(MessageSender.provides):
(MessageSender.should):
(MessageSender.__init__):
(MessageSender.run):
(MessageSender.send):
(MessageSender.send_nowait):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Added.
(_StandaloneConnection):
(_StandaloneConnection.__init__):
(_StandaloneConnection.get_local_addr):
(_StandaloneConnection.get_remote_addr):
(_StandaloneConnection.write):
(_StandaloneConnection.read):
(_StandaloneConnection.get_memorized_lines):
(_StandaloneRequest):
(_StandaloneRequest.__init__):
(_StandaloneRequest.get_uri):
(_StandaloneRequest.get_method):
(_StandaloneRequest.is_https):
(_StandaloneRequest._drain_received_data):
(_StandaloneSSLConnection):
(_StandaloneSSLConnection.for):
(_StandaloneSSLConnection.__init__):
(_StandaloneSSLConnection.__getattribute__):
(_StandaloneSSLConnection.__setattr__):
(_StandaloneSSLConnection.makefile):
(WebSocketServer):
(WebSocketServer.__init__):
(WebSocketServer._create_sockets):
(WebSocketServer.server_bind):
(WebSocketServer.server_activate):
(WebSocketServer.server_close):
(WebSocketServer.fileno):
(WebSocketServer.handle_error):
(WebSocketServer.get_request):
(WebSocketServer.serve_forever):
(WebSocketServer.shutdown):
(WebSocketRequestHandler):
(WebSocketRequestHandler.setup):
(WebSocketRequestHandler.setup.SocketServer):
(WebSocketRequestHandler.__init__):
(WebSocketRequestHandler.parse_request):
(WebSocketRequestHandler.log_request):
(WebSocketRequestHandler.log_error):
(WebSocketRequestHandler.is_cgi):
(_configure_logging):
(_alias_handlers):
(_build_option_parser):
(ThreadMonitor):
(ThreadMonitor.__init__):
(ThreadMonitor.run):
(_parse_args_and_config):
(_main):
(_main.if):
(_main.if.__check_script):
* Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Copied from Tools/Scripts/webkitpy/thirdparty/__init___unittest.py.
* Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Added.
(get_stack_trace):
(prepend_message_to_exception):
(__translate_interp):
(get_script_interp):
(wrap_popen3_for_win):
(wrap_popen3_for_win.__wrap_popen3):
(hexify):
(get_class_logger):
(NoopMasker):
(NoopMasker.__init__):
(NoopMasker.mask):
(RepeatedXorMasker):
(RepeatedXorMasker.__init__):
(RepeatedXorMasker.mask):
(DeflateRequest):
(DeflateRequest.for):
(DeflateRequest.__init__):
(DeflateRequest.__getattribute__):
(DeflateRequest.__setattr__):
(_Deflater):
(_Deflater.__init__):
(_Deflater.compress_and_flush):
(_Inflater):
(_Inflater.__init__):
(_Inflater.decompress):
(_Inflater.append):
(_Inflater.reset):
(_RFC1979Deflater):
(_RFC1979Deflater.that):
(_RFC1979Deflater.__init__):
(_RFC1979Deflater.filter):
(_RFC1979Inflater):
(_RFC1979Inflater.for):
(_RFC1979Inflater.__init__):
(_RFC1979Inflater.filter):
(DeflateSocket):
(DeflateSocket.for):
(DeflateSocket.__init__):
(DeflateSocket.recv):
(DeflateSocket.sendall):
(DeflateSocket.send):
(DeflateConnection):
(DeflateConnection.for):
(DeflateConnection.__init__):
(DeflateConnection.get_remote_addr):
(DeflateConnection.put_bytes):
(DeflateConnection.read):
(DeflateConnection.write):
(_is_ewouldblock_errno):
(drain_received_data):
2012-05-10 Raphael Kubo da Costa <rakuco@webkit.org>
[EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
https://bugs.webkit.org/show_bug.cgi?id=86117
Reviewed by Adam Barth.
Simplify the code used to wrap driver calls with jhbuild: we can
just define the 'wrapper' option instead of having to create a
Driver class just for that.
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.__init__):
(EflPort._port_flag_for_scripts):
2012-05-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r116633.
http://trac.webkit.org/changeset/116633
https://bugs.webkit.org/show_bug.cgi?id=86093
Breaks EFL tests (Requested by kov on #webkit).
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/EventSender.cpp:
(keyDownCallback):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setTabKeyCyclesThroughElements):
2012-05-10 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[EFL] Memory leaks found in EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=85889
Reviewed by Gustavo Noronha Silva.
Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
created with JSStringCreateWithUTF8CString.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWindowObjectCleared):
* DumpRenderTree/efl/EventSender.cpp:
(modifiersFromJSValue):
2012-05-10 Alexander Shalamov <alexander.shalamov@intel.com>
[EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
https://bugs.webkit.org/show_bug.cgi?id=82864
Reviewed by Gustavo Noronha Silva.
Add missing implementation for setTabKeyCyclesThroughElements to EFL's LayoutTestController
in order to unskip fast/events/keypress-insert-tab.html
* DumpRenderTree/efl/EventSender.cpp:
(keyDownCallback):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setTabKeyCyclesThroughElements):
2012-05-10 Alexander Shalamov <alexander.shalamov@intel.com>
[EFL][DRT] EventSender - set delayed event information if it was not set before
https://bugs.webkit.org/show_bug.cgi?id=85972
Reviewed by Gustavo Noronha Silva.
Reset delayed event information if it is missing.
* DumpRenderTree/efl/EventSender.cpp:
(feedOrQueueMouseEvent):
2012-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
https://bugs.webkit.org/show_bug.cgi?id=85806
The m_pendingAPIRequestURL member is used (presumably) to mask over the async
nature of WebKit2, so that starting a load of a URL will reflect that URL
immedeatly from activeURL, even if the request has not been passed over to
the web process yet and reflected there.
This works well, except in the case of the initial request, where the main
frame creation happens on the web process side and is notified back to the
UI process. Until we've recived the notification we don't know about the main
frame, and this race condition will potentially give us an empty url instead
of the pending request.
To solve this we always return the pending API request if it's set, even
when there's no mainframe yet (that we known about).
Reviewed by Simon Hausmann.
* TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2012-05-10 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[EFL][DRT] Clear added user style sheets before a new testcase execution.
https://bugs.webkit.org/show_bug.cgi?id=84792
Reviewed Gustavo Noronha Silva.
The added user style sheets from the previous testcases are cleared in order to avoid
flaky results.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2012-05-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Move suspendAnimations to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=85986
Reviewed by Ryosuke Niwa.
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2012-05-09 Kent Tamura <tkent@chromium.org>
[Chromium] Attempt to fix an Android build error.
https://bugs.webkit.org/show_bug.cgi?id=86045
* DumpRenderTree/DumpRenderTree.gypi:
2012-05-09 Ojan Vafai <ojan@chromium.org>
Don't show partytime if there are non-layout test failures.
https://bugs.webkit.org/show_bug.cgi?id=86056
Reviewed by Dimitri Glazkov.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2012-05-09 Hayato Ito <hayato@chromium.org>
Improve a warning message for a reftest having an unused expectation file.
https://bugs.webkit.org/show_bug.cgi?id=85975
Reviewed by Adam Barth.
The current warning message is not intuitive. It might be better to update the message
so that it encourage users to remove unused expectation files.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.__init__):
2012-05-09 Ojan Vafai <ojan@chromium.org>
Change "losing test coverage" to cover all non-layout test problems in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=86043
Reviewed by Adam Barth.
-Get rid of the gtest iframe.
-Cover all non-layout test problems. Before we wouldn't catch compile failures
or gtest failures since they were not on the webkit testing bots.
-Include the list of failing steps next to the builder name. This is a lot less
cluttered than you'd expect and already helped me find a compile failure early.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
Delete unused map.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2012-05-09 Jessie Berlin <jberlin@apple.com>
Crash using the new WKBundleDOMWindowExtensions APIs.
https://bugs.webkit.org/show_bug.cgi?id=85888
Reviewed by Brady Eidson.
Cached frames can live slightly longer than the page, but most clients unregister themselves
and do other cleanup in the willDestroyPage callback, making them miss the
willDestroyGlobalObjectForDOMWindowExtension callbacks.
The calls to willDestroyGlobalObjectForDOMWindowExtension in the DOMWindowExtensionBasic
test were all being invoked underneath WebPage::close. This is unrealistic. Update that test
to destroy the BundleDOMWindowExtensions in response to the willDestroyPage callback.
Add a test to verify that willDestroyGlobalObjectForDOMWindowExtension is being called for
pages that don't go into the page cache.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add DOMWindowExtensionNoCache.cpp, DOMWindowExtensionNoCache_Bundle.cpp, simple-unload.html
and simple-iframe-unload.html
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
(TestWebKitAPI):
Remove the expected messages for willDestroyGlobalObjectForDOMWindowExtension.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Do not bother to keep track of the live extension count - all of them are expected to be
live until the test completes.
(TestWebKitAPI::TEST):
Fix the calls to EXPECT to pass the expected value first, and use EXPECT_WK_STREQ so that
message failures will be clearer.
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
Clean up the BundleDOMWindowExtensions.
(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
Add an ASSERT_NOT_REACHED.
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Keep track of the messages received so they can be checked at the end of the test.
(TestWebKitAPI::TEST):
Navigate to uncacheable pages and back.
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp.
(DOMWindowExtensionNoCache):
(TestWebKitAPI::DOMWindowExtensionNoCache::DOMWindowExtensionNoCache):
Set up all the states for each BundleDOMWindowExtension.
(TestWebKitAPI::DOMWindowExtensionNoCache::frameLoadFinished):
Tell the UI Process about the states of the BundleDOMWindowExtensions.
(TestWebKitAPI::DOMWindowExtensionNoCache::sendExtensionStateMessage):
(TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
(TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
Remvoe the remaining BundleDOMWindowExtensions, send the updated state, and finish the test.
(TestWebKitAPI::DOMWindowExtensionNoCache::updateExtensionStateRecord):
(TestWebKitAPI::DOMWindowExtensionNoCache::sendBundleMessage):
(TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
(TestWebKitAPI::DOMWindowExtensionNoCache::willDisconnectDOMWindowExtensionFromGlobalObject):
ASSERT that these pages not going into the page cache are not getting disconnected to go into
the page cache.
(TestWebKitAPI::DOMWindowExtensionNoCache::didReconnectDOMWindowExtensionToGlobalObject):
Ditto about getting reconnected when coming out of the page cache.
(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyGlobalObjectForDOMWindowExtension):
Tell the UI Process, update the state, and get rid of the BundleDOMWindowExtension.
(TestWebKitAPI::didFinishLoadForFrameCallback):
(TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
(TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
(TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
(TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
* TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Added.
* TestWebKitAPI/Tests/WebKit2/simple-unload.html: Added.
2012-05-09 Adam Barth <abarth@webkit.org>
[Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
https://bugs.webkit.org/show_bug.cgi?id=86045
Reviewed by Eric Seidel.
* DumpRenderTree/DumpRenderTree.gypi:
2012-05-09 Adam Barth <abarth@webkit.org>
[Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
https://bugs.webkit.org/show_bug.cgi?id=86041
Reviewed by Eric Seidel.
* DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2012-05-09 Adam Barth <abarth@webkit.org>
[Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
https://bugs.webkit.org/show_bug.cgi?id=86040
Reviewed by Kent Tamura.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dumpImage):
2012-05-09 Raphael Kubo da Costa <rakuco@webkit.org>
[EFL] Build fix after r116464.
`ulong' is a type defined by glibc, so it is not very
portable. Use `unsigned long' instead.
* DumpRenderTree/efl/EventSender.cpp:
(DelayedEvent::DelayedEvent):
(DelayedEvent):
(leapForwardCallback):
2012-05-09 Adam Barth <abarth@webkit.org>
[Chromium] LayoutTestController should use ENABLE guards for some features
https://bugs.webkit.org/show_bug.cgi?id=86030
Reviewed by Eric Seidel.
These features are disabled on OS(ANDROID) and so shouldn't be compiled
when the feature is off.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
2012-05-09 Tom Zakrajsek <tomz@codeaurora.org>
Fix overzealous re-opened since blocked by... message
https://bugs.webkit.org/show_bug.cgi?id=86020
Reviewed by Adam Barth.
Changed CreateBug behavior to only re-open a blocked bug if it
was RESOLVED. Also had to update the test infrastructure slightly
to allow for distinct mock commit revisions, so one could point
to a RESOLVED bug for testing while another pointed to an OPEN bug.
Also moved default created mock bug to be 60001 instead of 50004
which already exists as a reference mock bug.
* Scripts/webkitpy/common/checkout/checkout_mock.py:
(MockCheckout.__init__):
(MockCheckout.commit_info_for_revision):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzilla.create_bug):
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
(test_create_rollout_resolved):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(FailureReasonTest.test_blame_line_for_revision):
* Scripts/webkitpy/tool/steps/createbug.py:
(CreateBug.run):
2012-05-09 Hugo Parente Lima <hugo.lima@openbossa.org>
Use suitable viewport values on XHTML-MP pages.
https://bugs.webkit.org/show_bug.cgi?id=85425
Reviewed by Kenneth Rohde Christiansen.
Enable LEGACY_VIEWPORT_ADAPTION on Qt port.
* qmake/mkspecs/features/features.prf:
2012-05-09 Jochen Eisinger <jochen@chromium.org>
When creating a new page during a navigation, prime the initial document with the correct referrer policy
https://bugs.webkit.org/show_bug.cgi?id=86001
Reviewed by Adam Barth.
Store the referrer policy in the request, so the network stack can comply with it.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willSendRequest):
2012-05-09 Vivek Galatage <vivekgalatage@gmail.com>
Remove CYGWIN=tty from environment variable as its no longer supported
https://bugs.webkit.org/show_bug.cgi?id=85791
The CYGWIN=tty environment variable is no longer supported from Cygwin
version 1.7.10. This fix avoids addition of this environment variable
for Cygwin versions greater than 1.7.9. For supporting older versions
i.e. 1.7.9 or older, the script takes care of retaining the environment
variable.
Reviewed by Adam Roben.
* Scripts/webkitdirs.pm:
(setupAppleWinEnv):
2012-05-09 Dirk Pranke <dpranke@chromium.org>
nrwt: --skip-failing-tests should also skip flaky tests
https://bugs.webkit.org/show_bug.cgi?id=85941
Reviewed by Ojan Vafai.
This changes --skip-failing-tests so that we skip tests that
are believed to pass sometimes as well as tests that are
believed to always fail.
In addition, in testing this I discovered that we had lousy
test coverage of the details of retrying test failures and
--clobber-old-results, so I wrote some more tests.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.prepare_lists_and_print_output):
* Scripts/webkitpy/layout_tests/port/test.py:
(unit_test_list):
(TestPort.__init__):
(TestDriver.run_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_skip_failing_tests):
(MainTest.test_retrying_and_flaky_tests):
2012-05-09 Christophe Dumez <christophe.dumez@intel.com>
[EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()
https://bugs.webkit.org/show_bug.cgi?id=84435
Reviewed by Antonio Gomes.
Catch the "icon,changed" signal on the frames in EFL's DumpRenderTree
to support LayoutTestController's dumpIconChanges().
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameIconChanged):
(DumpRenderTreeChrome::onFrameCreated):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
2012-05-09 Dominik Röttsches <dominik.rottsches@intel.com>
webkit-patch upload Fails Behind Load-balancing Proxies
https://bugs.webkit.org/show_bug.cgi?id=85980
Reviewed by Adam Barth.
Unchecking the login restriction to IP to allow the tool
to function behind load-balancing proxies that use multiple
outgoing IPs.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.authenticate):
2012-05-09 Hao Zheng <zhenghao@chromium.org>
[Chromium-android] Add unit test for Android layout test script (chromium_android.py)
https://bugs.webkit.org/show_bug.cgi?id=80852
Reviewed by Adam Barth.
Add some tests to ensure that chromium android port works to some
extent. Some methods is hard to test, as they rely on the actual
behavior on device, e.g. pushing files to device.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.get_last_stacktrace): Check if dir exists.
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest):
(ChromiumAndroidPortTest.test_attributes):
(ChromiumAndroidPortTest.test_get_last_stacktrace):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_dir):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_file):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_non_empty):
(ChromiumAndroidDriverTest):
(ChromiumAndroidDriverTest.setUp):
(ChromiumAndroidDriverTest.test_get_drt_return_value):
(ChromiumAndroidDriverTest.test_has_crash_hint):
(ChromiumAndroidDriverTest.test_read_prompt):
(ChromiumAndroidDriverTest.test_test_shell_command):
(ChromiumAndroidDriverTest.test_write_command_and_read_line):
2012-05-09 Allan Sandfeld Jensen <allan.jensen@nokia.com>
[Qt] ORWT fails with Qt 5 and WK2.
https://bugs.webkit.org/show_bug.cgi?id=85968
Reviewed by Csaba Osztrogonác.
The Qt5 binary does not have a -style argument, so avoid using it.
* Scripts/old-run-webkit-tests:
2012-05-09 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[EFL][DRT] LayoutTestController addUserScript implementation
https://bugs.webkit.org/show_bug.cgi?id=84718
Reviewed by Antonio Gomes.
Added implementation of addUserScript() to LayoutTestController.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): clear added user scripts
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addUserScript): added implementation
2012-05-09 Dan Bernstein <mitz@apple.com>
Made build-webkit copy WebKitLibraries to the right location again after r116257
Reviewed by Mark Rowe.
* Scripts/build-webkit: Pass the built product directory to copy-webkitlibraries-to-product-directory.
* Scripts/copy-webkitlibraries-to-product-directory: Use the first argument, if present, as the
product directory.
2012-05-08 Ojan Vafai <ojan@chromium.org>
Show the chromium non-layout test bots in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=85903
Reviewed by Eric Seidel.
This is just a single-line high-level overview of the chromium non-layout test bots.
This means that Chromium WebKit gardeners only need to keep garden-o-matic open in
order to do their job.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#chromium-gtests iframe):
(#chromium-gtests):
(#gtest-label):
2012-05-08 Kangil Han <kangil.han@samsung.com>
[EFL][DRT] Implement TextInputController.
https://bugs.webkit.org/show_bug.cgi?id=78559
Reviewed by Martin Robinson.
TextInputController has been created for an input emulation purpose in DRT.
However, not like other ports, EFL doesn't have it.
Therefore, this patch will enable EFL port to have an input emulation in DRT.
* DumpRenderTree/efl/CMakeLists.txt:
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWindowObjectCleared):
* DumpRenderTree/efl/TextInputController.cpp: Added.
(setMarkedTextCallback):
(hasMarkedTextCallback):
(markedRangeCallback):
(insertTextCallback):
(unmarkTextCallback):
(firstRectForCharacterRangeCallback):
(selectedRangeCallback):
(makeTextInputController):
* DumpRenderTree/efl/TextInputController.h: Added.
2012-04-23 Raphael Kubo da Costa <rakuco@webkit.org>
[EFL] Pass a WTF::String directly from DRT to ewebkit when possible
https://bugs.webkit.org/show_bug.cgi?id=84634
Reviewed by Gustavo Noronha Silva.
Drop unnecessary const char* -> WTF::String conversions by
creating String objects directly in LayoutTestController out of
JSStringRef's and passing them to DumpRenderTreeSupportEfl.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::queueLoad):
(LayoutTestController::setValueForUser):
(LayoutTestController::findString):
(LayoutTestController::addUserStyleSheet):
2012-05-08 Alexander Shalamov <alexander.shalamov@intel.com>
[EFL][DRT] EventSender needs implementation of leapForward function
https://bugs.webkit.org/show_bug.cgi?id=83486
Reviewed by Eric Seidel.
Implemented leapForward function in Efl's DRT. This function is required
to delay and queue event execution and simulate real user behavior.
* DumpRenderTree/efl/EventSender.cpp:
(DelayedEvent):
(MouseEventInfo::MouseEventInfo):
(MouseEventInfo):
(sendClick):
(mouseDownCallback):
(mouseUpCallback):
(mouseMoveToCallback):
(leapForwardCallback):
(mouseScrollByCallback):
(feedOrQueueMouseEvent):
(feedMouseEvent):
(feedQueuedMouseEvents):
2012-05-08 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[GTK] Memory leak in DRT EventSender.cpp
https://bugs.webkit.org/show_bug.cgi?id=85886
Reviewed by Martin Robinson.
Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
JSString created with JSStringCreateWithUTF8CString.
* DumpRenderTree/gtk/EventSender.cpp:
(gdkModifersFromJSValue):
2012-05-08 Christophe Dumez <christophe.dumez@intel.com>
[EFL] glib dependency needs to be updated in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=85878
Reviewed by Martin Robinson.
Bump glib version from 2.31.8 to 2.32.2 in jhbuild.modules. This
addresses flakiness in media tests due to possible deadlock with the
following output on stderr:
GStreamer-WARNING **: wrong STREAM_LOCK count 0
The bug was fixed upstream by:
http://git.gnome.org/browse/glib/commit/?id=265f265c677bc5399dbb1cfa449cb4b915a6459f
* efl/jhbuild.modules:
2012-05-07 Alexis Menard <alexis.menard@openbossa.org>
[Qt] Unbreak debugging of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85839
Reviewed by Simon Hausmann.
When you attach GDB to a running process, it stops it.
http://trac.webkit.org/changeset/115958 introduced a pause()
call to wait the debugger to be attached to then continue
the execution of the WebProcess. Unfortunately the pause()
function does not return unless a signal handler is called.
This patch introduce an event handler to exit from the paused
state when the debugger send the signal SIGCONT. The old code
works with older version of GDB (<7.0) but not with newer
versions where the behavior of pause() is correct.
* WebKitTestRunner/qt/main.cpp:
(sigcontHandler):
(main):
2012-05-08 Christophe Dumez <christophe.dumez@intel.com>
[EFL][DRT] EFL's DRT does not fully support page visibility
https://bugs.webkit.org/show_bug.cgi?id=85032
Reviewed by Antonio Gomes.
* DumpRenderTree/LayoutTestController.cpp:
(resetPageVisibilityCallback): Fix incorrect argumentCount check.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Properly
reset page visibility setting between tests.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setPageVisibility): Add support for "preview"
visibility state.
2012-05-08 Gavin Peters <gavinp@chromium.org>
[webkit-patch] Return meaningful results from single-result queries.
https://bugs.webkit.org/show_bug.cgi?id=85367
Reviewed by Dirk Pranke.
Sometimes a quicksearch returns a single result by just redirecting to the page for that single
bug. This patch hacks around that by noticing the redirect target is a single page, and constructing
a result list consisting of that one bug.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries._fetch_bugs_from_advanced_query):
2012-05-08 Gavin Peters <gavinp@chromium.org>
[webkit-patch] Add new chrome-channels command to track down current chrome release channels for a committed bug.
https://bugs.webkit.org/show_bug.cgi?id=85368
Reviewed by Eric Seidel.
* Scripts/webkitpy/common/config/urls.py:
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_bugs_matching_quicksearch):
* Scripts/webkitpy/common/net/omahaproxy.py: Added.
(OmahaProxy):
(OmahaProxy.__init__):
(OmahaProxy.set_url):
(OmahaProxy._json_url):
(OmahaProxy._get_json):
(OmahaProxy.get_revisions):
* Scripts/webkitpy/common/net/omahaproxy_unittest.py: Added.
(MockOmahaProxy):
(MockOmahaProxy.__init__):
(OmahaProxyTest):
(OmahaProxyTest.test_get_revisions):
* Scripts/webkitpy/tool/commands/__init__.py:
* Scripts/webkitpy/tool/commands/bugsearch.py:
(BugSearch):
* Scripts/webkitpy/tool/commands/chromechannels.py: Added.
(ChromeChannels):
(__init__):
(execute):
* Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Added.
(MockOmahaProxy):
(MockOmahaProxy.get_revisions):
(TestableChromeChannels):
(TestableChromeChannels.__init__):
(ChromeChannelsTest):
(ChromeChannelsTest.test_single_bug):
(ChromeChannelsTest.test_with_query):
2012-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix GTK+ unit tests.
* gtk/common.py:
(pkg_config_file_variable):
2012-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Google tests that time out are leaked
https://bugs.webkit.org/show_bug.cgi?id=84973
Reviewed by Philippe Normand.
Move Tools/Scripts/run-gtk-tests to Tools/gtk/run-api-tests
leaving run-gtk-tests as simple wrapper that runs run-api-tests in
a jhbuild environment when jhbuild is available.
* Scripts/run-gtk-tests: Run Tools/gtk/run-api-tests directly or
with jhbuild if present.
* gtk/common.py:
(pkg_config_file_variable): Generic function to get a variable
from a pkg-config file.
(prefix_of_pkg_config_file): Use pkg_config_file_variable with 'prefix'.
* gtk/run-api-tests: Copied from Tools/Scripts/run-gtk-tests.
(TestRunner.__init__): Use common.build_path() to get the programs path.
(TestRunner._lookup_atspi2_binary): Use
common.pkg_config_file_variable() to get the 'exec_prefix'.
(TestRunner._start_accessibility_daemons): Use subprocess.Popen()
directly instead of helper _create_process that has been removed.
(TestRunner._setup_testing_environment): Use subprocess.Popen()
directly instead of helper _create_process that has been
removed. Use common.top_level_path() and common.build_path()
instead of custom methods that have been removed too.
(TestRunner._run_test_command): Use subprocess.Popen() directly
instead of helper _create_process that has been removed.
2012-05-08 Thiago Marcos P. Santos <thiago.santos@intel.com>
[EFL] [DRT] Clear extra views before setting a blank page
https://bugs.webkit.org/show_bug.cgi?id=85608
Reviewed by Kenneth Rohde Christiansen.
We need to clear the extra views before setting a blank page,
otherwise it will cause more events interactions and sometimes
trigger a unload(). This was causing frame-crash-with-page-cache.html
to leak events to the next test causing any subsequent test to
fail.
* DumpRenderTree/efl/DumpRenderTree.cpp:
(runTest):
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::clearExtraViews):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
2012-05-08 Balazs Kelemen <kbalazs@webkit.org>
[Qt] X11 plugins need to be reworked for Qt5+WK1
https://bugs.webkit.org/show_bug.cgi?id=80691
Reviewed by Simon Hausmann.
Implement basic windowless plugin support with Qt5.
* qmake/mkspecs/features/features.prf:
Enable NPAPI plugins if X11 libraries are available.
* qmake/mkspecs/features/functions.prf:
Added a convenience function to determine availability
of X11 libraries.
2012-05-07 Raphael Kubo da Costa <rakuco@webkit.org>
[webkitpy] Remove Python 2.5-specific workaround from http_server_base.py.
https://bugs.webkit.org/show_bug.cgi?id=85852
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase._is_server_running_on_all_ports): Revert the part
of r89412 which was a workaround for an issue with Python 2.5 on
Mac 10.5.
2012-05-07 Raphael Kubo da Costa <rakuco@FreeBSD.org>
webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
https://bugs.webkit.org/show_bug.cgi?id=81481
Reviewed by Dirk Pranke.
FreeBSD has the same sysctl interface present in Darwin to query
the number of CPUs available, so use that too.
* Scripts/webkitdirs.pm:
(determineNumberOfCPUs): Share the sysctl call with Darwin.
(isFreeBSD): Added.
2012-05-07 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed Qt build fix in Debug.
We need some system includes here for getpid() to be recognized.
* WebKitTestRunner/qt/main.cpp:
2012-05-07 Ojan Vafai <ojan@chromium.org>
When embedding the flakiness dashboard, hide popups when the frame is blurred.
https://bugs.webkit.org/show_bug.cgi?id=85684
Reviewed by Dirk Pranke.
If you show a popup, then click elsewhere in garden-o-matic, it will now
properly hide it.
* TestResultServer/static-dashboards/dashboard_base.js:
(showPopup):
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(showPopupForBuild):
(generatePageForIndividualTests.if):
(generatePageForIndividualTests):
* TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js: Added.
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
* TestResultServer/static-dashboards/run-embedded-unittests.html: Added.
2012-05-07 Ian Vollick <vollick@chromium.org>
[chromium] WebViewHost should setCompositorSurfaceReady
https://bugs.webkit.org/show_bug.cgi?id=85418
Reviewed by James Robinson.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setWebWidget):
2012-05-07 Jon Lee <jonlee@apple.com>
WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
https://bugs.webkit.org/show_bug.cgi?id=42331
<rdar://problem/8193641>
Reviewed by Darin Adler.
This patch sets up the framework for supporting dumpFrameLoadCallbacks, as well as
outputting some of the required strings. As tests become unskipped the other callbacks
can be supported.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Add dumpFrameLoadCallbacks()
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage): pass in the dictionary containing keys needed to initialize
dump callbacks for the layoutTestController.
(WTR::InjectedBundle::booleanForKey): Helper function to extract boolean value from key in WKDictionaryRef.
Output some warning if we are trying to extract a value that is not a boolean.
(WTR::InjectedBundle::beginTesting): Update to take in the dictionary passed in by the TestController.
We cannot set the bits on the layoutTestController until it has been created in beginTesting().
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR):
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR):
(WTR::dumpFrameDescriptionSuitableForTestResult): Static function similar to
-[WebFrame _drt_descriptionSuitableForTestResult] in DumpRenderTree.
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Output string.
(WTR::InjectedBundlePage::didCommitLoadForFrame): Output string.
(WTR::InjectedBundlePage::didFinishLoadForFrame): Output string.
(WTR::InjectedBundlePage::didReceiveTitleForFrame): Output string.
(WTR::InjectedBundlePage::didCancelClientRedirectForFrame): Output string.
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Output string. In WK1 it's
"willPerformClientRedirectToURL" so we will have to use that value here.
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): Output string.
(WTR::InjectedBundlePage::didHandleOnloadEventsForFrame): Output string.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController): Initialize to not dump frame load callbacks.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpFrameLoadCallbacks): Change to use setShouldDumpFrameLoadCallbacks.
(WTR::LayoutTestController::setShouldDumpFrameLoadCallbacks): Set bit.
(WTR::LayoutTestController::shouldDumpFrameLoadCallbacks): Return bit.
(LayoutTestController): Added m_dumpFrameLoadCallbacks to track whether to dump the output.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::shouldLogFrameLoadDelegates): Similar to DRT.
(WTR::TestInvocation::invoke): Based on the URL loaded, set the bit in the dictionary that gets passed
to the injected bundle.
2012-05-07 Tommy Widenflycht <tommyw@google.com>
[chromium] MediaStream API: Enhance WebUserMediaClientMock and add a test for it
https://bugs.webkit.org/show_bug.cgi?id=85618
Reviewed by Adam Barth.
Adding the capability to control which MediaStreamTracks actually get created,
and adding a test that exercises the JS api using that capability.
* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(WebKit::WebUserMediaClientMock::requestUserMedia):
* DumpRenderTree/chromium/WebUserMediaClientMock.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::testMediaStreamClient):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
2012-05-07 Zan Dobersek <zandobersek@gmail.com>
[Gtk] WebGL feature is not built anymore through build-webkit after r116251
https://bugs.webkit.org/show_bug.cgi?id=85788
Reviewed by Martin Robinson.
Enable WebGL by default for the Gtk port. The feature is already enabled by
default in configure.ac, so there's no reason it shouldn't be enabled when
building through build-webkit.
* Scripts/webkitperl/FeatureList.pm:
2012-05-07 Csaba Osztrogonác <ossy@webkit.org>
Unittest fix after r116288, because now there are more than 5 hit for the 'Eric' word.
We have only 2 'Gavin', so it is a better choice than 'Eric' for unit testing.
Reviewed by Tor Arne Vestbø.
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):
2012-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r116299, r116301, and r116303.
http://trac.webkit.org/changeset/116299
http://trac.webkit.org/changeset/116301
http://trac.webkit.org/changeset/116303
https://bugs.webkit.org/show_bug.cgi?id=85795
Build is still broken (Requested by Ossy on #webkit).
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/main.cpp:
(main):
* QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Removed.
* QtTestPlatformPlugin/TestIntegration.cpp: Removed.
* QtTestPlatformPlugin/TestIntegration.h: Removed.
* QtTestPlatformPlugin/mac/TestFontDatabase.h: Removed.
* QtTestPlatformPlugin/mac/TestFontDatabase.mm: Removed.
* QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Removed.
* QtTestPlatformPlugin/main.cpp: Removed.
* QtTestPlatformPlugin/testplatform.json: Removed.
* Tools.pro:
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):
2012-05-07 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed Qt build fix.
One more try to learn how to use
const with a pointer array.
* DumpRenderTree/qt/main.cpp:
(initializeTestPlatformPlugin):
2012-05-07 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed build fix after r116299.
* DumpRenderTree/qt/main.cpp:
(initializeTestPlatformPlugin):
2012-05-07 Balazs Kelemen <kbalazs@webkit.org>
[Qt] Add test specific platform plugin to achieve unified layout test results
https://bugs.webkit.org/show_bug.cgi?id=80996
Reviewed by Simon Hausmann.
Added QtTestPlatformPlugin as a new project under Tools.
This is a Qt5-ish platform plugin that can be used to tweak the
platform support interfaces in order to unify layout test results.
For now it only overrides the font database on Mac and redirects
everything else to the real platform plugin. The font database it
provides mimics the way how we set up test fonts with fontconfig on Linux.
Make DumpRenderTree and WebKitTestRunner use this platform plugin.
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/main.cpp:
(initializeTestPlatformPlugin):
(main):
* QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Added.
* QtTestPlatformPlugin/TestIntegration.cpp: Added.
(TestIntegration::TestIntegration):
(TestIntegration::fontDatabase):
* QtTestPlatformPlugin/TestIntegration.h: Added.
(TestIntegration):
(TestIntegration::hasCapability):
(TestIntegration::createPlatformPixmap):
(TestIntegration::createPlatformWindow):
(TestIntegration::createPlatformBackingStore):
(TestIntegration::createPlatformOpenGLContext):
(TestIntegration::createPlatformSharedGraphicsCache):
(TestIntegration::guiThreadEventDispatcher):
(TestIntegration::clipboard):
(TestIntegration::drag):
(TestIntegration::inputContext):
(TestIntegration::accessibility):
(TestIntegration::nativeInterface):
(TestIntegration::services):
(TestIntegration::styleHint):
(TestIntegration::platformTheme):
* QtTestPlatformPlugin/mac/TestFontDatabase.h: Added.
(TestFontDatabase):
* QtTestPlatformPlugin/mac/TestFontDatabase.mm: Added.
(TestFontDatabase::populateFontDatabase):
* QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Added.
(TestIntegration::fontDatabase):
* QtTestPlatformPlugin/main.cpp: Added.
(TestIntegrationPlugin::keys):
(TestIntegrationPlugin::create):
(TestIntegrationPlugin::initialize):
* QtTestPlatformPlugin/testplatform.json: Added.
* Tools.pro:
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):
2012-05-07 Christophe Dumez <christophe.dumez@intel.com>
[EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=85609
Reviewed by Simon Hausmann.
Flakiness was caused by the fact that
media/crash-closing-page-with-media-as-plugin-fallback.html and
media/video-poster-blocked-by-willsendrequest.html use the same PNG
file as poster attribute in the video tag. The PNG file gets cached
when the first test is executed and this somehow causes the second
test to fail.
The flakiness was addressed by clearing the memory and page caches
between tests.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2012-05-07 Eric Seidel <eric@webkit.org>
Add values for all features to Qt's features.pri
https://bugs.webkit.org/show_bug.cgi?id=85746
Reviewed by Tor Arne Vestbø.
When generate-feature-files generates features.pri it provides a value
for every possible ENABLE_. In prepration for landing generate-feature-files
it seems appropriate to add a value for all possible ENABLEs to the existing
features.pri. This lets me make sure that I'm getting them all right!
* qmake/mkspecs/features/features.pri:
2012-05-07 Adam Bergkvist <adam.bergkvist@ericsson.com>
Added myself as a committer.
Not reviewed.
* Scripts/webkitpy/common/config/committers.py:
2012-05-07 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[EFL][DRT] Implement LayoutTestController::execCommand
https://bugs.webkit.org/show_bug.cgi?id=82286
Reviewed by Antonio Gomes.
Add missing implementation execCommand and isCommandEnabled to EFL's
LayoutTestController.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::execCommand):
(LayoutTestController::isCommandEnabled):
2012-05-06 Hayato Ito <hayato@chromium.org>
[prepare-ChangeLog] Excludes a reference file used by reftests from test files.
https://bugs.webkit.org/show_bug.cgi?id=74268
Reviewed by Ryosuke Niwa.
* Scripts/prepare-ChangeLog:
(generateFileList):
2012-05-06 Mary Wu <mary.wu@torchmobile.com.cn>
Add a contributor to committers.py
https://bugs.webkit.org/show_bug.cgi?id=85761
Reviewed by Unreviewed.
Add myself to committers.py contributor.
* Scripts/webkitpy/common/config/committers.py:
2012-05-06 Dan Bernstein <mitz@apple.com>
Tools part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
https://bugs.webkit.org/show_bug.cgi?id=85739
Reviewed by Daniel Bates.
* Scripts/build-webkit: Moved code that copies from WebKitLibraries to the product directory
from here...
* Scripts/copy-webkitlibraries-to-product-directory: ...to this new script.
2012-05-06 Andy Estes <aestes@apple.com>
Fix the build after r116246.
* DumpRenderTree/LayoutTestController.cpp: Remove an unused function.
2012-05-06 Eric Seidel <eric@webkit.org>
Update several build-webkit options to match the #defines they toggle
https://bugs.webkit.org/show_bug.cgi?id=85744
Reviewed by Adam Barth.
Most notable here is fixing --3d-canvas to be --webgl these days --
the define was renamed 15 months ago!
* Scripts/webkitperl/FeatureList.pm:
2012-05-06 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
https://bugs.webkit.org/show_bug.cgi?id=83687
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setJavaScriptCanAccessClipboard):
2012-05-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Convert isPageBoxVisible to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=85692
Reviewed by Darin Adler.
Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2012-05-06 Tom Zakrajsek <tomz@codeaurora.org>
sheriffbot isn't reopening patches after it lands rollouts
https://bugs.webkit.org/show_bug.cgi?id=64418
Reviewed by Adam Barth.
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/steps/createbug.py:
(CreateBug.run):
2012-05-04 Raphael Kubo da Costa <rakuco@webkit.org>
webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=85697
Reviewed by Eric Seidel.
* Scripts/new-run-webkit-tests: Instead of manually detecting whether
the path separator should be ':' or ';' by checking sys.platform, rely
on os.pathsep which has exactly the same information (os.pathsep is
':' for Cygwin, from what I could check in Python's sources).
2012-05-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r116223.
http://trac.webkit.org/changeset/116223
https://bugs.webkit.org/show_bug.cgi?id=85718
The bots need to set XDG_DATA_DIRS (Requested by rakuco on
#webkit).
* efl/jhbuildrc:
* gtk/jhbuildrc:
2012-05-05 Raphael Kubo da Costa <rakuco@webkit.org>
[jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=85717
Reviewed by Martin Robinson.
After r116209, the XDG_DATA_DIRS environment variable is now
passed by webkitpy's layout_tests code to run-with-jhbuild, so
instead of setting a few defaults in jhbuildrc we can now rely on
the values set and really used by each system.
* efl/jhbuildrc:
* gtk/jhbuildrc:
2012-05-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Buildfix for --minimal build after r116107.
Reviewed by Csaba Osztrogonác.
* qmake/mkspecs/features/features.prf:
2012-05-05 Zan Dobersek <zandobersek@gmail.com>
[Gtk] GtkDriver is not required anymore after r116134
https://bugs.webkit.org/show_bug.cgi?id=85699
Reviewed by Csaba Osztrogonác.
Remove GtkDriver as it was replaced by the XvfbDriver and is
no longer needed.
* Scripts/webkitpy/layout_tests/port/gtk.py:
2012-05-05 Zan Dobersek <zandobersek@gmail.com>
Increase the display ID for the Xvfb process to use if pixel_tests argument
is true rather than if pixel_tests option is present. This fixes the
XvfbDriver in the same way r115825 fixed the now-redundant GtkDriver.
Rubber-stamped by Csaba Osztrogonác.
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._start):
2012-05-04 Raphael Kubo da Costa <rakuco@webkit.org>
webkitpy: Preserve XDG_DATA_DIRS in the environment passed to ServerProcess.
https://bugs.webkit.org/show_bug.cgi?id=85694
Reviewed by Martin Robinson.
This is sort of a follow-up to r100674: $XDG_DATA_DIRS should be
preserved, as it is particularly useful for Linux/Unix
environments. As a real use case, if shared-mime-info is
installed into a non-trivial prefix, Glib and other libraries will
have trouble to properly identify mimetypes (in ResourceResponses,
for example) as the base freedesktop.org mimetype file will not be
found.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.setup_environ_for_server):
2012-05-04 Gustavo Noronha Silva <gns@gnome.org>
[GTK] Simplify how libWebCoreModules is linked in, and fix WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=85691
* GNUmakefile.am: no longer link libWebCoreModules to DumpRenderTree.
2012-05-04 Eric Seidel <eric@webkit.org>
Make capitalization and descriptions in FeatureList.pm more consistent to make easier to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=85583
Reviewed by Daniel Bates.
* Scripts/webkitperl/FeatureList.pm:
2012-05-04 Eric Seidel <eric@webkit.org>
Sort entries in FeaturesList.pm to make them easier to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=85584
Reviewed by Daniel Bates.
No functional changes, only sorting.
* Scripts/webkitperl/FeatureList.pm:
2012-05-04 Andy Estes <aestes@apple.com>
REGRESSION (r115752): WebKit2.NewFirstVisuallyNonEmptyLayout API test times out
https://bugs.webkit.org/show_bug.cgi?id=85675
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
(TestWebKitAPI::TEST): Disable the test.
2012-04-30 Jer Noble <jer.noble@apple.com>
Full screen will exit during a provisional load of a non-ancestor iframe.
https://bugs.webkit.org/show_bug.cgi?id=85230
Reviewed by Maciej Stachowiak .
Add support for the new UIDelegate webView:closeFullScreenWithListener: method:
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:closeFullScreenWithListener:]):
Add support for the new closeFullScreen injected bundle method:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::closeFullScreen):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2012-05-04 Ojan Vafai <ojan@chromium.org>
Fix test naming to be camel-case like the methods they are testing.
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
2012-05-04 Ojan Vafai <ojan@chromium.org>
Show the results links in the embedded flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85660
Reviewed by Adam Barth.
Turns out these links don't add much visual noise and it's annoying
to have to go to the dashboard from garden-o-matic just to view the
results for a test.
This is useful for cases where garden-o-matic doesn't properly show the
results (e.g. missing tests). If we address all those cases, then
we could easily hide the results links again if we wanted to.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(showUpdateInfoForTest):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
2012-05-04 Dirk Pranke <dpranke@chromium.org>
Revert to using chromium --test-shell mode on SL in NRWT
https://bugs.webkit.org/show_bug.cgi?id=83076
Unreviewed, build fix.
We seem to be seeing a lot more flakiness on the bot since
I switched NRWT to "DRT" mode. We'll try reverting back and
see if this helps things.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.__init__):
2012-05-04 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=84941
Reviewed by Martin Robinson.
Print MIME type detection messages in EFL's DumpRenderTree if
LayoutTestController's dumpResourceResponseMIMETypes() returns true.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onResponseReceived):
2012-05-04 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
https://bugs.webkit.org/show_bug.cgi?id=85134
Reviewed by Martin Robinson.
Add missing implementation setDefersLoading and goBack to GTK's
LayoutTestController so that the test case rely on these methods
can be enabled.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::goBack):
(LayoutTestController::setDefersLoading):
2012-05-04 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
[Qt][NRWT] Run each DRT in it's own xvfb
https://bugs.webkit.org/show_bug.cgi?id=77335
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._driver_class):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._driver_class):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
(XvfbDriver):
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):
2012-05-04 Zan Dobersek <zandobersek@gmail.com>
Use destructuring assingment for the return values of the
port.diff_image() method call.
Rubber-stamped by Dirk Pranke.
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
2012-05-03 Ojan Vafai <ojan@chromium.org>
Store fewer runs by default in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85568
Reviewed by Dirk Pranke.
This will greatly shrink the size of the json files we load,
resulting in a much faster initial load. People rarely care
about more than 100 runs. For the cases they do, they can still click
the show all runs checkbox to show 500 runs.
* TestResultServer/model/jsonresults.py:
2012-05-04 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Frame load callbacks output is missing for redirections
https://bugs.webkit.org/show_bug.cgi?id=85173
Reviewed by Antonio Gomes.
Catch the new ewk_frame signals to print the expected output in case
of redirections, when LayoutTestController's dumpFrameLoadCallbacks()
returns true.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onWillSendRequest):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameRedirectForProvisionalLoad):
(DumpRenderTreeChrome::onFrameRedirectRequested):
(DumpRenderTreeChrome::onResponseReceived):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
2012-05-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Fix up warning about missing GLib/Gio/GStreamer
We don't actually fall back.
Rubber-stamped by Csaba Osztrogonác.
* qmake/mkspecs/features/features.prf:
2012-05-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Clarify warning about missing GLib/Gio/GStreamer for media support
And only print it once.
Reviewed by Csaba Osztrogonác.
* qmake/mkspecs/features/features.prf:
2012-05-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Clean up and split features.prf into a static list of defaults
The static list of feature defaults is used as a fallback for any
feature that's not dynamically detected or overriden on the command