blob: 9ac4f75b47e8e3b184a56d50891a558962ef8374 [file] [log] [blame]
2013-05-13 Anders Carlsson <andersca@apple.com>
Frame::editor() should return a reference
https://bugs.webkit.org/show_bug.cgi?id=116037
Reviewed by Darin Adler.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::executeCoreCommandByName):
(DumpRenderTreeSupportEfl::isCommandEnabled):
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
(WebCore::EditorClientEfl::handleEditingKeyboardEvent):
* ewk/ewk_frame.cpp:
(ewk_frame_editable_set):
(ewk_frame_selection_get):
(ewk_frame_text_search):
(ewk_frame_text_matches_mark):
(ewk_frame_text_matches_highlight_set):
(ewk_frame_text_matches_highlight_get):
* ewk/ewk_view.cpp:
(ewk_view_selection_get):
(ewk_view_editor_command_execute):
2013-05-12 Timothy Hatcher <timothy@apple.com>
Add support for updating the Web Inspector toolbar height.
https://bugs.webkit.org/show_bug.cgi?id=115996
Reviewed by Joseph Pecoraro and Benjamin Poulain.
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorFrontendClientEfl::setToolbarHeight):
* WebCoreSupport/InspectorClientEfl.h:
2013-05-12 Anders Carlsson <andersca@apple.com>
Stop including UnusedParam.h
https://bugs.webkit.org/show_bug.cgi?id=116003
Reviewed by Sam Weinig.
UnusedParam.h is empty now so there's no need to include it anymore.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* ewk/ewk_js.cpp:
* ewk/ewk_security_origin.cpp:
* ewk/ewk_view.cpp:
* ewk/ewk_web_database.cpp:
2013-05-08 Jose Lejin PJ <jose.lejin@gmail.com>
[EFL] Correct documentation for ewk_settings APIs
https://bugs.webkit.org/show_bug.cgi?id=115507
Reviewed by Gyuyoung Kim.
Corrected documentation for ewk_settings APIs.
* ewk/ewk_settings.h:
2013-05-07 Jinwoo Song <jinwoo7.song@samsung.com>
[EFL] Remove the ewk_settings_shadow_dom_enable_set/get APIs from unit test
https://bugs.webkit.org/show_bug.cgi?id=115771
Reviewed by Gyuyoung Kim.
Unit test is failing since r149702. Remove the test case related to shadow dom.
* tests/test_ewk_setting.cpp:
2013-04-26 Jose Lejin PJ <jose.lejin@gmail.com>
[EFL] Add unit test cases for ewk_settings APIs
https://bugs.webkit.org/show_bug.cgi?id=114897
Reviewed by Gyuyoung Kim.
Added unit tests for ewk_settings APIs.
* tests/test_ewk_setting.cpp:
(TEST_F):
2013-04-25 Joseph Pecoraro <pecoraro@apple.com>
Web Inspector: ConsoleMessage should include line and column number where possible
https://bugs.webkit.org/show_bug.cgi?id=114929
Reviewed by Timothy Hatcher.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::addMessageToConsole):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
2013-04-25 Commit Queue <rniwa@webkit.org>
Unreviewed, rolling out r149032.
http://trac.webkit.org/changeset/149032
https://bugs.webkit.org/show_bug.cgi?id=115151
EFL WK1 API test has been broken after r149032 (Requested by
gyuyoung on #webkit).
* tests/test_ewk_setting.cpp:
(TEST_F):
2013-04-24 Jose Lejin PJ <jose.lejin@gmail.com>
[EFL] Add unit test cases for ewk_settings APIs
https://bugs.webkit.org/show_bug.cgi?id=114897
Reviewed by Gyuyoung Kim.
Added unit tests for ewk_settings APIs.
* tests/test_ewk_setting.cpp:
(TEST_F):
2013-04-19 Jose Lejin PJ <jose.lejin@gmail.com>
[EFL] Add method in ewk_settings for setting the CSS media type
https://bugs.webkit.org/show_bug.cgi?id=113284
Reviewed by Gyuyoung Kim.
Added APIs to set and get CSS media type.
Added unit tests for these APIs.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::overrideMediaType):
* ewk/ewk_settings.cpp:
(ewk_settings_css_media_type_set):
(ewk_settings_css_media_type_get):
* ewk/ewk_settings.h:
* tests/test_ewk_setting.cpp: Added.
(TEST_F):
2013-04-17 Geoffrey Garen <ggaren@apple.com>
Renamed JSGlobalData to VM
https://bugs.webkit.org/show_bug.cgi?id=114777
Reviewed by Phil Pizlo.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::javaScriptObjectsCount):
2013-04-16 Ryosuke Niwa <rniwa@webkit.org>
More EFL build fixes.
* ewk/ewk_frame.cpp:
* ewk/ewk_view.cpp:
2013-04-16 Ryosuke Niwa <rniwa@webkit.org>
EFL build fix after r148545.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
2013-04-16 Manuel Rego Casasnovas <rego@igalia.com>
REGRESSION (r148506): Use of deprecated libsoup API
https://bugs.webkit.org/show_bug.cgi?id=114679
Reviewed by Gyuyoung Kim.
Remove deprecated libsoup API usage.
* ewk/ewk_network.cpp:
(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):
2013-04-16 Manuel Rego Casasnovas <rego@igalia.com>
[GTK][EFL] Remove deprecated libsoup API usage
https://bugs.webkit.org/show_bug.cgi?id=104894
Reviewed by Philippe Normand.
Remove LIBSOUP_USE_UNSTABLE_REQUEST_API and only include
libsoup/soup.h.
2013-04-14 Christophe Dumez <ch.dumez@sisa.samsung.com>
Unreviewed build fix for WebKit1 EFL after r148373 due to missing
header includes.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/EditorClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
* WebCoreSupport/InspectorClientEfl.cpp:
* ewk/ewk_frame.cpp:
* ewk/ewk_view.cpp:
* ewk/ewk_view_private.h:
(WebCore):
2013-04-13 Ed Bartosh <bartosh@gmail.com>
[EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
https://bugs.webkit.org/show_bug.cgi?id=114048
Reviewed by Gyuyoung Kim.
Wrapped view-mode media related code into #if ENABLE(VIEW_MODE_CSS_MEDIA)
* WebCoreSupport/AssertMatchingEnums.cpp:
* ewk/ewk_view.cpp:
(ewk_view_mode_set):
2013-04-10 Benjamin Poulain <bpoulain@apple.com>
Mass remove all the empty directories
Rubberstamped by Ryosuke Niwa.
* DefaultTheme/widget/button: Removed.
* DefaultTheme/widget/check: Removed.
* DefaultTheme/widget/combo: Removed.
* DefaultTheme/widget/entry: Removed.
* DefaultTheme/widget/file: Removed.
* DefaultTheme/widget/mediacontrol/fullscreenbutton: Removed.
* DefaultTheme/widget/mediacontrol/mutebutton: Removed.
* DefaultTheme/widget/mediacontrol/playpausebutton: Removed.
* DefaultTheme/widget/mediacontrol/seekbackwardbutton: Removed.
* DefaultTheme/widget/mediacontrol/seekforwardbutton: Removed.
* DefaultTheme/widget/mediacontrol/togglecaptionsbutton: Removed.
* DefaultTheme/widget/progressbar: Removed.
* DefaultTheme/widget/radio: Removed.
* DefaultTheme/widget/scrollbar: Removed.
* DefaultTheme/widget/search/cancel: Removed.
* DefaultTheme/widget/search/decoration: Removed.
* DefaultTheme/widget/search/field: Removed.
* DefaultTheme/widget/slider: Removed.
* DefaultTheme/widget/spinner: Removed.
2013-04-09 Ed Bartosh <bartosh@gmail.com>
[EFL] --minimal build fails with error: `setSeamlessIFramesEnabled' is not a member of `WebCore::RuntimeEnabledFeatures'
https://bugs.webkit.org/show_bug.cgi?id=113951
Reviewed by Laszlo Gombos.
Wrapped code related to iframe seamless into #if ENABLE(IFRAME_SEAMLESS)
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
2013-04-08 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] rendering was broken when scrolled ewk_view_single
https://bugs.webkit.org/show_bug.cgi?id=114135
Reviewed by Gyuyoung Kim.
ewk_view_single use memcpy() to copy previous buffer for scrolling, but
memcpy() should not be used when source buffer and destination buffer are
overwrapped.
* ewk/ewk_view_single.cpp:
(_ewk_view_screen_move):
2013-04-07 Ed Bartosh <bartosh@gmail.com>
[EFL] --minimal build fails with error: expected `;' before `return'
https://bugs.webkit.org/show_bug.cgi?id=113953
Unreviewed.
* ewk/ewk_security_origin.cpp:
(ewk_security_origin_web_database_quota_get): Added missing semicolon.
2013-04-05 Geoffrey Garen <ggaren@apple.com>
Made USE(JSC) unconditional
https://bugs.webkit.org/show_bug.cgi?id=114058
Reviewed by Anders Carlsson.
* ewk/ewk_frame.cpp:
(ewk_frame_script_execute):
2013-04-04 Christophe Dumez <ch.dumez@sisa.samsung.com>
[Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo
https://bugs.webkit.org/show_bug.cgi?id=113929
Reviewed by Martin Robinson.
Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.
* ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_get):
2013-03-31 Kangil Han <kangil.han@samsung.com>
[EFL] Remove unused stdio.h includes
https://bugs.webkit.org/show_bug.cgi?id=113655
Reviewed by Andreas Kling.
We do not have to include unused header file.
* ewk/ewk_tiled_backing_store.cpp:
* ewk/ewk_tiled_matrix.cpp:
* ewk/ewk_tiled_model.cpp:
(tile_account):
2013-03-27 Timothy Hatcher <timothy@apple.com>
Add support for dock-to-right of the Web Inspector in the Mac port.
Unfortunately this requires Safari changes, so it is disabled in the nightly builds.
https://webkit.org/b/113341
rdar://problem/10368152
Reviewed by Joseph Pecoraro.
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorFrontendClientEfl::attachWindow):
(WebCore::InspectorFrontendClientEfl::setAttachedWindowWidth):
* WebCoreSupport/InspectorClientEfl.h:
(InspectorFrontendClientEfl):
2013-03-26 Hayato Ito <hayato@chromium.org>
Allow ShadowContents in HitTests by default.
https://bugs.webkit.org/show_bug.cgi?id=113171
Reviewed by Dimitri Glazkov.
* ewk/ewk_frame.cpp:
(ewk_frame_hit_test_new):
2013-03-20 Jose Lejin PJ <jose.lejin@gmail.com>
ewk_settings_memory_cache_clear should clear JS garbage and release FastMalloc's free pages to OS
https://bugs.webkit.org/show_bug.cgi?id=112536
Reviewed by Gyuyoung Kim.
Added changes to clear JS garbage and release FastMalloc's free pages to OS
while calling ewk_settings_memory_cache_clear API.
* ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):
2013-03-20 JungJik Lee <jungjik.lee@samsung.com>
[EFL] Disable REQUEST_ANIMATION_FRAME_TIMER to render a new animation frame.
https://bugs.webkit.org/show_bug.cgi?id=112114
Reviewed by Kenneth Rohde Christiansen.
Add dummy functions for WK1.
Example test case: ManualTests/animation/transition-on-and-offscreen-animation.html
* WebCoreSupport/ChromeClientEfl.cpp: Add dummy functions for WK1.
(WebCore):
(WebCore::ChromeClientEfl::scheduleAnimation):
(WebCore::ChromeClientEfl::serviceScriptedAnimations):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
2013-03-15 Nate Chapin <japhet@chromium.org>
Hide MainResourceLoader from the outside world
https://bugs.webkit.org/show_bug.cgi?id=109971
Reviewed by Adam Barth.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
2013-03-15 Abhishek Arya <inferno@chromium.org>
Replace static_casts with to* helper functions.
https://bugs.webkit.org/show_bug.cgi?id=112401
Reviewed by Stephen Chenney.
to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::redirectDataToPlugin):
2013-03-14 Manuel Rego Casasnovas <rego@igalia.com>
Add selectTrailingWhitespaceEnabled setting to WebCore::Page
https://bugs.webkit.org/show_bug.cgi?id=109404
Reviewed by Tony Chang.
Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.
Remove code related to DRT as it is not needed anymore.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::smartInsertDeleteEnabled):
(WebCore::EditorClientEfl::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientEfl::EditorClientEfl):
* WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
2013-03-14 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
[EFL] Use CROSS_PLATFORM_CONTEXT_MENU
https://bugs.webkit.org/show_bug.cgi?id=111877
Reviewed by Caio Marcelo de Oliveira Filho.
Adjust ContextMenuClient to use the CROSS_PLATFORM_CONTEXT_MENUS USE flag
by implementing customizeMenu() instead of getCustomMenuFromDefaultItems()
and by calling coreMenu->items() instead of coreMenu->platformDescription().
* WebCoreSupport/ContextMenuClientEfl.cpp:
(WebCore::ContextMenuClientEfl::customizeMenu):
* WebCoreSupport/ContextMenuClientEfl.h:
(ContextMenuClientEfl):
* ewk/ewk_contextmenu.cpp:
(ewk_context_menu_new):
2013-03-14 Jonathan Liu <net147@gmail.com>
Fix detection of Intel Mac OS X platform on Intel Mac 64-bit
https://bugs.webkit.org/show_bug.cgi?id=112312
Reviewed by Simon Hausmann.
* ewk/ewk_settings.cpp:
(_ewk_settings_webkit_os_version_get):
2013-03-13 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: get rid of hiddenPanels filter
https://bugs.webkit.org/show_bug.cgi?id=112252
Reviewed by Vsevolod Vlasov.
* WebCoreSupport/InspectorClientEfl.cpp:
* WebCoreSupport/InspectorClientEfl.h:
(InspectorFrontendClientEfl):
2013-03-06 Krzysztof Czech <k.czech@samsung.com>
[EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
https://bugs.webkit.org/show_bug.cgi?id=110584
Reviewed by Gyuyoung Kim.
Adds support for help text in DumpRenderTree.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::accessibilityHelpText):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2013-03-06 Benjamin Poulain <benjamin@webkit.org>
WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
https://bugs.webkit.org/show_bug.cgi?id=42696
Reviewed by Andreas Kling.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2013-03-05 Geoffrey Garen <ggaren@apple.com>
Removed some dead code in the page cache
https://bugs.webkit.org/show_bug.cgi?id=111525
Reviewed by Alexey Proskuryakov.
Page cache autorelease doesn't exist anymore, so there's no need to keep
around these olds hacks.
* ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):
2013-03-03 Adam Barth <abarth@webkit.org>
Unreviewed attempted build fix. Adds back some includes removed in
http://trac.webkit.org/changeset/144565.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* ewk/ewk_frame.cpp:
2013-03-03 Adam Barth <abarth@webkit.org>
Unreviewed rollout of http://trac.webkit.org/r144530
As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and
https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
large number of ASSERTs in chromium-win.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* ewk/ewk_frame.cpp:
2013-03-02 Benjamin Poulain <bpoulain@apple.com>
Move computedStyleIncludingVisitedInfo from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=109772
Reviewed by Andreas Kling.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2013-02-28 Alexey Proskuryakov <ap@apple.com>
Reduce amount of rebuilding when touching networking headers
https://bugs.webkit.org/show_bug.cgi?id=111035
Reviewed by Eric Seidel.
Adding includes that are now necessary because WebCore headers don't have them
any more.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* ewk/ewk_frame.cpp:
2013-03-01 Jason Anderssen <janderssen@gmail.com>
Move markerTextForListItem from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=110939
Reviewed by Benjamin Poulain.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2013-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r144422 and r144424.
http://trac.webkit.org/changeset/144422
http://trac.webkit.org/changeset/144424
https://bugs.webkit.org/show_bug.cgi?id=111167
Caused over 20 tests to fail assertion on Chromium Win port as
ASSERTION FAILED: m_platformRequestUpdated (Requested by
toyoshim on #webkit).
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* ewk/ewk_frame.cpp:
2013-02-28 Alexey Proskuryakov <ap@apple.com>
Reduce amount of rebuilding when touching networking headers
https://bugs.webkit.org/show_bug.cgi?id=111035
Reviewed by Eric Seidel.
Adding includes that are now necessary because WebCore headers don't have them
any more.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* ewk/ewk_frame.cpp:
2013-02-28 Seokju Kwon <seokju.kwon@gmail.com>
[EFL] Focus problem in inspector/extensions/extensions-panel.html
https://bugs.webkit.org/show_bug.cgi?id=97077
Reviewed by Laszlo Gombos.
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorFrontendClientEfl::bringToFront): Set focus on inspectorView.
2013-02-23 Jason Anderssen <janderssen@gmail.com>
Move setAutofilled from TestRunner to WebCore
https://bugs.webkit.org/show_bug.cgi?id=110521
Reviewed by Benjamin Poulain.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2013-02-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
[EFL] Use EINA_LOG instead of fprintf
https://bugs.webkit.org/show_bug.cgi?id=110313
Reviewed by Laszlo Gombos.
Replace fprintf with EINA_LOG.
* ewk/ewk_frame.cpp:
(_ewk_frame_debug):
2013-02-19 Tony Chang <tony@chromium.org>
Convert 3 settings to use Settings.in
https://bugs.webkit.org/show_bug.cgi?id=109875
Reviewed by Ryosuke Niwa.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new): Rename isDOMPasteAllowed to DOMPasteAllowed.
2013-02-18 Simon Fraser <simon.fraser@apple.com>
Clean up the boolean argument to visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=110167
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
* ewk/ewk_frame.cpp:
(ewk_frame_visible_content_geometry_get):
2013-02-18 Michał Pakuła vel Rutka <m.pakula@samsung.com>
[EFL] Fix build when CONTEXT_MENUS flag is turned off
https://bugs.webkit.org/show_bug.cgi?id=109924
Reviewed by Gyuyoung Kim.
* WebCoreSupport/ContextMenuClientEfl.cpp:
* WebCoreSupport/ContextMenuClientEfl.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(ewk_view_context_menu_get):
2013-02-18 Grzegorz Czajkowski <g.czajkowski@samsung.com>
[WK2][EFL] Unified text checker implementation
https://bugs.webkit.org/show_bug.cgi?id=107682
Reviewed by Anders Carlsson.
Add an empty checkTextOfParagraph implementation for WK1-EFL
to do not break build when WTF_USE_UNIFIED_TEXT_CHECKING
is enabled.
* WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
(WebCore::EditorClientEfl::checkTextOfParagraph):
2013-02-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720
Reviewed by Julien Chaffraix.
Update calls to new API.
* ewk/ewk_frame.cpp:
(ewk_frame_hit_test_new):
2013-02-13 Allan Sandfeld Jensen <allan.jensen@digia.com>
[Qt] window.open passes height and width parameters even if not defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705
Reviewed by Kenneth Rohde Christiansen.
Do not resize window when default size is requested.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::setWindowRect):
2013-02-12 Huang Dongsung <luxtella@company100.net>
[TexMap] Apply frames-per-second debug counter to WK1.
https://bugs.webkit.org/show_bug.cgi?id=109540
Reviewed by Noam Rosenthal.
Make AcceleratedCompositingContextEfl use TextureMapperFPSCounter.
* WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
(WebCore::AcceleratedCompositingContext::renderLayers):
* WebCoreSupport/AcceleratedCompositingContextEfl.h:
(AcceleratedCompositingContext):
2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
https://bugs.webkit.org/show_bug.cgi?id=109534
Reviewed by Anders Carlsson.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore):
* WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
2013-02-08 Benjamin Poulain <bpoulain@apple.com>
Move workerThreadCount from TestRunner to WebCore Internals
https://bugs.webkit.org/show_bug.cgi?id=109239
Reviewed by Darin Adler.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2013-02-07 Benjamin Poulain <bpoulain@apple.com>
Move pauseAnimation/pauseTransition from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=109107
Reviewed by Anders Carlsson.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2013-02-04 Benjamin Poulain <bpoulain@apple.com>
Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() from DRT/WTR; use Internals
https://bugs.webkit.org/show_bug.cgi?id=108741
Reviewed by Tony Chang.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2013-02-04 Balazs Kelemen <kbalazs@webkit.org>
[Soup] Wrap SoupSession by NetworkStorageSession
https://bugs.webkit.org/show_bug.cgi?id=108615
Reviewed by Alexey Proskuryakov.
Changed to hold the SoupSession pointer in a NetworkStorageSession
so we can pass it to WebCore. _Ewk_View_Private_Data has to be
changed for that reason.
* WebCoreSupport/FrameNetworkingContextEfl.cpp:
(WebCore::FrameNetworkingContextEfl::storageSession):
* WebCoreSupport/FrameNetworkingContextEfl.h:
(FrameNetworkingContextEfl):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
(EWKPrivate::storageSession):
(EWKPrivate):
* ewk/ewk_view_private.h:
(EWKPrivate):
2013-02-03 KwangYong Choi <ky0.choi@samsung.com>
Fix build warning after r141473
https://bugs.webkit.org/show_bug.cgi?id=108782
Reviewed by Kentaro Hara.
Fix -Wunused-parameter build warning.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::getClientPasteboardDataForRange):
2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
Editor::m_compositionNode not updated on HTMLInputElement::setValue()
https://bugs.webkit.org/show_bug.cgi?id=107737
Reviewed by Ryosuke Niwa.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
Adding a call to the newly refactored method.
2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r141479.
http://trac.webkit.org/changeset/141479
https://bugs.webkit.org/show_bug.cgi?id=108564
breaks chromium test (Requested by morrita on #webkit).
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
Editor::m_compositionNode not updated on HTMLInputElement::setValue()
https://bugs.webkit.org/show_bug.cgi?id=107737
Reviewed by Ryosuke Niwa.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
Adding a call to the newly refactored method.
2013-01-31 Enrica Casucci <enrica@apple.com>
WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
https://bugs.webkit.org/show_bug.cgi?id=108396.
<rdar://problem/12920461>
Reviewed by Alexey Proskuryakov.
Adds stub implementation for WebKit of the new EditorClient methods.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::willWriteSelectionToPasteboard):
(WebCore::EditorClientEfl::getClientPasteboardDataForRange):
* WebCoreSupport/EditorClientEfl.h:
2013-01-31 Christophe Dumez <dchris@gmail.com>
[EFL] Disable Web Intents
https://bugs.webkit.org/show_bug.cgi?id=108457
Reviewed by Alexey Proskuryakov.
Remove code related to Web Intents from EFL
WebKit.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
* ewk/EWebKit.h:
* ewk/ewk_frame.cpp:
* ewk/ewk_frame.h:
* ewk/ewk_frame_private.h:
* ewk/ewk_intent.cpp: Removed.
* ewk/ewk_intent.h: Removed.
* ewk/ewk_intent_private.h: Removed.
* ewk/ewk_intent_request.cpp: Removed.
* ewk/ewk_intent_request.h: Removed.
2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r141110.
http://trac.webkit.org/changeset/141110
https://bugs.webkit.org/show_bug.cgi?id=108349
This patch broke WK2-EFL unit tests (Requested by grzegorz on
#webkit).
* WebCoreSupport/EditorClientEfl.h:
2013-01-30 Huang Dongsung <luxtella@company100.net>
[TexMap] Remove GraphicsLayer in TextureMapperLayer.
https://bugs.webkit.org/show_bug.cgi?id=107073
Reviewed by Noam Rosenthal.
Include GraphicsLayerTextureMapper.h to use toTextureMapperLayer().
* WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
2013-01-29 Grzegorz Czajkowski <g.czajkowski@samsung.com>
[EFL] Unified text checker implementation.
https://bugs.webkit.org/show_bug.cgi?id=107682
Reviewed by Anders Carlsson.
Add an empty checkTextOfParagraph implementation for WK1-EFL
to do not break build when WTF_USE_UNIFIED_TEXT_CHECKING
is enabled.
* WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
(WebCore::EditorClientEfl::checkTextOfParagraph):
2013-01-28 Huang Dongsung <luxtella@company100.net>
[TexMap] Enable debug borders and repaint counter via Settings.
https://bugs.webkit.org/show_bug.cgi?id=107198
Reviewed by Benjamin Poulain.
If WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS is set to 1, set
showDebugBorders and showRepaintCounter in Settings to true.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
2013-01-22 Anders Carlsson <andersca@apple.com>
Use a platforom strategy for local storage
https://bugs.webkit.org/show_bug.cgi?id=107600
Reviewed by Andreas Kling.
Update for new storage strategy.
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::createStorageStrategy):
* WebCoreSupport/PlatformStrategiesEfl.h:
(PlatformStrategiesEfl):
2013-01-22 Krzysztof Czech <k.czech@samsung.com>
[EFL] Adds Accessibility support to wk1.
https://bugs.webkit.org/show_bug.cgi?id=107440
Reviewed by Gyuyoung Kim.
Adds possibility of focusing and retrieving accessible object.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::rootAccessibleElement):
(DumpRenderTreeSupportEfl::focusedAccessibleElement):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2013-01-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed. Fix build break by r139796.
* ewk/ewk_frame.cpp:
(ewk_frame_text_matches_mark):
2013-01-13 KwangYong Choi <ky0.choi@samsung.com>
[EFL] Unreviewed build fix after r139541
https://bugs.webkit.org/show_bug.cgi?id=106749
undefined reference to `JSC::JSCell::methodTable() const'
* ewk/ewk_js.cpp:
* ewk/ewk_view.cpp:
2013-01-11 Filip Pizlo <fpizlo@apple.com>
JITThunks should not compile only because of luck
https://bugs.webkit.org/show_bug.cgi?id=105696
Rubber stamped by Sam Weinig.
* ewk/EWebKit.h:
* ewk/ewk_main.cpp:
2013-01-11 KwangYong Choi <ky0.choi@samsung.com>
[EFL] Fix unused parameter build error
https://bugs.webkit.org/show_bug.cgi?id=106639
Reviewed by Kentaro Hara.
Use UNUSED_PARAM macro to fix build error.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::intentMessagePorts):
* ewk/ewk_contextmenu.cpp:
(ewk_context_menu_destroy):
(ewk_context_menu_item_select):
* ewk/ewk_file_chooser.cpp:
(ewk_file_chooser_capture_get):
* ewk/ewk_frame.cpp:
(ewk_frame_feed_touch_event):
* ewk/ewk_intent.cpp:
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):
* ewk/ewk_intent_request.cpp:
(ewk_intent_request_ref):
(ewk_intent_request_unref):
(ewk_intent_request_intent_get):
* ewk/ewk_security_origin.cpp:
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
* ewk/ewk_settings.cpp:
(ewk_settings_shadow_dom_enable_set):
* ewk/ewk_view.cpp:
(ewk_view_context_menu_forward_event):
(ewk_view_setting_should_display_subtitles_get):
(ewk_view_setting_should_display_captions_get):
(ewk_view_setting_should_display_captions_set):
(ewk_view_setting_should_display_subtitles_set):
(ewk_view_setting_should_display_text_descriptions_get):
(ewk_view_setting_should_display_text_descriptions_set):
2013-01-10 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Add gstreamer 1.0.5 to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=106178
Reviewed by Laszlo Gombos.
Fix compilation error when using gstreamer 1.0.
* WebCoreSupport/FullscreenVideoControllerEfl.cpp:
* WebCoreSupport/FullscreenVideoControllerEfl.h:
2013-01-08 Mark Lam <mark.lam@apple.com>
Removed the need for the ProposedDatabase mechanism.
https://bugs.webkit.org/show_bug.cgi?id=106292.
Reviewed by Sam Weinig.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::exceededDatabaseQuota):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
2013-01-07 Mike West <mkwst@chromium.org>
Make the IFRAME_SEAMLESS flag runtime-enabled.
https://bugs.webkit.org/show_bug.cgi?id=106213
Reviewed by Ojan Vafai.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
Add a toggle for seamless IFrames to EFL's DRTSuport.
2013-01-04 Adam Klein <adamk@chromium.org>
Remove ENABLE_MUTATION_OBSERVERS #define
https://bugs.webkit.org/show_bug.cgi?id=105459
Reviewed by Ryosuke Niwa.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::deliverAllMutationsIfNecessary):
2012-12-23 Alexey Proskuryakov <ap@apple.com>
<rdar://problem/12808377> Network process should respect cookie accept policy
https://bugs.webkit.org/show_bug.cgi?id=105684
Reviewed by Sam Weinig.
* WebCoreSupport/PlatformStrategiesEfl.cpp:
* WebCoreSupport/PlatformStrategiesEfl.h:
CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.
2012-12-22 Alexey Proskuryakov <ap@apple.com>
Add a separate class for networking related storage
https://bugs.webkit.org/show_bug.cgi?id=105676
Reviewed by Sam Weinig.
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::cookiesForDOM):
(PlatformStrategiesEfl::setCookiesFromDOM):
(PlatformStrategiesEfl::cookiesEnabled):
(PlatformStrategiesEfl::cookieRequestHeaderFieldValue):
(PlatformStrategiesEfl::getRawCookies):
(PlatformStrategiesEfl::deleteCookie):
* WebCoreSupport/PlatformStrategiesEfl.h:
Cookie functions now take a NetworkStorageSession, not a NetworkingContext.
2012-12-21 Seokju Kwon <seokju.kwon@gmail.com>
[EFL] Add guard around ContextMenuItemTagInspectElement
https://bugs.webkit.org/show_bug.cgi?id=105267
Reviewed by Ryosuke Niwa.
Need INSPECTOR guard for using ContextMenuItemTagInspectElement.
* WebCoreSupport/AssertMatchingEnums.cpp:
2012-12-21 Kangil Han <kangil.han@samsung.com>
[EFL][WK1] Obsolete a case in test_ewk_frame api test to not make bot sick
https://bugs.webkit.org/show_bug.cgi?id=105142
Reviewed by Gyuyoung Kim.
BUG 49246 has changed load behavior on malformed url input.
That is why test_ewk_frame api test is timed out.
To not make bot sick, this patch comments out that test case at a moment.
* tests/test_ewk_frame.cpp:
(TEST_F):
2012-12-20 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Build break with latest EFL libraries.
https://bugs.webkit.org/show_bug.cgi?id=104827
Reviewed by Laszlo Gombos.
* WebCoreSupport/ChromeClientEfl.h: Removed unnecessary declaration.
* WebCoreSupport/DumpRenderTreeSupportEfl.h: Ditto.
* WebCoreSupport/EditorClientEfl.h: Ditto.
* WebCoreSupport/FrameNetworkingContextEfl.h: Ditto.
* WebCoreSupport/PageClientEfl.h: Ditto.
2012-12-18 Alexey Proskuryakov <ap@apple.com>
Remove unnecessary functions from CookiesStrategy
https://bugs.webkit.org/show_bug.cgi?id=105369
Reviewed by Brady Eidson.
* WebCoreSupport/PlatformStrategiesEfl.cpp:
* WebCoreSupport/PlatformStrategiesEfl.h:
2012-12-16 Seokju Kwon <seokju.kwon@gmail.com>
Fix unused parameter compile warnings
https://bugs.webkit.org/show_bug.cgi?id=105089
Reviewed by Kentaro Hara.
Use UNUSED_PARAM macro to fix build warning -Wunused-parameter.
* ewk/ewk_view.cpp:
(ewk_view_inspector_show):
(ewk_view_inspector_close):
(ewk_view_inspector_view_get):
(ewk_view_inspector_view_set):
2012-12-15 Anders Carlsson <andersca@apple.com>
Rename FrameLoaderClient::download to convertMainResourceLoadToDownload
https://bugs.webkit.org/show_bug.cgi?id=105122
Reviewed by Andreas Kling.
Update for WebCore changes.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::convertMainResourceLoadToDownload):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
2012-12-15 Mark Lam <mark.lam@apple.com>
Re-landing patch for "Introducing the DatabaseStrategy and database servers".
https://bugs.webkit.org/show_bug.cgi?id=104934.
Not reviewed.
Merged from r137767. Previously reviewed by Sam Weinig.
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::createDatabaseStrategy):
* WebCoreSupport/PlatformStrategiesEfl.h:
(PlatformStrategiesEfl):
2012-12-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r137767.
http://trac.webkit.org/changeset/137767
https://bugs.webkit.org/show_bug.cgi?id=105062
Broke Mac builds. (Requested by mlam on #webkit).
* WebCoreSupport/PlatformStrategiesEfl.cpp:
* WebCoreSupport/PlatformStrategiesEfl.h:
(PlatformStrategiesEfl):
2012-12-14 Mark Lam <mark.lam@apple.com>
Introducing the DatabaseStrategy and database servers.
https://bugs.webkit.org/show_bug.cgi?id=104934.
Reviewed by Sam Weinig.
The database server is currently a placeholder that does nothing.
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::createDatabaseStrategy):
* WebCoreSupport/PlatformStrategiesEfl.h:
(PlatformStrategiesEfl):
2012-12-13 Seokju Kwon <seokju.kwon@gmail.com>
Fix unused parameter compile warnings
https://bugs.webkit.org/show_bug.cgi?id=104907
Reviewed by Kentaro Hara.
Use UNUSED_PARAM macro to fix build warning -Wunused-parameter
when ENABLE_INSPECTOR is disabled.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
2012-12-13 Jussi Kukkonen <jussi.kukkonen@intel.com>
[EFL][GTK] Don't call deprecated g_type_init when glib => 2.35
https://bugs.webkit.org/show_bug.cgi?id=103209
Reviewed by Kenneth Rohde Christiansen.
g_type_init() is deprecated from 2.35.0 onwards. Don't call it
in that case to avoid warnings and/or build failure.
* ewk/ewk_main.cpp:
(_ewk_init_body):
2012-12-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Regression(r137568): Broke layout test on EFL WK1
https://bugs.webkit.org/show_bug.cgi?id=104895
Reviewed by Kenneth Rohde Christiansen.
Fix layout test crash after r137568 because ewk_view.cpp has kept unused networkInfoClient member variable
using OwnPtr. The r137568 lets NetworkInfoClientEfl destroy by WebCore::NetworkInfoController.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
2012-12-12 Gyuyoung Kim <gyuyoung.kim@samsung.com>
NetworkInfoController needs to support destructor
https://bugs.webkit.org/show_bug.cgi?id=104642
Reviewed by Kentaro Hara.
Though NetworkInfoController can be referenced by each port in order to update network status change,
there is no virtual interface to destroy it. Beside each port client also needs to be destroyed when
controller is destroyed.
* WebCoreSupport/NetworkInfoClientEfl.cpp:
(WebCore::NetworkInfoClientEfl::networkInfoControllerDestroyed):
(WebCore):
* WebCoreSupport/NetworkInfoClientEfl.h:
(NetworkInfoClientEfl):
2012-12-12 Seokju Kwon <seokju.kwon@gmail.com>
[EFL] Refactor duplicate code into EflInspectorUtilities
https://bugs.webkit.org/show_bug.cgi?id=104329
Reviewed by Kenneth Rohde Christiansen.
Remove duplicated work to get the resource path for inspector.
And use WebCore::inspectorResourcePath().
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::inspectorFilesPath):
2012-12-12 Mark Lam <mark.lam@apple.com>
Encapsulate externally used webdatabase APIs in DatabaseManager.
https://bugs.webkit.org/show_bug.cgi?id=104741.
Reviewed by Sam Weinig.
Use DatabaseManager instead of accessing DatabaseTracker, AbstractDatabase,
and DatabaseContext directly. This is to prepare for upcoming webkit2
refactoring.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::exceededDatabaseQuota):
* ewk/ewk_security_origin.cpp:
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
(ewk_security_origin_web_database_quota_set):
(ewk_security_origin_web_database_get_all):
* ewk/ewk_settings.cpp:
(ewk_settings_web_database_path_set):
* ewk/ewk_web_database.cpp:
(ewk_web_database_display_name_get):
(ewk_web_database_expected_size_get):
(ewk_web_database_filename_get):
(ewk_web_database_size_get):
(ewk_web_database_remove):
(ewk_web_database_remove_all):
2012-12-12 Alexey Proskuryakov <ap@apple.com>
Make LOG() work in WebProcess and NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=104718
Reviewed by Tim Horton.
* ewk/ewk_main.cpp: Include InitializeLogging.h
2012-12-11 Kihong Kwon <kihong.kwon@samsung.com>
Vibration API: IDL type doesn't match implementation type
https://bugs.webkit.org/show_bug.cgi?id=103899
Reviewed by Kentaro Hara.
According to WebIDL, "unsigned long" corresponds to "unsigned" in the platform.
Therefore unsigned long need to be changed to unsigned for the Vibration API.
- Change a parameter type of vibrate function from unsigned long to unsigned.
* WebCoreSupport/VibrationClientEfl.cpp:
(WebCore::VibrationClientEfl::vibrate):
* WebCoreSupport/VibrationClientEfl.h:
(VibrationClientEfl):
2012-12-11 Seokju Kwon <seokju.kwon@gmail.com>
[EFL] Remove unused headers
https://bugs.webkit.org/show_bug.cgi?id=104661
Reviewed by Ryosuke Niwa.
Header inclusion cleanup.
Remove "NotImplemented.h".
* WebCoreSupport/PopupMenuEfl.cpp:
* ewk/ewk_intent.cpp:
2012-12-11 Mike West <mkwst@chromium.org>
Web Inspector: ConsoleTypes should not expose MessageType - it should be private to inspector.
https://bugs.webkit.org/show_bug.cgi?id=66371
Reviewed by Pavel Feldman.
Drops WebCore::MessageType from the addMessageToConsole method.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::addMessageToConsole):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
2012-12-05 Halton Huo <halton.huo@intel.com>
[CMake] Unify coding style for CMake files
https://bugs.webkit.org/show_bug.cgi?id=103605
Reviewed by Laszlo Gombos.
Update cmake files(.cmake, CMakeLists.txt) with following style rules:
1. Indentation
1.1 Use spaces, not tabs.
1.2 Four spaces as indent.
2. Spacing
2.1 Place one space between control statements and their parentheses.
For eg, if (), else (), elseif (), endif (), foreach (),
endforeach (), while (), endwhile (), break ().
2.2 Do not place spaces between function and macro statements and
their parentheses. For eg, macro(), endmacro(), function(),
endfunction().
2.3 Do not place spaces between a command or function or macro and its
parentheses, or between a parenthesis and its content. For eg,
message("testing") not message( "testing") or message ("testing" )
2.4 No space at line ending.
3. Lowercase when call commands macros and functions. For eg,
add_executable() not ADD_EXECUTABLE(), set() not SET().
* DefaultTheme/CMakeLists.txt:
2012-11-30 Mihai Maerean <mmaerean@adobe.com>
[CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
https://bugs.webkit.org/show_bug.cgi?id=101192
Reviewed by Hajime Morita.
Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
Tests: No new tests because there is no functional change.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSRegionsEnabled):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
2012-11-29 Alexey Proskuryakov <ap@apple.com>
[WK2] Forward cookie jar calls to NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=103457
Reviewed by Darin Adler.
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::cookiesForDOM):
(PlatformStrategiesEfl::setCookiesFromDOM):
(PlatformStrategiesEfl::cookiesEnabled):
(PlatformStrategiesEfl::cookieRequestHeaderFieldValue):
(PlatformStrategiesEfl::getRawCookies):
(PlatformStrategiesEfl::deleteCookie):
(PlatformStrategiesEfl::getHostnamesWithCookies):
(PlatformStrategiesEfl::deleteCookiesForHostname):
(PlatformStrategiesEfl::deleteAllCookies):
2012-11-29 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Broken rendering occurs when scrolling in ewk_view_single.
https://bugs.webkit.org/show_bug.cgi?id=77325
Reviewed by Gyuyoung Kim.
After r104687, broken rendering occurs when scrolling contents.
It's because scrollWidth can be smaller than width of image buffer.
This patch fixes it and renames parameter to avoid confusion.
* ewk/ewk_view_single.cpp:
(_ewk_view_screen_move):
(_ewk_view_single_scroll_process_single):
2012-11-28 Ryuan Choi <ryuan.choi@gmail.com>
[EFL] Generate big_button_theme.edj
https://bugs.webkit.org/show_bug.cgi?id=103511
Reviewed by Gyuyoung Kim.
big_button_theme.edj, binary file which is used for test, should be generated.
* DefaultTheme/CMakeLists.txt:
Introduced macro and new target to share files of default theme instead
of adding many files for big_button_theme.
* DefaultTheme/widget/button/button.edc:
Implemented for big_button_theme.
2012-11-28 Ryuan Choi <ryuan.choi@gmail.com>
[EFL] Refactor theme to choose whether to support foreground color of selection
https://bugs.webkit.org/show_bug.cgi?id=102037
Reviewed by Kenneth Rohde Christiansen.
* DefaultTheme/default.edc:
Refactored color classes from active/inactive to foreground/background.
2012-11-27 James Simonsen <simonjam@chromium.org>
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151
Reviewed by Adam Barth.
* ewk/ewk_frame.cpp:
(_ewk_frame_contents_set_internal):
2012-11-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r135786.
http://trac.webkit.org/changeset/135786
https://bugs.webkit.org/show_bug.cgi?id=103379
It made 3 plugin tests timeout on several platforms (Requested
by Ossy on #webkit).
* ewk/ewk_frame.cpp:
(ewk_frame_uri_set):
(_ewk_frame_contents_set_internal):
2012-11-26 James Simonsen <simonjam@chromium.org>
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151
Reviewed by Adam Barth.
* ewk/ewk_frame.cpp:
(_ewk_frame_contents_set_internal):
2012-11-24 Viatcheslav Ostapenko <v.ostapenko@samsung.com>
[EFL] Layout test comes to crash on WK1
https://bugs.webkit.org/show_bug.cgi?id=103170
Reviewed by Kenneth Rohde Christiansen.
Switch off accelerated compositing for WK1 because GraphicsContext3D is
missing direct rendering implementation that is required for EFL WK1.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
2012-11-21 Allan Sandfeld Jensen <allan.jensen@digia.com>
Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139
Reviewed by Julien Chaffraix.
* ewk/ewk_frame.cpp:
(ewk_frame_hit_test_new):
2012-11-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r135295.
http://trac.webkit.org/changeset/135295
https://bugs.webkit.org/show_bug.cgi?id=102834
This patch causes assertion to some layout tests on chromium
(Requested by jianli on #webkit).
* ewk/ewk_frame.cpp:
(ewk_frame_uri_set):
(_ewk_frame_contents_set_internal):
2012-11-20 James Simonsen <simonjam@chromium.org>
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151
Reviewed by Adam Barth.
* ewk/ewk_frame.cpp:
(_ewk_frame_contents_set_internal):
2012-11-19 Tony Chang <tony@chromium.org>
Remove 'is' prefix from WebSettings::isWebSecurityEnabled and WebSettings::isSpatialNavigationEnabled
https://bugs.webkit.org/show_bug.cgi?id=102548
Reviewed by Adam Barth.
Rename call to WebCore::Settings.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
2012-11-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r134694.
http://trac.webkit.org/changeset/134694
https://bugs.webkit.org/show_bug.cgi?id=102481
it made API test crash on EFL port (Requested by gyuyoung on
#webkit).
* DefaultTheme/default.edc:
2012-11-15 Kenneth Rohde Christiansen <kenneth@webkit.org>
Rename member vars in ViewportArgument to match css-device-adapt
https://bugs.webkit.org/show_bug.cgi?id=102355
Reviewed by Gyuyoung Kim.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new): Update to reflect name change.
2012-11-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed. Fix build break when using --no-tiled-backing-store option.
* ewk/ewk_frame_private.h:
(WebCore):
2012-11-14 Ryuan Choi <ryuan.choi@gmail.com>
[EFL] Port tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=71352
Reviewed by Gyuyoung Kim.
Added ewk_view_setting_tiled_backing_store_enabled_{get|set} to give possibility
to use WebCore's tiled backing store in WebKit/Efl port. This makes WebKit/Efl
compliant with WebKit's generic solution of tiled backing store.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore):
(WebCore::ChromeClientEfl::visibleRectForTiledBackingStore):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
* ewk/ewk_frame_private.h:
Declared missing classes which used in this file.
* ewk/ewk_paint_context.cpp:
(ewk_paint_context_paint): Implemented to paint tiled backing store
* ewk/ewk_view.cpp:
(ewk_view_setting_tiled_backing_store_enabled_set):
Added API to enable/disable the WebCore's tiled backing store.
(ewk_view_setting_tiled_backing_store_enabled_get):
Added API to query if the WebCore's tiled backing store is enabled.
(ewk_view_tiled_backing_store_invalidate):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:
* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_repaints_process):
Implemented to update visible area of tiled backing store.
* tests/test_ewk_view.cpp: Added test case of ewk_view_setting_tiled_backing_store.
(TEST_F):
2012-11-14 Ryuan Choi <ryuan.choi@gmail.com>
[EFL] Refactor theme to choose whether to support foreground color of selection
https://bugs.webkit.org/show_bug.cgi?id=102037
Reviewed by Gyuyoung Kim.
* DefaultTheme/default.edc:
Refactored color classes from active/inactive to foreground/background.
2012-11-12 KyungTae Kim <ktf.kim@samsung.com>
[EFL] In ewk_tiled_backing_store_pre_render_region, the 'slicer' may be uninitialized
https://bugs.webkit.org/show_bug.cgi?id=102038
Reviewed by Gyuyoung Kim.
To fix build warning -Wuninitialized,
initialize the 'slicer' in ewk_tiled_backing_store_pre_render_region.
* ewk/ewk_tiled_backing_store.cpp:
(ewk_tiled_backing_store_pre_render_region):
2012-11-09 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
[EFL][DRT] Force a repaint before tracking repaint rects.
https://bugs.webkit.org/show_bug.cgi?id=101743
Reviewed by Kenneth Rohde Christiansen.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::forceLayout): Added.
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2012-11-07 Emil A Eklund <eae@chromium.org>
Unreviewed EFL build fix.
* ewk/ewk_view.cpp:
2012-11-01 Seonae Kim <sunaeluv.kim@samsung.com>
[EFL][DRT] Support Geolocation
https://bugs.webkit.org/show_bug.cgi?id=97427
Reviewed by Gyuyoung Kim.
Implement methods to use GeolocationClientMock in DumpRenderTree.
This client attaches to the page whenever a view is created.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::attachClientToPage):
(DumpRenderTreeSupportEfl::resetGeolocationClientMock):
(DumpRenderTreeSupportEfl::setMockGeolocationPermission):
(DumpRenderTreeSupportEfl::setMockGeolocationPosition):
(DumpRenderTreeSupportEfl::setMockGeolocationPositionUnavailableError):
(DumpRenderTreeSupportEfl::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2012-10-31 Michał Pakuła vel Rutka <m.pakula@samsung.com>
[EFL][DRT] EventSender requires contextClick implementation
https://bugs.webkit.org/show_bug.cgi?id=86091
Reviewed by Gyuyoung Kim.
Add a pointer to parent menu in Ewk_Context_Menu_Item and a getter
function to allow selecting a context menu item without having
parent menu pointer in DumpRenderTree EventSender.
Three unit tests added due ewk API changes.
* ewk/ewk_contextmenu.cpp:
(_Ewk_Context_Menu_Item):
(ewk_context_menu_item_new):
(ewk_context_menu_item_parent_get):
(ewk_context_menu_item_append):
* ewk/ewk_contextmenu.h:
* ewk/ewk_view.cpp:
(ewk_view_context_menu_get):
* ewk/ewk_view.h:
* tests/test_ewk_contextmenu.cpp: Added.
(TEST_F):
* tests/test_ewk_view.cpp:
(TEST_F):
2012-10-30 Seokju Kwon <seokju.kwon@samsung.com>
[EFL] Fix failure to highlight nodes on web inspector
https://bugs.webkit.org/show_bug.cgi?id=100303
Reviewed by Gyuyoung Kim.
It is not working to highlight nodes on web inspector
when using 'Single Backing Store'.
Add code for drawing it if there is the highlighted node.
* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_repaints_process):
2012-10-30 Jinwoo Song <jinwoo7.song@samsung.com>
[EFL] Refactor tooltip callback signal in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=100571
Reviewed by Gyuyoung Kim.
Separate tooltip callback signal into 'tooltip,text,set'
and 'tooltip,text,unset' to be consistent with WebKit2.
* ewk/ewk_view.cpp:
(ewk_view_tooltip_text_set):
* ewk/ewk_view.h:
2012-10-26 Hyowon Kim <hw1008.kim@samsung.com>
[Texmap][EFL] Implementation of AC related functions in ChromeClientEfl and ewkView.
https://bugs.webkit.org/show_bug.cgi?id=82315
Reviewed by Kenneth Rohde Christiansen.
This patch implements accelerated-compositing-related functions
to enter accelerated-compositing mode and sync layers
in ChromeClientEfl and ewkView.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::attachRootGraphicsLayer):
(WebCore::ChromeClientEfl::setNeedsOneShotDrawingSynchronization):
(WebCore::ChromeClientEfl::scheduleCompositingLayerFlush):
(WebCore::ChromeClientEfl::allowedCompositingTriggers):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(_ewk_view_accelerated_compositing_cb):
Sync and render layers.
(_ewk_view_accelerated_compositing_context_create_if_needed):
Create a new AcceleratedCompositingContext.
(ewk_view_accelerated_compositing_object_create):
Create a new evas_image_object act as render target surface.
(ewk_view_accelerated_compositing_context_get):
Return the GraphicsContext3D for accelerated compositing.
(ewk_view_root_graphics_layer_set):
Set the root layer to AcceleratedCompositingContext.
(ewk_view_mark_for_sync):
Mark the evas_image_object for accelerated compositing as dirty to make it update.
* ewk/ewk_view_private.h:
(WebCore):
2012-10-24 Brady Eidson <beidson@apple.com>
Add a strategy for loader customization.
https://bugs.webkit.org/show_bug.cgi?id=100278
Reviewed by Alexey Proskuryakov.
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::createLoaderStrategy):
* WebCoreSupport/PlatformStrategiesEfl.h:
(PlatformStrategiesEfl):
2012-10-23 Alexey Proskuryakov <ap@apple.com>
Add a strategy for shared workers
https://bugs.webkit.org/show_bug.cgi?id=100165
Reviewed by Brady Eidson.
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::createPasteboardStrategy):
(PlatformStrategiesEfl::createSharedWorkerStrategy):
(PlatformStrategiesEfl::createVisitedLinkStrategy):
* WebCoreSupport/PlatformStrategiesEfl.h:
2012-10-23 Hyowon Kim <hw1008.kim@samsung.com>
[Texmap][EFL] Add AcceleratedCompositingContextEfl to the build system.
https://bugs.webkit.org/show_bug.cgi?id=88630
Reviewed by Gyuyoung Kim.
* WebCoreSupport/AcceleratedCompositingContextEfl.cpp: Modify the #include file.
2012-10-23 Andras Becsi <andras.becsi@digia.com>
Remove devicePixelRatio from ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=99845
Reviewed by Adam Barth.
* ewk/ewk_view.cpp:
(_ewk_view_viewport_attributes_compute):
Pass the device pixel ratio as a function argument.
2012-10-22 Ryuan Choi <ryuan.choi@gmail.com>
[EFL] pc files should use DATA_INSTALL_DIR for datadir
https://bugs.webkit.org/show_bug.cgi?id=99961
Reviewed by Gyuyoung Kim.
* ewebkit.pc.in: Used DATA_INSTALL_DIR instead of hardcoded `shared/XXX`
2012-10-22 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
[Qt] Fix "ASSERTION FAILED: !document->inPageCache()" when loading a page
https://bugs.webkit.org/show_bug.cgi?id=98514
Reviewed by Kenneth Rohde Christiansen.
* ewk/ewk_frame.cpp:
(ewk_frame_view_create_for_view):
2012-10-21 Seokju Kwon <seokju.kwon@samsung.com>
[EFL] Fix failure to access the inspector resources
https://bugs.webkit.org/show_bug.cgi?id=99816
Reviewed by Gyuyoung Kim.
access() returns -1, if path has a file protocol like "file://".
And I have removed it from the first argument of access().
If not, inspectorBaseURL() or inspectorFilesPath() always returns WEB_INSPECTOR_DIR.
Then all layout test related to inspector can fail after installing webkit package.
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::inspectorFilesPath):
2012-10-20 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
[EFL][DRT] Implement tracking and painting repaint rectangles.
https://bugs.webkit.org/show_bug.cgi?id=99838
Reviewed by Gyuyoung Kim.
Add the required DumpRenderTreeSupport plumbing functions to
interact with FrameView and track/obtain repaint rectangles for
DumpRenderTree.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled):
(DumpRenderTreeSupportEfl::setTracksRepaints):
(DumpRenderTreeSupportEfl::resetTrackedRepaints):
(DumpRenderTreeSupportEfl::isTrackingRepaints):
(DumpRenderTreeSupportEfl::trackedRepaintRects):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2012-10-18 Kangil Han <kangil.han@samsung.com>
[EFL] Add unit test for ewk_frame_source_get.
https://bugs.webkit.org/show_bug.cgi?id=95984
Reviewed by Gyuyoung Kim.
Add three unit test cases to verify ewk_frame_source_get function.
Additionally, insert code to check if uri exists in order to return error since view itself has blank html.
* ewk/ewk_frame.cpp:
(ewk_frame_source_get):
* tests/test_ewk_frame.cpp: Added.
(initBuffer):
(TEST_F):
2012-10-17 Byungwoo Lee <bw80.lee@samsung.com>
Fix build warnings : -Wunused-parameter, -Wunused-variable
https://bugs.webkit.org/show_bug.cgi?id=99539
Reviewed by Kentaro Hara.
Fix build warnings about unused parameter or unused variable when
WTF_USE_TILED_BACKING_STORE option is enabled.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::attachRootGraphicsLayer):
(WebCore::ChromeClientEfl::delegatedScrollRequested):
2012-10-17 Byungwoo Lee <bw80.lee@samsung.com>
[EFL] Add background color to the checkbox theme.
https://bugs.webkit.org/show_bug.cgi?id=98788
Reviewed by Gyuyoung Kim.
Background color is added to the checkbox theme for identifying
checkbox status easily.
Checkbox theme uses images which has transparent background, and the
theme itself doesn't have the background color.
When the background of checkbox is black, checked/unchecked status
cannot be distinguished because check mark color is black.
And it is hard to identify whether the checkbox is disabled or not,
because there is no background color in the checkbox theme.
Instead of adding background color to the edc script, background
images are added because the shape of the check box can be various.
* DefaultTheme/widget/check/check.edc:
* DefaultTheme/widget/check/img_check_bg_enabled.png: Added.
* DefaultTheme/widget/check/img_check_bg_disabled.png: Added.
2012-10-17 Byungwoo Lee <bw80.lee@samsung.com>
[EFL] Add background color to the radio button theme.
https://bugs.webkit.org/show_bug.cgi?id=98852
Reviewed by Gyuyoung Kim.
Background color is added to the radio button theme for identifying
radio button status easily.
Radio button theme uses images which has transparent background.
When the background of radio button is black, checked/unchecked status
cannot be distinguished because check mark color is black.
And it is hard to identify whether the radio button is disabled or not,
because there is no background color in the radio button theme.
* DefaultTheme/widget/radio/img_radio_bg_disabled.png: Added.
* DefaultTheme/widget/radio/img_radio_bg_enabled.png: Added.
* DefaultTheme/widget/radio/radio.edc:
2012-10-15 Christophe Dumez <christophe.dumez@intel.com>
[EFL][WK2] Implement Favicons API
https://bugs.webkit.org/show_bug.cgi?id=99087
Reviewed by Kenneth Rohde Christiansen.
Remove ewk_util now that its code has been moved
to CairoUtilitiesEfl in WebCore.
* ewk/ewk_history.cpp:
(ewk_history_item_icon_object_add):
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_object_get):
2012-10-15 Dongwoo Joshua Im <dw.im@samsung.com>
[EFL] Set the basepath of the File System API.
https://bugs.webkit.org/show_bug.cgi?id=98344
Reviewed by Gyuyoung Kim.
Set the basepath of the File System API using the internal setter function.
* ewk/ewk_main.cpp:
(_ewk_init_body): Call the setter function with the default path.
* ewk/ewk_settings.cpp:
(ewk_settings_file_system_path_set): Set the given path as the base path of the file system.
* ewk/ewk_settings_private.h: Add ewk_settings_file_system_path_set.
2012-10-14 Sam Weinig <sam@webkit.org>
Make UserScript and UserStyleSheet value objects that are copyable
https://bugs.webkit.org/show_bug.cgi?id=99275
Reviewed by Tim Horton.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::addUserScript):
(DumpRenderTreeSupportEfl::addUserStyleSheet):
Update for new PageGroup function signatures.
2012-10-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
[EFL] Remove "web" word in web inspector
https://bugs.webkit.org/show_bug.cgi?id=98724
Reviewed by Laszlo Gombos.
*web* word is redundant in web inspector. Beside r130494 and r130479 removed *web* from EFL WK2.
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::notifyInspectorDestroy):
(WebCore::InspectorClientEfl::openInspectorFrontend):
(WebCore::InspectorFrontendClientEfl::InspectorFrontendClientEfl):
(WebCore::InspectorFrontendClientEfl::~InspectorFrontendClientEfl):
* ewk/ewk_view.cpp:
(ewk_view_inspector_show):
(ewk_view_inspector_close):
(ewk_view_inspector_view_get):
(ewk_view_inspector_view_set):
* ewk/ewk_view.h:
2012-10-10 Jon Lee <jonlee@apple.com>
[WK2] Activate plugins when user clicks on snapshot
https://bugs.webkit.org/show_bug.cgi?id=98328
<rdar://problem/12426681>
Reviewed by Brady Eidson.
* WebCoreSupport/FrameLoaderClientEfl.h:
(WebCore::FrameLoaderClientEfl::recreatePlugin): Stub implementation of recreatePlugin().
2012-10-10 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Use ewk_view_paint instead of ewk_view_paint_contents in ewk_view_single.
https://bugs.webkit.org/show_bug.cgi?id=98716
Reviewed by Kenneth Rohde Christiansen.
ewk_view_paint is the wrapper of ScrollView::paint and
ewk_view_paint_contents is the wrapper of FrameView::paintContents.
Because FrameView::paintContents just draw contents,
ewk_view_single should use ewk_view_paint instead of ewk_view_paint_contents
like other ports.
* ewk/ewk_view.cpp:
(ewk_view_paint):
Moved updateLayoutAndStyleIfNeededRecursive to share ewk_view_paint.
* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_repaints_process):
Modified to call ewk_view_paint.
2012-10-10 Jaehun Lim <ljaehun.lim@samsung.com>
[EFL] Use Evas function instead of memcpy
https://bugs.webkit.org/show_bug.cgi?id=98483
Reviewed by Gyuyoung Kim.
Evas supports evas_object_image_data_copy_set() to copy raw image data.
Change memcpy() with evas_object_image_data_copy_set().
Spell out variable names and refactor variable declaration statements.
No new tests, no functionality was changed.
* ewk/ewk_util.cpp:
(ewk_util_image_from_cairo_surface_add):
2012-10-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784
Reviewed by Eric Seidel.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::getPluginInfo):
* ewk/ewk_intent.cpp:
(ewk_intent_extra_get):
2012-10-05 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Fix window resizing / moving in WK1 and WKTR
https://bugs.webkit.org/show_bug.cgi?id=98486
Reviewed by Gyuyoung Kim.
Fix ChromeClientEfl::windowRect() code to use
ecore_evas_request_geometry_get() instead of
evas_object_geometry_get() and therefore avoid
returning incorrect values when the engine has
not processed a call to ecore_evas_move_resize()
yet. This fixes a couple of layout tests.
The code was also refactored a bit for
consistency with the WebKit2 EFL implementation.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::windowRect):
(WebCore::ChromeClientEfl::setWindowRect):
2012-10-04 Simon Fraser <simon.fraser@apple.com>
Final part of "sync" to "flush" renaming
https://bugs.webkit.org/show_bug.cgi?id=98430
Reviewed by Tim Horton.
Change method names on GraphicsLayer and GraphicsLayerClient that
refer to "sync" to use the term "flush" instead, to be consistent
with the rest of the code.
* WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
(WebCore::AcceleratedCompositingContext::syncLayersNow):
(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):
2012-10-04 Simon Fraser <simon.fraser@apple.com>
Standardize on "flush" terminology for compositing layer flushing/syncing
https://bugs.webkit.org/show_bug.cgi?id=98321
Reviewed by Simon Fraser.
Rename compositing-related methods that refer to "syncing" to instead
refer to "flushing".
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::scheduleCompositingLayerFlush):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
2012-10-04 Christophe Dumez <christophe.dumez@intel.com>
[EFL] webintents/web-intents-failure.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98349
Reviewed by Gyuyoung Kim.
After r130344, OpaqueJSString().string() returns
an empty string instead of a null one. Therefore,
we need to update the check in
DumpRenderTreeSupportEfl::sendWebIntentResponse().
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::sendWebIntentResponse):
2012-10-04 Christophe Dumez <christophe.dumez@intel.com>
Regression(r130363): Broke unit tests
https://bugs.webkit.org/show_bug.cgi?id=98341
Reviewed by Gyuyoung Kim.
Fix WebKitEFL unit tests to use X11 as
well.
* tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::SetUp):
* tests/UnitTestUtils/EWKTestEnvironment.h:
(EWKTestEnvironment):
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):
2012-10-03 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Default.edj should be generated although ENABLE_WEBKIT disabled.
https://bugs.webkit.org/show_bug.cgi?id=97753
Reviewed by Laszlo Gombos.
default.edj is used in both webkit/efl and webkit2/efl.
However, it has been generated only when ENABLE_WEBKIT is enabled.
This patch separates the script which generates default.edj
from source/webkit/platformefl.cmake.
* DefaultTheme/CMakeLists.txt:
Extracted from Source/WebKit/PlatformEfl.cmake and sanitized.
2012-10-03 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=98231
Reviewed by Gyuyoung Kim.
Initialize ecore_x library in ewk_main since it is used by
WebKitEFL.
* ewk/ewk_main.cpp:
(ewk_init):
(ewk_shutdown):
2012-10-03 Kangil Han <kangil.han@samsung.com>
Fix unused parameter compile warnings.
https://bugs.webkit.org/show_bug.cgi?id=98243
Reviewed by Alexey Proskuryakov.
Fixed unused parameter compile warning by removing page parameter name and UNUSED_PARAM usage.
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::getPluginInfo):
2012-10-03 Jinwoo Song <jinwoo7.song@samsung.com>
[EFL] Change the reversed expected and actual parameter in WebKit1 unit tests
https://bugs.webkit.org/show_bug.cgi?id=98276
Reviewed by Laszlo Gombos.
Expected value should be at first and actual value be followed in ASSERT_STREQ().
* tests/test_ewk_view.cpp:
(TEST_F):
2012-10-02 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Add API to get the web view that initiated a custom URI request to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=97895
Reviewed by Martin Robinson.
* WebCoreSupport/FrameNetworkingContextEfl.cpp:
(WebCore::FrameNetworkingContextEfl::initiatingPageID): Stub
implementation.
* WebCoreSupport/FrameNetworkingContextEfl.h:
(FrameNetworkingContextEfl): Added.
2012-10-02 Krzysztof Czech <k.czech@samsung.com>
[EFL][UT] Refactoring an implementation of testing framework for wk1.
https://bugs.webkit.org/show_bug.cgi?id=94925
Reviewed by Gyuyoung Kim.
The reason of changing, was to adjust current implementation to use gtest features
related to cleaning (SetUp, TearDown), cleaning code in terms of useless methods
and lastly to make framework easier to use.
* tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::EWKTestBase):
(EWKUnitTests::EWKTestBase::webView): Returns current webview.
(EWKUnitTests::EWKTestBase::SetUp):
Before test is started, SetUp is called.
Used this to initialize test view.
(EWKUnitTests::EWKTestBase::onLoadFinished):
(EWKUnitTests::EWKTestBase::waitUntilLoadFinished): It waits till test page will be properly loaded.
(EWKUnitTests::EWKTestBase::loadUrl): Starts loading test page.
* tests/UnitTestUtils/EWKTestBase.h:
* tests/UnitTestUtils/EWKTestEnvironment.cpp:
Used to have global SetUp and TearDown.
Global SetUp starts initialization of webkit wherease
global TearDown shuts it down. Generally we would like to have
only one initialization of webkit while tests are executed.
(EWKUnitTests):
(EWKUnitTests::EWKTestEnvironment::EWKTestEnvironment):
(EWKUnitTests::EWKTestEnvironment::SetUp): Starts initialization of webkit.
(EWKUnitTests::EWKTestEnvironment::TearDown): Shuts down of webkit.
* tests/UnitTestUtils/EWKTestEnvironment.h:
(EWKUnitTests):
(EWKTestEnvironment):
(EWKUnitTests::EWKTestEnvironment::useX11Window):
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init): Starts initialization of test view.
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):
* tests/test_ewk_view.cpp: adjusted current unit tests to new implementation.
(TEST_F):
* tests/test_runner.cpp: entry point of all tests.
(parseCustomArguments):
(main):
2012-10-01 Brady Eidson <beidson@apple.com>
Remove the Safari 2 -> Safari 3 icon database import code.
https://bugs.webkit.org/show_bug.cgi?id=98113
Reviewed by Maciej Stachowiak.
Nuke the performImport() IconDatabaseClient method.
* WebCoreSupport/IconDatabaseClientEfl.cpp:
* WebCoreSupport/IconDatabaseClientEfl.h:
2012-09-28 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Code inside FrameLoaderClient::canShowMIMEType() implementations can be shared among different WK ports
https://bugs.webkit.org/show_bug.cgi?id=97547
Reviewed by Adam Barth.
Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
inside WebCore::FrameLoaderClientEfl::canShowMIMEType().
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::canShowMIMEType):
2012-09-28 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[EFL][DRT] EFL DRT should disable visited links tracking by default
https://bugs.webkit.org/show_bug.cgi?id=97881
Reviewed by Kenneth Rohde Christiansen.
Added aux DumpRenderTreeSupportEfl::setShouldTrackVisitedLinks() function.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setShouldTrackVisitedLinks):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2012-09-27 Christophe Dumez <christophe.dumez@intel.com>
[EFL] No way to exit video fullscreen mode once entered
https://bugs.webkit.org/show_bug.cgi?id=97631
Reviewed by Kenneth Rohde Christiansen.
Fix default theme so that we have 2 fullscreen buttons, one
to enter fullscreen mode and another to exit it.
New icon by Alexander Shalamov.
* DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png: Added.
* DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png: Added.
* DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
* DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreenbutton.png: Removed.
2012-09-26 Jinwoo Song <jinwoo7.song@samsung.com>
[EFL] Fix the typo in the ewk_view_fullscreen_exit()
https://bugs.webkit.org/show_bug.cgi?id=97635
Reviewed by Gyuyoung Kim.
Fix the silly typo in the ewk_view_fullscreen_exit() API.
* ewk/ewk_view.cpp:
(ewk_view_fullscreen_exit):
2012-09-25 Jinwoo Song <jinwoo7.song@samsung.com>
[EFL] Add fullscreen set/get APIs and callbacks
https://bugs.webkit.org/show_bug.cgi?id=97421
Reviewed by Gyuyoung Kim.
Add setting APIs for JavaScript Fullscreen API and also add two callbacks to ewk_view API,
so that UI could customise behavior when fullscreen mode is requested.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::enterFullScreenForElement):
(WebCore::ChromeClientEfl::exitFullScreenForElement):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_fullscreen_get):
(ewk_view_setting_enable_fullscreen_set):
(ewk_view_fullscreen_enter):
(ewk_view_fullscreen_exit):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:
* tests/test_ewk_view.cpp:
(ewkViewEnableFullscreenCb):
(TEST):
2012-09-25 Beth Dakin <bdakin@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=95397
Need to merge didFirstVisuallyNonEmptyLayout and
didNewFirstVisuallyNonEmptyLayout
-and corresponding-
<rdar://problem/10791680>
Reviewed by Sam Weinig.
Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
is now replaced by dispatchDidLayout(LayoutMilestoneOptions)
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidLayout):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
It is now necessary to opt into getting any of the
"layout milestone" notifications.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
2012-09-24 Dominik Röttsches <dominik.rottsches@intel.com>
[EFL][DRT] Enable Regions support
https://bugs.webkit.org/show_bug.cgi?id=83897
Reviewed by Kenneth Rohde Christiansen.
Activating CSS regions by default for EWK views.
* ewk/ewk_view.cpp: Switch CSS regions on by default.
(_ewk_view_priv_new):
2012-09-23 Byungwoo Lee <bw80.lee@gmail.com>
Fix build warnings : -Wunused-parameter, -Wparentheses, -Wuninitialized.
https://bugs.webkit.org/show_bug.cgi?id=97306
Reviewed by Benjamin Poulain.
Fix build warning about -Wunused-parameter on FrameLoaderClientEfl.cpp
by using ASSERT_UNUSED() macro.
Fix build warning aboug -Wparentheses on ewk_frame.cpp by adding
additional brace for the assign statement.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):
* ewk/ewk_frame.cpp:
(ewk_frame_resources_location_get):
2012-09-21 Christophe Dumez <christophe.dumez@intel.com>
[EFL] EventSender should mimic CTRL+o emacs shortcut
https://bugs.webkit.org/show_bug.cgi?id=97224
Reviewed by Kenneth Rohde Christiansen.
Fix bad use of temporary object causing wrong editing
callback dumping.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::shouldInsertText):
2012-09-20 Jinwoo Song <jinwoo7.song@samsung.com>
[EFL] Change the log macro names to be more consistent with EINA LOG
https://bugs.webkit.org/show_bug.cgi?id=97158
Reviewed by Kenneth Rohde Christiansen.
Some log macro names in WebKit1 are inconsistent with EINA LOG names
such as WRN/INF not WARN/INFO.
#define WRN(...) EINA_LOG_DOM_WARN(_ewk_log_dom, __VA_ARGS__)
#define INF(...) EINA_LOG_DOM_INFO(_ewk_log_dom, __VA_ARGS__)
This patch changes the such names to be consistent with EINA LOG's names.
* ewk/ewk_frame.cpp:
(_ewk_frame_smart_resize):
(ewk_frame_source_get):
(ewk_frame_uri_changed):
* ewk/ewk_main.cpp:
(_ewk_init_body):
* ewk/ewk_private.h:
* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_render):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(ewk_tiled_backing_store_pre_render_relative_radius):
* ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_free):
(ewk_tile_matrix_tile_exact_get):
(_ewk_tile_matrix_slicer_setup):
* ewk/ewk_view.cpp:
(_ewk_view_smart_add_console_message):
(_ewk_view_smart_run_javascript_alert):
(_ewk_view_smart_run_javascript_confirm):
(_ewk_view_smart_should_interrupt_javascript):
(_ewk_view_smart_run_javascript_prompt):
(_ewk_view_smart_pre_render_region):
(_ewk_view_smart_pre_render_relative_radius):
(_ewk_view_smart_pre_render_start):
(_ewk_view_smart_pre_render_cancel):
(_ewk_view_smart_disable_render):
(_ewk_view_smart_enable_render):
(ewk_view_bg_color_set):
(ewk_view_zoom_set):
(ewk_view_zoom_weak_set):
(ewk_view_zoom_animated_set):
(ewk_view_statusbar_text_set):
(ewk_view_exceeded_application_cache_quota):
(ewk_view_exceeded_database_quota):
(ewk_view_scroll):
(ewk_view_popup_new):
(ewk_view_popup_destroy):
(ewk_view_popup_selected_set):
(ewk_view_color_chooser_new):
(ewk_view_color_chooser_destroy):
(ewk_view_color_chooser_color_set):
(ewk_view_color_chooser_changed):
(ewk_view_zoom_range_set):
* ewk/ewk_view_private.h:
2012-09-19 Jinwoo Song <jinwoo7.song@samsung.com>
Fix unused parameter compile warnings in WebKit/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=96742
Reviewed by Gyuyoung Kim.
Fix unused parameter compile warning messages(-Wunused-parameter) in WebKit during EFL build.
WebCore's warning messages were fixed in r128570.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::createWindow):
(WebCore::ChromeClientEfl::mouseDidMoveOverElement):
(WebCore::ChromeClientEfl::print):
(WebCore::ChromeClientEfl::reachedMaxAppCacheSize):
(WebCore::ChromeClientEfl::invalidateContents):
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::handleInputMethodKeydown):
(WebCore::EditorClientEfl::getGuessesForWord):
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveAuthenticationChallenge):
(WebCore::FrameLoaderClientEfl::dispatchDidCancelAuthenticationChallenge):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::createFrame):
(WebCore::FrameLoaderClientEfl::createJavaAppletWidget):
(WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem):
(WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML):
(WebCore::FrameLoaderClientEfl::setTitle):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveContentLength):
(WebCore::FrameLoaderClientEfl::dispatchDidLoadResourceFromMemoryCache):
(WebCore::FrameLoaderClientEfl::setMainDocumentError):
* WebCoreSupport/FullscreenVideoControllerEfl.cpp:
(FullscreenVideoController::showHud):
(FullscreenVideoController::setVolume):
(FullscreenVideoController::setCurrentTime):
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::notifyWebInspectorDestroy):
(WebCore::InspectorFrontendSettingsEfl::getProperty):
(WebCore::InspectorFrontendSettingsEfl::setProperty):
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::getPluginInfo):
* ewk/ewk_auth_soup.cpp:
(ewk_auth_soup_dialog_class_init):
(ewk_auth_soup_dialog_init):
(ewk_auth_soup_dialog_session_feature_init):
(session_authenticate):
* ewk/ewk_file_chooser.cpp:
(ewk_file_chooser_allows_directory_upload_get):
* ewk/ewk_frame.cpp:
(ewk_frame_feed_focus_out):
(ewk_frame_view_state_save):
(ewk_frame_plugin_create):
* ewk/ewk_js.cpp:
(ewk_js_object_new):
(ewk_js_object_free):
(ewk_js_object_view_get):
(ewk_js_object_properties_get):
(ewk_js_object_name_get):
(ewk_js_object_invoke):
(ewk_js_object_type_get):
(ewk_js_object_type_set):
(ewk_js_variant_free):
(ewk_js_variant_array_free):
* ewk/ewk_tiled_model.cpp:
(tile_account):
(_ewk_tile_account_allocated):
(_ewk_tile_account_freed):
* ewk/ewk_view.cpp:
(_ewk_view_smart_add_console_message):
(_ewk_view_smart_run_javascript_alert):
(_ewk_view_smart_run_javascript_confirm):
(_ewk_view_smart_should_interrupt_javascript):
(_ewk_view_smart_run_javascript_prompt):
(_ewk_view_smart_move):
(_ewk_view_smart_contents_resize):
(_ewk_view_editor_command_string_get):
(ewk_view_popup_new):
(ewk_view_js_object_add):
(ewk_view_accelerated_compositing_object_create):
(ewk_view_accelerated_compositing_context_get):
(ewk_view_setting_web_audio_get):
(ewk_view_setting_web_audio_set):
* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_bg_color_set):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_updates_process_pre):
(_ewk_view_tiled_contents_size_changed_cb):
(_ewk_view_tiled_smart_bg_color_set):
2012-09-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r128995.
http://trac.webkit.org/changeset/128995
https://bugs.webkit.org/show_bug.cgi?id=97114
Causes the api tests to segfault. (Requested by rakuco on
#webkit).
* tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::init):
(EWKUnitTests::EWKTestBase::shutdownAll):
(EWKUnitTests::EWKTestBase::startTest):
(EWKUnitTests::EWKTestBase::endTest):
(EWKUnitTests::EWKTestBase::createTest):
(EWKUnitTests):
(EWKUnitTests::EWKTestBase::runTest):
* tests/UnitTestUtils/EWKTestBase.h:
(EWKUnitTests):
(EWKTestBase):
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestEcoreEvas::EWKTestEcoreEvas):
(EWKUnitTests::EWKTestEcoreEvas::evas):
(EWKUnitTests):
(EWKUnitTests::EWKTestEcoreEvas::show):
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init):
(EWKUnitTests::EWKTestView::show):
(EWKUnitTests::EWKTestView::mainFrame):
(EWKUnitTests::EWKTestView::evas):
(EWKUnitTests::EWKTestView::bindEvents):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestEcoreEvas):
(EWKUnitTests):
(EWKTestView):
* tests/test_ewk_view.cpp:
(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):
* tests/test_runner.cpp:
(main):
2012-09-19 Krzysztof Czech <k.czech@samsung.com>
[EFL][UT] Refactoring an implementation of testing framework for wk1.
https://bugs.webkit.org/show_bug.cgi?id=94925
Reviewed by Gyuyoung Kim.
The reason of changing, was to adjust current implementation to use gtest features
related to cleaning (SetUp, TearDown), cleaning code in terms of useless methods
and lastly to make framework easier to use.
* tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::EWKTestBase): Added to initialize test view.
(EWKUnitTests::EWKTestBase::webView): Returns current webview.
(EWKUnitTests::EWKTestBase::SetUp):
Before test is started, SetUp is called.
Used this to initialize efl and test view.
(EWKUnitTests::EWKTestBase::TearDown):
TearDown is called as soon as test is completed.
Used this to properly shutdown efl and clean test view.
(EWKUnitTests::EWKTestBase::onLoadFinished):
(EWKUnitTests::EWKTestBase::waitUntilLoadFinished): It waits till test page will be properly loaded.
(EWKUnitTests::EWKTestBase::loadUrl): Starts loading test page.
* tests/UnitTestUtils/EWKTestBase.h:
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init): Initialize test view.
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):
* tests/test_ewk_view.cpp:
(TEST_F):
* tests/test_runner.cpp:
(main):
2012-09-19 Christophe Dumez <christophe.dumez@intel.com>
[EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
https://bugs.webkit.org/show_bug.cgi?id=97100
Reviewed by Gyuyoung Kim.
Add DumpRenderTree support method to set the
'WebKitCSSRegionsEnabled' preference.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSRegionsEnabled):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2012-09-13 Kenneth Rohde Christiansen <kenneth@webkit.org>
Evas_Object* is a ref'ed structure, so tread it as such
https://bugs.webkit.org/show_bug.cgi?id=96659
Reviewed by Adam Barth.
Replace OwnPtr<Evas_Object> with RefPtr.
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):
2012-09-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed, rolling out r128507.
http://trac.webkit.org/changeset/128507
https://bugs.webkit.org/show_bug.cgi?id=96659
Revert. r128507 makes too many crashes in EFL layout test bots.
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):
2012-09-13 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Remove a lot of C'ism from Ewk_Tiled_Matrix
https://bugs.webkit.org/show_bug.cgi?id=96638
Reviewed by Gyuyoung Kim.
Remove a lot of C'ism from Ewk_Tiled_Matrix and
fix the code so that it follows coding style.
* ewk/ewk_tiled_matrix.cpp:
(_Ewk_Tile_Matrix):
(ewk_tile_matrix_entry_get):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_entry_new):
(ewk_tile_matrix_invalidate):
(ewk_tile_matrix_free):
(ewk_tile_matrix_resize):
(ewk_tile_matrix_size_get):
(ewk_tile_matrix_unused_cache_get):
(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_exact_exists):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_put):
(ewk_tile_matrix_tile_updates_clear):
(_ewk_tile_matrix_slicer_setup):
(ewk_tile_matrix_update):
(ewk_tile_matrix_updates_process):
(ewk_tile_matrix_updates_clear):
(ewk_tile_matrix_dbg):
(ewk_tile_matrix_freeze):
(ewk_tile_matrix_thaw):
* ewk/ewk_tiled_matrix_private.h:
2012-09-13 Kenneth Rohde Christiansen <kenneth@webkit.org>
Evas_Object* is a ref'ed structure, so tread it as such
https://bugs.webkit.org/show_bug.cgi?id=96659
Reviewed by Adam Barth.
Replace OwnPtr<Evas_Object> with RefPtr.
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):
2012-09-13 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Remove a lot of C'ism from Ewk_Tiled_Backing_Store
https://bugs.webkit.org/show_bug.cgi?id=96631
Reviewed by Kenneth Rohde Christiansen.
Remove a lot of C'ism from Ewk_Tiled_Backing_Store and
fix coding style.
* ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_updates_process):
(_ewk_tiled_backing_store_flush):
(_ewk_tiled_backing_store_tile_new):
(_ewk_tiled_backing_store_item_resize):
(_ewk_tiled_backing_store_tile_associate):
(_ewk_tiled_backing_store_tile_dissociate):
(_ewk_tiled_backing_store_tile_dissociate_all):
(_ewk_tiled_backing_store_pre_render_request_add):
(_ewk_tiled_backing_store_pre_render_request_del):
(_ewk_tiled_backing_store_pre_render_request_first):
(_ewk_tiled_backing_store_pre_render_request_clear):
(_ewk_tiled_backing_store_pre_render_request_process_single):
(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_disable_render):
(_ewk_tiled_backing_store_enable_render):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
(_ewk_tiled_backing_store_item_smooth_scale_set):
(_ewk_tiled_backing_store_changed):
(_ewk_tiled_backing_store_view_cols_end_del):
(_ewk_tiled_backing_store_view_cols_end_add):
(_ewk_tiled_backing_store_view_row_del):
(_ewk_tiled_backing_store_view_rows_range_del):
(_ewk_tiled_backing_store_view_rows_all_del):
(_ewk_tiled_backing_store_smart_member_del):
(_ewk_tiled_backing_store_smart_member_add):
(_ewk_tiled_backing_store_mem_dbg):
(_ewk_tiled_backing_store_sig_usr):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_del):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_smart_calculate_size):
(_ewk_tiled_backing_store_view_dbg):
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_wrap_right):
(_ewk_tiled_backing_store_view_refill):
(_ewk_tiled_backing_store_view_pos_apply):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(_ewk_tiled_backing_store_smart_calculate_pos):
(_ewk_tiled_backing_store_fill_renderers):
(_ewk_tiled_backing_store_smart_calculate):
(ewk_tiled_backing_store_render_cb_set):
(ewk_tiled_backing_store_tile_unused_cache_get):
(_ewk_tiled_backing_store_scroll_full_offset_set_internal):
(ewk_tiled_backing_store_scroll_full_offset_set):
(ewk_tiled_backing_store_scroll_full_offset_add):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_set):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_fix_offsets):
(ewk_tiled_backing_store_zoom_weak_smooth_scale_set):
(ewk_tiled_backing_store_alpha_set):
(ewk_tiled_backing_store_update):
(ewk_tiled_backing_store_updates_process_pre_set):
(ewk_tiled_backing_store_updates_process_post_set):
(ewk_tiled_backing_store_disabled_update_set):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_tile_add):
(ewk_tiled_backing_store_pre_render_spiral_queue):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):
(ewk_tiled_backing_store_pre_render_cancel):
(ewk_tiled_backing_store_disable_render):
(ewk_tiled_backing_store_enable_render):
* ewk/ewk_tiled_backing_store_private.h:
(_Ewk_Tile_Stats):
(_Ewk_Tile):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_render_cb):
(_ewk_view_tiled_smart_backing_store_add):
2012-09-13 Kenneth Rohde Christiansen <kenneth@webkit.org>
[EFL][DRT] Implement LayoutTestController::layerTreeAsText
https://bugs.webkit.org/show_bug.cgi?id=82294
Reviewed by Gyuyoung Kim.
Add a support method for getting layerTreeAsText.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::layerTreeAsText):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r127876.
http://trac.webkit.org/changeset/127876
https://bugs.webkit.org/show_bug.cgi?id=96600
mouse click doesn't work for spin button if spin button in
iframe (Requested by yosin on #webkit).
* ewk/ewk_frame.cpp:
(ewk_frame_hit_test_new):
2012-09-12 KyungTae Kim <ktf.kim@samsung.com>
[EFL] Support download attribute feature
https://bugs.webkit.org/show_bug.cgi?id=96462
Reviewed by Gyuyoung Kim.
Add suggested_name field on _Ewk_Download and set it on startDownload
to get suggested name passed as a download attribute.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::download):
(WebCore::FrameLoaderClientEfl::startDownload):
* ewk/ewk_view.h:
2012-09-10 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Create a toggle button for closed captions
https://bugs.webkit.org/show_bug.cgi?id=96259
Reviewed by Kenneth Rohde Christiansen.
Add closed caption toggling button to default WebKitEFL
theme.
* DefaultTheme/default.edc:
* DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption.png: Added.
* DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption_disabled.png: Added.
* DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc: Added.
2012-09-09 Emil A Eklund <eae@chromium.org>
Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
https://bugs.webkit.org/show_bug.cgi?id=81413
Reviewed by David Hyatt.
Update ewk_frame to call pixelSnappedBoundingBox.
* ewk/ewk_frame.cpp:
(ewk_frame_focused_element_geometry_get):
2012-09-07 Benjamin Poulain <bpoulain@apple.com>
Rename the ustring() accessor to string()
https://bugs.webkit.org/show_bug.cgi?id=95919
Reviewed by Geoffrey Garen.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::sendWebIntentResponse):
(DumpRenderTreeSupportEfl::deliverWebIntent):
Aslo update the code from the UString->String conversion through StringImpl.
2012-09-07 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Use same default minimum logical font size in DRT and WTR
https://bugs.webkit.org/show_bug.cgi?id=96116
Reviewed by Martin Robinson.
Add DRT helper function to set the minimum logical
font size setting.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setMinimumLogicalFontSize):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720
Reviewed by Antonio Gomes.
Update calls to new API.
* ewk/ewk_frame.cpp:
(ewk_frame_hit_test_new):
2012-09-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed, rolling out r127839.
http://trac.webkit.org/changeset/127839
https://bugs.webkit.org/show_bug.cgi?id=90603
This patch was landed with wrong implementation and policy.
* WebCoreSupport/NotificationPresenterClientEfl.cpp:
(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):
* WebCoreSupport/NotificationPresenterClientEfl.h:
(NotificationPresenterClientEfl):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:
2012-09-07 Kihong Kwon <kihong.kwon@samsung.com>
[EFL] Support the permission function of the Web Notification.
https://bugs.webkit.org/show_bug.cgi?id=90603
Reviewed by Gyuyoung Kim.
Implement permission related functions of Web Notifications.
checkPermission for Notification.permissionLevel().
requestPermission for Notification.requestPermission().
In addition, if the application(like a browser) has permitted domains already,
it can be cached using ewk_view_notification_permissions_store.
* WebCoreSupport/NotificationPresenterClientEfl.cpp:
(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::addToPermissionCache):
(WebCore):
(WebCore::NotificationPresenterClientEfl::setPermission):
* WebCoreSupport/NotificationPresenterClientEfl.h:
(WebCore):
(NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_notification_permission_store):
(ewk_view_notification_permissions_set):
(ewk_view_notification_permission_request):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:
2012-09-05 Sam Weinig <sam@webkit.org>
Part 2 of removing PlatformString.h, remove PlatformString.h
https://bugs.webkit.org/show_bug.cgi?id=95931
Reviewed by Adam Barth.
Remove PlatformString.h
* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/InspectorClientEfl.cpp:
2012-09-06 Kangil Han <kangil.han@samsung.com>
[EFL] Remove unnecessary logic in ewk_frame_source_get.
https://bugs.webkit.org/show_bug.cgi?id=95828
Reviewed by Kenneth Rohde Christiansen.
Removed unnecessary logic that checks if <html> tag exists in document.
WebKit automatically fill out <html></html> tags if they are not existed.
* ewk/ewk_frame.cpp:
(ewk_frame_source_get):
2012-09-05 Kangil Han <kangil.han@samsung.com>
[EFL] Remove '+=' usage in String
https://bugs.webkit.org/show_bug.cgi?id=95808
Reviewed by Benjamin Poulain.
Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
* ewk/ewk_frame.cpp:
(ewk_frame_source_get): Removed unnecessary strlen usage.
2012-09-05 Kaustubh Atrawalkar <kaustubh@motorola.com>
[DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
https://bugs.webkit.org/show_bug.cgi?id=92735
Reviewed by Hajime Morita.
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
2012-09-04 Michał Pakuła vel Rutka <m.pakula@samsung.com>
[EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179
Reviewed by Gyuyoung Kim.
Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.
* WebCoreSupport/ContextMenuClientEfl.cpp: Added.
(WebCore):
(WebCore::ContextMenuClientEfl::contextMenuDestroyed):
(WebCore::ContextMenuClientEfl::getCustomMenuFromDefaultItems):
(WebCore::ContextMenuClientEfl::contextMenuItemSelected):
(WebCore::ContextMenuClientEfl::downloadURL):
(WebCore::ContextMenuClientEfl::lookUpInDictionary):
(WebCore::ContextMenuClientEfl::speak):
(WebCore::ContextMenuClientEfl::isSpeaking):
(WebCore::ContextMenuClientEfl::stopSpeaking):
(WebCore::ContextMenuClientEfl::searchWithGoogle):
* WebCoreSupport/ContextMenuClientEfl.h: Added.
(WebCore):
(ContextMenuClientEfl):
* ewk/ewk_contextmenu.cpp: Removed ewk_context_menu_customize implementation.
(ewk_context_menu_destroy): Added freeing context menu.
(ewk_context_menu_new): Added filling ewk_contextmenu list.
(ewk_context_menu_item_append):
* ewk/ewk_contextmenu_private.h: Removed ewk_context_menu_customize and changed ewk_context_menu_new definition.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(ewk_view_context_menu_forward_event):
2012-09-04 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Drop default theme concept
https://bugs.webkit.org/show_bug.cgi?id=94778
Reviewed by Gyuyoung Kim.
* ewk/ewk_view.h:
Updated doxygen document not to mention default theme.
2012-09-03 Jinwoo Song <jinwoo7.song@samsung.com>
[EFL] Fix e_dbus_shutdown() error when exiting the Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=95636
Reviewed by Gyuyoung Kim.
Invoke stopUpdating() in the destructor of BatteryClinetEfl()
to call e_ukit_shutdown() and e_dbus_shutdown() if and when
stopUpdating() has not been called explicitly.
* WebCoreSupport/BatteryClientEfl.cpp:
(BatteryClientEfl::~BatteryClientEfl):
* WebCoreSupport/BatteryClientEfl.h:
(BatteryClientEfl):
2012-09-03 Jinwoo Song <jinwoo7.song@samsung.com>
[EFL] Use WebKitVersion.h to get version information
https://bugs.webkit.org/show_bug.cgi?id=95669
Reviewed by Gyuyoung Kim.
Use WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION
in the WebKitVersion.h
Relocate the StorageTracker.h to keep the sorted order.
* ewk/ewk_settings.cpp:
(ewk_settings_default_user_agent_get):
2012-09-01 Jinwoo Song <jinwoo7.song@samsung.com>
[EFL] Refactoring the DumpRenderTreeSupportEfl
https://bugs.webkit.org/show_bug.cgi?id=95544
Reviewed by Gyuyoung Kim.
There are lots of repeated codes for getting the WebCore::Frame
and WebCore::Page. To reduce these duplications, simple macros
are added.
No new tests, just refactoring.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::activeAnimationsCount):
(DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
(DumpRenderTreeSupportEfl::clearFrameName):
(DumpRenderTreeSupportEfl::clearOpener):
(DumpRenderTreeSupportEfl::elementDoesAutoCompleteForElementWithId):
(DumpRenderTreeSupportEfl::frameChildren):
(DumpRenderTreeSupportEfl::frameParent):
(DumpRenderTreeSupportEfl::layoutFrame):
(DumpRenderTreeSupportEfl::numberOfPages):
(DumpRenderTreeSupportEfl::pageSizeAndMarginsInPixels):
(DumpRenderTreeSupportEfl::pageProperty):
(DumpRenderTreeSupportEfl::pauseAnimation):
(DumpRenderTreeSupportEfl::pauseTransition):
(DumpRenderTreeSupportEfl::pendingUnloadEventCount):
(DumpRenderTreeSupportEfl::renderTreeDump):
(DumpRenderTreeSupportEfl::responseMimeType):
(DumpRenderTreeSupportEfl::selectionRectangle):
(DumpRenderTreeSupportEfl::suitableDRTFrameName):
(DumpRenderTreeSupportEfl::setDefersLoading):
(DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting):
(DumpRenderTreeSupportEfl::addUserScript):
(DumpRenderTreeSupportEfl::clearUserScripts):
(DumpRenderTreeSupportEfl::addUserStyleSheet):
(DumpRenderTreeSupportEfl::clearUserStyleSheets):
(DumpRenderTreeSupportEfl::executeCoreCommandByName):
(DumpRenderTreeSupportEfl::findString):
(DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled):
(DumpRenderTreeSupportEfl::isCommandEnabled):
(DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled):
(DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled):
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportEfl::globalContextRefForFrame):
(DumpRenderTreeSupportEfl::setInteractiveFormValidationEnabled):
(DumpRenderTreeSupportEfl::setValidationMessageTimerMagnification):
(DumpRenderTreeSupportEfl::setAuthorAndUserStylesEnabled):
(DumpRenderTreeSupportEfl::setComposition):
(DumpRenderTreeSupportEfl::hasComposition):
(DumpRenderTreeSupportEfl::compositionRange):
(DumpRenderTreeSupportEfl::confirmComposition):
(DumpRenderTreeSupportEfl::firstRectForCharacterRange):
(DumpRenderTreeSupportEfl::selectedRange):
2012-08-31 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Add proper support for navigator.onLine and associated events
https://bugs.webkit.org/show_bug.cgi?id=95532
Reviewed by Kenneth Rohde Christiansen.
Remove ewk_network_state_notifier_online_set() API since
the EFL port no longer relies on the client application to
provide it with the online state.
* ewk/ewk_network.cpp:
* ewk/ewk_network.h:
2012-08-31 Jinwoo Song <jinwoo7.song@samsung.com>
[EFL] Simplify FrameLoaderClinetEfl by adding a private method.
https://bugs.webkit.org/show_bug.cgi?id=95444
Reviewed by Gyuyoung Kim.
In the FrameLoaderClientEfl, the codes which checks that
if current frame is main frame are frequently used.
This patch adds a private method and replaces those codes
with the method to simplify.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidChangeLocationWithinPage):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveIcon):
(WebCore::FrameLoaderClientEfl::dispatchDidStartProvisionalLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveTitle):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailProvisionalLoad):
(WebCore::FrameLoaderClientEfl::transitionToCommittedForNewPage):
* WebCoreSupport/FrameLoaderClientEfl.h:
(WebCore::FrameLoaderClientEfl::isLoadingMainFrame):
2012-08-30 Benjamin Poulain <bpoulain@apple.com>
Replace JSC::UString by WTF::String
https://bugs.webkit.org/show_bug.cgi?id=95271
Reviewed by Geoffrey Garen.
Replace UString by String.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::sendWebIntentResponse):
* ewk/ewk_frame.cpp:
(ewk_frame_script_execute):
2012-08-29 Kamil Blank <k.blank@samsung.com>
[EFL] Add setting API for allow universal/file access from file URLs.
https://bugs.webkit.org/show_bug.cgi?id=83121
Reviewed by Eric Seidel.
Make it possible to enable allow universal/file access from file URLs.
Default value for both settings is true.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_allow_universal_access_from_file_urls_set): Function sets if locally loaded documents
are allowed to access remote urls.
(ewk_view_setting_allow_universal_access_from_file_urls_get):
(ewk_view_setting_allow_file_access_from_file_urls_set): Function sets if locally loaded documents
are allowed to access other local urls.
(ewk_view_setting_allow_file_access_from_file_urls_get):
* ewk/ewk_view.h:
2012-08-29 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Add *explicit* keyword to constructors in WebCoreSupport
https://bugs.webkit.org/show_bug.cgi?id=95307
Reviewed by Kentaro Hara.
Added explicit keyword in constructors in order to avoid implicit type conversion.
* WebCoreSupport/ColorChooserEfl.h:
(ColorChooserEfl):
* WebCoreSupport/PopupMenuEfl.h:
(PopupMenuEfl):
* WebCoreSupport/SearchPopupMenuEfl.h:
(SearchPopupMenuEfl):
2012-08-29 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Move several files to remove webkit1 dependency from WebCore.
https://bugs.webkit.org/show_bug.cgi?id=95264
Reviewed by Gyuyoung Kim.
ColorChooserEfl.cpp, PopupMenuEfl.cpp and SearchPopupMenuEfl.cpp are WebKit1/Efl
specific files and they can not be shared with WebKit2/Efl.
In order to remove WebKit dependency from WebCore, this patch moves them
to WebKit/efl/WebCoreSupport.
* WebCoreSupport/ColorChooserEfl.cpp: Renamed from Source/WebCore/platform/efl/ColorChooserEfl.cpp.
(WebCore):
(WebCore::ColorChooserEfl::ColorChooserEfl):
(WebCore::ColorChooserEfl::~ColorChooserEfl):
(WebCore::ColorChooserEfl::setSelectedColor):
(WebCore::ColorChooserEfl::endChooser):
* WebCoreSupport/ColorChooserEfl.h: Renamed from Source/WebCore/platform/efl/ColorChooserEfl.h.
(WebCore):
(ColorChooserEfl):
* WebCoreSupport/PopupMenuEfl.cpp: Renamed from Source/WebCore/platform/efl/PopupMenuEfl.cpp.
(WebCore):
(WebCore::PopupMenuEfl::PopupMenuEfl):
(WebCore::PopupMenuEfl::~PopupMenuEfl):
(WebCore::PopupMenuEfl::show):
(WebCore::PopupMenuEfl::hide):
(WebCore::PopupMenuEfl::updateFromElement):
(WebCore::PopupMenuEfl::disconnectClient):
* WebCoreSupport/PopupMenuEfl.h: Renamed from Source/WebCore/platform/efl/PopupMenuEfl.h.
(WebCore):
(PopupMenuEfl):
(WebCore::PopupMenuEfl::client):
* WebCoreSupport/SearchPopupMenuEfl.cpp: Renamed from Source/WebCore/platform/efl/SearchPopupMenuEfl.cpp.
(WebCore):
(WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
(WebCore::SearchPopupMenuEfl::popupMenu):
(WebCore::SearchPopupMenuEfl::saveRecentSearches):
(WebCore::SearchPopupMenuEfl::loadRecentSearches):
(WebCore::SearchPopupMenuEfl::enabled):
* WebCoreSupport/SearchPopupMenuEfl.h: Renamed from Source/WebCore/platform/efl/SearchPopupMenuEfl.h.
(WebCore):
(SearchPopupMenuEfl):
2012-08-28 Seokju Kwon <seokju.kwon@samsung.com>
[EFL] Add support for localization to the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=92961
Reviewed by Gyuyoung Kim.
Implement InspectorFrontendClientEfl::localizedStringsURL()
to return the URL of the localizedStrings.js.
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::openInspectorFrontend):
(WebCore::InspectorClientEfl::inspectorFilesPath):
(WebCore::InspectorFrontendClientEfl::localizedStringsURL):
2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r126914.
http://trac.webkit.org/changeset/126914
https://bugs.webkit.org/show_bug.cgi?id=95239
it breaks everything and fixes nothing (Requested by pizlo on
#webkit).
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::getPluginInfo):
* ewk/ewk_intent.cpp:
(ewk_intent_extra_get):
2012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784
Reviewed by Eric Seidel.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::getPluginInfo):
* ewk/ewk_intent.cpp:
(ewk_intent_extra_get):
2012-08-28 Christophe Dumez <christophe.dumez@intel.com>
[EFL] WebKit EFL updates view on HTTP 204 response
https://bugs.webkit.org/show_bug.cgi?id=95199
Reviewed by Kenneth Rohde Christiansen.
Ignore HTTP responses which have status code equal
to 204 (No Content).
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):
2012-08-28 Thiago Marcos P. Santos <thiago.santos@intel.com>
[EFL] Rename knob images to thumb on the default theme
https://bugs.webkit.org/show_bug.cgi?id=95186
Reviewed by Kenneth Rohde Christiansen.
WebKit reefers to these handles as thumb instead of knob. Let's make
it coherent on EFL.
* DefaultTheme/widget/slider/slider.edc:
* DefaultTheme/widget/slider/slider_thumb_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_h.png.
* DefaultTheme/widget/slider/slider_thumb_press_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_press_h.png.
* DefaultTheme/widget/slider/slider_thumb_press_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_press_v.png.
* DefaultTheme/widget/slider/slider_thumb_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_knob_v.png.
2012-08-28 Thiago Marcos P. Santos <thiago.santos@intel.com>
[EFL] Range input ignores padding
https://bugs.webkit.org/show_bug.cgi?id=94595
Reviewed by Kenneth Rohde Christiansen.
Updated default theme to paint the slider thumb in a different step.
This was done by splitting the thumb into a separated group.
* DefaultTheme/widget/slider/slider.edc:
2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r126836.
http://trac.webkit.org/changeset/126836
https://bugs.webkit.org/show_bug.cgi?id=95163
Broke all Apple ports, EFL, and Qt. (Requested by tkent on
#webkit).
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::getPluginInfo):
* ewk/ewk_intent.cpp:
(ewk_intent_extra_get):
2012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784
Reviewed by Eric Seidel.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::getPluginInfo):
* ewk/ewk_intent.cpp:
(ewk_intent_extra_get):
2012-08-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Rename RegisterProtocolHandler API to NavigatorContentUtils
https://bugs.webkit.org/show_bug.cgi?id=94920
Reviewed by Adam Barth.
Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
RegisterProtocolHandlerClientEfl is renamed to NavigatorContentUtilsClientEfl.
* WebCoreSupport/NavigatorContentUtilsClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp.
(WebCore):
(WebCore::customHandlerDataCreate):
(WebCore::customHandlerDataDelete):
(WebCore::NavigatorContentUtilsClientEfl::create):
(WebCore::NavigatorContentUtilsClientEfl::NavigatorContentUtilsClientEfl):
(WebCore::NavigatorContentUtilsClientEfl::registerProtocolHandler):
(WebCore::NavigatorContentUtilsClientEfl::isProtocolHandlerRegistered):
(WebCore::NavigatorContentUtilsClientEfl::unregisterProtocolHandler):
* WebCoreSupport/NavigatorContentUtilsClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/RegisterProtocolHandlerClientEfl.h.
(NavigatorContentUtilsClientEfl):
(WebCore::NavigatorContentUtilsClientEfl::~NavigatorContentUtilsClientEfl):
* ewk/ewk_custom_handler.cpp:
* ewk/ewk_custom_handler_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
2012-08-23 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Remove ewk_tile_matrix_tile_update.
https://bugs.webkit.org/show_bug.cgi?id=63437
Reviewed by Gyuyoung Kim.
* ewk/ewk_tiled_matrix.cpp:
Removed ewk_tile_matrix_tile_update and ewk_tile_matrix_tile_update_full
which are dead code.
* ewk/ewk_tiled_matrix_private.h: Ditto.
2012-08-21 Kihong Kwon <kihong.kwon@samsung.com>
[EFL][GTK][BlackBerry] Fix build error in the DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=94586
Reviewed by Kentaro Hara.
Fix build error in the DeviceOrientationClientEfl.cpp.
It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.
* WebCoreSupport/DeviceOrientationClientEfl.cpp:
(WebCore::DeviceOrientationClientEfl::lastOrientation):
2012-08-20 Thiago Marcos P. Santos <thiago.santos@intel.com>
Regression(r124945): Build is broken when touch events is disabled
https://bugs.webkit.org/show_bug.cgi?id=94466
Reviewed by Kenneth Rohde Christiansen.
Added missing guards around touch events code.
* ewk/ewk_touch_event.cpp:
* ewk/ewk_touch_event_private.h:
2012-08-17 Thiago Marcos P. Santos <thiago.santos@intel.com>
[EFL] Change font family/script on layout tests causes flakiness
https://bugs.webkit.org/show_bug.cgi?id=94327
Reviewed by Kenneth Rohde Christiansen.
Always set the font on WebCore even if the font family is the same. It
has to be done because the script value might have also changed.
Settings::set*FontFamily() has an implicit UScriptCode
parameter that will set the script back to the defaults.
* ewk/ewk_view.cpp:
(ewk_view_font_family_name_set):
2012-08-14 Adam Barth <abarth@webkit.org>
Delete Frame::domWindow() and Frame::existingDOMWindow()
https://bugs.webkit.org/show_bug.cgi?id=93990
Reviewed by Eric Seidel.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::pendingUnloadEventCount):
* ewk/ewk_frame.cpp:
(ewk_frame_intent_deliver):
2012-08-13 Tom Sepez <tsepez@chromium.org>
[chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
https://bugs.webkit.org/show_bug.cgi?id=93283
Reviewed by Eric Seidel.
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::redirectDataToPlugin):
2012-08-12 Krzysztof Czech <k.czech@samsung.com>
[EFL][UT] Delete shutdown method.
https://bugs.webkit.org/show_bug.cgi?id=90785
Reviewed by Eric Seidel.
EWKTestBase class already has a shutdownAll method that can be used instead of shutdown.
* tests/UnitTestUtils/EWKTestBase.cpp:
* tests/UnitTestUtils/EWKTestBase.h:
(EWKTestBase):
2012-08-09 Carlos Garcia Campos <cgarcia@igalia.com>
Handle SSL errors for SOUP
https://bugs.webkit.org/show_bug.cgi?id=90267
Reviewed by Martin Robinson.
Ignore SSL errors by default for compatibility.
* ewk/ewk_main.cpp:
(_ewk_init_body):
2012-08-07 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Remove PlatformTouchEventEfl and PlatformTouchPointEfl
https://bugs.webkit.org/show_bug.cgi?id=93270
Reviewed by Eric Seidel.
* ewk/ewk_frame.cpp:
(ewk_frame_feed_touch_event):
* ewk/ewk_touch_event.cpp: Added.
(WebKitPlatformTouchPoint):
(WebKitPlatformTouchPoint::WebKitPlatformTouchPoint):
Added to initialize members of PlatformTouchPoint.
(WebKitPlatformTouchEvent):
(WebKitPlatformTouchEvent::WebKitPlatformTouchEvent):
Added to initialize members of PlatformTouchEvent.
(EWKPrivate):
(EWKPrivate::platformTouchEvent):
Converted Ewk_Touch_Event to PlatformTouchEvent.
* ewk/ewk_touch_event_private.h:
(EWKPrivate):
2012-08-07 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
CUSTOM_SCHEME_HANDLER flag should depend on REGISTER_PROTOCOL_HANDLER
https://bugs.webkit.org/show_bug.cgi?id=93081
Reviewed by Adam Barth.
CUSTOM_SCHEME_HANDLER #if guards are enclosed in the REGISTER_PROTOCOL_HANDLER guards.
* WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:
(WebCore::RegisterProtocolHandlerClientEfl::registerProtocolHandler):
* WebCoreSupport/RegisterProtocolHandlerClientEfl.h:
* ewk/ewk_custom_handler.cpp:
(ewk_custom_handler_register_protocol_handler):
* ewk/ewk_custom_handler_private.h:
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
2012-08-06 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[EFL] [GTK] Register Protocol Handler Client is never deleted
https://bugs.webkit.org/show_bug.cgi?id=92745
Reviewed by Gustavo Noronha Silva.
Added usage of OwnPtr to manage register protocol handler client pointer.
* WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:
(WebCore::RegisterProtocolHandlerClientEfl::create): Factory function returning smart pointer.
(WebCore):
* WebCoreSupport/RegisterProtocolHandlerClientEfl.h:
(RegisterProtocolHandlerClientEfl):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
2012-08-01 Ryuan Choi <ryuan.choi@samsung.com>
[EFL][Regression] Build break with NETSCAPE_PLUGIN_API after r123604
https://bugs.webkit.org/show_bug.cgi?id=92937
Unreviewed build fix.
r123604 replaced strdup to eina_stringshare, but related codes are not
changed properly.
This patch changes remained code to use eina_stringshare.
* ewk/ewk_js.cpp:
(ewk_js_variant_to_npvariant):
(ewk_js_property_free):
(ewk_js_npvariant_to_variant):
(ewk_js_variant_free):
(ewk_js_variant_array_free):
* ewk/ewk_js.h:
2012-07-29 YoungTaeck Song <youngtaeck.song@samsung.com>
[WK2][EFL] TILED_BACKING_STORE support on Efl WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91582
Reviewed by Noam Rosenthal.
Add a dummy function for fixing building error when enabling TILED_BACKING_STORE.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore):
(WebCore::ChromeClientEfl::delegatedScrollRequested):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
2012-07-27 Christophe Dumez <christophe.dumez@intel.com>
[EFL] Regression(r123858): Default navigation policy decision was switched to "reject"
https://bugs.webkit.org/show_bug.cgi?id=92507
Reviewed by Kentaro Hara.
After r92466, the default navigation policy is to reject the request if the
client does not make a decision explicitly. The default policy should be
to accept. This broke ewk_view unit tests.
* ewk/ewk_view.cpp:
(ewk_view_navigation_policy_decision):
2012-07-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
[EFL] Fix wrong return value in EWK_VIEW_XXX macro.
https://bugs.webkit.org/show_bug.cgi?id=92466
Reviewed by Simon Hausmann.
There are wrong return values in EWK_VIEW_XXX macros. The wrong return values
should be fixed. In addition, API description is also modified according to returned
value change.
* ewk/ewk_view.cpp:
(ewk_view_setting_minimum_timer_interval_get):
(ewk_view_navigation_policy_decision):
(ewk_view_page_rect_get):
(ewk_view_setting_enable_xss_auditor_get):
* ewk/ewk_view.h:
2012-07-27 Kihong Kwon <kihong.kwon@samsung.com>
[EFL] Change prototype of run_open_panel
https://bugs.webkit.org/show_bug.cgi?id=91956
Reviewed by Kentaro Hara.
In order to support all of the file chooser attributes,
change the types of parameters in run_open_panel method.
i.e., change "Eina_Bool allows_multiple_files, Eina_List *accept_types"
to "Ewk_File_Chooser *file_chooser"
In addition, Efl can support the capture attribute for HTML media capture.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::runOpenPanel):
* ewk/ewk_view.cpp:
(ewk_view_run_open_panel):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:
2012-07-26 Seokju Kwon <seokju.kwon@samsung.com>
[EFL] Highlight the element under mouse on web inspector
https://bugs.webkit.org/show_bug.cgi?id=91592
Reviewed by Kentaro Hara.
Implement highlighting the nodes when using the web inspector.
* WebCoreSupport/InspectorClientEfl.cpp:
(WebCore::InspectorClientEfl::highlight):
(WebCore::InspectorClientEfl::hideHighlight):
(WebCore::InspectorClientEfl::invalidateView):
(WebCore):
* WebCoreSupport/InspectorClientEfl.h:
(InspectorClientEfl):
* ewk/ewk_paint_context.cpp:
(ewk_paint_context_paint_contents):
2012-07-26 Christophe Dumez <christophe.dumez@intel.com>
[EFL][WK2] Implement Network Information provider
https://bugs.webkit.org/show_bug.cgi?id=92343
Reviewed by Kenneth Rohde Christiansen.
Make NetworkInfoClientEfl use NetworkInfoProviderEfl
from WebCore to avoid code duplication with WebKit2.
* WebCoreSupport/NetworkInfoClientEfl.cpp:
(WebCore::NetworkInfoClientEfl::startUpdating):
(WebCore::NetworkInfoClientEfl::stopUpdating):
(WebCore::NetworkInfoClientEfl::bandwidth):
(WebCore::NetworkInfoClientEfl::metered):
(WebCore):
* WebCoreSupport/NetworkInfoClientEfl.h:
(WebCore):
(NetworkInfoClientEfl):
2012-07-26 Zoltan Nyul <zoltan.nyul@intel.com>
[EFL] EFL port should use XDG paths
https://bugs.webkit.org/show_bug.cgi?id=91719
Reviewed by Kenneth Rohde Christiansen.
Using xdg paths instead of home/.webkit directory for application
cache, web-database and local-storage.