)]}' { "commit": "b03323c1d9901ecafc4bcaf75d3e8afd2aaf9b6c", "tree": "93fcf86a88d988efabde4b2fd8f0472ea53420fa", "parents": [ "93db14575cd0b2fded108158cbb31c08177064f5" ], "author": { "name": "Eric Biggers", "email": "ebiggers@google.com", "time": "Sat Apr 30 19:21:30 2022" }, "committer": { "name": "Zorro Lang", "email": "zlang@kernel.org", "time": "Tue May 10 14:55:18 2022" }, "message": "ext4/053: fix the rejected mount option testing\n\n\u0027not_mnt OPTIONS\u0027 seems to have been intended to test that the\nfilesystem cannot be mounted at all with the given OPTIONS, meaning that\nthe mount fails as opposed to the options being ignored. However, this\ndoesn\u0027t actually work, as shown by the fact that the test case \u0027not_mnt\ntest_dummy_encryption\u003dv3\u0027 is passing in the !CONFIG_FS_ENCRYPTION case.\nActually ext4 ignores this mount option when !CONFIG_FS_ENCRYPTION.\n(The ext4 behavior might be changed, but that is besides the point.)\n\nThe problem is that the do_mnt() helper function is being misused in a\ncontext where a mount failure is expected, and it does some additional\nremount tests that don\u0027t make sense in that context. So if the mount\nunexpectedly succeeds, then one of these later tests can still \"fail\",\ncausing the unexpected success to be shadowed by a later failure, which\ncauses the overall test case to pass since it expects a failure.\n\nFix this by reworking not_mnt() and not_remount_noumount() to use\nsimple_mount() in cases where they are expecting a failure. Also fix\nup some of the naming and calling conventions to be less confusing.\nFinally, make sure to test that remounting fails too, not just mounting.\n\nSigned-off-by: Eric Biggers \u003cebiggers@google.com\u003e\nReviewed-by: Lukas Czerner \u003clczerner@redhat.com\u003e\nSigned-off-by: Zorro Lang \u003czlang@kernel.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "e1e7959268d17c3278ac2801a8be90b5234e1227", "old_mode": 33261, "old_path": "tests/ext4/053", "new_id": "bf6e3f6b4050ad9179d24235f698c6e13dbccb82", "new_mode": 33261, "new_path": "tests/ext4/053" } ] }