i#2600: fix race between detach and new thread (#2602)

Adds a counter uninit_thread_count which is incremented in UNIX just prior
to a new thread being created.  Synchall will keep looping while this
counter is positive, ensuring we avoid races with threads created but not
yet initialized during a detach synchall which then use DR resources after
detach, causing crashes.

Leaves the counter at 0 on Windows where we can't distinguish external vs
internal thread creation, but Windows does have the init_apc_go_native flag
which eliminates some races.

Adds a test.  To more reliably hit the race (about half the time) I locally
added a 50ms sleep at the top of dynamo_thread_init().

Fixes #2600
8 files changed
tree: 9137894f105b52f010bccf6cc071c384709791dd
  1. api/
  2. clients/
  3. core/
  4. ext/
  5. libutil/
  6. make/
  7. suite/
  8. third_party/
  9. tools/
  10. .appveyor.yml
  11. .travis.yml
  12. ACKNOWLEDGEMENTS
  13. CMakeLists.txt
  14. CONTRIBUTING.md
  15. CTestConfig.cmake
  16. License.txt
  17. README
  18. README.md
README.md

DynamoRIO

DynamoRIO logo

About DynamoRIO

DynamoRIO is a runtime code manipulation system that supports code transformations on any part of a program, while it executes. DynamoRIO exports an interface for building dynamic tools for a wide variety of uses: program analysis and understanding, profiling, instrumentation, optimization, translation, etc. Unlike many dynamic tool systems, DynamoRIO is not limited to insertion of callouts/trampolines and allows arbitrary modifications to application instructions via a powerful IA-32/AMD64/ARM/AArch64 instruction manipulation library. DynamoRIO provides efficient, transparent, and comprehensive manipulation of unmodified applications running on stock operating systems (Windows, Linux, or Android) and commodity IA-32, AMD64, ARM, and AArch64 hardware. Mac OSX support is in progress.

Existing DynamoRIO-based tools

Tools built on DynamoRIO include:

Building your own custom tools

DynamoRIO‘s powerful API abstracts away the details of the underlying infrastructure and allows the tool builder to concentrate on analyzing or modifying the application’s runtime code stream. API documentation is included in the release package and can also be browsed online. Slides from our past tutorials are also available.

Downloading DynamoRIO

DynamoRIO is available free of charge as a binary package for both Windows and Linux. DynamoRIO's source code is available under a BSD license.

Obtaining Help

Use the discussion list to ask questions.

To report a bug, use the issue tracker.

See also the DynamoRIO home page: http://dynamorio.org/