commit | 700d2e19ba83d03a8699d69e86e1e830388b1409 | [log] [tgz] |
---|---|---|
author | Pavel Shmakov <pshmakov@google.com> | Tue Apr 30 13:26:45 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu May 02 10:35:54 2019 |
tree | ade62806e0eee50222b32dcc60e2a323b200aeca | |
parent | 6c0621e714cd90acd271728629f86e5e8a784b97 [diff] |
Move general-purpose code out of LauncherActivity Two classes are factored out: - TwaLauncher encapsulates launching TWA, including connecting to service, etc. - PwaWrapperSplashScreenStrategy, which contains all the code managing splash screens (except for the decision of whether to show them). What remains in LauncherActivity: - Usage of TwaLauncher and SplashScreenStrategy, including destroying them. - Showing toast to update Chrome. I don't think this should be part of TwaLauncher or any other general-purpose class. - Code ensuring we finish LauncherActivity when TWA finishes. This is specific to TWA as PWA wrapper use case. - A few protected methods, such as getLaunchingUrl(). Change-Id: Ia87b24ac82710e163edb263fa94067dfc2ecb771 Reviewed-on: https://chromium-review.googlesource.com/c/custom-tabs-client/+/1581940 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Chrome Custom Tabs provides a way for an application to customize and interact with a Chrome Activity
on Android. This makes the web content feel like being a part of the application, while retaining the full functionality and performance of a complete web browser.
Using Custom Tabs should be easy. This repository hosts examples and in-depth documentation. The examples are importable as projects into the Android Studio.
We want to hear your feedback! Please create bugs and start discussions using this template. Please use the template for any issues related to the Custom Tabs APIs, their implementation in Chrome, the examples in this repository, and related functionality of the Android Support Library.
Note: we know that the GitHub issue tracker is great! However, since Custom Tabs is mostly driven by Chrome developers, and we want to keep all bugs in one place, we prefer the Chromium issue tracker at the moment.
We accept contributions to Custom Tabs examples and documentation. Please see our contributor's guide.