refactor(bigtable): 1x heartbeat + drop `active := 1` code smell
Two follow-ups after the java-bigtable heartbeat cross-check:
1) handleSessionParameters: drop 3x multiplier on nextHeartbeatDeadline
(already done in resetHeartbeatDeadline in the prior PR-2 commit).
Now 1 * interval, matching Java's SessionImpl.java:440 which sets
nextHeartbeat = now + heartbeatInterval on every reset. Wake-comment
updated to reflect the new arithmetic.
2) heartBeatLoop:
- Delete the `active := 1 // multiplex=1; kept as %d so a future >1
stays greppable` code smell. Inline `1` was documenting itself;
the variable existed only for its comment. Drop it — when
multiplex > 1 lands, the caller will read `s.activeVRPCCount()`
(or similar), not this stale scaffolding.
- `lastFrameAge = interval - remaining` (was `3*interval - remaining`)
to reflect the new 1x deadline.
- Debugf/recordEvent format strings drop the `in_flight=%d` field
that was carrying the constant `1`.
Test adjustments:
- TestHandleSessionParameters_UpdatesIntervalAndDeadline: expect
deadline ~= before+interval (1x) instead of before+3*interval.
- TestHeartBeatLoop_HeartbeatsKeepInflightVRPCAlive: seed deadline
at now+30ms (1x) instead of now+90ms (was 3x).
Go packages for Google Cloud Platform services.
go get cloud.google.com/go/firestore@latest # Replace firestore with the package you want to use.
NOTE: Some of these packages are under development, and may occasionally make backwards-incompatible changes.
For an updated list of all of our released APIs please see our reference docs.
Our libraries are compatible with the two most recent major Go releases, the same policy the Go programming language follows. This means the currently supported versions are:
By default, each client library will use Application Default Credentials (ADC) to automatically configure the credentials used in calling the API endpoint. When using the libraries in a Google Cloud Platform environment such as Compute Engine, Kubernetes Engine, or App Engine, no additional authentication steps are necessary. See Authentication methods at Google and Authenticate for using client libraries for more information.
client, err := storage.NewClient(ctx)
For applications running elsewhere, such as your local development environment, you can use the gcloud auth application-default login command from the Google Cloud CLI to set user credentials in your local filesystem. Application Default Credentials will automatically detect these credentials. See Set up ADC for a local development environment for more information.
Alternately, you may need to provide an explicit path to your credentials. To authenticate using a service account key file, either set the GOOGLE_APPLICATION_CREDENTIALS environment variable to the path to your key file, or programmatically pass option.WithCredentialsFile to the NewClient function of the desired package. For example:
client, err := storage.NewClient(ctx, option.WithCredentialsFile("path/to/keyfile.json"))
You can exert even more control over authentication by using the credentials package to create an auth.Credentials. Then pass option.WithAuthCredentials to the NewClient function:
creds, err := credentials.DetectDefault(&credentials.DetectOptions{...})
...
client, err := storage.NewClient(ctx, option.WithAuthCredentials(creds))
Contributions are welcome. Please, see the CONTRIBUTING document for details.
Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms. See Contributor Code of Conduct for more information.