commit dbd3e787fe4cf977c2da7c58f7505918eb293e6c
author Sven van Haastregt <sven.vanhaastregt@arm.com> Thu Mar 18 21:46:05 2021
committer GitHub <noreply@github.com> Thu Mar 18 21:46:05 2021
tree 52eeff726d4c0fafb78a805304c004073295a339
parent 6b36f645b835f8054422cad3f050d18935be11be

Do not dereference null pointer for no matching tests (#1191)

When invoking for example

    test_c11_atomics test-that-does-not-exist

parseAndCallCommandLineTests() would attempt to dereference
`resultTestList` which is still a null pointer.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>

test_common/harness/testHarness.cpp

diff --git a/test_common/harness/testHarness.cpp b/test_common/harness/testHarness.cpp
index 6b4c720..5d96c43 100644
--- a/test_common/harness/testHarness.cpp
+++ b/test_common/harness/testHarness.cpp
@@ -713,20 +713,20 @@
             ret = saveResultsToJson(filename, argv[0], testList,
                                     selectedTestList, resultTestList, testNum);
         }
-    }
 
-    if (std::any_of(resultTestList, resultTestList + testNum,
-                    [](test_status result) {
-                        switch (result)
-                        {
-                            case TEST_PASS:
-                            case TEST_SKIP: return false;
-                            case TEST_FAIL:
-                            default: return true;
-                        };
-                    }))
-    {
-        ret = EXIT_FAILURE;
+        if (std::any_of(resultTestList, resultTestList + testNum,
+                        [](test_status result) {
+                            switch (result)
+                            {
+                                case TEST_PASS:
+                                case TEST_SKIP: return false;
+                                case TEST_FAIL:
+                                default: return true;
+                            };
+                        }))
+        {
+            ret = EXIT_FAILURE;
+        }
     }
 
     free(selectedTestList);