commit 256098db1e096b3ac7b97a29486a1ea6bfb74fe6
author benjhayden <benjhayden@chromium.org> Fri Jul 07 23:21:24 2017
committer Commit Bot <commit-bot@chromium.org> Fri Jul 07 23:21:24 2017
tree fe529be4afeefe4113ded52b9674d64c55414516
parent d65401dc3ce9294b08dc27c4218f0e3e411e3844

Reland Fix _GetSelectedTestPathsForDict in /list_tests handler.

Currently, _GetSelectedTestPathsForDict sometimes filters out test paths that have
no rows. This causes the frontend to sometimes request timeseries that are empty,
which has unpredictable effects on various features such as the minimap.

This CL makes _GetSelectedTestPathsForDict always filter out test paths that have
no rows.

This CL is careful to avoid leaking information about internal timeseries by
catching the exception raised by the post-get hook, and returning an empty list so
that requests for empty timeseries, requests for internal-only timeseries, and
requests for non-existent timeseries all return the same results.

This CL also updates report-page to display a new error message whenever /list_tests
returns empty results:
"Some charts failed to load. Either they don't exist, or they are
empty, or they are accessible only for signed-in google.com accounts."

This is a reland of https://codereview.chromium.org/2895483002
Which caused this bug: https://github.com/catapult-project/catapult/issues/3619

https://dev-benjhayden-ac343097-dot-chromeperf.appspot.com/report?sid=b22d91217ee3ed5a934cb313faeba75904e26dec76f7845df109a98f7175ec05

https://dev-benjhayden-ac343097-dot-chromeperf.appspot.com/report?sid=9e2284521c01ea9d498275782527b1d41b6fe01f82dcb20cfd576bf37d040533

http://i.imgur.com/8ZRoJG2h.png

BUG=catapult:#3565,catapult:#3391

Review-Url: https://codereview.chromium.org/2920383003