cli/command: look up registry credentials through internal/registryauth

RetrieveAuthTokenFromImage is exported and imported by other projects, so it keeps reading only the configuration file. The commands that pull and push call registryauth.EncodedAuth instead, which asks DOCKER_AUTH_CONFIG, then the Docker Desktop session, then the configuration file. This drops command.EncodedRegistryAuth from the public API.

Each DockerCli owns its Docker Desktop sessions through RegistryAuthProvider, created on first use, instead of package-level sessions shared by every caller. A command.Cli without RegistryAuthProvider uses only its configuration file. The fallback reads the current configuration file, since Initialize replaces it.

Remove the session fields and the constructors that only tests used, move the staging and dhi.io hostnames into internal/secretsengine, and use testing/synctest instead of a fake clock, so that the tests run in parallel. Only the DOCKER_AUTH_CONFIG test still sets the environment.

Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
18 files changed
tree: 568341c85de11f99f2e82742cce84e3ec955a9dc
  1. .github/
  2. cli/
  3. cli-plugins/
  4. cmd/
  5. contrib/
  6. dockerfiles/
  7. docs/
  8. e2e/
  9. experimental/
  10. internal/
  11. man/
  12. opts/
  13. pkg/
  14. scripts/
  15. templates/
  16. vendor/
  17. .codecov.yml
  18. .dockerignore
  19. .gitattributes
  20. .gitignore
  21. .golangci.yml
  22. .mailmap
  23. AUTHORS
  24. CONTRIBUTING.md
  25. docker-bake.hcl
  26. docker.Makefile
  27. Dockerfile
  28. LICENSE
  29. MAINTAINERS
  30. Makefile
  31. NOTICE
  32. README.md
  33. SECURITY.md
  34. TESTING.md
  35. vendor.mod
  36. vendor.sum
  37. VERSION
README.md

Docker CLI

PkgGoDev Build Status Test Status OpenSSF Scorecard Codecov

About

This repository is the home of the Docker CLI.

Development

docker/cli is developed using Docker.

Build CLI from source:

docker buildx bake

Build binaries for all supported platforms:

docker buildx bake cross

Build for a specific platform:

docker buildx bake --set binary.platform=linux/arm64 

Build dynamic binary for glibc or musl:

USE_GLIBC=1 docker buildx bake dynbinary 

Run all linting:

docker buildx bake lint shellcheck

Run test:

docker buildx bake test

Run the unit test:

$ make -f docker.Makefile test-unit

Run the full test suite:

$ make -f docker.Makefile test

List all the available targets:

make help

In-container development environment

Start an interactive development environment:

make shell

Legal

Brought to you courtesy of our legal counsel. For more context, see the NOTICE document in this repo.

Use and transfer of Docker may be subject to certain restrictions by the United States and other governments.

It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.

For more information, see https://www.bis.doc.gov

Licensing

docker/cli is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.