[EH] Remove !rethrown check when destroying exception

In Emscripten EH, #25988 changed where we increment refcount to fix a
refcounting inconsistency between Emscripten vs. Wasm EH (#17115).
Before #25988, it was incremented in `__cxa_begin_catch`, but after
 #25988, it was in `__cxa_throw` and `__cxa_rethrow`, more inline with
Wasm EH.

`__cxa_end_catch` calls `__cxa_decrement_exception_refcount`, which
decrements the refcount and destroys/frees the exception. But when an
exception is rethrown, we should not destroy it in `__cxa_end_catch`.
The below illutrates how a rethrown exception is (correctly) not
destroyed in `__cxa_end_catch`:
```cpp
// Before #25988 (refcount incremented in __cxa_begin_catch):
try {
  throw MyEx(); // __cxa_throw:       refcount = 0, rethrown = false
} catch (...) { // __cxa_begin_catch: refcount = 1 (0 -> 1), rethrown = false
  throw;        // __cxa_rethrow:     refcount = 1 (unchanged), rethrown = true
}               // __cxa_end_catch:   refcount = 0 (1 -> 0); not destroyed/freed because rethrown == true

// After #25988 (refcount incremented in __cxa_throw and __cxa_rethrow):
try {
  throw MyEx(); // __cxa_throw:       refcount = 1 (0 -> 1)
} catch (...) { // __cxa_begin_catch: refcount = 1 (unchanged)
  throw;        // __cxa_rethrow:     refcount = 2 (1 -> 2)
}               // __cxa_end_catch:   refcount = 1 (2 -> 1); not destroyed/freed because refcount > 0
```

So after #25988 we were supposed to solely rely on the refcount to
determine whether to destroy an exception. But the
`!exception_header->rethrown` check was incorrectly still left in
`__cxa_decrement_exception_refcount`. This didn't affect C++-only
programs, but this prevented an exception from being destroyed when an
exception was rethrown to JS and `decrementExceptionRefcount` was called
from there, as in the test added here.

This removes the incorrect `rethrown` flag check. After this and #26518,
no code uses the `rethrown` field, so this also removes it and its
related methods.

This is a part of fixes for #27705.
10 files changed
tree: 28a869ccf1be5912ea0d234c32ea1258a444d020
  1. .circleci/
  2. .github/
  3. cmake/
  4. docs/
  5. html/
  6. media/
  7. site/
  8. src/
  9. system/
  10. test/
  11. third_party/
  12. tools/
  13. .clang-format
  14. .clang-format-ignore
  15. .editorconfig
  16. .git-blame-ignore-revs
  17. .gitattributes
  18. .gitignore
  19. .gitmodules
  20. .prettierrc.yml
  21. .style.yapf
  22. AUTHORS
  23. bootstrap.py
  24. ChangeLog.md
  25. CONTRIBUTING.md
  26. em++.py
  27. em-config.py
  28. emar.py
  29. embuilder.py
  30. emcc.py
  31. emcmake.py
  32. emconfigure.py
  33. emmake.py
  34. emranlib.py
  35. emrun.py
  36. emscan-deps.py
  37. emscons.py
  38. emscripten-version.txt
  39. emsize.py
  40. emstrip.py
  41. eslint.config.mjs
  42. LICENSE
  43. Makefile
  44. package-lock.json
  45. package.json
  46. pyproject.toml
  47. README.md
  48. requirements-dev.txt
  49. SECURITY.md
README.md

emscripten logo

Main project page: https://emscripten.org

GitHub CI status: CircleCI

Chromium builder status: emscripten-releases

Overview

Emscripten compiles C and C++ to WebAssembly using LLVM and Binaryen. Emscripten output can run on the Web, in Node.js, and in wasm runtimes.

Emscripten provides Web support for popular portable APIs such as OpenGL and SDL2, allowing complex graphical native applications to be ported, such as the Unity game engine and Google Earth. It can probably port your codebase, too!

While Emscripten mostly focuses on compiling C and C++ using Clang, it can be integrated with other LLVM-using compilers (for example, Rust has Emscripten integration, with the wasm32-unknown-emscripten target).

Getting Started

For detailed instructions and tutorials, visit the Emscripten Website.

Installation

There are two primary ways to install Emscripten:

  1. Using the Emscripten SDK (emsdk) (Recommended) The easiest way to get started is by using the Emscripten SDK. Follow the instructions on the downloads page to install it.

  2. From a Git Checkout (Manual Installation) If you have cloned the repository from Git, you can install the dependencies manually and then run the bootstrap script:

    ./bootstrap.py
    

    For more details, see the developer guide.

Using the compiler

Run emcc like you would gcc or clang:

$ emcc hello.c -o hello.js
$ node hello.js
Hello, world!

Emscripten will compile your code into a WebAssembly module along with a JavaScript file that can load and run it. You can then run the resulting JavaScript in your browser or under Node.js (or Deno or Bun).

Emscripten can also generate a sample HTML page that then loads the JavaScript:

$ emcc hello.c -o hello.html

You can then serve the generated hello.html using the emrun tool, or a web server of your choosing.

Contributing

For information on how to contribute to the project, see CONTRIBUTING.md and the Contributing section on the website.

License

Emscripten is available under 2 licenses, the MIT license and the University of Illinois/NCSA Open Source License.

Both are permissive open source licenses, with little if any practical difference between them.

The reason for offering both is that (1) the MIT license is well-known and suitable for a compiler toolchain, while (2) LLVM‘s original license, the University of Illinois/NCSA Open Source License, was also offered to allow Emscripten’s code to be integrated upstream into LLVM. The second reason became less important after Emscripten switched to the LLVM wasm backend, at which point there isn't any code we expect to move back and forth between the projects; also, LLVM relicensed to Apache 2.0 + exceptions meanwhile. In practice you can just consider Emscripten as MIT licensed (which allows you to do pretty much anything you want with a compiler, including commercial and non-commercial use).

See LICENSE for the full content of the licenses.