183602 Fix an issue with updating proper job attempt numbers on re-run (#4988) ### 1. Refactored Pull Request Retrieval - **Updated Handlers:** The logic in `rerun_all_failed_jobs.dart` and `rerun_failed_job.dart` has been updated to consistently use `PrCheckRuns.findPullRequestFor` to resolve the pull request via the commit SHA (`guard.commitSha`), rather than querying by PR number. - **Fixed Re-run Workflows:** Ensured that the handlers fetch the correct active pull request during re-runs and store the proper retry number/attempt information when invoking `reScheduleTryBuilds`. ### 2. Removed `pull_request_num` Field and Cache - **Model Cleanups:** The `pull_request_num` field was entirely removed from the `PrCheckRuns` Firestore model, including its related mappings and integration test matchers (`_pr_check_run.dart`). - **Removed Methods:** Deleted the obsolete `findPullRequestCachedForPullRequestNum` lookup method from both `PrCheckRuns` and the `Scheduler` service. Additionally, removed its related caching tests. ### 3. Service/Dependencies Cleanup - **Removed Unused Services:** Dropped the previously injected but unused `_githubService` from `scheduler.dart`. - **Code Formatting:** Ran standard Dart formatting rules (`dart format`) to ensure code uniformity in edited files. ### 4. Test Suite Adjustments - **Updated Mocks & Setup:** `rerun_all_failed_jobs_test.dart` and `rerun_failed_job_test.dart` were updated to properly seed data using `PrCheckRuns.initializeDocument(...)` mirroring production behavior. - **Updated Assertions:** Test assertions were updated to verify correct PR handling, most notably checking that `reScheduleTryBuilds` receives accurate target configurations (e.g., proper attempt increments like `containsPair(targetA, 2)`). - **Removed Deprecated Mocks:** Scrubbed generated files like `mocks.mocks.dart` and testing `data_seeder.dart` to remove references to the deleted fields and getters. fix: https://github.com/flutter/flutter/issues/183602
Cocoon is a Dart App Engine custom runtime (backend) with a frontend of Flutter apps (build and repository dashboard). Cocoon coordinates and aggregates the results of flutter/flutter builds.
It is not designed to help developers build Flutter apps.
Cocoon is not a Google product.
The server is driven by commits made to https://github.com/flutter/flutter repo. It periodically syncs new commits. If you need to manually force a refresh, query https://flutter-dashboard.appspot.com/api/refresh-github-commits.
You will need to be authenticated with Cocoon to do this.
Cocoon has several components:
A server, which coordinates everything. This is a Dart App Engine application. If you have never used that before, you may want to peruse the samples for Dart App Engine. The server is found in app_dart.
A Flutter app (generally used as a Web app) for the build dashboards. The dashboard is found in dashboard.
Cocoon creates a checklist for each Flutter commit. A checklist is made of multiple tasks. Tasks are performed by LUCI bots.
First, set up a Flutter development environment. This will, as a side-effect, provide you with a Dart SDK. Your life will be easier if you add that (.../flutter/bin/cache/dart-sdk/bin/) to your path.
To update the production server, you will need the Google Cloud SDK. Since there is no Dart SDK, we just use the command line tools.
All the commands in this section assume that you are in the app_dart/ directory.
dart bin/local_server.dart
This will output Serving requests at 0.0.0.0:8080 indicating the server is working.
New requests will be logged to the console.
To run live tests, build the app, and provide instructions for deploying to Google App Engine, run this command:
dart dev/deploy.dart --project {PROJECT} --version {VERSION}
You can test the new version by accessing {VERSION}-dot-flutter-dashboard.appspot.com in your browser. If the result is satisfactory, the new version can be activated by using the Cloud Console UI: https://console.cloud.google.com/appengine/versions?project=flutter-dashboard&serviceId=default
--profile: Deploy a profile mode of dashboard application for debugging purposes.
--ignore-version-check: Ignore the version of Flutter on path (expects to be relatively recent)
The dashboard application will use dummy data when it is not connected to the server, so it can be developed locally without a dev server.
To run the dashboard locally, go into the dashboard directory and run flutter run -d chrome. The dashboard will be served from localhost (the exact address will be given on the console); copy the URL into your browser to view the application. (The dashboard should also be able to run on non-Web platforms, but since the Web is our main target that is the one that should generally be used for development.)
You can run flutter packages upgrade to update the dependencies. This may be necessary if you see a failure in the dependencies.