Update x/sys (#614)
Also update some action runners, and remove unneeded files.
diff --git a/.editorconfig b/.editorconfig
deleted file mode 100644
index fad8958..0000000
--- a/.editorconfig
+++ /dev/null
@@ -1,12 +0,0 @@
-root = true
-
-[*.go]
-indent_style = tab
-indent_size = 4
-insert_final_newline = true
-
-[*.{yml,yaml}]
-indent_style = space
-indent_size = 2
-insert_final_newline = true
-trim_trailing_whitespace = true
diff --git a/.gitattributes b/.gitattributes
deleted file mode 100644
index 32f1001..0000000
--- a/.gitattributes
+++ /dev/null
@@ -1 +0,0 @@
-go.sum linguist-generated
diff --git a/.github/ISSUE_TEMPLATE/bug.yml b/.github/ISSUE_TEMPLATE/bug.yml
index 88d4f93..a2285f0 100644
--- a/.github/ISSUE_TEMPLATE/bug.yml
+++ b/.github/ISSUE_TEMPLATE/bug.yml
@@ -13,8 +13,14 @@
- type: 'textarea'
validations: {"required": true}
attributes:
- label: 'To Reproduce'
- placeholder: 'Please provide the FULL code to reproduce the problem (something that can be copy/pasted and run without having to write additional code) and any additional steps that are needed.'
+ label: 'Code to Reproduce'
+ placeholder: 'Please provide the FULL code to reproduce the problem: something that can be copy/pasted and run without having to write additional code.'
+
+ - type: 'textarea'
+ validations: {"required": true}
+ attributes:
+ label: 'File operations to reproduce'
+ placeholder: 'Full details on which file operations you did; simply "changed file" is not enough, as there are many ways to change a file.'
- type: 'textarea'
validations: {"required": true}
@@ -22,10 +28,9 @@
label: 'Which operating system and version are you using?'
description: |
```
- Linux: lsb_release -a
- macOS: sw_vers
- Windows: systeminfo | findstr /B /C:OS
- BSD: uname -a
+ Linux, BSD: uname -a
+ macOS: sw_vers
+ Windows: systeminfo | findstr /B /C:OS
```
- type: 'input'
diff --git a/.github/workflows/Vagrantfile.debian6 b/.github/workflows/Vagrantfile.debian6
deleted file mode 100644
index fbe8f08..0000000
--- a/.github/workflows/Vagrantfile.debian6
+++ /dev/null
@@ -1,6 +0,0 @@
-Vagrant.configure("2") do |config|
- config.vm.box = "threatstack/debian6"
- config.vm.box_version = "1.0.0"
-
- config.vm.define 'debian6'
-end
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index fcceac2..cf7912a 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -10,14 +10,12 @@
strategy:
fail-fast: false
matrix:
- go: ['1.17', '1.21']
- runs-on: ubuntu-latest
+ go: ['1.17', '1.22']
+ runs-on: 'ubuntu-latest'
steps:
- - name: checkout
- uses: actions/checkout@v3
+ - uses: 'actions/checkout@v4'
- - name: setup Go
- uses: actions/setup-go@v4
+ - uses: 'actions/setup-go@v4'
with:
go-version: ${{ matrix.go }}
diff --git a/.github/workflows/staticcheck.yml b/.github/workflows/staticcheck.yml
index f3caf4d..d96203a 100644
--- a/.github/workflows/staticcheck.yml
+++ b/.github/workflows/staticcheck.yml
@@ -8,16 +8,15 @@
jobs:
staticcheck:
name: 'staticcheck'
- runs-on: ubuntu-latest
+ runs-on: 'ubuntu-latest'
steps:
- - id: install_go
- uses: WillAbides/setup-go-faster@v1.7.0
+ - uses: 'actions/setup-go@v4'
with:
- go-version: "1.19.x"
+ go-version: '1.22'
- - uses: actions/cache@v3
+ - uses: 'actions/cache@v4'
with:
- key: ${{ runner.os }}-staticcheck
+ key: '${{ runner.os }}-staticcheck'
path: |
${{ runner.temp }}/staticcheck
${{ steps.install_go.outputs.GOCACHE || '' }}
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index fdee27d..6f29baa 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -10,14 +10,14 @@
strategy:
fail-fast: false
matrix:
- os: ['ubuntu-latest']
+ os: ['ubuntu-20.04', 'ubuntu-latest']
go: ['1.17', '1.22']
- runs-on: ${{ matrix.os }}
+ runs-on: '${{ matrix.os }}'
steps:
- uses: 'actions/checkout@v4'
- uses: 'actions/setup-go@v4'
with:
- go-version: ${{ matrix.go }}
+ go-version: '${{ matrix.go }}'
- name: test
run: |
FSNOTIFY_BUFFER=4096 go test -parallel 1 -race ./...
@@ -29,12 +29,12 @@
matrix:
os: ['windows-latest']
go: ['1.17', '1.22']
- runs-on: ${{ matrix.os }}
+ runs-on: '${{ matrix.os }}'
steps:
- uses: 'actions/checkout@v4'
- uses: 'actions/setup-go@v4'
with:
- go-version: ${{ matrix.go }}
+ go-version: '${{ matrix.go }}'
- name: test
run: |
go test -parallel 1 -race ./...
@@ -42,16 +42,17 @@
go test -parallel 1 -race ./...
# Test gccgo
- gcc:
- runs-on: 'ubuntu-22.04'
- name: 'test (ubuntu-22.04, gccgo 12.1)'
- steps:
- - uses: 'actions/checkout@v4'
- - name: test
- run: |
- sudo apt-get -y install gccgo-12
- FSNOTIFY_BUFFER=4096 go-12 test -parallel 1 ./...
- go-12 test -parallel 1 ./...
+ # Needs gccgo 13, which should be available in Ubuntu 24.04.
+ # gcc:
+ # runs-on: 'ubuntu-22.04'
+ # name: 'test (ubuntu-22.04, gccgo 12.1)'
+ # steps:
+ # - uses: 'actions/checkout@v4'
+ # - name: test
+ # run: |
+ # sudo apt-get -y install gccgo-12
+ # FSNOTIFY_BUFFER=4096 go-12 test -parallel 1 ./...
+ # go-12 test -parallel 1 ./...
# Test only the latest Go version on macOS; we use the macOS builders for BSD
# and illumos, and GitHub doesn't allow many of them to run concurrently. If
@@ -62,14 +63,13 @@
strategy:
fail-fast: false
matrix:
- os: ['macos-11', 'macos-13']
- go: ['1.22']
- runs-on: ${{ matrix.os }}
+ os: ['macos-11', 'macos-latest']
+ runs-on: '${{ matrix.os }}'
steps:
- uses: 'actions/checkout@v4'
- uses: 'actions/setup-go@v4'
with:
- go-version: ${{ matrix.go }}
+ go-version: '1.22'
- name: test
run: |
FSNOTIFY_BUFFER=4096 go test -parallel 1 -race ./...
@@ -151,7 +151,7 @@
# Solaris
- # TODO: latest version is go 1.7(!) Need ot find a good way to install a more
+ # TODO: latest version is go 1.7(!) Need to find a good way to install a more
# recent version; the go.dev doesn't have binaries for Solaris.
# solaris:
# runs-on: 'ubuntu-latest'
diff --git a/CHANGELOG.md b/CHANGELOG.md
index e0e5757..1ef6e3c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,7 +2,17 @@
Unreleased
----------
-Nothing yet.
+
+### Additions
+
+### Changes and fixes
+
+- windows: fix behaviour of `WatchList()` ([#610])
+
+- kqueue: ignore events with Ident=0 ([#590])
+
+[#590]: https://github.com/fsnotify/fsnotify/pull/590
+[#610]: https://github.com/fsnotify/fsnotify/pull/610
1.7.0 - 2023-10-22
------------------
diff --git a/go.mod b/go.mod
index 1deb88c..fb5963e 100644
--- a/go.mod
+++ b/go.mod
@@ -2,7 +2,7 @@
go 1.17
-require golang.org/x/sys v0.4.0
+require golang.org/x/sys v0.13.0
retract (
v1.5.3 // Published an incorrect branch accidentally https://github.com/fsnotify/fsnotify/issues/445
diff --git a/go.sum b/go.sum
index c2a6782..d4673ec 100644
--- a/go.sum
+++ b/go.sum
@@ -1,2 +1,2 @@
-golang.org/x/sys v0.4.0 h1:Zr2JFtRQNX3BCZ8YtxRE9hNJYC8J6I1MVbMg6owUp18=
-golang.org/x/sys v0.4.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.13.0 h1:Af8nKPmuFypiUBjVoU9V20FiaFXOcuZI21p0ycVYYGE=
+golang.org/x/sys v0.13.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=