tree bbe4962ad81a0411fc3c187c98e97be483b090eb
parent d86c4527bae98ccd4e5060f72887520ce30eda5e
author ICHINOSE Shogo <shogo82148@gmail.com> 1711123044 +0900
committer GitHub <noreply@github.com> 1711123044 +0900
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJl/apkCRC1aQ7uu5UhlAAACnIQAEtpxQe+YP2q6H6SAAOzPIQ4
 Cpq1On54wvzjY6Eeo0m5QwF5f38h3QiERgP3BDQogfvgrRB5NTW3h7kLUNLw6iq4
 2pmIDiDgRlWp4Pc0KYhip1xNwEPHjABcFbE8yd3D+20yBkNiWd8N3Wmno+3EBQnI
 /lMKDD8UTOT+TlUehldXi84ZvUirgM8t5jRFf5/hC+qGp5IqzzkmnW24vfRkWHO8
 tslMjjE2nCUMRlMNHIX7oqssizffr9MntTNPRPFTChTEZ+jKHgT4+/4sIbh2Hi5f
 4x08D3ikMZ7Bv0L9sBfSCqIVNHK/wZP/GoIk1EveXhPqWhZNGMfQaMEbLzR9sPmM
 rdwiwAO6UYWo7NV0xEzndm2gOlqDFTqch33UAZ7zryEcpktAcnLSG8H9fGBukWmY
 0+675v+rB0mfuxHJ0JS1JSHpb2gyNpZ5EuaBWDWbA50613mL86n49BQTeGZtBYo4
 tGHfCngwFTCzmK5BBL2ih/tRPFgMZTCpSsCrXj11hJxDdFCeGSDVhrAb9dzzcCLn
 j0iKHyIeBZiqE9Y/pLpxoVTxeq5Ne4eXnXSRM4qrZLuh5CWHoZrXKJMGZGIDV8gV
 XvFqevyNEJrX4uHuexs08Y5HYwiVRzGctbMmUY/bjrwSP1x8ATRwXPu01PMQNurt
 69uSYs2o55o5KNPA/Gh2
 =TFzS
 -----END PGP SIGNATURE-----
 

Fix issue 1567 (#1570)

### Description

closes https://github.com/go-sql-driver/mysql/issues/1567

When TLS is enabled, `mc.netConn` is rewritten after the TLS handshak as
detailed here:


https://github.com/go-sql-driver/mysql/blob/d86c4527bae98ccd4e5060f72887520ce30eda5e/packets.go#L355

Therefore, `mc.netConn` should not be accessed within the watcher
goroutine.
Instead, `mc.rawConn` should be initialized prior to invoking
`mc.startWatcher`, and `mc.rawConn` should be used in lieu of
`mc.netConn`.

### Checklist
- [x] Code compiles correctly
- [x] Created tests which fail without the change (if possible)
- [x] All tests passing
- [x] Extended the README / documentation, if necessary
- [x] Added myself / the copyright holder to the AUTHORS file


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
	- Improved variable naming for better code readability and maintenance.
	- Enhanced network connection handling logic.
- **New Features**
	- Updated TCP connection handling to better support TCP Keepalives.
- **Tests**
- Added a new test to address and verify the fix for a specific issue
related to TLS, connection pooling, and round trip time estimation.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->