)]}'
{
  "commit": "dc1a97174d5b84b1ce6720f1c98f85e6031b4723",
  "tree": "eda5470723517a4edc43ad1cdf3477e7c58cc489",
  "parents": [
    "8fd49d66719b37156d8e4f7bc2817665ce43664a"
  ],
  "author": {
    "name": "Vy Nguyen",
    "email": "oontvoo@users.noreply.github.com",
    "time": "Mon Aug 23 08:06:57 2021"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Mon Aug 23 08:06:57 2021"
  },
  "message": "Introduce accessors for currently public data members (threads and thread_index) (#1208)\n\n* [benchmark] Introduce accessors for currently public data members `threads` and `thread_index`\r\n\r\nAlso deprecate the direct access to these fields.\r\n\r\nMotivations:\r\n\r\nOur internal library provides accessors for those fields because the styleguide disalows accessing classes\u0027 data members directly (even if they\u0027re const).\r\nThere has been a discussion to simply move internal library to make its fields public similarly to the OSS version here, however, the concern is that these kinds of direct access would prevent many types of future design changes (eg how/whether the values would be stored in the data member)\r\n\r\nI think the concensus in the end is that we\u0027d change the external library for this case.\r\nAFAIK, there are three important third_party users that we\u0027d need to migrate: tcmalloc, abseil and tensorflow.\r\nPlease let me know if I\u0027m missing anyone else.\r\n\r\n* [benchmark] Introduce accessors for currently public data members `threads` and `thread_index`\r\n\r\nAlso deprecate the direct access to these fields.\r\n\r\nMotivations:\r\n\r\nOur internal library provides accessors for those fields because the styleguide disalows accessing classes\u0027 data members directly (even if they\u0027re const).\r\nThere has been a discussion to simply move internal library to make its fields public similarly to the OSS version here, however, the concern is that these kinds of direct access would prevent many types of future design changes (eg how/whether the values would be stored in the data member)\r\n\r\nI think the concensus in the end is that we\u0027d change the external library for this case.\r\nAFAIK, there are three important third_party users that we\u0027d need to migrate: tcmalloc, abseil and tensorflow.\r\nPlease let me know if I\u0027m missing anyone else.\r\n\r\n* [benchmark] Introduce accessors for currently public data members `threads` and `thread_index`\r\n\r\nAlso deprecate direct access to `.thread_index` and make threads a private field\r\n\r\nMotivations:\r\n\r\nOur internal library provides accessors for those fields because the styleguide disalows accessing classes\u0027 data members directly (even if they\u0027re const).\r\nThere has been a discussion to simply move internal library to make its fields public similarly to the OSS version here, however, the concern is that these kinds of direct access would prevent many types of future design changes (eg how/whether the values would be stored in the data member)\r\n\r\nI think the concensus in the end is that we\u0027d change the external library for this case.\r\nAFAIK, there are three important third_party users that we\u0027d need to migrate: tcmalloc, abseil and tensorflow.\r\nPlease let me know if I\u0027m missing anyone else.\r\n\r\n* [benchmark] Introduce accessors for currently public data members `threads` and `thread_index`\r\n\r\nAlso deprecate direct access to `.thread_index` and make threads a private field\r\n\r\nMotivations:\r\n\r\nOur internal library provides accessors for those fields because the styleguide disalows accessing classes\u0027 data members directly (even if they\u0027re const).\r\nThere has been a discussion to simply move internal library to make its fields public similarly to the OSS version here, however, the concern is that these kinds of direct access would prevent many types of future design changes (eg how/whether the values would be stored in the data member)\r\n\r\nI think the concensus in the end is that we\u0027d change the external library for this case.\r\nAFAIK, there are three important third_party users that we\u0027d need to migrate: tcmalloc, abseil and tensorflow.\r\nPlease let me know if I\u0027m missing anyone else.\r\n\r\n* [benchmark] Introduce accessors for currently public data members `threads` and `thread_index`\r\n\r\nAlso deprecate direct access to `.thread_index` and make threads a private field\r\n\r\nMotivations:\r\n\r\nOur internal library provides accessors for those fields because the styleguide disalows accessing classes\u0027 data members directly (even if they\u0027re const).\r\nThere has been a discussion to simply move internal library to make its fields public similarly to the OSS version here, however, the concern is that these kinds of direct access would prevent many types of future design changes (eg how/whether the values would be stored in the data member)\r\n\r\nI think the concensus in the end is that we\u0027d change the external library for this case.\r\nAFAIK, there are three important third_party users that we\u0027d need to migrate: tcmalloc, abseil and tensorflow.\r\nPlease let me know if I\u0027m missing anyone else.\r\n\r\n* [benchmark] Introduce accessors for currently public data members `threads` and `thread_index`\r\n\r\nAlso deprecate direct access to `.thread_index` and make threads a private field\r\n\r\nMotivations:\r\n\r\nOur internal library provides accessors for those fields because the styleguide disalows accessing classes\u0027 data members directly (even if they\u0027re const).\r\nThere has been a discussion to simply move internal library to make its fields public similarly to the OSS version here, however, the concern is that these kinds of direct access would prevent many types of future design changes (eg how/whether the values would be stored in the data member)\r\n\r\nI think the concensus in the end is that we\u0027d change the external library for this case.\r\nAFAIK, there are three important third_party users that we\u0027d need to migrate: tcmalloc, abseil and tensorflow.\r\nPlease let me know if I\u0027m missing anyone else.\r\n\r\n* [benchmark] Introduce accessors for currently public data members `threads` and `thread_index`\r\n\r\nAlso deprecate direct access to `.thread_index` and make threads a private field\r\n\r\nMotivations:\r\n\r\nOur internal library provides accessors for those fields because the styleguide disalows accessing classes\u0027 data members directly (even if they\u0027re const).\r\nThere has been a discussion to simply move internal library to make its fields public similarly to the OSS version here, however, the concern is that these kinds of direct access would prevent many types of future design changes (eg how/whether the values would be stored in the data member)\r\n\r\nI think the concensus in the end is that we\u0027d change the external library for this case.\r\nAFAIK, there are three important third_party users that we\u0027d need to migrate: tcmalloc, abseil and tensorflow.\r\nPlease let me know if I\u0027m missing anyone else.\r\n\r\n* [benchmark] Introduce accessors for currently public data members `threads` and `thread_index`\r\n\r\nAlso deprecate direct access to `.thread_index` and make threads a private field\r\n\r\nMotivations:\r\n\r\nOur internal library provides accessors for those fields because the styleguide disalows accessing classes\u0027 data members directly (even if they\u0027re const).\r\nThere has been a discussion to simply move internal library to make its fields public similarly to the OSS version here, however, the concern is that these kinds of direct access would prevent many types of future design changes (eg how/whether the values would be stored in the data member)\r\n\r\nI think the concensus in the end is that we\u0027d change the external library for this case.\r\nAFAIK, there are three important third_party users that we\u0027d need to migrate: tcmalloc, abseil and tensorflow.\r\nPlease let me know if I\u0027m missing anyone else.\r\n\r\n* [benchmark] Introduce accessors for currently public data members `threads` and `thread_index`\r\n\r\nAlso deprecate direct access to `.thread_index` and make threads a private field\r\n\r\nMotivations:\r\n\r\nOur internal library provides accessors for those fields because the styleguide disalows accessing classes\u0027 data members directly (even if they\u0027re const).\r\nThere has been a discussion to simply move internal library to make its fields public similarly to the OSS version here, however, the concern is that these kinds of direct access would prevent many types of future design changes (eg how/whether the values would be stored in the data member)\r\n\r\nI think the concensus in the end is that we\u0027d change the external library for this case.\r\nAFAIK, there are three important third_party users that we\u0027d need to migrate: tcmalloc, abseil and tensorflow.\r\nPlease let me know if I\u0027m missing anyone else.\r\n\r\n* [benchmark] Introduce accessors for currently public data members `threads` and `thread_index`\r\n\r\nAlso deprecate direct access to `.thread_index` and make threads a private field\r\n\r\nMotivations:\r\n\r\nOur internal library provides accessors for those fields because the styleguide disalows accessing classes\u0027 data members directly (even if they\u0027re const).\r\nThere has been a discussion to simply move internal library to make its fields public similarly to the OSS version here, however, the concern is that these kinds of direct access would prevent many types of future design changes (eg how/whether the values would be stored in the data member)\r\n\r\nI think the concensus in the end is that we\u0027d change the external library for this case.\r\nAFAIK, there are three important third_party users that we\u0027d need to migrate: tcmalloc, abseil and tensorflow.\r\nPlease let me know if I\u0027m missing anyone else.",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1b01fe7f7f0f7351d18aea241b02555863ca8ff4",
      "old_mode": 33188,
      "old_path": "bindings/python/google_benchmark/benchmark.cc",
      "new_id": "02b6ed7ed59009d0e4aacc2ca6b705103371a0fe",
      "new_mode": 33188,
      "new_path": "bindings/python/google_benchmark/benchmark.cc"
    },
    {
      "type": "modify",
      "old_id": "4a4214ee1c2fb9d76fc05ddd811b59ef4696205a",
      "old_mode": 33188,
      "old_path": "include/benchmark/benchmark.h",
      "new_id": "31f2b02f0935cf53672bb1c5db951e8fe743c70d",
      "new_mode": 33188,
      "new_path": "include/benchmark/benchmark.h"
    },
    {
      "type": "modify",
      "old_id": "493ebbe696d0344290d4a0ae6276f29e33cb3300",
      "old_mode": 33188,
      "old_path": "src/benchmark.cc",
      "new_id": "a086453a943a59ba1d650c03139d526b787dbf5c",
      "new_mode": 33188,
      "new_path": "src/benchmark.cc"
    },
    {
      "type": "modify",
      "old_id": "3cd4f5565fa1c9d9882bf3c220c2c305d0fdfeee",
      "old_mode": 33188,
      "old_path": "test/benchmark_test.cc",
      "new_id": "c63fc3149ee06b5b023c21d5b3ea995adfa8c78c",
      "new_mode": 33188,
      "new_path": "test/benchmark_test.cc"
    },
    {
      "type": "modify",
      "old_id": "eba0a42d9cb046eb5c27945d85df0dc03a583116",
      "old_mode": 33188,
      "old_path": "test/fixture_test.cc",
      "new_id": "452dd87380305bcfbe3ec75f8aa4f22f60c684cb",
      "new_mode": 33188,
      "new_path": "test/fixture_test.cc"
    },
    {
      "type": "modify",
      "old_id": "1156bc0ad6b3045a14e2f3e953f4d568f5497e8d",
      "old_mode": 33188,
      "old_path": "test/skip_with_error_test.cc",
      "new_id": "4d89671e3f6971b1bbbdf2083d949230ccd519a8",
      "new_mode": 33188,
      "new_path": "test/skip_with_error_test.cc"
    }
  ]
}