Add support for jakarta annotations to some checks
This MR adds jakarta annotations to the exempt lists.
We're currently migrating to Jakarta EE and we have to temporarily disable the rule or add exceptions in the code.
I didn't add new tests since it's just additional exempt annotations, but let me know if you want explicit tests.
Fixes #4782
COPYBARA_INTEGRATE_REVIEW=https://github.com/google/error-prone/pull/4782 from gavlyukovskiy:patch-1 398cd4a9f4795e22ac1bb606ff0e3e1327d93a78
PiperOrigin-RevId: 731727129
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeFinal.java b/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeFinal.java
index d3b2201..ce72c77 100644
--- a/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeFinal.java
+++ b/core/src/main/java/com/google/errorprone/bugpatterns/FieldCanBeFinal.java
@@ -77,6 +77,10 @@
"com.google.inject.Inject",
"com.google.inject.testing.fieldbinder.Bind",
"com.google.testing.junit.testparameterinjector.TestParameter",
+ "jakarta.inject.Inject",
+ "jakarta.jdo.annotations.Persistent",
+ "jakarta.persistence.Id",
+ "jakarta.xml.bind.annotation.XmlAttribute",
"javax.inject.Inject",
"javax.jdo.annotations.Persistent",
"javax.persistence.Id",
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/TooManyParameters.java b/core/src/main/java/com/google/errorprone/bugpatterns/TooManyParameters.java
index 39f6201..0fb66eb 100644
--- a/core/src/main/java/com/google/errorprone/bugpatterns/TooManyParameters.java
+++ b/core/src/main/java/com/google/errorprone/bugpatterns/TooManyParameters.java
@@ -53,6 +53,7 @@
"java.lang.Deprecated",
"java.lang.Override",
// dependency injection annotations
+ "jakarta.inject.Inject",
"javax.inject.Inject",
"com.google.inject.Inject",
"com.google.inject.Provides",
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyVisible.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyVisible.java
index f09be5f..9b34dfe 100644
--- a/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyVisible.java
+++ b/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyVisible.java
@@ -63,6 +63,7 @@
"com.google.inject.multibindings.ProvidesIntoMap",
"com.google.inject.multibindings.ProvidesIntoSet",
"dagger.Provides",
+ "jakarta.inject.Inject",
"javax.inject.Inject")
.map(s::getName)
.collect(toImmutableSet()));
@@ -70,7 +71,7 @@
private static final Supplier<ImmutableSet<Name>> INJECT_ANNOTATIONS =
VisitorState.memoize(
s ->
- Stream.of("com.google.inject.Inject", "javax.inject.Inject")
+ Stream.of("com.google.inject.Inject", "javax.inject.Inject", "jakarta.inject.Inject")
.map(s::getName)
.collect(toImmutableSet()));
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryAssignment.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryAssignment.java
index 41f9c92..e6c3f08 100644
--- a/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryAssignment.java
+++ b/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryAssignment.java
@@ -79,6 +79,7 @@
ImmutableSet.of(
"com.google.testing.junit.testparameterinjector.TestParameter",
"com.google.inject.Inject",
+ "jakarta.inject.Inject",
"javax.inject.Inject");
private static final Matcher<Tree> HAS_MOCK_ANNOTATION = hasAnnotation("org.mockito.Mock");
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java
index 139f6cd..73c2cbf 100644
--- a/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java
+++ b/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java
@@ -132,6 +132,8 @@
"jakarta.persistence.PrePersist",
"jakarta.persistence.PreRemove",
"jakarta.persistence.PreUpdate",
+ "jakarta.validation.constraints.AssertFalse",
+ "jakarta.validation.constraints.AssertTrue",
"javax.annotation.PreDestroy",
"javax.annotation.PostConstruct",
"javax.inject.Inject",
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java
index 4ce7570..dc6dad6 100644
--- a/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java
+++ b/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java
@@ -144,6 +144,11 @@
*/
private static final ImmutableSet<String> EXEMPTING_VARIABLE_ANNOTATIONS =
ImmutableSet.of(
+ "jakarta.persistence.Basic",
+ "jakarta.persistence.Column",
+ "jakarta.persistence.Id",
+ "jakarta.persistence.Version",
+ "jakarta.xml.bind.annotation.XmlElement",
"javax.persistence.Basic",
"javax.persistence.Column",
"javax.persistence.Id",
@@ -168,6 +173,7 @@
"com.google.inject.multibindings.ProvidesIntoMap",
"com.google.inject.multibindings.ProvidesIntoSet",
"dagger.Provides",
+ "jakarta.inject.Inject",
"javax.inject.Inject",
// Parameters on test methods imply the test is parameterised, and those parameters should
// be used or removed.
