Always generate problem summary report
diff --git a/platforms/ide/problems/src/main/java/org/gradle/problems/internal/services/ProblemsBuildTreeServices.java b/platforms/ide/problems/src/main/java/org/gradle/problems/internal/services/ProblemsBuildTreeServices.java
index b29ab96..3529136 100644
--- a/platforms/ide/problems/src/main/java/org/gradle/problems/internal/services/ProblemsBuildTreeServices.java
+++ b/platforms/ide/problems/src/main/java/org/gradle/problems/internal/services/ProblemsBuildTreeServices.java
@@ -21,8 +21,9 @@
import org.gradle.api.problems.internal.DefaultProblems;
import org.gradle.api.problems.internal.InternalProblems;
import org.gradle.api.problems.internal.ProblemEmitter;
-import org.gradle.internal.buildoption.InternalFlag;
+import org.gradle.internal.buildoption.InternalOption;
import org.gradle.internal.buildoption.InternalOptions;
+import org.gradle.internal.buildoption.StringInternalOption;
import org.gradle.internal.cc.impl.problems.BuildNameProvider;
import org.gradle.internal.concurrent.ExecutorFactory;
import org.gradle.internal.event.ListenerManager;
@@ -57,7 +58,7 @@ ProblemEmitter createProblemEmitter(BuildOperationProgressEventEmitter buildOper
return new BuildOperationBasedProblemEmitter(buildOperationProgressEventEmitter);
}
- private static InternalFlag enableProblemsReport = new InternalFlag("org.gradle.internal.problems.report.enabled", false);
+ private static InternalOption<String> enableProblemsReport = new StringInternalOption("org.gradle.internal.problems.report.enabled", "");
@Provides
ProblemReportCreator createProblemsReportCreator(
@@ -69,8 +70,12 @@ ProblemReportCreator createProblemsReportCreator(
FailureFactory failureFactory,
BuildNameProvider buildNameProvider
) {
- if (internalOptions.getOption(enableProblemsReport).get()) {
- return new DefaultProblemsReportCreator(executorFactory, temporaryFileProvider, internalOptions, startParameter, failureFactory, buildNameProvider);
+ // "false" - don't create report
+ // "true" - create report and show location on the console
+ // default - create report but don't show location on the console
+ String option = internalOptions.getOption(enableProblemsReport).get();
+ if (!"false".equals(option)) {
+ return new DefaultProblemsReportCreator(executorFactory, temporaryFileProvider, internalOptions, startParameter, failureFactory, buildNameProvider, "true".equals(option));
}
return new NoOpProblemReportCreator();
}
diff --git a/platforms/ide/problems/src/main/kotlin/org/gradle/problems/internal/impl/DefaultProblemsReportCreator.kt b/platforms/ide/problems/src/main/kotlin/org/gradle/problems/internal/impl/DefaultProblemsReportCreator.kt
index 0bb672c..5a15d73 100644
--- a/platforms/ide/problems/src/main/kotlin/org/gradle/problems/internal/impl/DefaultProblemsReportCreator.kt
+++ b/platforms/ide/problems/src/main/kotlin/org/gradle/problems/internal/impl/DefaultProblemsReportCreator.kt
@@ -50,7 +50,8 @@
internalOptions: InternalOptions,
startParameter: StartParameterInternal,
private val failureFactory: FailureFactory,
- private val buildNameProvider: BuildNameProvider
+ private val buildNameProvider: BuildNameProvider,
+ private val showUrlOnConsole: Boolean
) : ProblemReportCreator {
private val report = CommonReport(executorFactory, temporaryFileProvider, internalOptions, "problem report", "problem-report")
@@ -79,8 +80,10 @@
}
}
})?.let {
- val url = ConsoleRenderer().asClickableFileUrl(it)
- logger.warn("Problems report is available at: $url")
+ if (showUrlOnConsole) {
+ val url = ConsoleRenderer().asClickableFileUrl(it)
+ logger.warn("Problems report is available at: $url")
+ }
}
}
