| commit | cfe586321e3b2869b42a3c398204a320b35a15e0 | [log] [tgz] |
|---|---|---|
| author | Logan Smith <logan.r.smith0@gmail.com> | Wed Jul 22 21:16:35 2020 |
| committer | Logan Smith <logan.r.smith0@gmail.com> | Wed Jul 22 21:19:34 2020 |
| tree | 9e8c5311a5b7026fc4b14561a318b44894b043f6 | |
| parent | c3a526adbd0ab49f5ce9789bc603d942fdda93a1 [diff] |
Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories. Using add_compile_definitions caused the flag to be passed to rc.exe on Windows and thus broke Windows builds. Cr-Mirrored-From: https://chromium.googlesource.com/external/github.com/llvm/llvm-project Cr-Mirrored-Commit: 388c9fb1af48b059d8b65cb2e002e0992d147aa5