Google Git
Sign in
chromium / external / github.com / luci / luci-go / 0a455fedda06056a0be820f951c16655b3420899
commit0a455fedda06056a0be820f951c16655b3420899[log] [tgz]
authordnj <dnj@google.com>Wed Jun 07 19:07:22 2017
committerCommit Bot <commit-bot@chromium.org>Wed Jun 07 19:07:22 2017
treeead24caa3b7d706b000be9678615503a337a8631
parent288831e8f27616792594ba30104b6266ba9af015 [diff]
[vpython] Fix PEP425 naming.

Early choices resulted in some incorrect naming of PEP425 structure
fields. Fix this before "vpython" is used in too many places to make
fixing this feasible.

The "Pep425Tag" Protobuf struct is now named "PEP425Tag" so that its
Go-generated structure is more idiomatic. This has no impact on the text
or binary protobuf format.

The fields in a "Pep425Tag" have been renamed from "Version, ABI, Arch"
to the proper "Python, ABI, Platform" terminology used in PEP425. This
will break existing text protobuf naming, so we have updated the
protobuf version from "v1" to "v2".

BUG=None
TEST=local

Review-Url: https://codereview.chromium.org/2927573002
16 files changed
tree: ead24caa3b7d706b000be9678615503a337a8631
  1. appengine/
  2. buildbucket/
  3. cipd/
  4. client/
  5. common/
  6. deploytool/
  7. dm/
  8. examples/
  9. grpc/
  10. hardcoded/
  11. infra/
  12. logdog/
  13. luci_config/
  14. lucictx/
  15. milo/
  16. scheduler/
  17. scripts/
  18. server/
  19. swarming/
  20. tokenserver/
  21. tools/
  22. tumble/
  23. vpython/
  24. web/
  25. .travis.yml
  26. AUTHORS
  27. codereview.settings
  28. CONTRIBUTORS
  29. LICENSE
  30. luci-deploy.cfg
  31. pre-commit-go.yml
  32. PRESUBMIT.py
  33. README.md
  34. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoDoc Build Status Coverage Status

Installing

go get -u github.com/luci/luci-go/client/cmd/...
go get -u github.com/luci/luci-go/server/cmd/...

Code layout

  • /appengine/... contains AppEngine server code. It imports packages from /common/... and /server/....
  • /client/... contains all client code.
  • /common/... contains code and structures shared between all of /appengine/..., /client/... and /server/...; for example, the structures used by the server APIs. These are inherently APIs.
  • /deploytool/... contains the LUCI cloud services deployment tool.
  • /logdog/... contains LogDog client and server code, as well as APIs, protobufs, and support libraries.
  • /server/... contains standalone server code. Its packages are reusable by /appengine/....
  • /tools/... contains support tools used by other LUCI components.

Versioning

  • Branch go1 contains the stable code.
  • Branch master constains the latest code.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.
  • Install test-only packages: go get -u -t github.com/luci/luci-go/client/...
  • Install the pcg git hook: go get -u github.com/maruel/pre-commit-go/cmd/... && pcg

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
cd $GOROOT/github.com/luci/luci-go
git checkout -b work origin/master

# hack hack

git commit -a -m "This is awesome\nR=joe@example.com"
# This will ask for your Google Account credentials.
git cl upload -s
# Wait for LGTM over email.
# Check the commit queue box in codereview website.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.