Google Git
Sign in
chromium / external / github.com / luci / luci-go / 300d5a6b74053bed93529c62119d09516c14b447
commit300d5a6b74053bed93529c62119d09516c14b447[log] [tgz]
authormcgreevy <mcgreevy@chromium.org>Tue Aug 01 04:41:58 2017
committerCommit Bot <commit-bot@chromium.org>Tue Aug 01 04:41:58 2017
tree89ab03f2c9417092b8e802a542e7309d7d4976c9
parent7981ab04f53fb3eb949c32f8eafbc077c15d66d5 [diff]
isolate: manage lifetime of checker and uploader in main.

It makes sense for the uploader and checker to be Closed in the same block of
code that they are created in. This will also make it possible to share Checker
and Uploaders between TarringArchivers.

BUG=692940

Review-Url: https://codereview.chromium.org/2988133002
2 files changed
tree: 89ab03f2c9417092b8e802a542e7309d7d4976c9
  1. appengine/
  2. buildbucket/
  3. cipd/
  4. client/
  5. common/
  6. deploytool/
  7. dm/
  8. examples/
  9. grpc/
  10. hardcoded/
  11. infra/
  12. logdog/
  13. luci_config/
  14. lucictx/
  15. milo/
  16. mmutex/
  17. scheduler/
  18. scripts/
  19. server/
  20. swarming/
  21. tokenserver/
  22. tools/
  23. tumble/
  24. vpython/
  25. web/
  26. .travis.yml
  27. AUTHORS
  28. codereview.settings
  29. CONTRIBUTING.md
  30. CONTRIBUTORS
  31. LICENSE
  32. luci-deploy.cfg
  33. pre-commit-go.yml
  34. PRESUBMIT.py
  35. README.md
  36. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoDoc Build Status Coverage Status

Installing

go get -u github.com/luci/luci-go/client/cmd/...
go get -u github.com/luci/luci-go/server/cmd/...

Code layout

  • /appengine/... contains AppEngine server code. It imports packages from /common/... and /server/....
  • /client/... contains all client code.
  • /common/... contains code and structures shared between all of /appengine/..., /client/... and /server/...; for example, the structures used by the server APIs. These are inherently APIs.
  • /deploytool/... contains the LUCI cloud services deployment tool.
  • /logdog/... contains LogDog client and server code, as well as APIs, protobufs, and support libraries.
  • /server/... contains standalone server code. Its packages are reusable by /appengine/....
  • /tools/... contains support tools used by other LUCI components.

Versioning

  • Branch go1 contains the stable code.
  • Branch master constains the latest code.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.
  • Install test-only packages: go get -u -t github.com/luci/luci-go/client/...
  • Install the pcg git hook: go get -u github.com/maruel/pre-commit-go/cmd/... && pcg

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
cd $GOROOT/github.com/luci/luci-go
git checkout -b work origin/master

# hack hack

git commit -a -m "This is awesome\nR=joe@example.com"
# This will ask for your Google Account credentials.
git cl upload -s
# Wait for LGTM over email.
# Check the commit queue box in codereview website.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.