Google Git
Sign in
chromium / external / github.com / luci / luci-go / 7e4835b3ee45d01e99c04376b7bcfb741c6960fb
commit7e4835b3ee45d01e99c04376b7bcfb741c6960fb[log] [tgz]
authorvadimsh <vadimsh@chromium.org>Wed Jun 21 00:38:05 2017
committerCommit Bot <commit-bot@chromium.org>Wed Jun 21 00:38:05 2017
treef03ea10120781ccd62a6605f2097f50238fc26d2
parent71aba0a6cd7d6264e0ecdd38afe5b69db8c8556f [diff]
token-server: Make machine token minter config apply to subdomains.

Token server is configured with a list of domains it is allowed to mint machine
tokens for. This list used to be matched exactly, e.g a cert with Common Name
"machine.sub.example.com" can be exchanged to a machine token only if
"sub.example.com" is listed in the config.

This change relaxes this rule and allows configured domains to match subdomains
too.

Also cleanup some stale assumptions in comments and code.

R=smut@google.com, iannucci@chromium.org
BUG=732467

Review-Url: https://codereview.chromium.org/2952723003
5 files changed
tree: f03ea10120781ccd62a6605f2097f50238fc26d2
  1. appengine/
  2. buildbucket/
  3. cipd/
  4. client/
  5. common/
  6. deploytool/
  7. dm/
  8. examples/
  9. grpc/
  10. hardcoded/
  11. infra/
  12. logdog/
  13. luci_config/
  14. lucictx/
  15. milo/
  16. scheduler/
  17. scripts/
  18. server/
  19. swarming/
  20. tokenserver/
  21. tools/
  22. tumble/
  23. vpython/
  24. web/
  25. .travis.yml
  26. AUTHORS
  27. codereview.settings
  28. CONTRIBUTORS
  29. LICENSE
  30. luci-deploy.cfg
  31. pre-commit-go.yml
  32. PRESUBMIT.py
  33. README.md
  34. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoDoc Build Status Coverage Status

Installing

go get -u github.com/luci/luci-go/client/cmd/...
go get -u github.com/luci/luci-go/server/cmd/...

Code layout

  • /appengine/... contains AppEngine server code. It imports packages from /common/... and /server/....
  • /client/... contains all client code.
  • /common/... contains code and structures shared between all of /appengine/..., /client/... and /server/...; for example, the structures used by the server APIs. These are inherently APIs.
  • /deploytool/... contains the LUCI cloud services deployment tool.
  • /logdog/... contains LogDog client and server code, as well as APIs, protobufs, and support libraries.
  • /server/... contains standalone server code. Its packages are reusable by /appengine/....
  • /tools/... contains support tools used by other LUCI components.

Versioning

  • Branch go1 contains the stable code.
  • Branch master constains the latest code.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.
  • Install test-only packages: go get -u -t github.com/luci/luci-go/client/...
  • Install the pcg git hook: go get -u github.com/maruel/pre-commit-go/cmd/... && pcg

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
cd $GOROOT/github.com/luci/luci-go
git checkout -b work origin/master

# hack hack

git commit -a -m "This is awesome\nR=joe@example.com"
# This will ask for your Google Account credentials.
git cl upload -s
# Wait for LGTM over email.
# Check the commit queue box in codereview website.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.