Google Git
Sign in
chromium / external / github.com / luci / luci-go / 810e5dc1dfbe94f009ae3cd5e0d3c92d1a375d88
commit810e5dc1dfbe94f009ae3cd5e0d3c92d1a375d88[log] [tgz]
authordnj <dnj@chromium.org>Tue Aug 01 22:31:17 2017
committerCommit Bot <commit-bot@chromium.org>Tue Aug 01 22:31:17 2017
treeb1cb804a971a54938c1589e6da59b8d2635388f2
parentdb21483023eebb29ad6bcf00585a6b854609c657 [diff]
[logdog-view] Update UX, fix bugs.

Update the LogDog Web Viewer user experience and fix a bug where the
stream finishing wasn't always acknowledged by the UI.

This makes button visibility modal. While the stream is automatically
loading, control buttons will be hidden. When it is paused, they will be
shown. This will reduce the number of active buttons that the user has
to see during log interaction.

Following is no longer optional. It is enabled by default, and disabled
permanently for the duration of the stream on scroll or pause. This
removes the need for a user to manage this option.

BUG=None
TEST=local

Review-Url: https://codereview.chromium.org/2988993003
3 files changed
tree: b1cb804a971a54938c1589e6da59b8d2635388f2
  1. appengine/
  2. buildbucket/
  3. cipd/
  4. client/
  5. common/
  6. deploytool/
  7. dm/
  8. examples/
  9. grpc/
  10. hardcoded/
  11. infra/
  12. logdog/
  13. luci_config/
  14. lucictx/
  15. milo/
  16. mmutex/
  17. scheduler/
  18. scripts/
  19. server/
  20. swarming/
  21. tokenserver/
  22. tools/
  23. tumble/
  24. vpython/
  25. web/
  26. .travis.yml
  27. AUTHORS
  28. codereview.settings
  29. CONTRIBUTING.md
  30. CONTRIBUTORS
  31. LICENSE
  32. luci-deploy.cfg
  33. pre-commit-go.yml
  34. PRESUBMIT.py
  35. README.md
  36. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoDoc Build Status Coverage Status

Installing

go get -u github.com/luci/luci-go/client/cmd/...
go get -u github.com/luci/luci-go/server/cmd/...

Code layout

  • /appengine/... contains AppEngine server code. It imports packages from /common/... and /server/....
  • /client/... contains all client code.
  • /common/... contains code and structures shared between all of /appengine/..., /client/... and /server/...; for example, the structures used by the server APIs. These are inherently APIs.
  • /deploytool/... contains the LUCI cloud services deployment tool.
  • /logdog/... contains LogDog client and server code, as well as APIs, protobufs, and support libraries.
  • /server/... contains standalone server code. Its packages are reusable by /appengine/....
  • /tools/... contains support tools used by other LUCI components.

Versioning

  • Branch go1 contains the stable code.
  • Branch master constains the latest code.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.
  • Install test-only packages: go get -u -t github.com/luci/luci-go/client/...
  • Install the pcg git hook: go get -u github.com/maruel/pre-commit-go/cmd/... && pcg

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
cd $GOROOT/github.com/luci/luci-go
git checkout -b work origin/master

# hack hack

git commit -a -m "This is awesome\nR=joe@example.com"
# This will ask for your Google Account credentials.
git cl upload -s
# Wait for LGTM over email.
# Check the commit queue box in codereview website.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.