Google Git
Sign in
chromium / external / github.com / luci / luci-go / ad913aefc7240bcad0a7d52d31345b2e181b456a
commitad913aefc7240bcad0a7d52d31345b2e181b456a[log] [tgz]
authorvadimsh <vadimsh@chromium.org>Wed Aug 02 09:41:37 2017
committerCommit Bot <commit-bot@chromium.org>Wed Aug 02 09:41:37 2017
tree00329905ef541853893dda52fbbdb645ab4857fb
parentfb82bfe733c86cb9d46ff4ebc0fec2d727abf8a8 [diff]
Fix mocked time in 'common/auth/localauth' tests.

It incorrectly set local time as test time. TestRecentTimeLocal represents
different instances in time for different local timezones (but same local clock
readings).

The test later compares Unix representation of this time to a predefined value.
Unix time is always counted from UTC zone, so different moments in time have
different representations. The test hardcoded Unix representation of PST variant
of TestRecentTimeLocal, and so tests passed only in PST zone.

R=tandrii@chromium.org
BUG=747013

Review-Url: https://codereview.chromium.org/2988263002
2 files changed
tree: 00329905ef541853893dda52fbbdb645ab4857fb
  1. appengine/
  2. buildbucket/
  3. cipd/
  4. client/
  5. common/
  6. deploytool/
  7. dm/
  8. examples/
  9. grpc/
  10. hardcoded/
  11. infra/
  12. logdog/
  13. luci_config/
  14. lucictx/
  15. milo/
  16. mmutex/
  17. scheduler/
  18. scripts/
  19. server/
  20. swarming/
  21. tokenserver/
  22. tools/
  23. tumble/
  24. vpython/
  25. web/
  26. .travis.yml
  27. AUTHORS
  28. codereview.settings
  29. CONTRIBUTING.md
  30. CONTRIBUTORS
  31. LICENSE
  32. luci-deploy.cfg
  33. pre-commit-go.yml
  34. PRESUBMIT.py
  35. README.md
  36. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoDoc Build Status Coverage Status

Installing

go get -u github.com/luci/luci-go/client/cmd/...
go get -u github.com/luci/luci-go/server/cmd/...

Code layout

  • /appengine/... contains AppEngine server code. It imports packages from /common/... and /server/....
  • /client/... contains all client code.
  • /common/... contains code and structures shared between all of /appengine/..., /client/... and /server/...; for example, the structures used by the server APIs. These are inherently APIs.
  • /deploytool/... contains the LUCI cloud services deployment tool.
  • /logdog/... contains LogDog client and server code, as well as APIs, protobufs, and support libraries.
  • /server/... contains standalone server code. Its packages are reusable by /appengine/....
  • /tools/... contains support tools used by other LUCI components.

Versioning

  • Branch go1 contains the stable code.
  • Branch master constains the latest code.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.
  • Install test-only packages: go get -u -t github.com/luci/luci-go/client/...
  • Install the pcg git hook: go get -u github.com/maruel/pre-commit-go/cmd/... && pcg

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
cd $GOROOT/github.com/luci/luci-go
git checkout -b work origin/master

# hack hack

git commit -a -m "This is awesome\nR=joe@example.com"
# This will ask for your Google Account credentials.
git cl upload -s
# Wait for LGTM over email.
# Check the commit queue box in codereview website.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.