Ensure (de)compressor is always closed. Minor cleanup of a few missing calls to Close() on decompressor and compressor instances. R=maruel@chromium.org, mcgreevy@chromium.org, tandrii@chromium.org BUG= Review-Url: https://codereview.chromium.org/2884413002
diff --git a/common/isolatedclient/isolatedclient.go b/common/isolatedclient/isolatedclient.go index 50325f5..462da9c 100644 --- a/common/isolatedclient/isolatedclient.go +++ b/common/isolatedclient/isolatedclient.go
@@ -349,6 +349,7 @@ } buf := make([]byte, 4096) if _, err := io.CopyBuffer(compressor, src, buf); err != nil { + compressor.Close() pw.CloseWithError(err) return }
diff --git a/common/isolatedclient/isolatedfake/isolatedfake.go b/common/isolatedclient/isolatedfake/isolatedfake.go index 5fccb6c..3813871 100644 --- a/common/isolatedclient/isolatedfake/isolatedfake.go +++ b/common/isolatedclient/isolatedfake/isolatedfake.go
@@ -193,6 +193,7 @@ server.Fail(err) return } + defer decompressor.Close() raw, err := ioutil.ReadAll(decompressor) if err != nil { w.WriteHeader(500) @@ -273,6 +274,7 @@ server.Fail(err) return map[string]string{"err": err.Error()} } + defer decompressor.Close() raw, err := ioutil.ReadAll(decompressor) if err != nil { server.Fail(err)