Google Git
Sign in
chromium / external / github.com / luci / luci-go / d9f6561f4b6d29a16f889ad4f6f2898c5794303a
commitd9f6561f4b6d29a16f889ad4f6f2898c5794303a[log] [tgz]
authordnj <dnj@chromium.org>Thu Jun 15 19:09:59 2017
committerCommit Bot <commit-bot@chromium.org>Thu Jun 15 19:09:59 2017
tree973404b2c983b5ef513511257fcb748e2bf19c04
parent35426aab5e558df793b116a5f0c516633a32376b [diff]
[vpython] Fix intolerant lookup logic.

The old probe-based Python lookup will return an error if any single
candidate Python could not be identified. This prevents fallthrough,
e.g., "python2.7" => "python2" => "python" will fail error on
"python2.7" being missing.

Refactor the lookup function a bit to be more tolerant of lookup errors.
It should now try all candidate Python names and only fail if none of
them matched.

BUG=None
TEST=local
R=iannucci@chromium.org, qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2943513002
1 file changed
tree: 973404b2c983b5ef513511257fcb748e2bf19c04
  1. appengine/
  2. buildbucket/
  3. cipd/
  4. client/
  5. common/
  6. deploytool/
  7. dm/
  8. examples/
  9. grpc/
  10. hardcoded/
  11. infra/
  12. logdog/
  13. luci_config/
  14. lucictx/
  15. milo/
  16. scheduler/
  17. scripts/
  18. server/
  19. swarming/
  20. tokenserver/
  21. tools/
  22. tumble/
  23. vpython/
  24. web/
  25. .travis.yml
  26. AUTHORS
  27. codereview.settings
  28. CONTRIBUTORS
  29. LICENSE
  30. luci-deploy.cfg
  31. pre-commit-go.yml
  32. PRESUBMIT.py
  33. README.md
  34. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoDoc Build Status Coverage Status

Installing

go get -u github.com/luci/luci-go/client/cmd/...
go get -u github.com/luci/luci-go/server/cmd/...

Code layout

  • /appengine/... contains AppEngine server code. It imports packages from /common/... and /server/....
  • /client/... contains all client code.
  • /common/... contains code and structures shared between all of /appengine/..., /client/... and /server/...; for example, the structures used by the server APIs. These are inherently APIs.
  • /deploytool/... contains the LUCI cloud services deployment tool.
  • /logdog/... contains LogDog client and server code, as well as APIs, protobufs, and support libraries.
  • /server/... contains standalone server code. Its packages are reusable by /appengine/....
  • /tools/... contains support tools used by other LUCI components.

Versioning

  • Branch go1 contains the stable code.
  • Branch master constains the latest code.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.
  • Install test-only packages: go get -u -t github.com/luci/luci-go/client/...
  • Install the pcg git hook: go get -u github.com/maruel/pre-commit-go/cmd/... && pcg

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
cd $GOROOT/github.com/luci/luci-go
git checkout -b work origin/master

# hack hack

git commit -a -m "This is awesome\nR=joe@example.com"
# This will ask for your Google Account credentials.
git cl upload -s
# Wait for LGTM over email.
# Check the commit queue box in codereview website.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.